tfa 0.0.11 → 0.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1fb7180ac2ccb7c877e05e1927763d9bdb0d4e6c
-  data.tar.gz: f7d18a024879662a22404c42b1a3ef01975b027e
+  metadata.gz: e9f7fbb44a573c867d8a50eba076c43886e7badc
+  data.tar.gz: 9d6e750cd8c636b7fdd243848e80a335062c48cf
 SHA512:
-  metadata.gz: 79e854463b20f67ec678ac3c0e0e08e3c00df4ce9fc27df0a0b7b320647d65de78d938fa38f9a3074f3050dd6789fa4f2166c6e24b173c7e540eb33d40fd6efd
-  data.tar.gz: 0741cd7c80b47730893ad23fc962d0448a2e8ae3be72a4c98c5ddefab31fe423d8bd6ec4fbefeaa3a2c2b9b2d17c902a37642f73e360a2dfc3cbb725cc79ca23
+  metadata.gz: 1999844fac258b7908d306d7d01fd428d2f8ae2918c39826a14a07825fd1e8131aabea4d2cec247b5111e7435ae542dbc92592f6775d318ebd6e4dc1ff66eb02
+  data.tar.gz: 214f69224f8a41a12703c980dbb357e54d01ee9c5d05abc714cd113f4b242da19a4ddb2d8627699dfc6fb43ea9c7998e5c0247f4da307b34dcb03ff8278b1261

data/.travis.yml

@@ -1,3 +1,4 @@
 language: ruby
 rvm:
   - 2.1.1
+  - 2.3.1

data/lib/tfa/cli.rb

@@ -12,6 +12,11 @@ module TFA
       "Added #{name}"
     end
 
+    desc "destroy NAME", "remove the secret associated with the name"
+    def destroy(name)
+      storage.delete(name)
+    end
+
     desc "show NAME", "shows the secret for the given key"
     def show(name = nil)
       name ? storage.secret_for(name) : storage.all

data/lib/tfa/storage.rb

@@ -30,6 +30,12 @@ module TFA
       end
     end
 
+    def delete(key)
+      @storage.transaction do
+        @storage.delete(key)
+      end
+    end
+
     private
 
     def open_readonly

data/lib/tfa/totp_command.rb

@@ -13,6 +13,8 @@ module TFA
 
     def password_for(secret)
       ::ROTP::TOTP.new(secret).now
+    rescue ROTP::Base32::Base32Error
+      "INVALID SECRET"
     end
 
     def all_passwords

data/lib/tfa/version.rb

@@ -1,3 +1,3 @@
 module TFA
-  VERSION = "0.0.11"
+  VERSION = "0.0.12".freeze
 end

data/spec/lib/cli_spec.rb

@@ -6,22 +6,43 @@ module TFA
       ::ROTP::TOTP.new(secret).now
     end
 
-    let(:secret) { ::ROTP::Base32.random_base32 }
+    let(:dev_secret) { ::ROTP::Base32.random_base32 }
+    let(:prod_secret) { ::ROTP::Base32.random_base32 }
 
     describe "#add" do
       context "when a secret is added" do
         it "adds the secret" do
-          subject.add("development", secret)
-          expect(subject.show("development")).to eql(secret)
+          subject.add("development", dev_secret)
+          expect(subject.show("development")).to eql(dev_secret)
         end
       end
 
       context "when a full otpauth string is added" do
         it "strips out the url for just the secret" do
-          url = "otpauth://totp/email@email.com?secret=#{secret}&issuer="
+          url = "otpauth://totp/email@email.com?secret=#{dev_secret}&issuer="
 
           subject.add("development", url)
-          expect(subject.show("development")).to eql(secret)
+          expect(subject.show("development")).to eql(dev_secret)
+        end
+      end
+    end
+
+    describe "#show" do
+      context "when a single key is given" do
+        it "returns the secret" do
+          subject.add("development", dev_secret)
+          expect(subject.show("development")).to eql(dev_secret)
+        end
+      end
+
+      context "when no key is given" do
+        it "returns the secret for all keys" do
+          subject.add("development", dev_secret)
+          subject.add("production", prod_secret)
+
+          result = subject.show.to_s
+          expect(result).to include(dev_secret)
+          expect(result).to include(prod_secret)
         end
       end
     end
@@ -29,10 +50,32 @@ module TFA
     describe "#totp" do
       context "when a single key is given" do
         it "returns a time based one time password" do
-          subject.add("development", secret)
-          expect(subject.totp("development")).to eql(code_for(secret))
+          subject.add("development", dev_secret)
+          expect(subject.totp("development")).to eql(code_for(dev_secret))
         end
       end
+
+      context "when no key is given" do
+        it "returns a time based one time password for all keys" do
+          subject.add("development", dev_secret)
+          subject.add("production", prod_secret)
+
+          result = subject.totp.to_s
+          expect(result).to include(code_for(dev_secret))
+          expect(result).to include(code_for(prod_secret))
+        end
+      end
+    end
+
+    describe "#destroy" do
+      let(:name) { "development" }
+
+      it "removes the secret with the given name" do
+        subject.add(name, dev_secret)
+        subject.destroy(name)
+
+        expect(subject.show(name)).to be_nil
+      end
     end
   end
 end

data/spec/lib/totp_command_spec.rb

@@ -12,7 +12,7 @@ module TFA
         let(:secret) { ::ROTP::Base32.random_base32 }
 
         it "returns a time based one time password for the authentication secret given" do
-          storage.save('development', secret)
+          storage.save("development", secret)
           expect(subject.run("development")).to eql(code_for(secret))
         end
       end
@@ -22,20 +22,34 @@ module TFA
         let(:staging_secret) { ::ROTP::Base32.random_base32 }
 
         it "returns the one time password for all keys" do
-          storage.save('development', development_secret)
-          storage.save('staging', staging_secret)
-          expect(subject.run(nil)).to eql([
-            { 'development' => code_for(development_secret) },
-            { 'staging' => code_for(staging_secret) }
+          storage.save("development", development_secret)
+          storage.save("staging", staging_secret)
+
+          expect(subject.run(nil)).to match_array([
+            { "development" => code_for(development_secret) },
+            { "staging" => code_for(staging_secret) }
           ])
         end
       end
 
-      context 'when the key is not known' do
+      context "when the key is not known" do
         it "returns with nothing" do
           expect(subject.run(["blah"])).to be_empty
         end
       end
+
+      context "when the secret is invalid" do
+        let(:invalid_secret) { "hello world" }
+
+        before :each do
+          storage.save("development", invalid_secret)
+        end
+
+        it "returns an error message" do
+          expected = { "development" => "INVALID SECRET" }
+          expect(subject.run(["development"])).to match_array([expected])
+        end
+      end
     end
   end
 end

data/tfa.gemspec

@@ -8,9 +8,9 @@ Gem::Specification.new do |spec|
   spec.version       = TFA::VERSION
   spec.authors       = ["mo khan"]
   spec.email         = ["mo@mokhan.ca"]
-  spec.summary       = %q{A CLI to manage your one time passwords.}
-  spec.description   = %q{A CLI to manage your one time passwords.}
-  spec.homepage      = ""
+  spec.summary       = %q{A CLI to manage your time based one time passwords.}
+  spec.description   = %q{A CLI to manage your time based one time passwords.}
+  spec.homepage      = "https://github.com/mokhan/tfa/"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tfa
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - mo khan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-09 00:00:00.000000000 Z
+date: 2016-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rotp
@@ -80,7 +80,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: A CLI to manage your one time passwords.
+description: A CLI to manage your time based one time passwords.
 email:
 - mo@mokhan.ca
 executables:
@@ -106,7 +106,7 @@ files:
 - spec/lib/totp_command_spec.rb
 - spec/spec_helper.rb
 - tfa.gemspec
-homepage: ''
+homepage: https://github.com/mokhan/tfa/
 licenses:
 - MIT
 metadata: {}
@@ -126,10 +126,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
-summary: A CLI to manage your one time passwords.
+summary: A CLI to manage your time based one time passwords.
 test_files:
 - spec/lib/cli_spec.rb
 - spec/lib/console_spec.rb