text_helpers 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 97f5f8d490471d60b7cc9286f2fb49460862917a1ed6b6d36c984fb8f5a22ac3
-  data.tar.gz: a2fadb5cea94f89c87cf31ef1a7dbb8779739c6aab67d2b9f143968498cc25e7
+  metadata.gz: d4e0a6d2b19adb159000ea905c72b4023942ae268e36ac0eb9b39baf551e7460
+  data.tar.gz: ba520c7137fe2355dab9c1e29cbf215c2a19baccef7b246b850f188f909e81e5
 SHA512:
-  metadata.gz: 73f98e2a518aeafb35653d9d713a3b983d456d2e947bc98fcc1c519d9b8b7034f741eb2985475336e5b9fe6786ebc8502e2fe9994001a259c19c1c0800b769d2
-  data.tar.gz: 37a0c2ba7e0510dd38d720abafb43ba6342f1af8b578422b520d82956aa9a46df22b87a6774b615f1665a21b11618f185229face8e8c9b44513c44081cd1f2f0
+  metadata.gz: c1fb87f89fbc7e42cfeab3fa224573097626b6dafd3c252076f7b13df1de5c7a8e8046b95207ba8d69dc9d50aa4290b2bd859166ef2cf17441bddad961ad8f10
+  data.tar.gz: 599e77b95ca58b291bf1d0348b65cfb4e7f2ff831e2a2850a2fd883df1e4fb9e6d569aecd1a209fb6cedf1df1e7aa9136be5ec3db55a6bc61b3ab2b3197d9eb5

data/CHANGELOG.md

@@ -0,0 +1,88 @@
+# Change Log
+
+## [1.1.0] - 2020-12-02
+
+### New Features 
+
+- Add `rel=noopener` to external links (thanks to @n00dle)
+
+## [1.0.1] - 2020-12-02
+
+### Changes 
+
+- Support cascading backends by default
+
+## [1.0.0] - 2020-03-27
+
+### Changes
+
+- **(Breaking)** Drop explicit support for Ruby versions below 2.6
+
+### Bug Fixes
+
+- Properly support translations using I18n::Pluralization backend (thanks to @jhanggi)
+
+## [0.7.2] - 2019-07-06
+
+### Bug Fixes
+
+- Improve orphaned text matcher targeting
+
+## [0.7.1] - 2019-07-05
+
+### Bug Fixes
+
+- Prevent unnecessary non-breaking spaces in generated HTML
+
+### Changes
+
+- Improve `NotImplementedError` messaging (thanks to @stephen-puiszis)
+- Update README with spec setup instructions (thanks to @jhanggi)
+
+## [0.7.0] - 2016-05-06
+
+### New features
+
+- Automatically load entire locale directory via Railtie
+
+## [0.6.1] - 2015-10-01
+
+### Changes
+
+- Bump version requirement for Redcarpet gem to address memory leaks
+
+## [0.6.0] - 2015-06-15
+
+### New Features
+
+- Apply `target=_blank` attribute to anchor tags pointed at external URLs
+
+## [0.5.3] - 2015-02-25
+
+### Changes
+
+- Update spec helpers for compatibility with RSpec 3 (thanks to @gabrielg)
+
+## [0.5.2] - 2015-02-03
+
+### Changes
+
+- Support cascading backends for interpolated keys (thanks to @gabrielg)
+
+## [0.5.1] - 2015-01-23
+
+### New Features
+
+- Add RSpec helpers (thanks to @gabrielg)
+
+[1.1.0]: https://github.com/ahorner/text-helpers/compare/v1.0.1...v1.1.0
+[1.0.1]: https://github.com/ahorner/text-helpers/compare/v1.0.0...v1.0.1
+[1.0.0]: https://github.com/ahorner/text-helpers/compare/v0.7.2...v1.0.0
+[0.7.2]: https://github.com/ahorner/text-helpers/compare/v0.7.1...v0.7.2
+[0.7.1]: https://github.com/ahorner/text-helpers/compare/v0.7.0...v0.7.1
+[0.7.0]: https://github.com/ahorner/text-helpers/compare/v0.6.1...v0.7.0
+[0.6.1]: https://github.com/ahorner/text-helpers/compare/v0.6.0...v0.6.1
+[0.6.0]: https://github.com/ahorner/text-helpers/compare/v0.5.3...v0.6.0
+[0.5.3]: https://github.com/ahorner/text-helpers/compare/v0.5.2...v0.5.3
+[0.5.2]: https://github.com/ahorner/text-helpers/compare/v0.5.1...v0.5.2
+[0.5.1]: https://github.com/ahorner/text-helpers/compare/v0.5.0...v0.5.1

data/lib/text_helpers/translation.rb

@@ -12,7 +12,7 @@ module TextHelpers
       attributes = [
         ("href=\"#{link}\"" if link),
         ("title=\"#{title}\"" if title),
-        ("target=\"_blank\"" if link =~ PROTOCOL_MATCHER),
+        ("target=\"_blank\" rel=\"noopener\"" if link.match?(PROTOCOL_MATCHER)),
       ]
 
       "<a #{attributes.compact.join(" ")}>#{content}</a>"
@@ -44,7 +44,7 @@ module TextHelpers
       interpolation_options = { cascade: true }.merge(options)
 
       # Interpolate any keypaths (e.g., `!some.lookup.path/key!`) found in the text.
-      while text =~ KEYPATH_MATCHER do
+      while text.match?(KEYPATH_MATCHER) do
         text = text.gsub(KEYPATH_MATCHER) { |match| I18n.t($1, **interpolation_options) }
       end
 

data/lib/text_helpers/version.rb

@@ -1,3 +1,3 @@
 module TextHelpers
-  VERSION = "1.0.1"
+  VERSION = "1.1.0"
 end

data/test/lib/text_helpers/translation_test.rb

@@ -119,12 +119,12 @@ describe TextHelpers::Translation do
         assert_equal "<em>#{@scoped_text}</em>\n", @helper.html(:test_key, inline: true, orphans: true)
       end
 
-      it "renders internal links without a target" do
+      it "renders internal links without a target or rel" do
         assert_equal "<a href=\"/internal/path\">Internal&nbsp;link</a>\n", @helper.html(:internal_link, inline: true)
       end
 
-      it "renders external links with target='_blank'" do
-        assert_equal "<a href=\"http://external.com\" target=\"_blank\">External&nbsp;link</a>\n", @helper.html(:external_link, inline: true)
+      it "renders external links with target='_blank' and rel='noopener'" do
+        assert_equal "<a href=\"http://external.com\" target=\"_blank\" rel=\"noopener\">External&nbsp;link</a>\n", @helper.html(:external_link, inline: true)
       end
 
       it "interpolates values wrapped in !!" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: text_helpers
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Andrew Horner
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-12-03 00:00:00.000000000 Z
+date: 2020-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -89,6 +89,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md