test_track_rails_client 4.0.0.alpha8 → 4.0.0.alpha9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3c421a570a50e10dbfdff7420aafa19964ee4c01
-  data.tar.gz: 901a202cbb0db2717ba240b6466f6408ddb1b3c4
+  metadata.gz: 629da11fcbfee5696bb015df4e2e14258cee29c3
+  data.tar.gz: 8ae8b3bf5ea58b8cbbe858f4b6dff750474282b1
 SHA512:
-  metadata.gz: 684fa6562e8a88bd4092bbd2cf0f5527f84c4c4e55b307c5ca9ec88f4d965cfb193aec37fb20a08aefda96588fbc34597f9b1b91198bf3390c3dde7c09484505
-  data.tar.gz: 63edb85ee37e5eba3d15fc2f926eca2aae470bf0f927d2b5cde366206edc48f8b12ebc685849343fd06fb66a54a53aa101e51606e02c4869923bad91694c750c
+  metadata.gz: 5dde230b69d332342cfde930cef086e44bc33e3d69363e93884f464d99dbdcf74f8ad292d757a48973b31ad4a35f94bbd5f1f4a07b75c216a6ecd1fdf9bd9e77
+  data.tar.gz: acbc533c47b4ed7ab1d170a67c37f31852a161dbaf558bed87c9a1a786914a942cde94843326f3e9c2fb20a267d7bf921242053a308007ed15b030041434f672

data/app/models/test_track/analytics_event.rb

@@ -1,10 +1,9 @@
 module TestTrack
   class AnalyticsEvent
-    attr_reader :assignment
+    attr_reader :visitor_id, :assignment
 
-    delegate :visitor_id, to: :assignment
-
-    def initialize(assignment)
+    def initialize(visitor_id, assignment)
+      @visitor_id = visitor_id
       @assignment = assignment
     end
 

data/app/models/test_track/assignment.rb

@@ -23,10 +23,6 @@ class TestTrack::Assignment
     split_name.end_with?('_enabled')
   end
 
-  def visitor_id
-    visitor.id
-  end
-
   private
 
   def _variant

data/app/models/test_track/fake/visitor.rb

@@ -1,7 +1,7 @@
 class TestTrack::Fake::Visitor
   attr_reader :id
 
-  Assignment = Struct.new(:split_name, :variant, :unsynced, :context, :visitor_id)
+  Assignment = Struct.new(:split_name, :variant, :unsynced, :context)
 
   def self.instance
     @instance ||= new(TestTrack::FakeServer.seed)
@@ -28,7 +28,7 @@ class TestTrack::Fake::Visitor
   def _assignments
     split_registry.keys.map do |split_name|
       variant = TestTrack::VariantCalculator.new(visitor: self, split_name: split_name).variant
-      Assignment.new(split_name, variant, false, "the_context", id)
+      Assignment.new(split_name, variant, false, "the_context")
     end
   end
 end

data/app/models/test_track/notify_assignment_job.rb

@@ -27,7 +27,7 @@ class TestTrack::NotifyAssignmentJob
 
   def track
     return "failure" unless TestTrack.enabled?
-    result = TestTrack.analytics.track(TestTrack::AnalyticsEvent.new(assignment))
+    result = TestTrack.analytics.track(TestTrack::AnalyticsEvent.new(visitor_id, assignment))
     result ? "success" : "failure"
   end
 end

data/app/models/test_track/offline_session.rb

@@ -1,14 +1,4 @@
 class TestTrack::OfflineSession
-  AnalyticsAssignment = Struct.new(:visitor_id, :split_name, :variant, :context, :unsynced) do
-    def unsynced?
-      unsynced
-    end
-
-    def feature_gate?
-      split_name.end_with?('_enabled')
-    end
-  end
-
   def initialize(remote_visitor)
     @remote_visitor = remote_visitor
   end
@@ -40,22 +30,10 @@ class TestTrack::OfflineSession
   def visitor
     @visitor ||= TestTrack::Visitor.new(
       id: remote_visitor.id,
-      assignments: analytics_assignments
+      assignments: remote_visitor.assignments
     )
   end
 
-  def analytics_assignments
-    remote_visitor.assignments.map do |remote_assignment|
-      AnalyticsAssignment.new(
-        remote_visitor.id,
-        remote_assignment.split_name,
-        remote_assignment.variant,
-        remote_assignment.context,
-        remote_assignment.unsynced
-      )
-    end
-  end
-
   def manage
     yield TestTrack::VisitorDSL.new(visitor)
   ensure

data/app/models/test_track/remote/assignment.rb

@@ -1,14 +1,18 @@
 class TestTrack::Remote::Assignment
   include TestTrack::RemoteModel
 
-  attributes :visitor_id, :split_name, :variant, :context, :unsynced
+  attributes :split_name, :variant, :context, :unsynced
 
-  validates :visitor_id, :split_name, :variant, :mixpanel_result, presence: true
+  validates :split_name, :variant, :mixpanel_result, presence: true
 
   def unsynced?
     unsynced || variant_changed?
   end
 
+  def feature_gate?
+    split_name.end_with?('_enabled')
+  end
+
   def self.fake_instance_attributes(id)
     {
       split_name: "split_#{id}",

data/lib/test_track_rails_client/version.rb

@@ -1,3 +1,3 @@
 module TestTrackRailsClient
-  VERSION = "4.0.0.alpha8" # rubocop:disable Style/MutableConstant
+  VERSION = "4.0.0.alpha9" # rubocop:disable Style/MutableConstant
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: test_track_rails_client
 version: !ruby/object:Gem::Version
-  version: 4.0.0.alpha8
+  version: 4.0.0.alpha9
 platform: ruby
 authors:
 - Ryan O'Neill
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-08 00:00:00.000000000 Z
+date: 2018-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: airbrake