test_track_rails_client 4.0.0.alpha33 → 4.0.0.alpha34

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 04e1d08411f4d058bdafcfdb9b9fa9d9055e4e7c
-  data.tar.gz: d6eb123a181c09a0f28d66c4d9e08d53d463f3d1
+SHA256:
+  metadata.gz: 2ebec3b017f9413465d5366f3b94d95c12b38d7bf408693ce0a0d4086d39a107
+  data.tar.gz: '0728b2597327fb1e1583de3c9b4ed3eaf9a7f95bf62617d5cb2702c33d9723d8'
 SHA512:
-  metadata.gz: 2a11aeb59407096e014890089d70b17249796b6cbddc17dcb9ed7bbb34a9c60fdb4b584e1671c04e0db1fae7615a640375c78888e79795dec85e3bcc084b1282
-  data.tar.gz: 83095dea4ae36815b4497240d1b8eee1eaabecff2b24a5b82f9b5af0607c0a3b549c2d50765603cf82e38a3c05d188dea7917c15eb6f0bd9da35fc558a026315
+  metadata.gz: 86cbae6aa9be897b607781bb26bd53cc834bf47c140d1d2e7f911baadada95f280094ece25de2a4a2ce1415b20eeb4eb63e472fe60c6dc8a5a2256c6f63ecaab
+  data.tar.gz: 5cf5546c8d41542813f2aa682024ca3b476fc51afa7bd3144d93634982806fbfa7b2827f232de2da459a88118c1c43a26a5cdbab9713d42fd9d22ea739f1b970

data/Rakefile

@@ -14,7 +14,7 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-APP_RAKEFILE = File.expand_path("../spec/dummy/Rakefile", __FILE__)
+APP_RAKEFILE = File.expand_path('spec/dummy/Rakefile', __dir__)
 load 'rails/tasks/engine.rake'
 
 Bundler::GemHelper.install_tasks

data/app/controllers/concerns/test_track/controller.rb

@@ -12,9 +12,7 @@ module TestTrack::Controller
   class_methods do
     def require_feature_flag(feature_flag, *args)
       before_action(*args) do
-        unless test_track_visitor.ab(feature_flag, context: self.class.name.underscore)
-          raise ActionController::RoutingError, 'Not Found'
-        end
+        raise ActionController::RoutingError, 'Not Found' unless test_track_visitor.ab(feature_flag, context: self.class.name.underscore)
       end
     end
   end

data/app/models/concerns/test_track/required_options.rb

@@ -6,6 +6,7 @@ module TestTrack::RequiredOptions
   def require_option!(opts, opt_name, my_opts = {})
     opt_provided = my_opts[:allow_nil] ? opts.key?(opt_name) : opts[opt_name]
     raise(ArgumentError, "Must provide #{opt_name}") unless opt_provided
+
     opts.delete(opt_name)
   end
 end

data/app/models/test_track/ab_configuration.rb

@@ -19,9 +19,7 @@ class TestTrack::ABConfiguration
   private
 
   def build_variant_hash
-    if split_variants && split_variants.size > 2 # rubocop:disable Style/SafeNavigation
-      notify_because_ab("configures split with more than 2 variants")
-    end
+    notify_because_ab("configures split with more than 2 variants") if split_variants && split_variants.size > 2
     { true: true_variant, false: false_variant }
   end
 
@@ -30,7 +28,7 @@ class TestTrack::ABConfiguration
   end
 
   def false_variant
-    @false_variant ||= non_true_variants.present? ? non_true_variants.sort.first : false
+    @false_variant ||= non_true_variants.present? ? non_true_variants.min : false
   end
 
   attr_reader :split_name, :split_registry

data/app/models/test_track/analytics/mixpanel_client.rb

@@ -8,6 +8,7 @@ module TestTrack::Analytics
 
     def mixpanel
       raise "ENV['MIXPANEL_TOKEN'] must be set" unless ENV['MIXPANEL_TOKEN']
+
       @mixpanel ||= Mixpanel::Tracker.new(ENV['MIXPANEL_TOKEN'])
     end
   end

data/app/models/test_track/analytics/safe_wrapper.rb

@@ -9,6 +9,7 @@ module TestTrack::Analytics
     def error_handler=(handler)
       raise ArgumentError, "error_handler must be a lambda" unless handler.lambda?
       raise ArgumentError, "error_handler must accept 1 argument" unless handler.arity == 1
+
       @error_handler = handler
     end
 

data/app/models/test_track/application_identity.rb

@@ -7,6 +7,7 @@ class TestTrack::ApplicationIdentity
 
   def app_name
     raise 'must configure TestTrack.app_name on application initialization' if TestTrack.app_name.blank?
+
     TestTrack.app_name
   end
 

data/app/models/test_track/assignment.rb

@@ -27,7 +27,8 @@ class TestTrack::Assignment
 
   def _variant
     return if visitor.offline?
+
     variant = TestTrack::VariantCalculator.new(visitor: visitor, split_name: split_name).variant
-    variant && variant.to_s
+    variant&.to_s
   end
 end

data/app/models/test_track/fake/split_registry.rb

@@ -50,9 +50,7 @@ class TestTrack::Fake::SplitRegistry
   end
 
   def legacy_test_track_schema_yml
-    unless instance_variable_defined?(:@legacy_test_track_schema_yml)
-      @legacy_test_track_schema_yml = _legacy_test_track_schema_yml
-    end
+    @legacy_test_track_schema_yml = _legacy_test_track_schema_yml unless instance_variable_defined?(:@legacy_test_track_schema_yml)
     @legacy_test_track_schema_yml
   end
 
@@ -69,7 +67,7 @@ class TestTrack::Fake::SplitRegistry
 
   def split_registry_with_deterministic_weights
     splits = split_hash.each_with_object({}) do |(split_name, weighting_registry), result|
-      default_variant = weighting_registry.keys.sort.first
+      default_variant = weighting_registry.keys.min
 
       adjusted_weights = { default_variant => 100 }
       weighting_registry.except(default_variant).each_key do |variant|

data/app/models/test_track/job_session.rb

@@ -24,9 +24,7 @@ class TestTrack::JobSession
 
   def notify_unsynced_assignments!
     identity_visitor_map.each_value do |visitor|
-      if visitor.loaded? && visitor.unsynced_assignments.present?
-        TestTrack::ThreadedVisitorNotifier.new(visitor).notify
-      end
+      TestTrack::ThreadedVisitorNotifier.new(visitor).notify if visitor.loaded? && visitor.unsynced_assignments.present?
     end
   end
 

data/app/models/test_track/lazy_visitor_by_identity.rb

@@ -13,7 +13,7 @@ class TestTrack::LazyVisitorByIdentity
 
   private
 
-  def method_missing(method, *args, &block) # rubocop:disable Style/MethodMissing
+  def method_missing(method, *args, &block)
     __visitor__.send(method, *args, &block)
   end
 

data/app/models/test_track/misconfiguration_notifier.rb

@@ -22,6 +22,7 @@ module TestTrack::MisconfigurationNotifier
   class Airbrake
     def notify(msg)
       raise "Aibrake was configured but not found" unless defined?(::Airbrake)
+
       if ::Airbrake.respond_to?(:notify_or_ignore)
         ::Airbrake.notify_or_ignore(StandardError.new, error_message: msg)
       else

data/app/models/test_track/notify_assignment_job.rb

@@ -28,6 +28,7 @@ class TestTrack::NotifyAssignmentJob
   def maybe_track
     return "failure" unless TestTrack.enabled?
     return "success" if skip_analytics_event?
+
     result = TestTrack.analytics.track(TestTrack::AnalyticsEvent.new(visitor_id, assignment))
     result ? "success" : "failure"
   end

data/app/models/test_track/remote/fake_server.rb

@@ -3,6 +3,7 @@ class TestTrack::Remote::FakeServer
 
   def self.reset!(seed)
     raise('Cannot reset FakeServer if TestTrack is enabled.') if TestTrack.enabled?
+
     put('api/v1/reset', seed: seed)
   end
 end

data/app/models/test_track/remote/identifier.rb

@@ -21,6 +21,7 @@ class TestTrack::Remote::Identifier
 
   def visitor_opts!
     raise("Visitor data unavailable until you save this identifier.") unless attributes[:remote_visitor]
+
     { id: remote_visitor.id, assignments: remote_visitor.assignments }
   end
 end

data/app/models/test_track/variant_calculator.rb

@@ -15,6 +15,7 @@ class TestTrack::VariantCalculator
 
   def variant
     return nil unless split_registry.loaded?
+
     @variant ||= _variant || raise("Assignment bucket out of range. #{assignment_bucket} unmatched in #{split_name}: #{weighting}")
   end
 

data/app/models/test_track/vary_dsl.rb

@@ -18,6 +18,7 @@ class TestTrack::VaryDSL
 
   def when(*variants, &block)
     raise ArgumentError, "must provide at least one variant" if variants.blank?
+
     variants.each do |variant|
       assign_behavior_to_variant(variant, block)
     end
@@ -25,6 +26,7 @@ class TestTrack::VaryDSL
 
   def default(variant, &block)
     raise ArgumentError, "cannot provide more than one `default`" unless default_variant.nil?
+
     @default_variant = assign_behavior_to_variant(variant, block)
   end
 
@@ -57,6 +59,7 @@ class TestTrack::VaryDSL
     variant = variant.to_s
 
     raise ArgumentError, "must provide block for #{variant}" unless behavior_proc
+
     notify_because_vary(<<-MESSAGE) if variant_behaviors.include?(variant)
       configures variant "#{variant}" more than once.
       This will raise an error in the next version of test_track_rails_client.
@@ -93,6 +96,7 @@ class TestTrack::VaryDSL
     raise ArgumentError, "must provide exactly one `default`" unless default_variant
     raise ArgumentError, "must provide at least one `when`" unless variant_behaviors.size >= 2
     return true unless split_variants
+
     missing_variants = split_variants - variant_behaviors.keys
     notify_because_vary("does not configure variants #{missing_variants.to_sentence}") && false unless missing_variants.empty?
   end

data/app/models/test_track/visitor.rb

@@ -23,6 +23,7 @@ class TestTrack::Visitor
     raise "unknown opts: #{opts.keys.to_sentence}" if opts.present?
 
     raise ArgumentError, "must provide block to `vary` for #{split_name}" unless block_given?
+
     v = TestTrack::VaryDSL.new(assignment: assignment_for(split_name), context: context, split_registry: split_registry)
     yield v
     v.send :run

data/app/models/test_track/web_session.rb

@@ -59,6 +59,7 @@ class TestTrack::WebSession
 
       If your app doesn't support authentication, set it to `:none`.
     ERROR
+
     identity = controller.class.test_track_identity
     controller.send(identity) unless identity == :none
   end

data/app/models/test_track/web_session_visitor_repository.rb

@@ -34,9 +34,7 @@ class TestTrack::WebSessionVisitorRepository
 
   def notify_unsynced_assignments!
     all.each do |visitor|
-      if visitor.loaded? && visitor.unsynced_assignments.present?
-        TestTrack::ThreadedVisitorNotifier.new(visitor).notify
-      end
+      TestTrack::ThreadedVisitorNotifier.new(visitor).notify if visitor.loaded? && visitor.unsynced_assignments.present?
     end
   end
 

data/lib/test_track.rb

@@ -95,6 +95,7 @@ module TestTrack
 
   def url
     return nil unless private_url
+
     full_uri = URI.parse(private_url)
     full_uri.user = nil
     full_uri.password = nil

data/lib/test_track_rails_client/version.rb

@@ -1,3 +1,3 @@
 module TestTrackRailsClient
-  VERSION = "4.0.0.alpha33" # rubocop:disable Style/MutableConstant
+  VERSION = "4.0.0.alpha34" # rubocop:disable Style/MutableConstant
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: test_track_rails_client
 version: !ruby/object:Gem::Version
-  version: 4.0.0.alpha33
+  version: 4.0.0.alpha34
 platform: ruby
 authors:
 - Ryan O'Neill
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-11 00:00:00.000000000 Z
+date: 2020-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: delayed_job
@@ -134,7 +134,7 @@ dependencies:
         version: '4.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -144,7 +144,7 @@ dependencies:
         version: '4.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: request_store
   requirement: !ruby/object:Gem::Requirement
@@ -356,8 +356,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Rails client for TestTrack