test_after_commit 0.2.0 → 0.2.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 0771c33d6db21be88b98458395d484ee9414352a
+  data.tar.gz: 154e46ea5761f401201401913c2af9dc9ebf698e
+SHA512:
+  metadata.gz: 9188eaac46d1ea76037eebbde65b5ee700d173ab597a9e0e04165fcc689875c3382a84acdc474dbccd7949ed75cfa2958975547552136a548b53670209d783aa
+  data.tar.gz: 0cbf8d71596dfd913df0160e1a5932b7bbc844472cab2e968cb5f075b1ae1597f73e4fcad5837adbbaca6a3a784367a10831b781141b5bcf99415c2bf257ad17

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    test_after_commit (0.2.0)
+    test_after_commit (0.2.1)
 
 GEM
   remote: https://rubygems.org/

data/Readme.md

@@ -5,9 +5,31 @@ Install
 
     gem install test_after_commit
 
-    # Gemfile
+    # Gemfile (never include in :development !)
     gem 'test_after_commit', :group => :test
 
+Usage
+=====
+Test that the methods get called or the side-effect of the methods, something like:
+
+```Ruby
+class Car < ActiveRecord::Base
+  after_commit :foo, :on => :update
+
+  def foo
+    $foo = 1
+  end
+end
+
+...
+
+it "sets $foo on commit" do
+  $foo.should == nil
+  car.save!
+  $foo.should == 1
+end
+```
+
 TIPS
 ====
  - hooks do not re-raise errors (with or without this gem)

data/gemfiles/30.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/test_after_commit
   specs:
-    test_after_commit (0.1.1)
+    test_after_commit (0.2.0)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/31.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/test_after_commit
   specs:
-    test_after_commit (0.1.1)
+    test_after_commit (0.2.0)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/32.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/test_after_commit
   specs:
-    test_after_commit (0.1.1)
+    test_after_commit (0.2.0)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/40.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: /Users/mgrosser/code/tools/test_after_commit
   specs:
-    test_after_commit (0.1.1)
+    test_after_commit (0.2.0)
 
 GEM
   remote: https://rubygems.org/

data/lib/test_after_commit.rb

@@ -11,14 +11,14 @@ ActiveRecord::ConnectionAdapters::DatabaseStatements.class_eval do
         @test_open_transactions += 1
         result = yield
       rescue ActiveRecord::Rollback => e
+        rolled_back = true
         raise e
-      else
-        if @test_open_transactions == 1
+      ensure
+        if @test_open_transactions == 1 && !rolled_back
           test_commit_records
         end
-        result
-      ensure
         @test_open_transactions -= 1
+        result
       end
     end
   end

data/lib/test_after_commit/version.rb

@@ -1,3 +1,3 @@
 module TestAfterCommit
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

data/spec/database.rb

@@ -18,6 +18,16 @@ ActiveRecord::Schema.define(:version => 1) do
     t.integer :car_id
     t.timestamps
   end
+
+  create_table "addresses", :force => true do |t|
+    t.integer :number_of_residents, :default => 0, :null => false
+    t.timestamps
+  end
+
+  create_table "people", :force => true do |t|
+    t.belongs_to :address
+    t.timestamps
+  end
 end
 
 class Car < ActiveRecord::Base
@@ -46,6 +56,12 @@ class Car < ActiveRecord::Base
     raise ActiveRecord::Rollback if make_rollback
   end
 
+  def self.returning_method_with_transaction
+    Car.transaction do
+      return Car.create
+    end
+  end
+
   private
 
   def save_once
@@ -91,3 +107,30 @@ class Bar < ActiveRecord::Base
   self.table_name = "cars"
   has_many :bars, :foreign_key => :car_id
 end
+
+class Address < ActiveRecord::Base
+  has_many :people
+
+  after_commit :create_residents, :on => :create
+
+  def create_residents
+    if ActiveRecord::VERSION::MAJOR == 3
+      # stupid hack because nested after_commit is broken on rails 3 and loops
+      return if @create_residents
+      @create_residents = true
+    end
+
+    Person.create!(:address => self)
+    Person.create!(:address => self)
+  end
+end
+
+class Person < ActiveRecord::Base
+  belongs_to :address
+
+  after_commit :update_number_of_residents_on_address, :on => :create
+
+  def update_number_of_residents_on_address
+    address.update_attributes(:number_of_residents => address.number_of_residents + 1)
+  end
+end

data/spec/spec_helper.rb

@@ -13,7 +13,7 @@ RSpec.configure do |config|
       # open a transaction without using .transaction as activerecord use_transactional_fixtures does
       if ActiveRecord::VERSION::MAJOR > 3
         connection = ActiveRecord::Base.connection_handler.connection_pool_list.map(&:connection).first
-        connection.begin_transaction joinable: false
+        connection.begin_transaction :joinable => false
       else
         connection = ActiveRecord::Base.connection_handler.connection_pools.values.map(&:connection).first
         connection.increment_open_transactions

data/spec/test_after_commit_spec.rb

@@ -22,6 +22,13 @@ describe TestAfterCommit do
     Car.called.should == [:update, :always]
   end
 
+  it "fires on update_attribute" do
+    car = Car.create
+    Car.called.clear
+    car.update_attribute :counter, 123
+    Car.called.should == [:update, :always]
+  end
+
   it "does not fire on rollback" do
     car = Car.new
     car.make_rollback = true
@@ -40,6 +47,11 @@ describe TestAfterCommit do
     Car.called.should == [:create, :always]
   end
 
+  it "fires when transaction block returns from method" do
+    Car.returning_method_with_transaction
+    Car.called.should == [:create, :always]
+  end
+
   it "does not raises errors" do
     car = Car.new
     car.raise_error = true
@@ -86,4 +98,20 @@ describe TestAfterCommit do
       Car.called.should == [:observed_after_commit, :create, :always]
     end
   end
+
+  context "nested after_commit" do
+    before do
+      @address = Address.create!
+    end
+
+    it 'is executed' do
+      pending unless ENV["REAL"] && ActiveRecord::VERSION::MAJOR == 4
+      lambda { Person.create!(:address => @address) }.should change(@address, :number_of_residents).by(1)
+
+      # one from the line above and two from the after_commit
+      @address.people.count.should == 3
+
+      @address.number_of_residents.should == 3
+    end
+  end
 end

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: test_after_commit
 version: !ruby/object:Gem::Version
-  version: 0.2.0
-  prerelease: 
+  version: 0.2.1
 platform: ruby
 authors:
 - Michael Grosser
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-04 00:00:00.000000000 Z
+date: 2013-08-22 00:00:00.000000000 Z
 dependencies: []
 description: 
 email: michael@grosser.it
@@ -40,32 +39,25 @@ files:
 homepage: http://github.com/grosser/test_after_commit
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1962794305227048949
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1962794305227048949
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.6
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: makes after_commit callbacks testable in Rails 3+ with transactional_fixtures
 test_files: []