test-prof 0.4.7 → 0.4.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 20a2f32b0735b5254ea790c2d7aca6a342e5fdcf
-  data.tar.gz: 462e6279110f67ddd11523f662c3958e1346b279
+  metadata.gz: 7ee0adbe47a16f3597f414b935d5917664d66da2
+  data.tar.gz: 132cb58a1c11f996f305bd8e6d0a56318f5fe620
 SHA512:
-  metadata.gz: 7466fa2bf79b1b73f3677d48bb56381695b463d019c725343ad85e06419bf5cdfbc70183f36241a87c97fda8b5f3562e2d1d92feb8eaaef0813653f0a04b9b86
-  data.tar.gz: af769d6f5a0a6d2736d4c79cfb3c42831f7f8aa91216a2ab08d90c47a0e3eeaa3a24b31362bd51200c354c9fe399b8d06f3d1cce7d6651cce1352c3b6b11cb3f
+  metadata.gz: f39de8ba35ef1ef80c3ece126fae024761829a524d7c3412b08568b71b70a51a24834dc54f135642800de59d31b54629c8876fbaa58f171ca2857b0a48dd82df
+  data.tar.gz: 20b100dd5c25949fb55e7cad47cfec779288f31a553b12b4e42888208ca34d9ff6cff92d91ef26fa9cf862b9315b2fd1becb76e6b9a01ecc904c0a9a057c1608

data/CHANGELOG.md

@@ -1,6 +1,17 @@
 # Change log
 
-## master
+## 0.4.8
+
+- Add `minitest` 5.11 support. ([@palkan][])
+
+- Fix `spring` detection. ([@palkan][])
+
+  Some `spring`-related gems do not check whether Spring is running and load
+  Spring modules. Thus we have `Spring` defined (and even `Spring.after_fork` defined) but no-op.
+
+  Now we require that `Spring::Applcation` is defined in order to rely on Spring.
+
+  Possibly fixes [#47](https://github.com/palkan/test-prof/issues/47).
 
 ## 0.4.7
 

data/lib/minitest/base_reporter.rb

@@ -30,6 +30,8 @@ module Minitest
       private
 
       def location(group, example = nil)
+        # Minitest::Result (>= 5.11) has `source_location` method
+        return group.source_location if group.respond_to?(:source_location)
         if group.is_a? Class
           suite = group.public_instance_methods.select { |mtd| mtd.to_s.match /^test_/ }
           name = suite.find { |mtd| mtd.to_s == example }

data/lib/test_prof.rb

@@ -59,7 +59,7 @@ module TestProf
     # equal to the provided value (if any).
     # Contains workaround for applications using Spring.
     def activate(env_var, val = nil)
-      if defined?(::Spring)
+      if defined?(::Spring::Application)
         ::Spring.after_fork { activate!(env_var, val) { yield } }
       else
         activate!(env_var, val) { yield }

data/lib/test_prof/factory_doctor.rb

@@ -86,6 +86,14 @@ module TestProf
         res
       end
 
+      def ignore!
+        @ignored = true
+      end
+
+      def ignore?
+        @ignored == true
+      end
+
       def within_factory(strategy)
         return yield if ignore? || !running? || (strategy != :create)
 
@@ -108,6 +116,7 @@ module TestProf
         @time = 0.0
         @count = 0
         @queries_count = 0
+        @ignored = false
       end
 
       def subscribe!
@@ -122,10 +131,6 @@ module TestProf
         @depth > 0
       end
 
-      def ignore?
-        @ignored == true
-      end
-
       def running?
         @running == true
       end

data/lib/test_prof/factory_doctor/minitest.rb

@@ -1,12 +1,20 @@
 # frozen_string_literal: true
 
 require 'minitest/base_reporter'
-require 'minitest/fd_ignorable'
 require 'test_prof/ext/float_duration'
 require 'test_prof/ext/string_strip_heredoc'
 
 module Minitest
-  module TestProf
+  module TestProf # :nodoc:
+    # Add fd_ignore methods
+    module FactoryDoctorIgnore
+      def fd_ignore
+        ::TestProf::FactoryDoctor.ignore!
+      end
+    end
+
+    Minitest::Test.include FactoryDoctorIgnore
+
     class FactoryDoctorReporter < BaseReporter # :nodoc:
       using ::TestProf::FloatDuration
       using ::TestProf::StringStripHeredoc
@@ -27,13 +35,16 @@ module Minitest
 
       def record(example)
         ::TestProf::FactoryDoctor.stop
-        return if example.skipped? || example.fd_ignore?
+        return if example.skipped? || ::TestProf::FactoryDoctor.ignore?
 
         result = ::TestProf::FactoryDoctor.result
         return unless result.bad?
 
+        # Minitest::Result (>= 5.11) has `klass` method
+        group_name = example.respond_to?(:klass) ? example.klass : example.class.name
+
         group = {
-          description: example.class.name,
+          description: group_name,
           location: location_without_line_number(example)
         }
 

data/lib/test_prof/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TestProf
-  VERSION = "0.4.7".freeze
+  VERSION = "0.4.8".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: test-prof
 version: !ruby/object:Gem::Version
-  version: 0.4.7
+  version: 0.4.8
 platform: ruby
 authors:
 - Vladimir Dementyev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-25 00:00:00.000000000 Z
+date: 2018-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -135,7 +135,6 @@ files:
 - guides/tests_sampling.md
 - lib/minitest/base_reporter.rb
 - lib/minitest/event_prof_formatter.rb
-- lib/minitest/fd_ignorable.rb
 - lib/minitest/test_prof_plugin.rb
 - lib/test-prof.rb
 - lib/test_prof.rb

data/lib/minitest/fd_ignorable.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-module Minitest
-  module Assertions # :nodoc:
-    def fd_ignore
-      @fd_ignore = true
-    end
-
-    def fd_ignore?
-      @fd_ignore == true
-    end
-  end
-end