test-prof 0.3.0.beta2 → 0.3.0.beta3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6af9c62cf692b558711fe96e40cff6e82fb49b99
-  data.tar.gz: e308236c1ed5c5c9abc81e6a7a672adfcbc49dbf
+  metadata.gz: 6f2516ff090c97feae6be50fe1edc765aa495337
+  data.tar.gz: d6c4aba8cd0ace60d4c80898a8cfc1b22015a32c
 SHA512:
-  metadata.gz: 493dfc669dec10234282bc6c24c22a4da701537f30f920f295a98993fd029abd47f5fd419e27779711d2f9266c4011778bf61fafb9da8894bfb20b3d18e728d9
-  data.tar.gz: 57f0c57b1320e4f2fa50249e0f88da00fb6091b32faef4f16ef57c65deb784ba203b9bab10d54e5ebc0c279a79de02539f69ea3af2bc429b492060c29ad2d253
+  metadata.gz: ddf6a60d44432bc56b253b7c667f40efedee36f7f37a4710c826ef5625dcb5c6768416e2c8fea681843894dfd8e39d78ba53ea48fb7ff6ee382eb24b807e8afa
+  data.tar.gz: 5fadec4649c715e2fcd93ab5ec6fc4b3e55c6b2cfeba877659431cb6894d3dcc9ed9a5b6bef5b46b36f28cfd34d928a2618b89f195808cc4ef95d9b0f6935f50

data/CHANGELOG.md

@@ -4,6 +4,10 @@
 
 Features:
 
+- Combine RSpecStamp with FactoryDoctor. ([@palkan][])
+
+Automatically mark _bad_ examples with custom tags.
+
 - [#17](https://github.com/palkan/test-prof/pull/17) Combine RSpecStamp with EventProf and RSpecDissect. ([@palkan][])
 
 It is possible now to automatically mark _slow_ examples and groups with custom tags. For example:

data/guides/factory_doctor.md

@@ -62,3 +62,13 @@ To activate FactoryDoctor use `FDOC` environment variable:
 ```sh
 FDOC=1 rspec ...
 ```
+
+## Using with RSpecStamp
+
+FactoryDoctor can be used with [RSpec Stamp](https://github.com/palkan/test-prof/tree/master/guides/rspec_stamp.md) to automatically mark _bad_ examples with custom tags. For example:
+
+```sh
+FDOC=1 FDOC_STAMP="fdoc:consider" rspec ...
+```
+
+After running the command above all _potentially_ bad examples would be marked with the `fdoc: :consider` tag.

data/lib/test_prof/factory_doctor.rb

@@ -54,6 +54,14 @@ module TestProf
           defined?(::FactoryGirl)
 
         subscribe!
+
+        @stamp = ENV['FDOC_STAMP']
+
+        RSpecStamp.config.tags = @stamp if stamp?
+      end
+
+      def stamp?
+        !@stamp.nil?
       end
 
       def start

data/lib/test_prof/factory_doctor/rspec.rb

@@ -70,6 +70,40 @@ module TestProf
         end
 
         log :info, msgs.join
+
+        stamp! if FactoryDoctor.stamp?
+      end
+
+      def stamp!
+        stamper = RSpecStamp::Stamper.new
+
+        examples = Hash.new { |h, k| h[k] = [] }
+
+        @example_groups.each do |_group, bad_examples|
+          bad_examples.each do |example|
+            file, line = example.metadata[:location].split(":")
+            examples[file] << line.to_i
+          end
+        end
+
+        examples.each do |file, lines|
+          stamper.stamp_file(file, lines.uniq)
+        end
+
+        msgs = []
+
+        msgs <<
+          <<-MSG.strip_heredoc
+            RSpec Stamp results
+
+            Total patches: #{stamper.total}
+            Total files: #{examples.keys.size}
+
+            Failed patches: #{stamper.failed}
+            Ignored files: #{stamper.ignored}
+          MSG
+
+        log :info, msgs.join
       end
 
       private

data/lib/test_prof/rspec_stamp.rb

@@ -144,9 +144,9 @@ module TestProf
         need_parens = block == "{"
 
         tags_str = parsed.tags.map { |t| t.is_a?(Symbol) ? ":#{t}" : t }.join(", ") unless
-          parsed.tags.nil?
+          parsed.tags.nil? || parsed.tags.empty?
 
-        unless parsed.htags.nil?
+        unless parsed.htags.nil? || parsed.htags.empty?
           htags_str = parsed.htags.map do |(k, v)|
             vstr = v.is_a?(Symbol) ? ":#{v}" : quote(v)
 
@@ -169,6 +169,7 @@ module TestProf
       # rubocop: enable Metrics/PerceivedComplexity
 
       def quote(str)
+        return str unless str.is_a?(String)
         if str.include?("'")
           "\"#{str}\""
         else

data/lib/test_prof/rspec_stamp/parser.rb

@@ -100,7 +100,24 @@ module TestProf
 
         def parse_hash(res, hash_arg)
           hash_arg.each do |(_, label, val)|
-            res.add_htag label[1][0..-2].to_sym, parse_literal(val)
+            res.add_htag label[1][0..-2].to_sym, parse_value(val)
+          end
+        end
+
+        # Expr of the form:
+        #  bool - [:var_ref, [:@kw, "true", [1, 24]]]
+        #  string - [:string_literal, [:string_content, [...]]]
+        #  int - [:@int, "3", [1, 52]]]]
+        def parse_value(expr)
+          case expr.first
+          when :var_ref
+            expr[1][1] == "true"
+          when :@int
+            expr[1].to_i
+          when :@float
+            expr[1].to_f
+          else
+            parse_literal(expr)
           end
         end
 

data/lib/test_prof/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TestProf
-  VERSION = "0.3.0.beta2".freeze
+  VERSION = "0.3.0.beta3".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: test-prof
 version: !ruby/object:Gem::Version
-  version: 0.3.0.beta2
+  version: 0.3.0.beta3
 platform: ruby
 authors:
 - Vladimir Dementyev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-31 00:00:00.000000000 Z
+date: 2017-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -184,7 +184,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Ruby applications tests profiling tools