test-page 0.0.1 → 0.0.2

data/lib/test/page.rb

@@ -57,12 +57,14 @@ module Test
     #
     # @return [Object] if element is specified for {#initialize}.
     # @return [Object] otherwise {.element} block is evaluated once per {Page} instance and its value will be returned.
+    # @raise [NoBrowserSetException] if {.element} has been set via block and browser has not been set.
     def element
       @setup_done ||= begin
                         setup if respond_to?(:setup)
                         true
                       end
       @element ||= begin
+                     raise_no_browser_set_exception unless browser
                      element_proc = self.class.element_block
                      element_proc && instance_eval(&element_proc)
                    end
@@ -133,9 +135,14 @@ module Test
     # Proxies every method call not found on {Page} to element instance.
     # Subsequent executions of the same method will be invoked on the {Page} object directly.
     def method_missing(name, *args)
-      if element.respond_to?(name)
+      begin
+        el = element
+      rescue SystemStackError
+        raise_invalid_element_definition
+      end
+      if el.respond_to?(name)
         self.class.send :define_method, name do |*args|
-          element.send(name, *args) {yield}
+          el.send(name, *args) {yield}
         end
         self.send(name, *args) {yield}
       else
@@ -151,6 +158,31 @@ module Test
       end
       page_with_browser ? page_with_browser.browser : nil
     end
-      
+
+    def raise_no_browser_set_exception
+      raise NoBrowserSetException.new %q[No browser has been set to the page!
+
+Set it to the class directly:
+  Test::Page.browser = browser_instance
+
+Or set it to the instance of page:
+  page = MyPage.new
+  page.browser = browser_instance]
+    end
+
+    def raise_invalid_element_definition
+      raise InvalidElementDefinition.new %q[Element defined via block cannot be evaluated, because it is causing SystemStackError.
+
+This is usually caused by the fact that the browser instance is not used to search that element.
+
+For example, this is not a correct way to define an element:
+  element { div(:id => "something") }
+
+Correct way would be like this:
+  element { browser.div(:id => "something") }]
+    end
+
+    NoBrowserSetException = Class.new(RuntimeError)
+    InvalidElementDefinition = Class.new(RuntimeError)
   end
 end

data/lib/test/page/version.rb

@@ -1,5 +1,5 @@
 module Test
   class Page
-    VERSION = "0.0.1"
+    VERSION = "0.0.2"
   end
 end

data/spec/test/page_spec.rb

@@ -3,10 +3,9 @@ require File.expand_path("../../lib/test/page", File.dirname(__FILE__))
 
 describe Test::Page do
   let(:page_class) { Class.new(Test::Page) }
+  before { Test::Page.browser = nil }
 
   context ".browser" do
-    before { Test::Page.browser = nil }
-
     it "sets the browser object for page" do
       Test::Page.browser = "my browser"
       Test::Page.browser.should == "my browser"
@@ -32,6 +31,8 @@ describe Test::Page do
   end
 
   context ".element" do
+    before { page_class.browser = "foo" }
+
     it "sets the element via block" do
       page_class.element { "my element" }
       page = page_class.new
@@ -48,6 +49,7 @@ describe Test::Page do
 
   context "#element" do
     it "evaluates element provided by the block only once per instance" do
+      page_class.browser = "foo"
       block_called = false
       page_class.element do
         raise "block should have been called only once!" if block_called
@@ -58,6 +60,23 @@ describe Test::Page do
       2.times { page.element.should == "my element in block" }
       block_called.should be_true
     end
+
+    it "raises an exception if browser is not set" do
+      page_class.element { "whatever" }
+
+      expect {
+        page_class.new.element
+      }.to raise_error(Test::Page::NoBrowserSetException)
+    end
+
+    it "raises an exception if element is set via block without using browser" do
+      page_class.element { foo_bar }
+      page_class.browser = "foo"
+
+      expect {
+        page_class.new.element
+      }.to raise_error(Test::Page::InvalidElementDefinition)
+    end
   end
 
   context "#setup" do
@@ -121,6 +140,7 @@ describe Test::Page do
     it "returns the new page instance" do
       second_page = Class.new(Test::Page)
       page_class.send(:define_method, :redirect_me) { redirect_to second_page }
+      page_class.browser = "foo"
       page = page_class.new
       page.redirect_me.should be_an_instance_of(second_page)
     end
@@ -128,6 +148,7 @@ describe Test::Page do
     it "reuses the existing page element" do
       second_page = Class.new(Test::Page)
       page_class.send(:define_method, :redirect_me) { redirect_to second_page }
+      page_class.browser = "foo"
       page = page_class.new "provided element"
       redirected_page = page.redirect_me
       redirected_page.element.should == "provided element"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: test-page
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-31 00:00:00.000000000 Z
+date: 2012-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec