test-kitchen 1.4.2 → 1.5.0.rc.1

data/spec/kitchen/provisioner/chef_solo_spec.rb

@@ -296,6 +296,23 @@ describe Kitchen::Provisioner::ChefSolo do
 
     let(:cmd) { provisioner.run_command }
 
+    describe "common behavior" do
+
+      before { platform.stubs(:shell_type).returns("fake") }
+
+      it "prefixs the whole command with the command_prefix if set" do
+        config[:command_prefix] = "my_prefix"
+
+        cmd.must_match(/\Amy_prefix /)
+      end
+
+      it "does not prefix the command if command_prefix is not set" do
+        config[:command_prefix] = nil
+
+        cmd.wont_match(/\Amy_prefix /)
+      end
+    end
+
     describe "for bourne shells" do
 
       before { platform.stubs(:shell_type).returns("bourne") }

data/spec/kitchen/provisioner/chef_zero_spec.rb

@@ -588,8 +588,8 @@ describe Kitchen::Provisioner::ChefZero do
           " --config #{custom_base}client.rb", :partial_line)
       end
 
-      it "sets log level flag on chef-client to auto by default" do
-        cmd.must_match regexify(" --log_level auto", :partial_line)
+      it "sets log level flag on chef-client to warn by default" do
+        cmd.must_match regexify(" --log_level warn", :partial_line)
       end
 
       it "set log level flag for custom level" do
@@ -634,6 +634,18 @@ describe Kitchen::Provisioner::ChefZero do
       it "does not set logfile flag by default" do
         cmd.wont_match regexify(" --logfile ", :partial_line)
       end
+
+      it "prefixs the whole command with the command_prefix if set" do
+        config[:command_prefix] = "my_prefix"
+
+        cmd.must_match(/\Amy_prefix /)
+      end
+
+      it "does not prefix the command if command_prefix is not set" do
+        config[:command_prefix] = nil
+
+        cmd.wont_match(/\Amy_prefix /)
+      end
     end
     # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
 

data/spec/kitchen/provisioner/shell_spec.rb

@@ -119,15 +119,27 @@ describe Kitchen::Provisioner::Shell do
         ])
       end
 
-      it "exports all http proxy variables when both are set" do
+      it "exports ftp_proxy & FTP_PROXY when :ftp_proxy is set" do
+        config[:ftp_proxy] = "ftp://proxy"
+
+        cmd.lines.to_a[1..2].must_equal([
+          %{ftp_proxy="ftp://proxy"; export ftp_proxy\n},
+          %{FTP_PROXY="ftp://proxy"; export FTP_PROXY\n}
+        ])
+      end
+
+      it "exports all proxy variables when all are set" do
         config[:http_proxy] = "http://proxy"
         config[:https_proxy] = "https://proxy"
+        config[:ftp_proxy] = "ftp://proxy"
 
-        cmd.lines.to_a[1..4].must_equal([
+        cmd.lines.to_a[1..6].must_equal([
           %{http_proxy="http://proxy"; export http_proxy\n},
           %{HTTP_PROXY="http://proxy"; export HTTP_PROXY\n},
           %{https_proxy="https://proxy"; export https_proxy\n},
-          %{HTTPS_PROXY="https://proxy"; export HTTPS_PROXY\n}
+          %{HTTPS_PROXY="https://proxy"; export HTTPS_PROXY\n},
+          %{ftp_proxy="ftp://proxy"; export ftp_proxy\n},
+          %{FTP_PROXY="ftp://proxy"; export FTP_PROXY\n}
         ])
       end
 
@@ -184,15 +196,27 @@ describe Kitchen::Provisioner::Shell do
         ])
       end
 
-      it "exports all http proxy variables when both are set" do
+      it "exports ftp_proxy & FTP_PROXY when :ftp_proxy is set" do
+        config[:ftp_proxy] = "ftp://proxy"
+
+        cmd.lines.to_a[0..1].must_equal([
+          %{$env:ftp_proxy = "ftp://proxy"\n},
+          %{$env:FTP_PROXY = "ftp://proxy"\n}
+        ])
+      end
+
+      it "exports all proxy variables when all are set" do
         config[:http_proxy] = "http://proxy"
         config[:https_proxy] = "https://proxy"
+        config[:ftp_proxy] = "ftp://proxy"
 
-        cmd.lines.to_a[0..3].must_equal([
+        cmd.lines.to_a[0..5].must_equal([
           %{$env:http_proxy = "http://proxy"\n},
           %{$env:HTTP_PROXY = "http://proxy"\n},
           %{$env:https_proxy = "https://proxy"\n},
-          %{$env:HTTPS_PROXY = "https://proxy"\n}
+          %{$env:HTTPS_PROXY = "https://proxy"\n},
+          %{$env:ftp_proxy = "ftp://proxy"\n},
+          %{$env:FTP_PROXY = "ftp://proxy"\n}
         ])
       end
 
@@ -253,15 +277,27 @@ describe Kitchen::Provisioner::Shell do
         ])
       end
 
-      it "exports all http proxy variables when both are set" do
+      it "exports ftp_proxy & FTP_PROXY when :ftp_proxy is set" do
+        config[:ftp_proxy] = "ftp://proxy"
+
+        cmd.lines.to_a[1..2].must_equal([
+          %{ftp_proxy="ftp://proxy"; export ftp_proxy\n},
+          %{FTP_PROXY="ftp://proxy"; export FTP_PROXY\n}
+        ])
+      end
+
+      it "exports all proxy variables when all are set" do
         config[:http_proxy] = "http://proxy"
         config[:https_proxy] = "https://proxy"
+        config[:ftp_proxy] = "ftp://proxy"
 
-        cmd.lines.to_a[1..4].must_equal([
+        cmd.lines.to_a[1..6].must_equal([
           %{http_proxy="http://proxy"; export http_proxy\n},
           %{HTTP_PROXY="http://proxy"; export HTTP_PROXY\n},
           %{https_proxy="https://proxy"; export https_proxy\n},
-          %{HTTPS_PROXY="https://proxy"; export HTTPS_PROXY\n}
+          %{HTTPS_PROXY="https://proxy"; export HTTPS_PROXY\n},
+          %{ftp_proxy="ftp://proxy"; export ftp_proxy\n},
+          %{FTP_PROXY="ftp://proxy"; export FTP_PROXY\n}
         ])
       end
 
@@ -306,15 +342,27 @@ describe Kitchen::Provisioner::Shell do
         ])
       end
 
-      it "exports all http proxy variables when both are set" do
+      it "exports ftp_proxy & FTP_PROXY when :ftp_proxy is set" do
+        config[:ftp_proxy] = "ftp://proxy"
+
+        cmd.lines.to_a[0..1].must_equal([
+          %{$env:ftp_proxy = "ftp://proxy"\n},
+          %{$env:FTP_PROXY = "ftp://proxy"\n}
+        ])
+      end
+
+      it "exports all proxy variables when all are set" do
         config[:http_proxy] = "http://proxy"
         config[:https_proxy] = "https://proxy"
+        config[:ftp_proxy] = "ftp://proxy"
 
-        cmd.lines.to_a[0..3].must_equal([
+        cmd.lines.to_a[0..5].must_equal([
           %{$env:http_proxy = "http://proxy"\n},
           %{$env:HTTP_PROXY = "http://proxy"\n},
           %{$env:https_proxy = "https://proxy"\n},
-          %{$env:HTTPS_PROXY = "https://proxy"\n}
+          %{$env:HTTPS_PROXY = "https://proxy"\n},
+          %{$env:ftp_proxy = "ftp://proxy"\n},
+          %{$env:FTP_PROXY = "ftp://proxy"\n}
         ])
       end
 

data/spec/kitchen/transport/winrm_spec.rb

@@ -24,6 +24,23 @@ require "winrm/transport/command_executor"
 require "winrm/transport/shell_closer"
 require "winrm/transport/file_transporter"
 
+module Kitchen
+
+  module Transport
+
+    class WinRMConnectionDummy < Kitchen::Transport::Winrm::Connection
+
+      attr_reader :saved_command, :remote_path, :local_path
+
+      def upload(locals, remote)
+        @saved_command = IO.read(locals)
+        @local_path = locals
+        @remote_path = remote
+      end
+    end
+  end
+end
+
 describe Kitchen::Transport::Winrm do
 
   let(:logged_output) { StringIO.new }
@@ -576,6 +593,39 @@ describe Kitchen::Transport::Winrm::Connection do
       end
     end
 
+    describe "long command" do
+      let(:command) { %{Write-Host "#{"a" * 4000}"} }
+
+      let(:connection) do
+        Kitchen::Transport::WinRMConnectionDummy.new(options)
+      end
+
+      let(:response) do
+        o = WinRM::Output.new
+        o[:exitcode] = 0
+        o[:data].concat([
+          { :stdout => "ok\r\n" },
+          { :stderr => "congrats\r\n" }
+        ])
+        o
+      end
+
+      before do
+        executor.expects(:open).returns("shell-123")
+        executor.expects(:run_powershell_script).
+          with(%{& "$env:TEMP/kitchen/coolbeans-long_script.ps1"}).
+          yields("ok\n", nil).returns(response)
+      end
+
+      it "uploads the long command" do
+        with_fake_fs do
+          connection.execute(command)
+
+          connection.saved_command.must_equal command
+        end
+      end
+    end
+
     describe "for a failed command" do
 
       let(:response) do

data/spec/kitchen/verifier/base_spec.rb

@@ -17,6 +17,7 @@
 # limitations under the License.
 
 require_relative "../../spec_helper"
+require_relative "../ssh_spec"
 
 require "logger"
 require "stringio"
@@ -139,6 +140,10 @@ describe Kitchen::Verifier::Base do
     it ":http_proxys defaults to nil" do
       verifier[:https_proxy].must_equal nil
     end
+
+    it ":ftp_proxy defaults to nil" do
+      verifier[:ftp_proxy].must_equal nil
+    end
   end
 
   describe "#call" do
@@ -333,4 +338,25 @@ describe Kitchen::Verifier::Base do
       end
     end
   end
+
+  describe "#prefix_command" do
+
+    describe "with :command_prefix set" do
+
+      before { config[:command_prefix] = "my_prefix" }
+
+      it "prepends the command with the prefix" do
+        verifier.send(:prefix_command, "my_command").must_equal("my_prefix my_command")
+      end
+    end
+
+    describe "with :command_prefix unset" do
+
+      before { config[:command_prefix] = nil }
+
+      it "returns an unaltered command" do
+        verifier.send(:prefix_command, "my_command").must_equal("my_command")
+      end
+    end
+  end
 end

data/spec/kitchen/verifier/busser_spec.rb

@@ -101,7 +101,9 @@ describe Kitchen::Verifier::Busser do
 
     describe "for unix operating systems" do
 
-      before { platform.stubs(:os_type).returns("unix") }
+      before {
+        platform.stubs(:os_type).returns("unix")
+      }
 
       it ":ruby_bindir defaults the an Omnibus Chef installation" do
         verifier[:ruby_bindir].must_equal "/opt/chef/embedded/bin"
@@ -210,6 +212,26 @@ describe Kitchen::Verifier::Busser do
 
     describe "with suite test files" do
 
+      describe "common behavior" do
+
+        before do
+          platform.stubs(:shell_type).returns("fake")
+          create_test_files
+        end
+
+        it "prefixs the whole command with the command_prefix if set" do
+          config[:command_prefix] = "my_prefix"
+
+          cmd.must_match(/\Amy_prefix /)
+        end
+
+        it "does not prefix the command if command_prefix is not set" do
+          config[:command_prefix] = nil
+
+          cmd.wont_match(/\Amy_prefix /)
+        end
+      end
+
       describe "for bourne shells" do
 
         before do
@@ -237,7 +259,9 @@ describe Kitchen::Verifier::Busser do
 
         it "sets gem install arguments" do
           cmd.must_match regexify(
-            %{gem_install_args="busser --no-rdoc --no-ri"})
+            "gem_install_args=\"busser --no-rdoc --no-ri --no-format-executable" \
+            " -n /r/bin --no-user-install\""
+          )
         end
 
         it "prepends sudo for busser binstub command when :sudo is set" do
@@ -284,7 +308,9 @@ describe Kitchen::Verifier::Busser do
 
         it "sets gem install arguments" do
           cmd.must_match regexify(
-            %{$gem_install_args = "busser --no-rdoc --no-ri"})
+            "$gem_install_args = \"busser --no-rdoc --no-ri --no-format-executable" \
+            " -n \\r\\bin --no-user-install\""
+          )
         end
 
         it "sets path to busser binstub command" do
@@ -329,6 +355,26 @@ describe Kitchen::Verifier::Busser do
 
     describe "with suite test files" do
 
+      describe "common behavior" do
+
+        before do
+          platform.stubs(:shell_type).returns("fake")
+          create_test_files
+        end
+
+        it "prefixs the whole command with the command_prefix if set" do
+          config[:command_prefix] = "my_prefix"
+
+          cmd.must_match(/\Amy_prefix /)
+        end
+
+        it "does not prefix the command if command_prefix is not set" do
+          config[:command_prefix] = nil
+
+          cmd.wont_match(/\Amy_prefix /)
+        end
+      end
+
       describe "for bourne shells" do
 
         before do
@@ -407,6 +453,26 @@ describe Kitchen::Verifier::Busser do
 
     describe "with suite test files" do
 
+      describe "common behavior" do
+
+        before do
+          platform.stubs(:shell_type).returns("fake")
+          create_test_files
+        end
+
+        it "prefixs the whole command with the command_prefix if set" do
+          config[:command_prefix] = "my_prefix"
+
+          cmd.must_match(/\Amy_prefix /)
+        end
+
+        it "does not prefix the command if command_prefix is not set" do
+          config[:command_prefix] = nil
+
+          cmd.wont_match(/\Amy_prefix /)
+        end
+      end
+
       describe "for bourne shells" do
 
         before do

data/spec/kitchen/verifier/shell_spec.rb

@@ -0,0 +1,157 @@
+# -*- encoding: utf-8 -*-
+#
+# Author:: SAWANOBORI Yukihiko (<sawanoboriyu@higanworks.com>)
+#
+# Copyright (C) 2015, HiganWorks LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+require_relative "../../spec_helper"
+
+require "logger"
+require "stringio"
+
+require "kitchen/verifier/shell"
+
+describe Kitchen::Verifier::Shell do
+
+  let(:logged_output) { StringIO.new }
+  let(:logger)        { Logger.new(logged_output) }
+  let(:platform)      { stub(:os_type => nil, :shell_type => nil, :name => "coolbeans") }
+  let(:suite)         { stub(:name => "fries") }
+  let(:state)         { Hash.new }
+
+  let(:config) do
+    { :test_base_path => "/basist", :kitchen_root => "/rooty" }
+  end
+
+  let(:instance) do
+    stub(
+      :name => [platform.name, suite.name].join("-"),
+      :to_str => "instance",
+      :logger => logger,
+      :suite => suite,
+      :platform => platform
+    )
+  end
+
+  let(:verifier) do
+    Kitchen::Verifier::Shell.new(config).finalize_config!(instance)
+  end
+
+  it "verifier api_version is 1" do
+    verifier.diagnose_plugin[:api_version].must_equal 1
+  end
+
+  it "plugin_version is set to Kitchen::VERSION" do
+    verifier.diagnose_plugin[:version].must_equal Kitchen::VERSION
+  end
+
+  describe "configuration" do
+
+    it "sets :sleep to 0 by default" do
+      verifier[:sleep].must_equal 0
+    end
+
+    it "sets :command to 'true' by default" do
+      verifier[:command].must_equal "true"
+    end
+
+    it "sets :live_stream to stdout by default" do
+      verifier[:live_stream].must_equal $stdout
+    end
+  end
+
+  describe "#call" do
+
+    describe "#shell_out" do
+      it "calls sleep if :sleep value is greater than 0" do
+        config[:sleep] = 3
+        verifier.expects(:sleep).with(1).returns(true).at_least(3)
+
+        verifier.call(state)
+      end
+
+      it "states are set to environment" do
+        state[:hostname] = "testhost"
+        state[:server_id] = "i-xxxxxx"
+        verifier.call(state)
+        config[:shellout_opts][:environment]["KITCHEN_HOSTNAME"].must_equal "testhost"
+        config[:shellout_opts][:environment]["KITCHEN_SERVER_ID"].must_equal "i-xxxxxx"
+        config[:shellout_opts][:environment]["KITCHEN_INSTANCE"].must_equal "coolbeans-fries"
+        config[:shellout_opts][:environment]["KITCHEN_PLATFORM"].must_equal "coolbeans"
+        config[:shellout_opts][:environment]["KITCHEN_SUITE"].must_equal "fries"
+      end
+
+      it "raises ActionFailed if set false to :command" do
+        config[:command] = "false"
+
+        proc { verifier.call(state) }.must_raise Kitchen::ActionFailed
+      end
+
+      it "logs a converge event to INFO" do
+        verifier.call(state)
+
+        logged_output.string.must_match(/^.+ INFO .+ \[Shell\] Verify on .+$/)
+      end
+    end
+
+    describe "remote_exec" do
+      let(:transport) do
+        t = mock("transport")
+        t.responds_like_instance_of(Kitchen::Transport::Ssh)
+        t
+      end
+
+      let(:connection) do
+        c = mock("transport_connection")
+        c.responds_like_instance_of(Kitchen::Transport::Ssh::Connection)
+        c
+      end
+
+      let(:instance) do
+        stub(
+          :name => "coolbeans",
+          :to_str => "instance",
+          :logger => logger,
+          :platform => platform,
+          :suite => suite,
+          :transport => transport
+        )
+      end
+
+      before do
+        transport.stubs(:connection).yields(connection)
+        connection.stubs(:execute)
+      end
+
+      it "execute command onto instance." do
+        config[:remote_exec] = true
+
+        transport.expects(:connection).with(state).yields(connection)
+        verifier.call(state)
+      end
+    end
+  end
+
+  describe "#run_command" do
+    it "execute localy and returns nil" do
+      verifier.run_command
+    end
+
+    it "returns string when remote_exec" do
+      config[:remote_exec] = true
+      verifier.run_command.must_equal "true"
+    end
+  end
+end