test-factory 0.2.4 → 0.2.5

data/README.md

@@ -35,6 +35,13 @@ Using the TestFactory properly involves three distinct steps:
    level requires only basic skills with Ruby and Watir, but a strong command of your DSL
    (the thing you're building with TestFactory).
 
+These three steps can all be accomplished by a single person. However, ideally, they should be done by three or four people, as the design philosophy of TestFactory allows for specialization:
+
+ - A Watir specialist works on defining page elements and actions inside of page classes
+ - A Ruby specialist uses the output of the Watir specialist to build the data objects and their helper methods, creating the DSL for the project
+ - A non-programmer--say, a business analyst or a manual tester with domain expertise--writes test scenarios, in English
+ - A more junior automation engineer translates the English into Ruby code, via the DSL created by the Ruby specialist (if you're using Cucumber, these would be your step definitions)
+
 How to Start
 ------------
 
@@ -120,7 +127,7 @@ class YourDataObject
     # Hash into YourDataObject's class instance variables
     set_options(defaults.merge(opts))
 
-    requires @id # This line allows you to specify any class instance variables that must
+    requires :id # This line allows you to specify any class instance variables that must
                  # be explicitly defined for the data object
   end
 
@@ -227,12 +234,12 @@ end
 ```
 
 *  The setting of random values for select lists in a data object is determined by passing
-   the symbol `:random` in the instance variable, or as the value in the key/value pair
+   the string '::random::' in the instance variable, or as the value in the key/value pair
    passed in an `#edit` method's `opts` parameter. The `#create` and `#edit` methods will
    handle the necessary logic. The purpose is to prevent the need for custom randomizing
    CRUD methods in the data object.
 *  See the gem_ext.rb file's discussion of the Watir `#fit` method for additional
-   design pattern rules to follow.
+   design pattern rules to follow (If you're reading this on rubydoc.info then click the Watir module link)
 *  Please make an effort to follow the [Ruby Style Guidelines](http://www.caliban.org/ruby/rubyguide.shtml#style).
 
 Notice

data/lib/test-factory/page_factory.rb

@@ -79,6 +79,7 @@ class PageFactory
     #   action(:select_style) { |stylename, b| b.div(:text=>/#{Regexp.escape(stylename)}/).link(:text=>"Select").click } => #select_style(stylename)
     #
     def action method_name, &block
+      raise "#{method_name} is being defined twice in #{self}!" if self.instance_methods.include?(method_name.to_sym)
       define_method method_name.to_s do |*thing|
         Proc.new(&block).call *thing, self
       end
@@ -98,7 +99,9 @@ class PageFactory
     #
     # The last parameter in the method is optional. Use it when
     # you need the method name to be different from the text of
-    # the link--for example if the link text changes and you don't
+    # the link--for example if the link text is something unhelpful,
+    # like "here", or else the link text gets updated (e.g., what was
+    # "Log In" is now "Sign In", instead) and you don't
     # want to have to go through all your data objects and step
     # definitions to update them to the new method name.
     #
@@ -124,7 +127,8 @@ class PageFactory
     #
     # The last parameter in the method is optional. Use it when
     # you need the method name to be different from the text of
-    # the button--for example if the button text changes and you don't
+    # the button--for example if the button text is unhelpful, like "Go", or else
+    # it changes (e.g., from "Update" to "Edit") and you don't
     # want to have to go through all your data objects and step
     # definitions to update them to the new method name.
     #

data/lib/test-factory/string_factory.rb

@@ -9,9 +9,7 @@ module StringFactory
   # @param s [String] Typically this will be left blank, but if included, any string created will be prepended with s. Note that the string length will still be as specified
   #
   def random_string(length=10, s="")
-    length.enum_for(:times).inject(s) do |result, index|
-      s << rand(93) + 33
-    end
+    length.enum_for(:times).inject(s) { s << rand(93) + 33 }
   end
 
   # A random string creator that draws from all printable ASCII and High ASCII characters
@@ -20,9 +18,7 @@ module StringFactory
   # @param s [String] Typically this will be left blank, but if included, any string created will be prepended with s. Note that the string length will still be as specified
   #
   def random_high_ascii(length=10, s="")
-    length.enum_for(:times).inject(s) do |result, index|
-      s << rand(223) + 33
-    end
+    length.enum_for(:times).inject(s) { s << rand(223) + 33 }
   end
 
   # A "friendlier" random string generator. No characters need to be escaped for valid URLs.

data/test-factory.gemspec

@@ -1,6 +1,6 @@
 spec = Gem::Specification.new do |s|
   s.name = 'test-factory'
-  s.version = '0.2.4'
+  s.version = '0.2.5'
   s.summary = %q{rSmart's framework for creating automated testing scripts}
   s.description = %q{This gem provides a set of modules and methods to help quickly and DRYly create a test automation framework using Ruby and Watir (or watir-webdriver).}
   s.files = Dir.glob("**/**/**")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: test-factory
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-19 00:00:00.000000000 Z
+date: 2013-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: watir-webdriver