test-cmd.rb 2.7.1 → 2.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 79bec627803ce82d85c99a7f55f00b007cdfba9ecf54634b8c48e9fa64083b17
-  data.tar.gz: 73ab470f82fc83f120ab84c5a4345ce6da2c417edf121e24db314ba2cd9b1dad
+  metadata.gz: a9c323a0dbc2f142481d09008829ca2f3e6d8dc53d4f4c3dcf1efacc3096f58b
+  data.tar.gz: d3ff8c6062fe90054e4953a5ea69c6aacb4048b420c6b6344b6985ebee751e29
 SHA512:
-  metadata.gz: e9d84416530c7becb5915bca84d2bc7eb17532d0bbb53756d205ab2ba06c6f63999ad395ca206e6a943d6f24fc2ce3913b0db7061164bab018499021a3705e20
-  data.tar.gz: 6aedc2200539e08f31eebd9d480cbb3c7a4ee0096e477d153a969096df542e79e5b3ac236ebabce6c476bba9f3fce2c3b5210c97e5378d9dd50a3e6fbc406d9c
+  metadata.gz: 13e73947059bbb45f6c9c6af29619e7d22751af6dda7574aa5c2b87485786d0c8e2f2e88f2739c9c4087c88e55536c6f18e617ce033fd2a0616494e72fea185b
+  data.tar.gz: 6556f3ff5a3bc05f71ecbb4242ed3cccdfd7aa5f3dc528ca09daf6c850e797595cf1de6c3c426b7a4e1061145588c84215ba034a09228fe09f5a9a51ea059d1b

data/lib/test/command/version.rb

@@ -4,5 +4,5 @@ end unless defined?(Test)
 class Test::Command
   ##
   # @string [String]
-  VERSION = "2.7.1"
+  VERSION = "2.7.2"
 end

data/lib/test/command.rb

@@ -102,8 +102,10 @@ class Test::Command
       @producer = Thread.new do
         @stdout = read_limited(@out.r, @limit[:stdout])
         @stderr = read_limited(@err.r, @limit[:stderr])
-        Process.wait
-        @status = $?
+        @status = Process.waitpid2(@pid).last
+      rescue Errno::ECHILD
+        errpid  = Process.spawn("false")
+        @status = Process.waitpid2(errpid).last
       ensure
         @out.r.close
         @err.r.close

data/test/cmd_test.rb

@@ -263,3 +263,44 @@ class Test::Command
     end
   end
 end
+
+class Test::Command
+  ##
+  # A command's status belongs to the command, and is not taken from
+  # another child that happens to be ready to be reaped.
+  #
+  # A bare `Process.wait` reaps whichever child is ready, so a child
+  # that has exited and been reaped by nobody - another test's, another
+  # thread's - could answer for a command that never spawned it.
+  class StatusTest < Test
+    def test_failure_is_not_answered_by_a_successful_decoy
+      decoy = Process.spawn("true")
+      sleep 0.1
+      assert_equal false, ::Test::Command.new("false").success?
+    ensure
+      reap(decoy)
+    end
+
+    def test_success_is_not_answered_by_a_failing_decoy
+      decoy = Process.spawn("false")
+      sleep 0.1
+      assert_equal true, ::Test::Command.new("true").success?
+    ensure
+      reap(decoy)
+    end
+
+    private
+
+    ##
+    # Reaps a decoy the command left alone, and says nothing when the
+    # command took it: the test that got there first is the point of
+    # these.
+    # @param [Integer, nil] pid
+    # @return [void]
+    def reap(pid)
+      Process.waitpid(pid) if pid
+    rescue Errno::ECHILD
+      nil
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: test-cmd.rb
 version: !ruby/object:Gem::Version
-  version: 2.7.1
+  version: 2.7.2
 platform: ruby
 authors:
 - Robert Gleeson
@@ -124,7 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.20
+rubygems_version: 4.0.16
 specification_version: 4
 summary: test-cmd.rb is a Go-inspired, object-oriented interface for running commands
   on UNIX-like systems, in the spirit of Go's `os/exec`. A command can be built by