tessa 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 81149b78c787bad3ecc780af3813bdd561a6bee6
-  data.tar.gz: 47db4550ad97c731ead3e96578108b0017422247
+  metadata.gz: 93cafce92a98390762cbd8d7f1d033e7b03e15a1
+  data.tar.gz: ac5791937677c234980abb77e77caec40a7f6898
 SHA512:
-  metadata.gz: 61d136b95f0682a8609a43130d2cd1bf5f91d6195c8ccadd99a152cee2b9ad6660f80311f41f008227ced1f4fee885e9d90d5b0bcad9151b8b158386e3ce2678
-  data.tar.gz: 15c2e37be659860fbb28b9e525f1316c924e14fea7ed64b72ef91948e1a923a9f1812d17a5dc5249cf1bab762952a9f00561e2ba45dae37cb70a261959e6ad4e
+  metadata.gz: d0146024146bcf5204facc53f4abf14df135a2728e8101715630dfa5b8b52634672296fd94e2655922d1bd1aa50aceb788c3428cb2e25f5baa105e1bd8a984ca
+  data.tar.gz: 28c21e8452a61969bba191101298638d1489a163ec4ea1d1be889dd892c7f7cfb91665691ccbbf077d56e62ff59f300467492c9f97c248b7d15f1e977ef767ac

data/.env.example

@@ -1,5 +1,5 @@
 TESSA_USERNAME=username
 TESSA_PASSWORD=password
 TESSA_URL=http://tessa.dev
-TESSA_DEFAULT_STRATEGY=default
+TESSA_STRATEGY=default
 

data/lib/tessa.rb

@@ -18,4 +18,6 @@ module Tessa
   def self.setup
     yield config
   end
+
+  class RequestFailed < StandardError; end
 end

data/lib/tessa/config.rb

@@ -2,10 +2,12 @@ module Tessa
   class Config
     include Virtus.model
 
+    DEFAULT_STRATEGY = "default"
+
     attribute :username, String, default: -> (*_) { ENV['TESSA_USERNAME'] }
     attribute :password, String, default: -> (*_) { ENV['TESSA_PASSWORD'] }
     attribute :url, String, default: -> (*_) { ENV['TESSA_URL'] }
-    attribute :default_strategy, String, default: -> (*_) { ENV['TESSA_DEFAULT_STRATEGY'] }
+    attribute :strategy, String, default: -> (*_) { ENV['TESSA_STRATEGY'] || DEFAULT_STRATEGY }
 
     def connection
       @connection ||= Faraday.new(url: url) do |conn|

data/lib/tessa/response_factory.rb

@@ -2,6 +2,7 @@ module Tessa
   module ResponseFactory
 
     def new_from_response(response)
+      raise RequestFailed unless response.success?
       case json = JSON.parse(response.body)
       when Array
         json.map { |record| new record }

data/lib/tessa/upload.rb

@@ -17,7 +17,7 @@ module Tessa
     end
 
     def self.create(connection: Tessa.config.connection,
-                    strategy: Tessa.config.default_strategy,
+                    strategy: Tessa.config.strategy,
                     **options)
       new_from_response connection.post('/uploads', options.merge(strategy: strategy))
     end

data/lib/tessa/version.rb

@@ -1,3 +1,3 @@
 module Tessa
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/tessa/config_spec.rb

@@ -52,15 +52,19 @@ RSpec.describe Tessa::Config do
     end
   end
 
-  describe "#default_strategy" do
+  describe "#strategy" do
     it_behaves_like "defaults to environment variable" do
-      let(:variable_name) { 'TESSA_DEFAULT_STRATEGY' }
-      subject(:default_strategy) { config.default_strategy }
+      let(:variable_name) { 'TESSA_STRATEGY' }
+      subject(:strategy) { config.strategy }
+    end
+
+    it "uses the string 'default' when no envvar passed" do
+      expect(config.strategy).to eq("default")
     end
 
     it "behaves like a normal accessor" do
-      config.default_strategy = "my-new-value"
-      expect(config.default_strategy).to eq("my-new-value")
+      config.strategy = "my-new-value"
+      expect(config.strategy).to eq("my-new-value")
     end
   end
 

data/spec/tessa/upload_spec.rb

@@ -56,6 +56,18 @@ RSpec.describe Tessa::Upload do
       end
     end
 
+    context "when response is not successful" do
+      let(:faraday_stubs) {
+        Faraday::Adapter::Test::Stubs.new do |stub|
+          stub.send(method, path) { |env| [422, {}, { "error" => "error" }.to_json] }
+        end
+      }
+
+      it "raises Tessa::RequestFailed" do
+        expect{ call }.to raise_error(Tessa::RequestFailed)
+      end
+    end
+
     it "returns an instance of #{return_type}" do
       expect(call).to be_a(return_type)
     end
@@ -91,8 +103,8 @@ RSpec.describe Tessa::Upload do
     end
 
     describe ":strategy param" do
-      it "defaults to config.default_strategy" do
-        expect(Tessa.config).to receive(:default_strategy).and_return(:my_default)
+      it "defaults to config.strategy" do
+        expect(Tessa.config).to receive(:strategy).and_return(:my_default)
         expect_post_with_hash_including(strategy: :my_default)
         described_class.create(connection: connection)
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tessa
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Justin Powell
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-10 00:00:00.000000000 Z
+date: 2015-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday