terraform_landscape 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 40513d03606eab44c554ef6196aa955f8754a152
-  data.tar.gz: ce631707b6a1e771f28d2889106223c4a52102aa
+  metadata.gz: 3ace34fbfa3fda6d50ce79a8742347010d6c8b61
+  data.tar.gz: c6bcaeeb446acbf6384e3a393f6c0fd77570fcf2
 SHA512:
-  metadata.gz: 87ada90324a21ad2d9f86e4260cf608bbe6326935a79b9cb70e83d375f28008230e5861a0cb434ba9dd20eec10422859e1c005dbfa37fbe9d6c7959454791246
-  data.tar.gz: 7cea6eed6a12dc627846df140a42fefa79fe2a4d348d1f3bed1d54f97d335f0e3db9007a1b2e775e7d18d68c7f8d3e61a8f9e5b1fe1a31344090e8e7f8036bc5
+  metadata.gz: 79be9e2e8d64bfe76f7b1d788f6b887f4946f3e9c08ba52ee46e0bca80c22222b9d904ae70bab9d878df6d290b20602b1ccf69cdc7b325a6b8c65a70975be59a
+  data.tar.gz: aa2e0b433e761b1102868d24e67c195bb79fa31e89d4688f016f65189a9d83d010278ec057ff5727155c729cfd092788dc93bb97a66c05d590451c8fb64b461e

data/lib/terraform_landscape/arguments_parser.rb

@@ -13,7 +13,7 @@ module TerraformLandscape
       @options[:command] = :pretty_print # Default command
 
       OptionParser.new do |parser|
-        parser.banner = "Usage: landscape [options] [plan-output-file]"
+        parser.banner = 'Usage: landscape [options] [plan-output-file]'
 
         add_info_options parser
       end.parse!(args)

data/lib/terraform_landscape/cli.rb

@@ -15,7 +15,7 @@ module TerraformLandscape
     # @param args [Array<String>] command line arguments
     #
     # @return [Integer] exit status code
-    def run(args)
+    def run(_args)
       program :name, 'Terraform Landscape'
       program :version, VERSION
       program :description, 'Pretty-print your Terraform plan output'

data/lib/terraform_landscape/printer.rb

@@ -1,6 +1,8 @@
 require 'stringio'
 
 module TerraformLandscape
+  # Takes output from Terraform executable nad outputs it in a prettified
+  # format.
   class Printer
     def initialize(output)
       @output = output
@@ -30,7 +32,10 @@ module TerraformLandscape
         io.close
       end
 
-      plan_output = buffer.string
+      process_string(buffer.string)
+    end
+
+    def process_string(plan_output)
       scrubbed_output = plan_output.gsub(/\e\[\d+m/, '')
 
       # Remove preface
@@ -38,7 +43,7 @@ module TerraformLandscape
         scrubbed_output = scrubbed_output[match.end(0)..-1]
       elsif (match = scrubbed_output.match(/^(~|\+|\-)/))
         scrubbed_output = scrubbed_output[match.begin(0)..-1]
-      elsif scrubbed_output.match(/^No changes/)
+      elsif scrubbed_output =~ /^No changes/
         @output.puts 'No changes'
         return
       else
@@ -49,8 +54,6 @@ module TerraformLandscape
       if (match = scrubbed_output.match(/^Plan:[^\n]+/))
         plan_summary = scrubbed_output[match.begin(0)..match.end(0)]
         scrubbed_output = scrubbed_output[0...match.begin(0)]
-      else
-        raise ParseError, 'Output does not container proper postface'
       end
 
       plan = TerraformPlan.from_output(scrubbed_output)

data/lib/terraform_landscape/terraform_plan.rb

@@ -9,7 +9,7 @@ require 'treetop'
 # This allows us to easily inspect the plan and present a more readable
 # explanation of the plan to the user.
 ########################################################################
-class TerraformLandscape::TerraformPlan
+class TerraformLandscape::TerraformPlan # rubocop:disable Metrics/ClassLength
   GRAMMAR_FILE = File.expand_path(File.join(File.dirname(__FILE__),
                                             '..', '..', 'grammar',
                                             'terraform_plan.treetop'))
@@ -141,7 +141,7 @@ class TerraformLandscape::TerraformPlan
     end
   end
 
-  def display_modified_attribute( # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+  def display_modified_attribute( # rubocop:disable Metrics/MethodLength
     change_color,
     attribute_name,
     attribute_value,
@@ -151,7 +151,7 @@ class TerraformLandscape::TerraformPlan
     # Handle case where attribute has an annotation (e.g. "forces new resource")
     # appended onto the end. This is hard to parse in the Treetop grammar, so we
     # instead catch it here and extract
-    if match = attribute_value.match(/\((?<reason>[^)]+)\)$/)
+    if (match = attribute_value.match(/\((?<reason>[^)]+)\)$/))
       reason = match['reason']
       attribute_value = attribute_value[0...match.begin(0)]
     end
@@ -159,7 +159,7 @@ class TerraformLandscape::TerraformPlan
     # Since the attribute line is always of the form
     # "old value" => "new value", we can add curly braces and parse with
     # `eval` to obtain a hash with a single key/value.
-    old, new = eval("{#{attribute_value}}").to_a.first # rubocop:disable Lint/Eval
+    old, new = eval("{#{attribute_value}}").to_a.first # rubocop:disable Security/Eval
 
     return if old == new # Don't show unchanged attributes
 
@@ -196,9 +196,10 @@ class TerraformLandscape::TerraformPlan
     @out.print "    #{attribute_name}:".ljust(attribute_value_indent_amount, ' ')
       .colorize(change_color)
 
-    evaluated_string = eval(attribute_value) # rubocop:disable Lint/Eval
+    evaluated_string = eval(attribute_value) # rubocop:disable Security/Eval
     if json?(evaluated_string)
-      @out.print to_pretty_json(evaluated_string).gsub("\n", "\n" + attribute_value_indent)
+      @out.print to_pretty_json(evaluated_string).gsub("\n",
+                                                       "\n#{attribute_value_indent}")
         .colorize(change_color)
     else
       @out.print "\"#{evaluated_string.colorize(change_color)}\""

data/lib/terraform_landscape/version.rb

@@ -2,5 +2,5 @@
 
 # Defines the gem version.
 module TerraformLandscape
-  VERSION = '0.1.6'.freeze
+  VERSION = '0.1.7'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: terraform_landscape
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Coinbase
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-24 00:00:00.000000000 Z
+date: 2017-08-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colorize
@@ -106,7 +106,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: Pretty-print Terraform plan output