terminal_game_of_life 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b949e4ff807eb374946cc0c2647f9aa5cf3f79b2427cab818b492ecdbb9a3b24
-  data.tar.gz: b0e82c40b3c53972f52382728281cc2b83219835ffe1ad65c89f9e446beadf02
+  metadata.gz: d10a840c6d071548bbd56b1fb2f17a9658c19c086bd47d54446eeaff15644f0a
+  data.tar.gz: e310c4bc97030a3499da866a6a388f4b50dc262d7a6e6821af888691570cda54
 SHA512:
-  metadata.gz: 96e1fd3c329a3d775a7d332351303c53a2767857ccef421ad372ec8abbebae7bd4f7d07ae2ad23210cd360d889d21fa7ccafc6c9dc08388a6ffb967dd44afa52
-  data.tar.gz: 8674f279918813b3cf8c4ee1ed9a2d257c48755a3c06e687a2f5f17cdf6707e85509277042e3176d6eaa5e7c69ae143bc5d4e996572a55fa73900c2bc8e9ac1d
+  metadata.gz: '085e910813f204a6780bebee121a51dd3a5813f969ccf4a001039d46e7606ad87200f9cac47049e8963894d94fafbdc9331c22260d86c4987dff423ef996143e'
+  data.tar.gz: d3bbf008fb39c7b2e2f5858c68fd991fbe998113d4260abda46cac403d21931bff74e3f46a56f657e0c9adb479725fbbf1ef870cb0f782031658132487295577

data/README.md

@@ -9,7 +9,11 @@ $ gem install terminal_game_of_life
 
 ## Usage
 
-Run `$game-of-life -i https://gitlab.com/a14m --live-cell +`
+```bash
+$game-of-life -i https://gitlab.com/a14m.keys --live-cell +
+$game-of-life -i /path/to/file.txt --height 35 --width 35
+$game-of-life -s 1337 --delay 250
+```
 
 Check `game-of-life --help` for usage info.
 
@@ -26,7 +30,7 @@ Options:
       [--height=HEIGHT]        # Specify the hight of generated universe. (default to terminal height)
       [--dead-cell=CHAR]       # Specify the dead-cell representation
                                # Default:  
-      [--live-cell=CHAR]       # Specify the dead-cell representation
+      [--live-cell=CHAR]       # Specify the live-cell representation
                                # Default: █
   -d, [--delay=Milli-Seconds]  # Specify the introduced delay between each generation
                                # Default: 50

data/bin/game-of-life

@@ -3,7 +3,6 @@
 
 require "game_of_life"
 require "thor"
-require "io/console"
 
 class CLI < Thor
   map %w[-v --version] => :version
@@ -30,35 +29,14 @@ class CLI < Thor
                             desc: "Specify the dead-cell representation"
 
   class_option "live-cell", type: :string, banner: :CHAR, default: "\u2588",
-                            desc: "Specify the dead-cell representation"
+                            desc: "Specify the live-cell representation"
 
   class_option "delay", aliases: "-d", type: :numeric, banner: "Milli-Seconds", default: 50,
                         desc: "Specify the introduced delay between each generation"
-  # rubocop:disable Metrics/AbcSize
-  # rubocop:disable Metrics/MethodLength
   def start
-    max_height = IO.console.winsize[0] - 2
-    max_width  = IO.console.winsize[1]
-    if options["width"]&.> max_width
-      fail GameOfLife::Error, "Invalid --width value, must not exceed current terminal width: #{max_width}"
-    end
-    if options["height"]&.> max_height
-      fail GameOfLife::Error, "Invalid --height value, must not exceed current terminal height: #{max_height}"
-    end
-
-    options_with_console_defaults = {
-      # Defaults the hight to less then the height of the terminal to allow banner info
-      # and an extra emtpy line to avoid triggering terminal scroll while flushing
-      "height" => max_height,
-      "width" => max_width,
-      "seed" => rand(100_000),
-    }.merge(options)
-
-    universe = GameOfLife.generate(options_with_console_defaults)
+    universe = GameOfLife.generate(GameOfLife.parsed_options(options))
     GameOfLife.run(universe)
   end
-  # rubocop:enable Metrics/AbcSize
-  # rubocop:enable Metrics/MethodLength
 
   class << self
     # Allow exit with status 1 on failure

data/game_of_life.gemspec

@@ -31,6 +31,10 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "rubocop"
+  spec.add_development_dependency "rubocop-rspec"
+  # Code Coverage dependencies
+  spec.add_development_dependency "codecov"
+  spec.add_development_dependency "simplecov"
   # Documentation dependencies
   spec.add_development_dependency "redcarpet"
   spec.add_development_dependency "yard"

data/lib/game_of_life.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require "io/console"
 require "game_of_life/version"
 require "game_of_life/plane"
 require "game_of_life/universe"
@@ -11,6 +12,50 @@ module GameOfLife
   class Error < StandardError; end
 
   class << self
+    # Validate and parse the CLI options and set defaults for the dynamic options.
+    # @param options [Hash] CLI options to generate initial conditions
+    # @option options [String | nil] "input" path to a local file or URL to open
+    # @option options [Numeric | nil] "seed" number to use if no "input" is provided
+    # @option options [Numeric] "width" of the universe
+    # @option options [Numeric] "height" of the universe
+    # @option options [Numeric] "delay" introduced after each cycle
+    # @option options [String] "live-cell" representation
+    # @option options [String] "dead-cell" representation
+    # @smell AbcSize, MethodLenght, Cyclomatic and Perceived Complexity needed for parsing and validating options
+    #   rubocop:disable Metrics/AbcSize
+    #   rubocop:disable Metrics/MethodLength
+    #   rubocop:disable Metrics/CyclomaticComplexity
+    #   rubocop:disable Metrics/PerceivedComplexity
+    # return [Hash] of the parsed options with dynamic defaults based on window size and kernel random
+    def parsed_options(options)
+      max_height = IO.console.winsize[0] - 2
+      max_width  = IO.console.winsize[1]
+
+      if options["delay"].to_i.negative?
+        fail GameOfLife::Error, "Invalid --delay value. must be positive value (sadly this is how time works -so far-)"
+      end
+      if (options["width"]&.< 1) || (options["width"]&.> max_width)
+        fail GameOfLife::Error, "Invalid --width value. " \
+          "must be between 1 and #{max_width} (current terminal width)"
+      end
+      if (options["height"]&.< 1) || (options["height"]&.> max_height)
+        fail GameOfLife::Error, "Invalid --height value. " \
+          "must be between 1 and #{max_height} (current terminal height)"
+      end
+
+      {
+        # Defaults the hight to less then the height of the terminal to allow banner info
+        # and an extra emtpy line to avoid triggering terminal scroll while flushing
+        "height" => max_height,
+        "width" => max_width,
+        "seed" => rand(100_000),
+      }.merge(options)
+    end
+    # rubocop:enable Metrics/AbcSize
+    # rubocop:enable Metrics/MethodLength
+    # rubocop:enable Metrics/CyclomaticComplexity
+    # rubocop:enable Metrics/PerceivedComplexity
+
     # Generate a universe based on the options (from an input file/URI) or using a random/passed seed
     # This method also sets the Classes/Modules constants for the run defining the options for
     # Cell (Dead/Live) state representations, and the delay introduced after rendering each universe/generation

data/lib/game_of_life/version.rb

@@ -2,5 +2,5 @@
 
 module GameOfLife
   # Game of life version number
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: terminal_game_of_life
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - a14m
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-12 00:00:00.000000000 Z
+date: 2020-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -94,6 +94,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: codecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: redcarpet
   requirement: !ruby/object:Gem::Requirement
@@ -165,7 +207,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.0
+rubygems_version: 3.2.1
 signing_key: 
 specification_version: 4
 summary: Game of Life CLI