terminal-notifier-guard 1.6.4 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 03bb1db479ef19787f57ac0c6aebcfdf29ef92a4
-  data.tar.gz: 63645cd387bfe950ebdaf24d3ae539b0e3d50042
+  metadata.gz: ea0bfaf44ae88a389c6fd5dd95c7c0c879731d24
+  data.tar.gz: b437929f03ff02c3d43b99da82ed8348f5cb020f
 SHA512:
-  metadata.gz: 16f8f5398b9ab5458b341db3e7a013b6b5d372071b09ce197e108172b59a03c5397e5e551fe750ed36e59917c4f89c3885c56d8dbdb842d73e651652c4a97691
-  data.tar.gz: e859a738aa64d27425cb179daf28a7ef865b7d7d18c62541f83f6194ed92893fde02340c52ee78175d5d1fa45be42b3a9ed7faea1c59367d7a7a5d1e6223aac0
+  metadata.gz: a96884f7bb4caecc9962e6be5be1df866568046de509d21f4700edb81587098c53680a81dd6783ffc60f47ea37ce6173d3c9b58a1cb8e2e031934636b3ced220
+  data.tar.gz: 9dc03d445c2cc563d6eff882ea380bbd4da414040d0d9f623588e063fb8483e0f1e0343e95890d67b3c1db917947a1474cfb5cf41e34fb933b9ded56dfe1ed8e

data/README.markdown

@@ -31,10 +31,31 @@ $ gem install terminal-notifier-guard
 
 Or add it to your Gemfile:
 
+```ruby
+gem 'terminal-notifier-guard', '~> 1.6.1'
 ```
-$ gem 'terminal-notifier-guard', '~> 1.6.1'
+
+Then, add the notifier to your Guardfile:
+
+```ruby
+# Guardfile
+notification :terminal_notifier #, app_name: "MyApp ::", activate: 'com.googlecode.iTerm2'
 ```
 
+### Configure Binary Path
+
+You can override the binary path detection with an environment variable. This solves a problem where the default binary found by `which` is the Ruby gem version of `terminal-notifier`. This version is slow, especially in a Bundler environment.
+
+In this scenario we would much rather use the version installed by Homebrew at `/usr/local/bin/terminal-notifier` which is noticeably faster.
+
+This commit allows us to set an environment variable to explicitly specify the binary to use, like this:
+
+```bash
+export TERMINAL_NOTIFIER_BIN=/usr/local/bin/terminal-notifier
+```
+
+_When using guard to monitor test results in TDD, speed is of the essence. Using the right binary can save a half second or more during each test run, which doesn't seem like much but makes a big difference in productivity._
+
 ### OSX 10.8 users
 
 As of version `1.6.1`, we no longer bundle notifiers binaries in this gem. Please revert to
@@ -82,3 +103,7 @@ See [LICENSE][LICENSE] for details.
 - @alloy (For the terminal-notifier)
 - @railsme (For a clean way to test for OSX version #15)
 - @jamilbx (For support for local terminal-notifier command #8)
+- @mattbrictson (For adding support for the TERMINAL_NOTIFIER_BIN env var)
+- @goronfreeman (For the lovely icon set!)
+- @bbonamin (For fixing the license issue)
+- @croeck (For fixing the binary detection)

data/lib/terminal-notifier-guard.rb

@@ -1,6 +1,6 @@
 module TerminalNotifier
   module Guard
-    VERSION = "1.6.4"
+    VERSION = "1.7.0"
     ICONS_PATH = File.expand_path("../../icons", __FILE__)
     GUARD_ICON = File.join(ICONS_PATH, 'Guard.icns')
 
@@ -10,7 +10,8 @@ module TerminalNotifier
 
     def self.terminal_notifier_version
       return Gem::Version("0.0.0") unless installed?
-      Gem::Version.new(`#{bin_path}`.lines.first.match(/\d\.\d\.\d/)[0])
+      # invoke the help option since the binary otherwise may get stuck
+      Gem::Version.new(`#{bin_path} -help`.lines.first.match(/\d\.\d\.\d/)[0])
     rescue
       Gem::Version.new("0.0.0")
     end
@@ -41,7 +42,9 @@ module TerminalNotifier
     end
 
     def self.bin_path
-      @@binary ||= `which terminal-notifier`.chomp
+      ENV["TERMINAL_NOTIFIER_BIN"] || begin
+        @@binary ||= `which terminal-notifier`.chomp
+      end
     end
 
     def self.execute(verbose, options)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: terminal-notifier-guard
 version: !ruby/object:Gem::Version
-  version: 1.6.4
+  version: 1.7.0
 platform: ruby
 authors:
 - Eloy Duran
@@ -9,62 +9,62 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-03 00:00:00.000000000 Z
+date: 2016-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bacon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha-on-bacon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -83,7 +83,8 @@ files:
 - icons/Success.icns
 - lib/terminal-notifier-guard.rb
 homepage: https://github.com/Springest/terminal-notifier-guard
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -91,18 +92,19 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.2
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Send User Notifications on Mac OS X 10.8 - with status icons.
 test_files: []
+has_rdoc: