temporal_tables 1.1.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 60c0235cfec08bde495d37a7304eeca6a0bd46aa310224b8a240bbc2ff98bd23
-  data.tar.gz: b68fb0409c0fd389e6a544f0d3ba10f560da3e6536e6dff5a3655e8fe21c3494
+  metadata.gz: 457aecc9f2b96e0a7ef98f6e7e2d4c30fc0aa091ddeb3abc9a3c684cae67768c
+  data.tar.gz: 1bf1f9bd6e98b063b73c3bdafb9f5d31bba6e75a2e605838c466915c85231317
 SHA512:
-  metadata.gz: 2b9e2a3855dcce4b6f50a40e887451097efe51377cd3edbfe4ee7af6023dfb62f3f8deb9d3664827cc7db6426d29aab235349ab33b00b691b7dcaca639c0874b
-  data.tar.gz: f35f963e1540f869f0d0375d63aacd02eb76805a51f11324163712e48a7e38e54153c6ab496088edfc647dc3dfa1b689d03d17908033c9addd10fad6138ff5ac
+  metadata.gz: 9b9baeefc81aadfe5f23db7fc5790321cf2550812a6818a9b3d2d3f96af4f12efb8672bea34e9b7981f6e577c9c43574378d72894684a866c762aaf94d17d5f2
+  data.tar.gz: 9ae4da3db11583308195eca7c1965c0a91242ab61711794bb8b0f3264e25df39b2453a6dcafd3ae7dad119f7f5d31d3a5d681b18bd711422c12d0965e8b184fb

data/lib/temporal_tables/arel_table.rb

@@ -9,7 +9,7 @@ module TemporalTables
       if at_value
         join =
           join
-          .and(to[:eff_to].gteq(at_value))
+          .and(to[:eff_to].gt(at_value).or(to[:eff_to].eq(TemporalTables::END_OF_TIME)))
           .and(to[:eff_from].lteq(at_value))
       end
       join

data/lib/temporal_tables/connection_adapters/mysql_adapter.rb

@@ -34,7 +34,7 @@ module TemporalTables
 
             update #{temporal_name(table_name)} set eff_to = @current_time
             where #{primary_key} = new.#{primary_key}
-            and eff_to = '9999-12-31';
+            and eff_to = '#{TemporalTables::END_OF_TIME}';
 
             insert into #{temporal_name(table_name)} (#{column_names.join(', ')}, eff_from)
             values (#{column_names.collect { |c| "new.#{c}" }.join(', ')}, @current_time);
@@ -51,7 +51,7 @@ module TemporalTables
 
             update #{temporal_name(table_name)} set eff_to = @current_time
             where #{primary_key} = old.#{primary_key}
-            and eff_to = '9999-12-31';
+            and eff_to = '#{TemporalTables::END_OF_TIME}';
 
           end
         }

data/lib/temporal_tables/connection_adapters/postgresql_adapter.rb

@@ -40,7 +40,7 @@ module TemporalTables
 
               update #{temporal_name(table_name)} set eff_to = cur_time
               where #{primary_key} = new.#{primary_key}
-                and eff_to = '9999-12-31';
+                and eff_to = '#{TemporalTables::END_OF_TIME}';
 
               insert into #{temporal_name(table_name)} (#{column_list(column_names)}, eff_from)
               values (#{column_names.collect { |c| "new.#{c}" }.join(', ')}, cur_time);
@@ -63,7 +63,7 @@ module TemporalTables
 
               update #{temporal_name(table_name)} set eff_to = cur_time
               where #{primary_key} = old.#{primary_key}
-                and eff_to = '9999-12-31';
+                and eff_to = '#{TemporalTables::END_OF_TIME}';
 
               return null;
             end

data/lib/temporal_tables/constants.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+module TemporalTables
+  END_OF_TIME = '9999-12-31'
+end

data/lib/temporal_tables/temporal_adapter.rb

@@ -35,7 +35,7 @@ module TemporalTables
         **options.merge(id: false, primary_key: 'history_id', temporal_bypass: true)
       ) do |t|
         t.datetime :eff_from, null: false, limit: 6
-        t.datetime :eff_to,   null: false, limit: 6, default: '9999-12-31'
+        t.datetime :eff_to,   null: false, limit: 6, default: TemporalTables::END_OF_TIME
 
         columns(table_name).each do |c|
           column_options = { limit: c.limit }

data/lib/temporal_tables/temporal_adapter_six_oh.rb

@@ -37,7 +37,7 @@ module TemporalTables
         **options.merge(id: false, primary_key: 'history_id', temporal_bypass: true)
       ) do |t|
         t.datetime :eff_from, null: false, limit: 6
-        t.datetime :eff_to,   null: false, limit: 6, default: '9999-12-31'
+        t.datetime :eff_to,   null: false, limit: 6, default: TemporalTables::END_OF_TIME
 
         columns(table_name).each do |c|
           column_type = c.type == :enum ? c.sql_type_metadata.sql_type : c.type

data/lib/temporal_tables/temporal_class.rb

@@ -74,8 +74,10 @@ module TemporalTables
 
       delegate :descends_from_active_record?, to: :superclass
 
+      # An object at a given time should fall within the range, excluding the effective end date.
+      # However, when using '9999-12-31', this is effectively infinity and should not be excluded.
       def build_temporal_constraint(at_value)
-        arel_table[:eff_to].gteq(at_value).and(
+        (arel_table[:eff_to].gt(at_value).or(arel_table[:eff_to].eq(TemporalTables::END_OF_TIME))).and(
           arel_table[:eff_from].lteq(at_value)
         )
       end

data/lib/temporal_tables/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TemporalTables
-  VERSION = '1.1.0'
+  VERSION = '2.0.0'
 end

data/lib/temporal_tables.rb

@@ -12,6 +12,7 @@ require 'temporal_tables/association_extensions'
 require 'temporal_tables/preloader_extensions'
 require 'temporal_tables/reflection_extensions'
 require 'temporal_tables/arel_table'
+require 'temporal_tables/constants'
 require 'temporal_tables/version'
 
 module TemporalTables

data/spec/basic_history_spec.rb

@@ -90,10 +90,10 @@ describe Person do
         where = sql[4]
 
         expect(from.scan(/.warts_h.\..eff_from./i).count).to eq(1)
-        expect(from.scan(/.warts_h.\..eff_to./i).count).to eq(1)
+        expect(from.scan(/.warts_h.\..eff_to./i).count).to eq(2)
 
         expect(where.scan(/.people_h.\..eff_from./i).count).to eq(1)
-        expect(where.scan(/.people_h.\..eff_to./i).count).to eq(1)
+        expect(where.scan(/.people_h.\..eff_to./i).count).to eq(2)
         expect(where.scan(/.warts_h.\..eff_from./i).count).to eq(0)
         expect(where.scan(/.warts_h.\..eff_to./i).count).to eq(0)
       end
@@ -195,6 +195,12 @@ describe Person do
         expect(fido.orig_obj.name).to eq('Max')
       end
 
+      it 'at the exact time of the name change, the dog should not be both Max and Fido' do
+        dog_at_moment_of_name_change = dog.history.at(dog.history.last.eff_from)
+        expect(dog_at_moment_of_name_change.count).to eq(1)
+        expect(dog_at_moment_of_name_change.first.name).to eq('Max')
+      end
+
       context 'Max is rehomed' do
         before do
           dog.destroy!

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: temporal_tables
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Brent Kroeker
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-14 00:00:00.000000000 Z
+date: 2022-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -179,6 +179,7 @@ files:
 - lib/temporal_tables/association_extensions.rb
 - lib/temporal_tables/connection_adapters/mysql_adapter.rb
 - lib/temporal_tables/connection_adapters/postgresql_adapter.rb
+- lib/temporal_tables/constants.rb
 - lib/temporal_tables/history_hook.rb
 - lib/temporal_tables/preloader_extensions.rb
 - lib/temporal_tables/reflection_extensions.rb