telein-client 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c44c3cceda568525149c516df84adec350ce2979
-  data.tar.gz: a4bf9baa84c52e7d43e6b9eecf70f5f2812bb400
+  metadata.gz: bf452376aa876894548cda758ce3852b50000d39
+  data.tar.gz: d0e74d19b7e146124075d87991aea0141f8e2e30
 SHA512:
-  metadata.gz: 344d0408e0146df2904dab11405e56ce89dc06e7270e09488c606025beb238bb9b508e808decf76c2528f731575dd24dbfc136946c30890b9e84723a91ecaf82
-  data.tar.gz: 32200f66888504f448635204ba22e4d2049ece6ff3e77d9ad70c4d65f31c94308b5f9f3fa397df53c9bd359f3292ac3701034c47686966d9a3a4481931c004e5
+  metadata.gz: 9cc73b0933b263f95be1ae917a6a5cd6980eb5fa0ae251bdf2fea400338c798670add3bfe7ef00cf54374cb8205bcbc67fbf9fc6ef949fff03d2a10415f92df4
+  data.tar.gz: b52f29a359cb169a98351f5719e62c4b894fc564ff7516170cc738b7554aac3d62f3cfa94c5d135bc2129ae4e8801986538d1fc66c8653d68c8f253644cb43c0

data/lib/telein/client.rb

@@ -26,15 +26,17 @@ module Telein
   #    client.carrier_code_for('(12) 3434-5656') # => '41'
   class Client
 
-    # Queries the Telein servers for the carrier code of value
-    #
+    # Queries the Telein servers for the carrier code and corrected
+    #   phone number of value.
     # @param value [String] A string supposedly containing phone information
-    # @return [Integer] The carrier code for value
-    def carrier_code_for(value)
-      return 999 unless Telein.api_key
-
+    # @return [Array<Integer, String>] A pair with carrier code for value
+    #    and corrected phone number.
+    private
+    def raw_query(value)
       phone = Telein::Util::Phone.new(value)
 
+      return [999, value] unless Telein.api_key
+
       if phone.valid?
         Telein.servers.each do |server|
           begin
@@ -49,23 +51,41 @@ module Telein
             response = curl.body_str
 
             # response parsing (carrier#number)
-            carrier_code, _ = response.split('#')
+            carrier_code, number = response.split('#')
 
-            return 101 if carrier_code.to_i == 0
+            return [101, number] if carrier_code.to_i == 0
 
-            return carrier_code.to_i
+            return [carrier_code.to_i, number]
           rescue
             next
           end
         end
 
         # all servers down
-        return 101
+        return [101, phone.to_telein_s]
       else
         # invalid phone
-        return 100
+        return [100, value]
       end
     end
+    # Wraps the query to the Telein servers for the carrier code and
+    #   corrected phone number of value on a dictionary.
+    # @param value [String] A string supposedly containing phone information
+    # @return [Hash] with :carrier_code as the carrier code
+    #    and :number as the corrected phone number.
+    public
+    def query(value)
+      carrier_code, number = raw_query(value)
+      return { :carrier_code => carrier_code, :number => number }
+    end
 
+    # Filters the query to the Telein servers so that it only returns
+    #   the carrier code.
+    # @deprecated Use {#query} for greater functionality.
+    # @param value [String] A string supposedly containing phone information
+    # @return [Integer] The carrier code for value
+    def carrier_code_for(value)
+      return query(value)[:carrier_code]
+    end
   end
 end

data/lib/telein/version.rb

@@ -1,4 +1,4 @@
 module Telein
   # Telein version
-  VERSION = "0.1.2"
+  VERSION = "0.2.0"
 end

data/spec/telein/client_spec.rb

@@ -38,6 +38,19 @@ describe Telein::Client do
     client.carrier_code_for('(12) 9434-5656').should == 41
   end
 
+  it 'returns both carrier code and fixed number' do
+    Telein.servers.each do |server|
+      stub_request(:get,server.query_url_for('0000000000')).to_return(:body => '99#0000000000')
+      stub_request(:get,server.query_url_for('1234345656')).to_return(:body => '98#1234345656')
+      stub_request(:get,server.query_url_for('1294345656')).to_return(:body => '41#12994345656')
+    end
+
+    client = described_class.new
+    expect(client.query('(00) 0000-0000')).to  eq({ carrier_code: 100, number: "(00) 0000-0000"})
+    expect(client.query('(12) 3434-5656')).to  eq({ carrier_code:  98, number: "1234345656"})
+    expect(client.query('(12) 9434-5656')).to  eq({ carrier_code:  41, number: "12994345656"})
+  end
+
   it 'returns server error code when all endpoints are down' do
     Telein.servers.each do |server|
       stub_request(:get,server.query_url_for('0000000000')).to_timeout

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: telein-client
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Thiago Brandão Damasceno
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-08 00:00:00.000000000 Z
+date: 2014-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: curb