tedkulp-freshbooks.rb 3.0.23 → 3.0.24

data/README

@@ -1,3 +1,18 @@
+= Todo
+
+Please send me a message if you are interested in contributing. Here is a quick overview of some things I'd like to add to the gem.
+
+Merge in forked versions of this gem (any idea what forks are worth while?)
+Provide a way to retrieve the error message with actions beside list are called.
+Make ListProxy optional on list actions. Some people have valid reason to deal with pagination.
+Add oAuth
+Add webhooks
+More tests including integration tests
+Write some documentation and examples
+Launch an official 3.0 (maybe call it 4.0) version of the gem
+Post the official version to rubygems
+Ensure rubygems aren't required for this gem. 
+
 = About
 
 FreshBooks.rb is a Ruby interface to the FreshBooks API. It exposes easy-to-use classes and methods for interacting with your FreshBooks account.
@@ -35,7 +50,7 @@ This work is distributed under the MIT License. Use/modify the code however you
 
 = Download
 
-sudo gem install tedkulp-freshbooks.rb
+sudo gem install bcurren-freshbooks.rb
 
 = Credits
 

data/Rakefile

@@ -8,7 +8,7 @@ $hoe = Hoe.spec('freshbooks.rb') do |p|
   p.summary              = ''
   p.changes              = p.paragraphs_of("History.txt", 0..1).join("\n\n")
   p.rubyforge_name       = p.name # TODO this is default value
-  p.extra_deps           = [ ['activesupport', '>= 0'] ]
+  p.extra_deps           = [ ['activesupport', '>= 3.0.0'] ]
   p.extra_dev_deps = [
     ['newgem', ">= #{::Newgem::VERSION}"],
     ['mocha', ">= 0.9.4"]

data/lib/freshbooks.rb

@@ -8,6 +8,7 @@ rescue LoadError
   gem 'activesupport'
   require 'active_support'
 end
+require 'active_support/all'
 
 require 'freshbooks/base'
 require 'freshbooks/category'
@@ -60,7 +61,7 @@ require 'logger'
 #
 #==============================================================================
 module FreshBooks
-  VERSION = '3.0.20'     # Gem version
+  VERSION = '3.0.24'     # Gem version
   API_VERSION = '2.1' # FreshBooks API version
   SERVICE_URL = "/api/#{API_VERSION}/xml-in"
 

data/lib/freshbooks/base.rb

@@ -19,10 +19,10 @@ module FreshBooks
     end
     
     def self.new_from_xml(xml_root)
-      object = self.new
+      object = self.new()
       
       self.schema_definition.members.each do |member_name, member_options|
-        node = xml_root.elements[member_name]
+        node = xml_root.elements[member_name.dup]
         next if node.nil?
         
         value = FreshBooks::XmlSerializer.to_value(node, member_options[:type])
@@ -32,7 +32,10 @@ module FreshBooks
       return object
       
     rescue => e
-      raise ParseError.new(e, xml_root.to_s)
+      error = ParseError.new(e, xml_root.to_s)
+      error.set_backtrace(e.backtrace)
+      raise error
+      # raise ParseError.new(e, xml_root.to_s)
     end
     
     def to_xml(elem_name = nil)

data/lib/freshbooks/schema/definition.rb

@@ -4,7 +4,7 @@ module FreshBooks
       attr_reader :members
       
       def initialize
-        @members = {}
+        @members = ActiveSupport::OrderedHash.new
       end
       
       def method_missing(method, *attributes)
@@ -17,4 +17,4 @@ module FreshBooks
       end
     end
   end
-end
+end

data/test/test_base.rb

@@ -96,6 +96,22 @@ class TestBase < Test::Unit::TestCase
     assert_equal invoice_1.to_xml, invoice_2.to_xml
   end
   
+  def test_can_handle_all_zero_updated_at
+    xml = <<-END_XML
+      <my_client> 
+        <client_id>3</client_id> 
+        <first_name>Test</first_name> 
+        <last_name>User</last_name> 
+        <organization>User Testing</organization> 
+        <updated>0000-00-00 00:00:00</updated> 
+      </my_client>
+    END_XML
+    doc = REXML::Document.new(xml)
+    
+    item = FreshBooks::MyClient.new_from_xml(doc.root)
+    assert_equal nil, item.updated
+  end
+  
 end
 
 module FreshBooks
@@ -113,6 +129,14 @@ module FreshBooks
     end
   end
 
+  class MyClient < FreshBooks::Base
+    define_schema do |s|
+      s.string :first_name, :last_name, :organization
+      s.fixnum :client_id
+      s.date_time :updated
+    end
+  end
+
   class MyAddress < FreshBooks::Base
     define_schema do |s|
       s.string :street1

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: tedkulp-freshbooks.rb
 version: !ruby/object:Gem::Version 
+  hash: 55
   prerelease: false
   segments: 
   - 3
   - 0
-  - 23
-  version: 3.0.23
+  - 24
+  version: 3.0.24
 platform: ruby
 authors: 
 - Ben Curren
@@ -14,16 +15,18 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-09 00:00:00 -04:00
+date: 2010-10-27 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activesupport
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
@@ -33,9 +36,11 @@ dependencies:
   name: newgem
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 25
         segments: 
         - 1
         - 2
@@ -47,9 +52,11 @@ dependencies:
   name: mocha
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 51
         segments: 
         - 0
         - 9
@@ -61,9 +68,11 @@ dependencies:
   name: hoe
   prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 55
         segments: 
         - 1
         - 8
@@ -138,23 +147,27 @@ rdoc_options:
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: freshbooks.rb
-rubygems_version: 1.3.6
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 2
 summary: ""