teamtailor 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 875df74665c08b8bf0e4635883a05948da1f081112b482a3a0131603d453e708
-  data.tar.gz: 6cc44d2eed9d30462bbad0869da85d17da1a1a5a275667cbe940eb376eded6f3
+  metadata.gz: a3c5016ea7f30bfad3cedc6f375d495b1a998c74e74e16d0a02456c6af9f7211
+  data.tar.gz: 2248deff3a6d9c943c0d2302ae4435fb07cd3d6e62eae93f3e53e3b57c32357a
 SHA512:
-  metadata.gz: f689da0ed44d1ea65c5d724b4025c133ce54a51e6e6f6941e06eddabaab85fcb98686522e92e745f14d72e0db2a8dff404f9ddd7af11078c9f8d6a7ed67a140e
-  data.tar.gz: 1a97c168e9081d1b4c565d324eced4fbb48611e6af34fba45e9d2fcaa1029788f4bac3328192d5bd87872971102968bdaa1f44a5609836b235afbf7e938820d3
+  metadata.gz: 37db447ae0d55f7fe2e8139c7d8d045e9472787f61b7034e66d9c8d07013079a2bf4409a934e256bdc7b1130cb0954754db099b0b959b7c1c39e6aeb27c3ea35
+  data.tar.gz: 63f111aa5ab9ae0931ced51074a653af946af6b9838f40d5c1402f64266fb47b1cb89cd079febadf8035d99f687818d104c81b57c7f1b977bbe6520fad35c549

data/.github/workflows/ruby.yml

@@ -6,7 +6,7 @@ jobs:
       fail-fast: true
       matrix:
         os: [ubuntu-latest]
-        ruby: [2.6, 2.7, "3.0", 3.1, 3.2, 3.3, 3.4] # Due to https://github.com/actions/runner/issues/849
+        ruby: ["3.0", 3.1, 3.2, 3.3] # Due to https://github.com/actions/runner/issues/849
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v2
@@ -15,13 +15,3 @@ jobs:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true
       - run: bundle exec rake
-
-  lint:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      - uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: 2.7
-          bundler-cache: true
-      - run: bundle exec rubocop

data/.rubocop-rake-rspec.yml

@@ -0,0 +1,2 @@
+plugins:
+  - rubocop-rake

data/.standard.yml

@@ -0,0 +1,2 @@
+extend_config:
+  - .rubocop-rake-rspec.yml

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## Unreleased
 
+## v0.4.1 - 2025-04-09
+
+- Handle more errors [#15](https://github.com/Teamtailor/teamtailor-rb/pull/15)
+- Fix issue with invalid request header [#14](https://github.com/Teamtailor/teamtailor-rb/pull/14)
+
 ## v0.4.0 - 2021-09-06
 
 - Added `Client#create_upload`

data/Gemfile

@@ -9,9 +9,9 @@ gem "rake", "~> 12.0"
 
 group :test do
   gem "rspec", "~> 3.0"
-  gem "rubocop"
-  gem "rubocop-rake"
-  gem "rubocop-rspec"
   gem "webmock", "~> 3.4", ">= 3.4.2"
   gem "simplecov", require: false
+
+  gem "standard"
+  gem "rubocop-rake"
 end

data/Gemfile.lock

@@ -1,31 +1,39 @@
 PATH
   remote: .
   specs:
-    teamtailor (0.4.1)
+    teamtailor (0.5.0)
       typhoeus (~> 1.4.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.8.0)
-      public_suffix (>= 2.0.2, < 5.0)
-    ast (2.4.2)
-    crack (0.4.3)
-      safe_yaml (~> 1.0.0)
+    addressable (2.8.7)
+      public_suffix (>= 2.0.2, < 7.0)
+    ast (2.4.3)
+    bigdecimal (3.1.9)
+    crack (1.0.0)
+      bigdecimal
+      rexml
     diff-lcs (1.3)
     docile (1.3.2)
     ethon (0.16.0)
       ffi (>= 1.15.0)
     ffi (1.17.0)
-    hashdiff (1.0.1)
-    parallel (1.20.1)
-    parser (3.0.0.0)
+    hashdiff (1.1.2)
+    json (2.10.2)
+    language_server-protocol (3.17.0.4)
+    lint_roller (1.1.0)
+    parallel (1.26.3)
+    parser (3.3.7.4)
       ast (~> 2.4.1)
-    public_suffix (4.0.7)
-    rainbow (3.0.0)
+      racc
+    prism (1.4.0)
+    public_suffix (6.0.1)
+    racc (1.8.1)
+    rainbow (3.1.1)
     rake (12.3.3)
-    regexp_parser (2.0.3)
-    rexml (3.2.5)
+    regexp_parser (2.10.0)
+    rexml (3.4.1)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -39,33 +47,51 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.9.0)
     rspec-support (3.9.2)
-    rubocop (1.9.1)
+    rubocop (1.75.2)
+      json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.2.0, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.4.1)
-      parser (>= 2.7.1.5)
-    rubocop-rake (0.5.1)
-      rubocop
-    rubocop-rspec (2.2.0)
-      rubocop (~> 1.0)
-      rubocop-ast (>= 1.1.0)
-    ruby-progressbar (1.11.0)
-    safe_yaml (1.0.5)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.44.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-performance (1.25.0)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
+    ruby-progressbar (1.13.0)
     simplecov (0.18.5)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
     simplecov-html (0.12.3)
+    standard (1.49.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.75.2)
+      standard-custom (~> 1.0.0)
+      standard-performance (~> 1.8)
+    standard-custom (1.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.50)
+    standard-performance (1.8.0)
+      lint_roller (~> 1.1)
+      rubocop-performance (~> 1.25.0)
     typhoeus (1.4.1)
       ethon (>= 0.9.0)
-    unicode-display_width (2.0.0)
-    webmock (3.8.3)
-      addressable (>= 2.3.6)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
+    webmock (3.25.1)
+      addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
 
@@ -75,12 +101,11 @@ PLATFORMS
 DEPENDENCIES
   rake (~> 12.0)
   rspec (~> 3.0)
-  rubocop
   rubocop-rake
-  rubocop-rspec
   simplecov
+  standard
   teamtailor!
   webmock (~> 3.4, >= 3.4.2)
 
 BUNDLED WITH
-   2.2.22
+   2.5.23

data/Rakefile

@@ -2,7 +2,8 @@
 
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
+require "standard/rake"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task default: :spec
+task default: [:spec, :standard]

data/lib/teamtailor/client.rb

@@ -17,7 +17,7 @@ module Teamtailor
         api_version: api_version,
         path: "/v1/company",
         params: {
-          "include" => include.join(","),
+          "include" => include.join(",")
         }
       ).call
     end
@@ -31,25 +31,25 @@ module Teamtailor
         params: {
           "page[number]" => page,
           "page[size]" => 30,
-          "include" => include.join(","),
+          "include" => include.join(",")
         }
       ).call
     end
 
     def create_candidate(attributes:, relationships:)
       Teamtailor::Request.new(
-          base_url: base_url,
-          api_token: api_token,
-          api_version: api_version,
-          path: "/v1/candidates",
-          method: :post,
-          body: {
-              data: {
-                  type: "candidates",
-                  attributes: attributes.transform_keys { |k| k.to_s.gsub("_", "-") },
-                  relationships: relationships,
-              },
+        base_url: base_url,
+        api_token: api_token,
+        api_version: api_version,
+        path: "/v1/candidates",
+        method: :post,
+        body: {
+          data: {
+            type: "candidates",
+            attributes: attributes.transform_keys { |k| k.to_s.tr("_", "-") },
+            relationships: relationships
           }
+        }
       ).call
     end
 
@@ -64,7 +64,7 @@ module Teamtailor
         params: {
           "page[number]" => page,
           "page[size]" => 30,
-          "include" => include.join(","),
+          "include" => include.join(",")
         }.merge(filter_params)
       ).call
     end
@@ -78,42 +78,42 @@ module Teamtailor
         params: {
           "page[number]" => page,
           "page[size]" => 30,
-          "include" => include.join(","),
+          "include" => include.join(",")
         }
       ).call
     end
 
     def create_upload(attributes:, relationships:)
       Teamtailor::Request.new(
-          base_url: base_url,
-          api_token: api_token,
-          api_version: api_version,
-          path: "/v1/uploads",
-          method: :post,
-          body: {
-              data: {
-                  type: "uploads",
-                  attributes: attributes.transform_keys { |k| k.to_s.gsub("_", "-") },
-                  relationships: relationships,
-              },
+        base_url: base_url,
+        api_token: api_token,
+        api_version: api_version,
+        path: "/v1/uploads",
+        method: :post,
+        body: {
+          data: {
+            type: "uploads",
+            attributes: attributes.transform_keys { |k| k.to_s.tr("_", "-") },
+            relationships: relationships
           }
+        }
       ).call
     end
 
     def create_job_application(attributes:, relationships:)
       Teamtailor::Request.new(
-          base_url: base_url,
-          api_token: api_token,
-          api_version: api_version,
-          path: "/v1/job-applications",
-          method: :post,
-          body: {
-              data: {
-                  type: "job-applications",
-                  attributes: attributes.transform_keys { |k| k.to_s.gsub("_", "-") },
-                  relationships: relationships,
-              },
+        base_url: base_url,
+        api_token: api_token,
+        api_version: api_version,
+        path: "/v1/job-applications",
+        method: :post,
+        body: {
+          data: {
+            type: "job-applications",
+            attributes: attributes.transform_keys { |k| k.to_s.tr("_", "-") },
+            relationships: relationships
           }
+        }
       ).call
     end
 
@@ -126,7 +126,7 @@ module Teamtailor
         params: {
           "page[number]" => page,
           "page[size]" => 30,
-          "include" => include.join(","),
+          "include" => include.join(",")
         }
       ).call
     end
@@ -140,7 +140,7 @@ module Teamtailor
         params: {
           "page[number]" => page,
           "page[size]" => 30,
-          "include" => include.join(","),
+          "include" => include.join(",")
         }
       ).call
     end
@@ -154,7 +154,7 @@ module Teamtailor
         params: {
           "page[number]" => page,
           "page[size]" => 30,
-          "include" => include.join(","),
+          "include" => include.join(",")
         }
       ).call
     end
@@ -168,7 +168,7 @@ module Teamtailor
         params: {
           "page[number]" => page,
           "page[size]" => 30,
-          "include" => include.join(","),
+          "include" => include.join(",")
         }
       ).call
     end
@@ -182,7 +182,7 @@ module Teamtailor
         params: {
           "page[number]" => page,
           "page[size]" => 30,
-          "include" => include.join(","),
+          "include" => include.join(",")
         }
       ).call
     end
@@ -196,7 +196,7 @@ module Teamtailor
         params: {
           "page[number]" => page,
           "page[size]" => 30,
-          "include" => include.join(","),
+          "include" => include.join(",")
         }
       ).call
     end
@@ -210,7 +210,7 @@ module Teamtailor
         params: {
           "page[number]" => page,
           "page[size]" => 30,
-          "include" => include.join(","),
+          "include" => include.join(",")
         }
       ).call
     end
@@ -224,7 +224,7 @@ module Teamtailor
         params: {
           "page[number]" => page,
           "page[size]" => 30,
-          "include" => include.join(","),
+          "include" => include.join(",")
         }
       ).call
     end
@@ -238,7 +238,7 @@ module Teamtailor
         params: {
           "page[number]" => page,
           "page[size]" => 30,
-          "include" => include.join(","),
+          "include" => include.join(",")
         }
       ).call
     end
@@ -252,7 +252,7 @@ module Teamtailor
         params: {
           "page[number]" => page,
           "page[size]" => 30,
-          "include" => include.join(","),
+          "include" => include.join(",")
         }
       ).call
     end

data/lib/teamtailor/error.rb

@@ -14,6 +14,8 @@ module Teamtailor
         Teamtailor::InvalidApiVersionError.new(error_message)
       when 422
         Teamtailor::UnprocessableEntityError.new(error_message)
+      when 429
+        RateLimitError.new
       when 400..499
         ClientError.new(error_message)
       when 500..599
@@ -24,11 +26,9 @@ module Teamtailor
     end
 
     def self.parse_body(body)
-      begin
-        JSON.parse(body)
-      rescue JSON::ParserError => e
-        {}
-      end
+      JSON.parse(body)
+    rescue JSON::ParserError
+      {}
     end
   end
 
@@ -48,5 +48,7 @@ module Teamtailor
 
   class UnprocessableEntityError < ClientError; end
 
+  class RateLimitError < ClientError; end
+
   class UnknownResponseError < Error; end
 end

data/lib/teamtailor/record.rb

@@ -15,20 +15,24 @@ module Teamtailor
     def serialize
       {
         data: data,
-        included: included,
+        included: included
       }.to_json
     end
 
     def method_missing(m)
       if m == :id
         data.dig("id").to_i
-      elsif relationship_keys.include?(m.to_s.gsub("_", "-"))
-        build_relationship(m.to_s.gsub("_", "-"))
+      elsif relationship_keys.include?(m.to_s.tr("_", "-"))
+        build_relationship(m.to_s.tr("_", "-"))
       else
-        data.dig("attributes", m.to_s.gsub("_", "-"))
+        data.dig("attributes", m.to_s.tr("_", "-"))
       end
     end
 
+    def respond_to_missing?(m, include_private = false)
+      m == :id || relationship_keys.include?(m.to_s.tr("_", "-")) || data.dig("attributes")&.key?(m.to_s.tr("_", "-")) || super
+    end
+
     private
 
     attr_reader :data, :included

data/lib/teamtailor/relationship.rb

@@ -19,7 +19,7 @@ module Teamtailor
         record_ids.include?(k["id"]) && k["type"] == record_type
       end
 
-      Teamtailor::Parser.parse({ "data" => record_json, "included" => included })
+      Teamtailor::Parser.parse({"data" => record_json, "included" => included})
     end
 
     private

data/lib/teamtailor/request.rb

@@ -43,10 +43,10 @@ module Teamtailor
 
     def request_headers
       {
-        "Authorization": "Token token=#{api_token}",
+        :Authorization => "Token token=#{api_token}",
         "X-Api-Version" => api_version,
         "User-Agent" => "teamtailor-rb v#{Teamtailor::VERSION}",
-        "Content-Type" => "application/vnd.api+json",
+        "Content-Type" => "application/vnd.api+json"
       }
     end
   end

data/lib/teamtailor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Teamtailor
-  VERSION = "0.4.1"
+  VERSION = "0.5.0"
 end

data/teamtailor.gemspec

@@ -3,19 +3,19 @@
 require_relative "lib/teamtailor/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = "teamtailor"
-  spec.version       = Teamtailor::VERSION
-  spec.authors       = ["André Ligné"]
-  spec.email         = ["hi@andreligne.se"]
+  spec.name = "teamtailor"
+  spec.version = Teamtailor::VERSION
+  spec.authors = ["André Ligné", "Jonas Brusman"]
+  spec.email = ["andre@teamtailor.com", "jonas@teamtailor.com"]
 
-  spec.summary       = "Library for interacting with the Teamtailor API"
-  spec.homepage      = "https://github.com/teamtailor/teamtailor-gem"
-  spec.license       = "MIT"
+  spec.summary = "Library for interacting with the Teamtailor API"
+  spec.homepage = "https://github.com/Teamtailor/teamtailor-rb"
+  spec.license = "MIT"
   spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
 
   spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = "https://github.com/bzf/teamtailor-rb"
-  spec.metadata["changelog_uri"] = "https://github.com/bzf/teamtailor-rb/main/CHANGELOG.md"
+  spec.metadata["source_code_uri"] = "https://github.com/Teamtailor/teamtailor-rb"
+  spec.metadata["changelog_uri"] = "https://github.com/Teamtailor/teamtailor-rb/main/CHANGELOG.md"
 
   spec.extra_rdoc_files = ["README.md"]
 
@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
       f.match(%r{^(test|spec|features)/})
     end
   end
-  spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.bindir = "exe"
+  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: teamtailor
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - André Ligné
+- Jonas Brusman
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-04-09 00:00:00.000000000 Z
+date: 2025-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -40,7 +41,8 @@ dependencies:
         version: 1.4.0
 description:
 email:
-- hi@andreligne.se
+- andre@teamtailor.com
+- jonas@teamtailor.com
 executables: []
 extensions: []
 extra_rdoc_files:
@@ -49,7 +51,8 @@ files:
 - ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
-- ".rubocop.yml"
+- ".rubocop-rake-rspec.yml"
+- ".standard.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -85,13 +88,13 @@ files:
 - lib/teamtailor/request.rb
 - lib/teamtailor/version.rb
 - teamtailor.gemspec
-homepage: https://github.com/teamtailor/teamtailor-gem
+homepage: https://github.com/Teamtailor/teamtailor-rb
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://github.com/teamtailor/teamtailor-gem
-  source_code_uri: https://github.com/bzf/teamtailor-rb
-  changelog_uri: https://github.com/bzf/teamtailor-rb/main/CHANGELOG.md
+  homepage_uri: https://github.com/Teamtailor/teamtailor-rb
+  source_code_uri: https://github.com/Teamtailor/teamtailor-rb
+  changelog_uri: https://github.com/Teamtailor/teamtailor-rb/main/CHANGELOG.md
 post_install_message:
 rdoc_options: []
 require_paths:

data/.rubocop.yml

@@ -1,129 +0,0 @@
-require:
-  - rubocop-rake
-  - rubocop-rspec
-
-AllCops:
-  TargetRubyVersion: 2.7
-  # RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
-  # to ignore them, so only the ones explicitly set in this file are enabled.
-  DisabledByDefault: true
-
-# Prefer &&/|| over and/or.
-Style/AndOr:
-  Enabled: true
-
-# Align `when` with `case`.
-Layout/CaseIndentation:
-  Enabled: false
-
-# Align comments with method definitions.
-Layout/CommentIndentation:
-  Enabled: true
-
-# No extra empty lines.
-Layout/EmptyLines:
-  Enabled: true
-
-# In a regular class definition, no empty lines around the body.
-Layout/EmptyLinesAroundClassBody:
-  Enabled: true
-
-# In a regular method definition, no empty lines around the body.
-Layout/EmptyLinesAroundMethodBody:
-  Enabled: true
-
-# In a regular module definition, no empty lines around the body.
-Layout/EmptyLinesAroundModuleBody:
-  Enabled: true
-
-# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
-Style/HashSyntax:
-  Enabled: true
-
-# Method definitions after `private` or `protected` isolated calls need one
-# extra level of indentation.
-Layout/IndentationConsistency:
-  Enabled: false
-
-# Two spaces, no tabs (for indentation).
-Layout/IndentationWidth:
-  Enabled: true
-
-Layout/SpaceAfterColon:
-  Enabled: true
-
-Layout/SpaceAfterComma:
-  Enabled: true
-
-Layout/SpaceAroundEqualsInParameterDefault:
-  Enabled: true
-
-Layout/SpaceAroundKeyword:
-  Enabled: true
-
-Layout/EmptyLinesAroundBlockBody:
-  Enabled: true
-
-Layout/SpaceAroundOperators:
-  Enabled: true
-
-Layout/SpaceBeforeFirstArg:
-    Enabled: true
-
-# Defining a method with parameters needs parentheses.
-Style/MethodDefParentheses:
-  Enabled: true
-
-# Use `foo {}` not `foo{}`.
-Layout/SpaceBeforeBlockBraces:
-  Enabled: true
-
-# Use `foo { bar }` not `foo {bar}`.
-Layout/SpaceInsideBlockBraces:
-  Enabled: true
-
-# Use `{ a: 1 }` not `{a:1}`.
-Layout/SpaceInsideHashLiteralBraces:
-  Enabled: true
-
-Layout/SpaceInsideParens:
-  Enabled: true
-
-# Check quotes usage according to lint rule below.
-Style/StringLiterals:
-  Enabled: true
-  EnforcedStyle: double_quotes
-
-# Detect hard tabs, no hard tabs.
-Layout/IndentationStyle:
-  Enabled: true
-
-# Blank lines should not have any spaces.
-Layout/TrailingEmptyLines:
-  Enabled: true
-
-# No trailing whitespace.
-Layout/TrailingWhitespace:
-  Enabled: true
-
-# Use quotes for string literals when they are enough.
-Style/RedundantPercentQ:
-  Enabled: true
-
-# Align `end` with the matching keyword or starting expression except for
-# assignments, where it should be aligned with the LHS.
-Layout/EndAlignment:
-  Enabled: true
-  EnforcedStyleAlignWith: variable
-
-# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
-Lint/RequireParentheses:
-  Enabled: true
-
-Style/TrailingCommaInArrayLiteral:
-  Enabled: true
-  EnforcedStyleForMultiline: consistent_comma
-
-Style/TrailingCommaInHashLiteral:
-  Enabled: true
-  EnforcedStyleForMultiline: consistent_comma