tdc 0.4.4.1 → 0.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eca13ff55c92fc5eb5b78f57e7d4e21fab8cffbc6a06eb3f1e824339b678736b
-  data.tar.gz: '057623005580c59c306cf9efd677cfc36547cba6f2bc633ac456d7d219a0fa90'
+  metadata.gz: a605f44cef27e72e80f13f582363886ca57b61238bec36ff2f3367c2c0cd4973
+  data.tar.gz: a61883e606e164fa260f02c3b2588a352600b54b6c0fc9e8b0ae9fc7df6d3970
 SHA512:
-  metadata.gz: 2f130af08383189a6b21cb2d35a71705efecc6e64fe17e44f13265bc8b4b0967b7a85e8baea4ca1a84effb60b6998de5e57c53c6eff8f1ad979917f37f161093
-  data.tar.gz: 1b3cf70a0abe5fa1b6f6cfcf1c3d3455a227ceeca98ed39714ad65b8ecf786a04af9c83ce5452840b469038661acbc076f6657251c3660519a6dbd2bf2efa98c
+  metadata.gz: 2f2d9ac1591cf59bbc6c4bc2c128f5a891cef41c5399b480215f4644dae499f24a8f68bc4e3aef729e66d4f99aee978b4be523d82d58e5757b536bec19ae973e
+  data.tar.gz: 5b69a6c7393477eab60ffea42f8c0764ab1a289fb791c952e3f56f7ad6e9e368f9dfbc9229b82cddb431f6bd5fe637a9fa99dbc3428eb52f75940a0984004a47

data/.rubocop.yml

@@ -20,7 +20,10 @@ Lint/MissingSuper:
   Enabled: false
 
 Metrics/BlockLength:
-  Enabled: false
+  Exclude:
+    - 'tdc.gemspec'
+    - '**/*_shared_example.rb'
+    - '**/*_spec.rb'
 
 Naming/MemoizedInstanceVariableName:
   EnforcedStyleForLeadingUnderscores: required

data/CHANGELOG.md

@@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.4.6] - 2020-09-26
+
+- Better error message when a tag cannot be resolved
+
+Note: version `0.4.5` was yanked from RubyGems.
+
 ## [0.4.4.1] - 2020-09-12
 
 - Avoid registering the same class of interpreter a second time

data/Gemfile

@@ -2,6 +2,3 @@ source "https://rubygems.org"
 
 # Specify your gem's dependencies in tdc.gemspec
 gemspec
-
-gem "rake", "~> 12.0"
-gem "rspec", "~> 3.0"

data/Rakefile

@@ -1,8 +1,17 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 require "rubocop/rake_task"
+require "rubycritic/rake_task"
 
-RuboCop::RakeTask.new
 RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new
+
+RubyCritic::RakeTask.new do |task|
+  files = FileList["**/*.rb"]
+  files.exclude("**/*_spec.rb")
+  files.exclude("**/*_shared_example.rb")
+
+  task.paths = files
+end
 
 task :default => [:rubocop, :spec]

data/lib/tdc/definition_resolvers/tag_resolver.rb

@@ -24,15 +24,23 @@ module Tdc
         # Use the tag to source an object from the current catalog.
         sourced_object = catalog_entry.send(tag)
 
-        unless sourced_object
-          message = "Could not find a tag reference for '#{key}' in the catalog entries provided."
-
-          raise Tdc::FatalError, message
-        end
+        unresolvable_tag(tag, catalog_entry) unless sourced_object
 
         # Replace the tag value with the sourced object.
         instance_definition[key] = sourced_object
       end
+
+      private
+
+      def unresolvable_tag(tag, catalog_entry)
+        source_tags = catalog_entry.entries.sort.map { |entry| "'#{entry}'" }.to_sentence
+
+        raise Tdc::FatalError, <<~MESSAGE
+          Could not resolve key '#{key}' from source '#{source}'.
+
+          Attempted to resolve tag '#{tag}' from these tags: #{source_tags}
+        MESSAGE
+      end
     end
   end
 end

data/lib/tdc/generators/catalog_entries.rb

@@ -13,6 +13,10 @@ module Tdc
         to_h.empty?
       end
 
+      def entries
+        to_h.keys
+      end
+
       def first
         to_h.first&.second
       end

data/lib/tdc/generators/definition_sourcable.rb

@@ -46,7 +46,7 @@ module Tdc
         end
       end
 
-      def respond_to_missing?(method, include_all = false) # rubocop:disable Style/OptionalBooleanParameter
+      def respond_to_missing?(method, include_all = false)
         ghost_definition?(method) || ghost_optional_definition?(method) ? true : super
       end
 

data/lib/tdc/version.rb

@@ -1,3 +1,3 @@
 module Tdc
-  VERSION = "0.4.4.1"
+  VERSION = "0.4.6"
 end

data/tdc.gemspec

@@ -33,6 +33,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", ">= 12.1", "< 13.1"
   spec.add_development_dependency "rspec", ">= 3.9", "< 4.0"
   spec.add_development_dependency "rubocop", "~> 0.89"
+  spec.add_development_dependency "rubocop-performance", "~> 1.8"
   spec.add_development_dependency "rubocop-rspec", "~> 1.42"
+  spec.add_development_dependency "rubycritic", "~> 4.5"
   spec.add_development_dependency "simplecov", "~> 0.17"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tdc
 version: !ruby/object:Gem::Version
-  version: 0.4.4.1
+  version: 0.4.6
 platform: ruby
 authors:
 - Alistair McKinnell
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-09-13 00:00:00.000000000 Z
+date: 2020-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -78,6 +78,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.89'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -92,6 +106,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.42'
+- !ruby/object:Gem::Dependency
+  name: rubycritic
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.5'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement