tdc 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d7775cd9909b7d1aef1f59def823777cc24d6bbfc50ddfd41eda202f5f5f387
-  data.tar.gz: 11b7ddadec9d97e1953f34efdee8b66d6f0cb08213dd8d9a9e9d4ae8372687fa
+  metadata.gz: 46a2a39e062ccd48c5634a1c0f2fb07e5705268ceb930bb0dc4b41127683406b
+  data.tar.gz: 9ea9e2f9ddf8bb1696151426ab584a734544ed51c9dac67d2e153293707b522b
 SHA512:
-  metadata.gz: 1f396da321ee096251062cd35ff6add1d19292591dc8fa019509fe432f2fd7faea74844ee4583fbb30bc03e9f8106fbeabdb403732ec5098d70c40b69e2c216c
-  data.tar.gz: 69cfdaa1a302ae2d458f6775db22134953db4f6f584ba9af36970f4865d308de9a44d9c5c6ec10e7db0a4ec5c05d340254a4458dfc843d6676225459e2542660
+  metadata.gz: 15cab57dccd6be42ab9f1de3782db7df1f29c33f20196aa40ba4b7cfaf36fe4a30a84ee7d8b0b4f38dbccf6afd24b6580b21fe1c9a6afa2d78eae8852eac889c
+  data.tar.gz: e7182a480f845f3e196354c2d170df24f9a762f57db3993c9ca8e266425d01637960f588ae938484a9731e99d7b5bc9f71b1921773b6d3450f02d681515d89fd

data/.rubocop.yml

@@ -17,6 +17,16 @@ Layout/MultilineMethodCallBraceLayout:
 Layout/SpaceAroundMethodCallOperator:
   Enabled: true
 
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
+
 Lint/RaiseException:
   Enabled: true
 
@@ -59,6 +69,15 @@ RSpec/MultipleExpectations:
 RSpec/SubjectStub:
   Enabled: false
 
+Style/AccessorGrouping:
+  Enabled: true
+
+Style/ArrayCoercion:
+  Enabled: true
+
+Style/BisectedAttrAccessor:
+  Enabled: true
+
 Style/BlockDelimiters:
   Enabled: true
   EnforcedStyle: line_count_based
@@ -66,6 +85,9 @@ Style/BlockDelimiters:
     - 'let'
     - 'subject'
 
+Style/CaseLikeIf:
+  Enabled: true
+
 Style/Documentation:
   Enabled: false
 
@@ -79,9 +101,15 @@ Style/ExponentialNotation:
 Style/FrozenStringLiteralComment:
   Enabled: false
 
+Style/HashAsLastArrayItem:
+  Enabled: true
+
 Style/HashEachMethods:
   Enabled: true
 
+Style/HashLikeCase:
+  Enabled: true
+
 Style/HashTransformKeys:
   Enabled: true
 
@@ -93,6 +121,21 @@ Style/HashSyntax:
   Exclude:
     - 'Rakefile'
 
+Style/RedundantAssignment:
+  Enabled: true
+
+Style/RedundantFetchBlock:
+  Enabled: true
+
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
+
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+Style/RedundantRegexpEscape:
+  Enabled: true
+
 # No need to mention StandardError.
 Style/RescueStandardError:
   EnforcedStyle: implicit

data/CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.3.1] - 2020-07-25
+
+- Support DefinitionResolver instance registration
+
 ## [0.3.0] - 2020-07-19
 
 - Introduce the DefinitionResolver abstraction

data/lib/tdc/generators/definition_resolvable.rb

@@ -2,7 +2,7 @@ module Tdc
   module Generators
     #
     # Knows how to resolve attribute values in an instance definition. The attribute value will be replaced
-    # by the result of invoking the specified resolver.
+    # by the result of invoking the registered resolver.
     #
     # The resolve_tag class macro is provided for generators to define tag resolution. The test data definition
     # YAML file has attribute values than contain a catalog entry tag.
@@ -14,18 +14,9 @@ module Tdc
     #
     #   resolve_tag key: :subcomponent, source: "item_master.items"
     #
-    # The resolve_definition class macro is provided for generators to define definition resolution. The test data
-    # definition YAML file has attribute values than contain an arbitrary value that will typically be replaced by
-    # an instance of an object returned by the specified resolver.
-    #
-    # Example:
-    #
-    # Suppose a particular instance definition contained { pallet_number: P0001 } then a generator could resolve
-    # the pallet_number to a pallet instance by defining:
-    #
-    #   resolve_definition :pallet_number, to: :pallet_id, resolver: "TestDataCatalog::Resolvers::PalletNumberResolver"
-    #
-    # The PalletNumberResolver class inherits from Tdc::DefinitionResolvers::DefinitionResolver.
+    # The register_definition_resolver class macro is provided for generators to define and register their own
+    # definition resolvers. The test data  definition YAML file has attribute values than contain an arbitrary
+    # value that will typically be replaced by an instance of an object returned by the specified resolver.
     #
     module DefinitionResolvable
       extend ActiveSupport::Concern
@@ -37,14 +28,12 @@ module Tdc
       end
 
       class_methods do
-        def resolve_definition(key:, to: nil, resolver:)
-          resolver_instance = resolver.constantize.new(key: key, to: to || key)
-
+        def register_definition_resolver(resolver_instance)
           _definition_resolvers << resolver_instance
         end
 
         def resolve_tag(key:, source:)
-          _definition_resolvers << Tdc::DefinitionResolvers::TagResolver.new(key: key, source: source)
+          register_definition_resolver(Tdc::DefinitionResolvers::TagResolver.new(key: key, source: source))
         end
       end
 

data/lib/tdc/version.rb

@@ -1,3 +1,3 @@
 module Tdc
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/tdc.gemspec

@@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "rake", ">= 12.1", "< 13.1"
   spec.add_development_dependency "rspec", ">= 3.9", "< 4.0"
-  spec.add_development_dependency "rubocop", "~> 0.82"
-  spec.add_development_dependency "rubocop-rspec", "~> 1.38"
+  spec.add_development_dependency "rubocop", "~> 0.88"
+  spec.add_development_dependency "rubocop-rspec", "~> 1.42"
   spec.add_development_dependency "simplecov", "~> 0.17"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tdc
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Alistair McKinnell
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-07-20 00:00:00.000000000 Z
+date: 2020-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -70,28 +70,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.82'
+        version: '0.88'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.82'
+        version: '0.88'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.38'
+        version: '1.42'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.38'
+        version: '1.42'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement