tcs-ldap-permission 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: d2025fb81cee1f349807d52ca15b280a46cb1176
-  data.tar.gz: 22e2e6c8d17d5c273cc300abd0e7993994b63264
+SHA256:
+  metadata.gz: 9680916e4e4eea217de0da66b7302a9089b7c61368f4a61d82cb95067837c2b3
+  data.tar.gz: 70b3bea402407ef6ae215c8f1a38372b81ca3db40c86cb7c2a8d2a048016d8f6
 SHA512:
-  metadata.gz: 463819ac04e04f5a5703e0fea5b4fbade157a1e0f5bf27a40116df6599b5507917c0dba5ceb3bfa0689f20f716dc0209e9e17826d3696f5466ccc21c3d4e1d3f
-  data.tar.gz: 16fef793d951f59c0d42fc8749a1c11acb38e7d406673d41a567412519ac1e68dc927131498d1fb315c81ba1d59f2a90f64ab159d3136ff16add0765738716ac
+  metadata.gz: a956eaf072f9bc0b2f2a88e554d8f44f676e9c8362f4504523bae74f4c209c64cd302fcc2482187e21234d99172096a7ea988b85858df93c926cc80d0cb55120
+  data.tar.gz: efd1dbc9564645274ae0e423b0bf0aa500f7ec5cf80047b85cb43a9e036d948ffce5646a015995ff7192ef797a12a9d9d17c537289f4c2bea98cf8b8798b1dfc

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    tcs-ldap-permission (1.0.0)
+    tcs-ldap-permission (1.1.0)
 
 GEM
   remote: https://rubygems.org/
@@ -37,4 +37,4 @@ DEPENDENCIES
   tcs-rubocop
 
 BUNDLED WITH
-   1.16.0
+   1.16.1

data/README.md

@@ -21,7 +21,7 @@ Or install it yourself as:
 
 ## Usage
 
-Add a `config/ldap_perimissions.yml` configuration file, e.g.
+Add a `config/ldap_permissions.yml` configuration file, e.g.
 ```yaml
 <%= Rails.env %>:
   groups:
@@ -57,8 +57,8 @@ end
 
 ### Configuration
 
-The `config/ldap_perimissions.yml` file specifies what actions are available to a group or user.
-It is preferable to only use groups so that the `config/ldap_perimissions.yml` doesn't
+The `config/ldap_permissions.yml` file specifies what actions are available to a group or user.
+It is preferable to only use groups so that the `config/ldap_permissions.yml` doesn't
 need to be updated every time a person moves into or out of a role.
 In situations where it doesn't make sense to create a group, you can specify individual
 users by their login.   

data/lib/tcs/ldap/group.rb

@@ -11,6 +11,8 @@
 #   ['DC', 'com']
 # ]
 class Tcs::Ldap::Group
+  SECURITY_GROUP_ROOT = [["DC", "com"], ["DC", "containerstore"], ["OU", "Group Accounts"], ["OU", "Security Groups"]]
+
   def initialize(group_string)
     @original_string = group_string
     # CN=pb\, admins,OU=Security Groups\=good,OU=Group Accounts,DC=containerstore,DC=com
@@ -28,6 +30,10 @@ class Tcs::Ldap::Group
     @nodes = nodes_with_equals_replaced.collect { |n| [n.first, n.last.gsub(/;;/, "=")] }
   end
 
+  def security_group?
+    @nodes.reverse[0...4] == SECURITY_GROUP_ROOT
+  end
+
   def cn
     @nodes.first.last
   end

data/lib/tcs/ldap/permission.rb

@@ -24,8 +24,14 @@ module Tcs
         klass.extend(ClassMethods)
       end
 
+      # Return the user's groups that have been configured in ldap_permissions.yml
       def groups
-        @groups ||= fetch_groups
+        @groups ||= fetch_configured_group_names
+      end
+
+      # Return all of this user's security groups, whether or not they are in ldap_permissions.yml
+      def all_security_groups
+        @all_security_groups ||= fetch_security_groups
       end
 
       def authorized_actions
@@ -42,11 +48,18 @@ module Tcs
 
       private
 
-      def fetch_groups
+      def fetch_configured_group_names
+        fetch_all_groups.map(&:cn) & self.class.configured_ldap_groups
+      end
+
+      def fetch_security_groups
+        fetch_all_groups.select(&:security_group?).map(&:cn)
+      end
+
+      def fetch_all_groups
         ldap_array = ldap(:memberof)
         return [] if ldap_array.nil?
-        groups = ldap_array.collect { |g| Tcs::Ldap::Group.new(g) }
-        groups.collect(&:cn) & self.class.configured_ldap_groups
+        ldap_array.collect { |g| Tcs::Ldap::Group.new(g) }
       end
 
       def ldap(attr)

data/lib/tcs/ldap/permission/version.rb

@@ -2,7 +2,7 @@
 module Tcs
   module Ldap
     module Permission
-      VERSION = "1.0.0"
+      VERSION = "1.1.0"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tcs-ldap-permission
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Ed Wagner
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-04-13 00:00:00.000000000 Z
+date: 2019-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -104,7 +104,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.9
 signing_key: 
 specification_version: 4
 summary: An easy way to map LDAP groups to application roles