tco_client_core 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a06f11ee66ae3e0e9d4fab6f00c0e923461baa48
-  data.tar.gz: 437730372295d925701bb287ca233faf7afb65c5
+  metadata.gz: 1fba66273191b0a4c9ce439c6ce0a12b64a05152
+  data.tar.gz: ad1536d4cd5639e70d4f138a289f4fc59250c9d0
 SHA512:
-  metadata.gz: b3d70e7a309c7124bb47b1ccfec371673dcfe89741df7d7a1f029e95b97381833bf5bf6239b23bc0c4d6dabf455e53356c37bf7b63ac0b3ebca21ad4708a6333
-  data.tar.gz: b06644348ba495de742978219e1ac1f41d044a692b0df7aaba47b42892151fd2847fbcc07f3c6355f2998753c6f601bf5292c93efa9bcd2ea3a4f1ee8307f2c5
+  metadata.gz: 125cd1fa26f50f6e6e8c1c162f6357177015a4fe3c340d6e95e1dc1295ef27f9dea83c280d8e52fb865214243427bdf2ec8479bd6f53edbcb54f1ced2b525b2a
+  data.tar.gz: ad32aa74c0b5005f039ea864ae8db43316e43a4e58c86bab7ba05baf509e63e121eb36924e96e74548b8704a44fa7fe057dc128b3331b542075e1cb58cfbb207

data/lib/tco_client_core/response.rb

@@ -14,21 +14,25 @@ module TcoClientCore
       end
     end
 
+    def to_json
+      to_s
+    end
+
     def as_json
       JSON.parse(raw)
     end
 
     def to_s
-      raw
+      raw.to_s
     end
 
     def to_struct(object=nil)
       object ||= as_json
       if object.is_a? Array
-        object.map { |v| to_struct(v) }
+        object.map { |v| v.nil? ? v : to_struct(v) }
       elsif object.is_a? Hash
         object.each_with_object(OpenStruct.new) do |(key, val), st|
-          st[key] = to_struct(val)
+          st[key] = val.nil? ? val : to_struct(val)
         end
       else
         object

data/lib/tco_client_core/version.rb

@@ -1,3 +1,3 @@
 module TcoClientCore
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/response_spec.rb

@@ -15,6 +15,12 @@ describe TcoClientCore::Response do
   end
 
   describe "#to_json" do
+    it "returns the raw json" do
+      expect(subject.to_json).to eq(raw_response)
+    end
+  end
+
+  describe "#as_json" do
     it "returns the response as json" do
       expect(subject.as_json).to have_key("test")
     end
@@ -43,6 +49,14 @@ describe TcoClientCore::Response do
         })
         expect(ostruct.two.three.first).to be_kind_of(OpenStruct)
       end
+
+      context "with nil values" do
+        subject { TcoClientCore::Response.new({ test: nil }.to_json) }
+
+        it "does not create an infinite loop" do
+          expect { subject.to_struct }.not_to raise_error
+        end
+      end
     end
 
     context "with an array" do
@@ -59,6 +73,14 @@ describe TcoClientCore::Response do
         ])
         expect(array.last.first).to be_kind_of(OpenStruct)
       end
+
+      context "with nil values" do
+        subject { TcoClientCore::Response.new([nil].to_json) }
+
+        it "does not create an infinite loop" do
+          expect { subject.to_struct }.not_to raise_error
+        end
+      end
     end
   end
 

data/spec/spec_helper.rb

@@ -2,7 +2,6 @@ require "rubygems"
 require "awesome_print"
 require "bundler/setup"
 require "tco_client_core"
-require "vcr"
 require "json"
 
 RSpec.configure do |config|
@@ -12,11 +11,4 @@ end
 
 TcoClientCore.configure do |config|
   config.base_uri = "localhost:4000/internal"
-end
-
-VCR.configure do |config|
-  config.configure_rspec_metadata!
-  config.allow_http_connections_when_no_cassette = true
-  config.cassette_library_dir = "spec/fixtures/vcr_cassettes"
-  config.hook_into :webmock
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tco_client_core
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - 2CO Inc
@@ -220,34 +220,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.2'
-- !ruby/object:Gem::Dependency
-  name: vcr
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.9'
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.20'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.20'
 description: Handles communication with 2checkout.com's API
 email:
 - support@2co.com