tb_banners 1.2.1 → 1.3.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5084f24ce0780c4f094bda989dea064c2b444bd0
-  data.tar.gz: c31a8e5ed4cf76249e77a8d169718d8bf3d535b6
+  metadata.gz: 4c5570408f1fd6f89b4ded74aaf55fbe28485c35
+  data.tar.gz: c747224366ee66af3f347a8c569d8d66bdb51956
 SHA512:
-  metadata.gz: e500326dd50361f539c42aadc48aeebf51370b1ecd66bb2e98f7f0ccdffbb75ca373110155b17edaa4d3e9424d0dda94970082a12ccf5dce5c59d1704cd26be3
-  data.tar.gz: 2e2c66573d537ee204f6751ae1b73cb6abb8647f15ef89a0fc6e2d7098df6a580cc20733f1db2f7d88384a2dfc757e4ba146860213f2c546edfc62033415dc9a
+  metadata.gz: 3f55b7a276d17e9215bb54c109fdda5d0fe1515bb41c01da8197f98daff23f192fc31dc9c47f5c9d633a3ccb11654fe818ce8cbb4a3b977283404fa7f617f824
+  data.tar.gz: 10bef6d2c769966df3dd61b1543e2371a78c0a8e7ec2b541d8680109ce2614c5ef7fdd675f5e997d6c4f36b1f20531575cb836bdbf37d5bfdba863a4dffb99ed

data/README.markdown

@@ -103,21 +103,11 @@ Displaying banners using the helper, with a block for even more custom html.
 	</ul>
 ```
 
-## Liquid
-
-TB Banners comes with its own custom [Liquid][liquid] tag. For now the liquid tag only supports rendering the standard html as generated by the `spud_banners_for_set`. Will provide support more advanced options in the future.
-
-Usage:
-
-```erb
-	<%= raw Liquid::Template.parse("{% spud_banner_set Promotions %}").render %>
-```
-
 ## Rich Text
 
-Banner Sets contain a configuration for rich text. Turning this feature on will enable a rich text editor on individual banners. The default setting for this option is off. 
+Banner Sets contain a configuration for rich text. Turning this feature on will enable a rich text editor on individual banners. The default setting for this option is off.
 
-Rich text is intended to be more of an edge case feature, and should be used only if your banner needs to include an editable HTML block. The built-in helpers described earlier will not automatically include your rich text; If you want to use this feature, you should supply a block to the helper and render the rich text yourself. 
+Rich text is intended to be more of an edge case feature, and should be used only if your banner needs to include an editable HTML block. The built-in helpers described earlier will not automatically include your rich text; If you want to use this feature, you should supply a block to the helper and render the rich text yourself.
 
 ```erb
 	<ul id="slides">

data/Rakefile

@@ -20,11 +20,9 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-APP_RAKEFILE = File.expand_path("../spec/dummy/Rakefile", __FILE__)
+APP_RAKEFILE = File.expand_path('../spec/dummy/Rakefile', __FILE__)
 load 'rails/tasks/engine.rake'
 
-
-
 Bundler::GemHelper.install_tasks
 
 require 'rake/testtask'
@@ -36,5 +34,4 @@ Rake::TestTask.new(:test) do |t|
   t.verbose = false
 end
 
-
-task :default => :test
+task default: :test

data/app/assets/javascripts/admin/banners/banners.js

@@ -3,7 +3,6 @@
 
 (function(){
 
-var html5upload = false;
 var bannerEditId = false;
 
 spud.admin.banners = {
@@ -11,9 +10,6 @@ spud.admin.banners = {
   // Index Page
   /////////////
   init: function(){
-    if(typeof(FormData) != 'undefined'){
-      html5upload = true;
-    }
     $('.admin-banner-set-item-add').on('click', clickedAddNewBanner);
     $('.admin-banner-set-items-container').on('click', '.admin-banner-set-item-edit', clickedEditBanner);
     $('.admin-banner-set-items-container').on('click', '.admin-banner-set-item-delete', clickedDeleteBanner);
@@ -87,43 +83,41 @@ var clickedDeleteBanner = function(e){
 };
 
 var submittedBannerForm = function(e){
-  if(html5upload){
-    e.preventDefault();
+  e.preventDefault();
 
-    var form = $(this);
-    var fd = new FormData();
-    
-    $('input[type=text], input[type=hidden], select').each(function(index, element){
-      var input = $(element);
-      var name = input.attr('name');
-      var value = input.val();
-      fd.append(name, value);
-    });
+  var form = $(this);
+  var fd = new FormData();
 
-    var richText = form.find('.admin-banner-rich-text');
-    if(richText.length > 0){
-      fd.append('spud_banner[rich_text]', richText.val());
-    }
-    else{
-      fd.append('spud_banner[rich_text]', '');
-    }
+  $('input[type=text], input[type=hidden], select').each(function(index, element){
+    var input = $(element);
+    var name = input.attr('name');
+    var value = input.val();
+    fd.append(name, value);
+  });
 
-    var file = form.find('#spud_banner_banner')[0].files[0];
-    if(file){
-      fd.append('spud_banner[banner]', file);
-      $('.admin-banner-upload-progress').show();
-    }
+  var richText = form.find('.admin-banner-rich-text');
+  if(richText.length > 0){
+    fd.append('spud_banner[rich_text]', richText.val());
+  }
+  else{
+    fd.append('spud_banner[rich_text]', '');
+  }
 
-    var xhr = new XMLHttpRequest();
-    xhr.upload.addEventListener('progress', onFileUploadProgress);
-    xhr.addEventListener('load', onFileUploadComplete);
-    xhr.addEventListener('error', onFileUploadError);
-    xhr.addEventListener('abort', onFileUploadAbort);
-    xhr.open('POST', form.attr('action'));
-    xhr.setRequestHeader('X-Requested-With', 'XMLHttpRequest');
-    xhr.send(fd);
-    return false;
+  var file = form.find('#spud_banner_banner')[0].files[0];
+  if(file){
+    fd.append('spud_banner[banner]', file);
+    $('.admin-banner-upload-progress').show();
   }
+
+  var xhr = new XMLHttpRequest();
+  xhr.upload.addEventListener('progress', onFileUploadProgress);
+  xhr.addEventListener('load', onFileUploadComplete);
+  xhr.addEventListener('error', onFileUploadError);
+  xhr.addEventListener('abort', onFileUploadAbort);
+  xhr.open('POST', form.attr('action'));
+  xhr.setRequestHeader('X-Requested-With', 'XMLHttpRequest');
+  xhr.send(fd);
+  return false;
 };
 
 var onFileUploadProgress = function(e){
@@ -138,10 +132,10 @@ var onFileUploadProgress = function(e){
 var onFileUploadComplete = function(e){
   switch(this.status){
     case 200:
-      spud.admin.banners.onLegacyUploadComplete(e.target.response);
+      onUploadComplete(e.target.response);
       break;
     case 422:
-      spud.admin.banners.onLegacyUploadError(e.target.response);
+      onUploadError(e.target.response);
       break;
     default:
       window.alert("Whoops! Something has gone wrong.");
@@ -156,8 +150,7 @@ var onFileUploadAbort = function(e){
 
 };
 
-// Non-html5 upload
-spud.admin.banners.onLegacyUploadComplete = function(html){
+var onUploadComplete = function(html){
   if(bannerEditId){
     var item = $('.admin-banner-set-item[data-id="'+bannerEditId+'"]');
     item.replaceWith(html);
@@ -168,7 +161,7 @@ spud.admin.banners.onLegacyUploadComplete = function(html){
   spud.admin.modal.hide();
 };
 
-spud.admin.banners.onLegacyUploadError = function(html){
+var onUploadError = function(html){
   $('.admin-banner-form').replaceWith(html);
   initForm();
 };

data/app/controllers/admin/banner_sets_controller.rb

@@ -1,6 +1,6 @@
 class Admin::BannerSetsController < Admin::ApplicationController
 
-  before_filter :get_record, :only => [:show, :edit, :update, :destroy]
+  before_action :get_record, only: [:show, :edit, :update, :destroy]
   respond_to :html
   belongs_to_app :banner_sets
   add_breadcrumb 'Banner Sets', :admin_banner_sets_path
@@ -8,11 +8,11 @@ class Admin::BannerSetsController < Admin::ApplicationController
 
   def index
     @banner_sets = SpudBannerSet.all
-    respond_with @banner_sets, :layout => 'admin/detail'
+    respond_with @banner_sets, layout: 'admin/detail'
   end
 
   def show
-    respond_with @banner_set, :layout => 'admin/detail'
+    respond_with @banner_set, layout: 'admin/detail'
   end
 
   def new
@@ -23,10 +23,10 @@ class Admin::BannerSetsController < Admin::ApplicationController
   def create
     @banner_set = SpudBannerSet.new(banner_set_params)
     if @banner_set.save
-      flash.now[:notice] = 'BannerSet created successfully' 
+      flash.now[:notice] = 'BannerSet created successfully'
       render 'create'
     else
-      render 'new', :status => 422
+      render 'new', status: 422
     end
   end
 
@@ -39,31 +39,27 @@ class Admin::BannerSetsController < Admin::ApplicationController
       flash.now[:notice] = 'BannerSet updated successfully'
       render 'create'
     else
-      render 'edit', :status => 422
+      render 'edit', status: 422
     end
   end
 
   def destroy
-    if @banner_set.destroy
-      flash.now[:notice] = 'BannerSet deleted successfully' 
-    end
-    render :nothing => true
+    flash.now[:notice] = 'BannerSet deleted successfully' if @banner_set.destroy
+    head :ok
   end
 
-private
+  private
 
   def get_record
-    begin
-      @banner_set = SpudBannerSet.find(params[:id])
-    rescue ActiveRecord::RecordNotFound => e
-      flash.now[:error] = "Could not find the requested BannerSet"
-      redirect_to admin_banner_sets_path
-      return false
-    end
+    @banner_set = SpudBannerSet.find(params[:id])
+  rescue ActiveRecord::RecordNotFound => e
+    flash.now[:error] = 'Could not find the requested BannerSet'
+    redirect_to admin_banner_sets_path
+    return false
   end
 
   def banner_set_params
     params.require(:spud_banner_set).permit(:cropped, :height, :name, :short_name, :width, :has_rich_text)
   end
 
-end
+end

data/app/controllers/admin/banners_controller.rb

@@ -1,14 +1,12 @@
 class Admin::BannersController < Admin::ApplicationController
 
-  include RespondsToParent
-
-  before_filter :get_set, :only => [:new, :create]
-  before_filter :get_record, :only => [:edit, :update, :destroy]
+  before_action :get_set, only: [:new, :create]
+  before_action :get_record, only: [:edit, :update, :destroy]
   respond_to :html
   layout false
 
   def new
-    @banner = @banner_set.banners.new(:start_date => Date.today)
+    @banner = @banner_set.banners.new(start_date: Date.today)
     respond_with @banner
   end
 
@@ -16,23 +14,14 @@ class Admin::BannersController < Admin::ApplicationController
     @banner = @banner_set.banners.build
     @banner.attributes = banner_params
 
-    last_banner = SpudBanner.select('sort_order').where(:spud_banner_set_id => @banner_set.id).order('sort_order desc').first
-    if last_banner
-     @banner.sort_order = last_banner.sort_order + 1
-    end
+    last_banner = SpudBanner.select('sort_order').where(spud_banner_set_id: @banner_set.id).order('sort_order desc').first
+    @banner.sort_order = last_banner.sort_order + 1 if last_banner
 
-    if request.xhr?
-      if @banner.save
-        flash.now[:notice] = 'SpudBanner created successfully' 
-        render 'show'
-      else
-        render 'new', :status => 422
-      end
+    if @banner.save
+      flash.now[:notice] = 'SpudBanner created successfully'
+      render 'show'
     else
-      @banner.save
-      respond_to_parent do
-        render 'legacy', :formats => [:js]
-      end
+      render 'new', status: 422
     end
   end
 
@@ -41,68 +30,57 @@ class Admin::BannersController < Admin::ApplicationController
   end
 
   def update
-    if request.xhr?
-      if @banner.update_attributes(banner_params)
-        flash.now[:notice] = 'SpudBanner created successfully' 
-        render 'show'
-      else
-        render 'edit', :status => 422
-      end
+    if @banner.update_attributes(banner_params)
+      flash.now[:notice] = 'SpudBanner created successfully'
+      render 'show'
     else
-      @banner.update_attributes(banner_params)
-      respond_to_parent do
-        render 'legacy', :formats => [:js]
-      end
+      render 'edit', status: 422
     end
   end
 
   def destroy
     if @banner.destroy
-      flash.now[:notice] = 'SpudBanner deleted successfully' 
+      flash.now[:notice] = 'SpudBanner deleted successfully'
       status = 200
     else
       status = 422
     end
-    render :nothing => true, :status => status
+    render blank: true, status: status
   end
 
   def sort
     banner_ids = params[:spud_banner_ids]
-    banners = SpudBanner.where(:id => banner_ids).to_a
+    banners = SpudBanner.where(id: banner_ids).to_a
     SpudBanner.transaction do
       banner_ids.each_with_index do |id, index|
-        banner = banners.select{ |b| b.id == id.to_i }.first
+        banner = banners.select { |b| b.id == id.to_i }.first
         banner.update_column(:sort_order, index)
       end
       banners.last.owner.touch()
     end
-    render :nothing => true, :status => 200
+    head :ok
   end
 
-private
+  private
 
   def get_set
-    begin
-      @banner_set = SpudBannerSet.find(params[:banner_set_id])
-    rescue ActiveRecord::RecordNotFound => e
-      flash.now[:error] = "Could not find the requested SpudBannerSet"
-      render :nothing => true, :status => 404
-      return false
-    end
+    @banner_set = SpudBannerSet.find(params[:banner_set_id])
+  rescue ActiveRecord::RecordNotFound => e
+    flash.now[:error] = 'Could not find the requested SpudBannerSet'
+    render blank: true, status: 404
+    return false
   end
 
   def get_record
-    begin
-      @banner = SpudBanner.find(params[:id])
-    rescue ActiveRecord::RecordNotFound => e
-      flash.now[:error] = "Could not find the requested SpudBanner"
-      redirect_to admin_banner_sets_path
-      return false
-    end
+    @banner = SpudBanner.find(params[:id])
+  rescue ActiveRecord::RecordNotFound => e
+    flash.now[:error] = 'Could not find the requested SpudBanner'
+    redirect_to admin_banner_sets_path
+    return false
   end
 
   def banner_params
     params.require(:spud_banner).permit(:banner, :link_to, :link_target, :title, :alt, :sort_order, :rich_text, :start_date, :end_date)
   end
 
-end
+end

data/app/helpers/spud_banners_helper.rb

@@ -9,11 +9,11 @@ module SpudBannersHelper
   #   - background_image: Pass true to return the banners as CSS background-image properties rather than <img/> tags
   #
   def spud_banners_for_set(set_or_identifier, options = {})
-    if set_or_identifier.is_a?(SpudBannerSet)
-      banner_set = set_or_identifier
-    else
-      banner_set = SpudBannerSet.find_by_identifier(set_or_identifier)
-    end
+    banner_set = if set_or_identifier.is_a?(SpudBannerSet)
+                   set_or_identifier
+                 else
+                   SpudBannerSet.find_with_identifier(set_or_identifier)
+                 end
     return '' if banner_set.blank?
     cache(banner_set) do
       concat spud_banners_set_tag(banner_set, options)
@@ -39,13 +39,13 @@ module SpudBannersHelper
       content_tag(:div, :class => "spud-banner-set #{options[:wrapper_class]}", 'data-id' => banner_set.id) do
         banners_query.map do |banner|
           if background_image
-            concat(content_tag(:div, :class => "spud-banner #{options[:banner_class]}", 'data-id' => banner.id, :style => "background-image:url('#{banner.banner.url(:banner)}');"){
+            concat(content_tag(:div, :class => "spud-banner #{options[:banner_class]}", 'data-id' => banner.id, :style => "background-image:url('#{banner.banner.url(:banner)}');") do
               if banner.rich_text
-                content_tag :div, raw(banner.rich_text), :class => 'spud-banner-rich-text'
+                content_tag :div, raw(banner.rich_text), class: 'spud-banner-rich-text'
               end
-            })
+            end)
           else
-            concat(content_tag(:div, :class => "spud-banner #{options[:banner_class]}", 'data-id' => banner.id){ spud_banner_tag(banner, options) })
+            concat(content_tag(:div, :class => "spud-banner #{options[:banner_class]}", 'data-id' => banner.id) { spud_banner_tag(banner, options) })
           end
         end
       end
@@ -55,11 +55,11 @@ module SpudBannersHelper
   # Returns an HTML tag for a single banner
   # May return either an <img/> or an <a/> depending on the banner
   #
-  def spud_banner_tag(banner, options={})
+  def spud_banner_tag(banner, _options = {})
     if banner.link_to.blank?
       spud_banner_image_tag(banner)
     else
-      link_to(banner.link_to, :target => banner.link_target) do
+      link_to(banner.link_to, target: banner.link_target) do
         spud_banner_image_tag(banner)
       end
     end
@@ -68,7 +68,7 @@ module SpudBannersHelper
   # Returns an HTML <img/> tag for a single banner
   #
   def spud_banner_image_tag(banner)
-    image_tag(banner.banner.url(:banner), :alt => banner.alt, :title => banner.title)
+    image_tag(banner.banner.url(:banner), alt: banner.alt, title: banner.title)
   end
 
 end

data/app/models/spud_banner.rb

@@ -1,34 +1,34 @@
 class SpudBanner < ActiveRecord::Base
-  belongs_to :owner, :class_name => 'SpudBannerSet', :foreign_key => 'spud_banner_set_id', :inverse_of => :banners, :touch => true
+  belongs_to :owner, class_name: 'SpudBannerSet', foreign_key: 'spud_banner_set_id', inverse_of: :banners, touch: true
 
-  scope :active, ->{
+  scope :active, -> {
     where('(start_date IS NULL OR start_date <= ?) AND (end_date IS NULL OR end_date >= ?)', Date.today, Date.today)
   }
 
-  has_attached_file :banner, 
-    :styles => lambda { |attachment| attachment.instance.dynamic_styles },
-    :convert_options => {
-      :tiny => '-strip -density 72x72',
-      :banner => '-strip -density 72x72'
+  has_attached_file :banner,
+    styles: ->(attachment) { attachment.instance.dynamic_styles },
+    convert_options: {
+      tiny: '-strip -density 72x72',
+      banner: '-strip -density 72x72'
     },
-    :storage => Spud::Banners.paperclip_storage,
-    :s3_credentials => Spud::Banners.s3_credentials,
-    :s3_protocol => Spud::Banners.s3_protocol,
-    :url => Spud::Banners.storage_url,
-    :path => Spud::Banners.storage_path
+    storage: Spud::Banners.paperclip_storage,
+    s3_credentials: Spud::Banners.s3_credentials,
+    s3_protocol: Spud::Banners.s3_protocol,
+    url: Spud::Banners.storage_url,
+    path: Spud::Banners.storage_path
 
   validates_attachment :banner,
-    :presence => true,
-    :content_type => {:content_type => ['image/jpg', 'image/jpeg', 'image/png']}
+    presence: true,
+    content_type: { content_type: ['image/jpg', 'image/jpeg', 'image/png'] }
 
   def dynamic_styles
     styles = {
-      :tiny => '150x150'
+      tiny: '150x150'
     }
     owner_style = nil
-    if self.owner
-      owner_style = "#{self.owner.width}x#{self.owner.height}"
-      owner_style += '#' if self.owner.cropped
+    if owner
+      owner_style = "#{owner.width}x#{owner.height}"
+      owner_style += '#' if owner.cropped
       styles[:banner] = owner_style
     end
     return styles

data/app/models/spud_banner_set.rb

@@ -1,27 +1,27 @@
 class SpudBannerSet < ActiveRecord::Base
-  has_many :banners, ->{ order('sort_order asc') }, :class_name => 'SpudBanner', :dependent => :destroy, :inverse_of => :owner
+  has_many :banners, -> { order('sort_order asc') }, class_name: 'SpudBanner', dependent: :destroy, inverse_of: :owner
 
-  validates_presence_of :name
-  validates_uniqueness_of :name
-  validates_numericality_of :width, :height
+  validates :name, presence: true
+  validates :name, uniqueness: true
+  validates :width, :height, numericality: true
 
   acts_as_tb_liquid_tag :spud_banner_set, :name
 
   after_update :check_for_dimension_change
 
-  def self.find_by_identifier(identifier)
-    if identifier.class == String
-      banner_set = SpudBannerSet.find_by_name(identifier)
-    elsif identifier.class == Symbol
-      banner_set = SpudBannerSet.find_by_name(identifier.to_s.titleize)
-    else
-      banner_set = SpudBannerSet.find(identifier)
-    end
+  def self.find_with_identifier(identifier)
+    banner_set = if identifier.class == String
+                   SpudBannerSet.find_by(name: identifier.strip)
+                 elsif identifier.class == Symbol
+                   SpudBannerSet.find_by(name: identifier.to_s.titleize)
+                 else
+                   SpudBannerSet.find(identifier)
+                 end
     return banner_set
   end
 
   def reprocess_banners!
-    self.banners.each do |banner|
+    banners.each do |banner|
       banner.banner.reprocess!
     end
   end
@@ -30,12 +30,10 @@ class SpudBannerSet < ActiveRecord::Base
     return name
   end
 
-private
+  private
 
   def check_for_dimension_change
-    if self.height_changed? || self.width_changed? || self.cropped_changed?
-      self.reprocess_banners!
-    end
+    reprocess_banners! if height_changed? || width_changed? || cropped_changed?
   end
 
 end

data/app/views/admin/banners/_form.html.erb

@@ -1,4 +1,4 @@
-<%= form_for @banner, :url => path, :builder => TbCore::FormBuilder, :html => {:class => 'admin-banner-form', :target => 'admin-banner-upload-target'} do |f| %>
+<%= form_for @banner, :url => path, :builder => TbCore::FormBuilder, :html => { :class => 'admin-banner-form' } do |f| %>
 
   <%= tb_form_errors(f.object) %>
 
@@ -63,5 +63,3 @@
   </div>
 
 <% end %>
-
-<iframe id="admin-banner-upload-target" name="admin-banner-upload-target" style="display:none;"></iframe>

data/lib/spud_banners/configuration.rb

@@ -5,7 +5,7 @@ module Spud
     self.paperclip_storage = :filesystem
     self.s3_credentials = "#{Rails.root}/config/s3.yml"
     self.s3_protocol = 'https'
-    self.storage_path = ":rails_root/public/system/spud_banners/:id/:style/:basename.:extension"
-    self.storage_url = "/system/spud_banners/:id/:style/:basename.:extension"
+    self.storage_path = ':rails_root/public/system/spud_banners/:id/:style/:basename.:extension'
+    self.storage_url = '/system/spud_banners/:id/:style/:basename.:extension'
   end
 end

data/lib/spud_banners/engine.rb

@@ -6,14 +6,14 @@ module Spud
   module Banners
     class Engine < Rails::Engine
       engine_name :tb_banners
-      
+
       initializer :admin do
         Spud::Core.config.admin_applications += [{
-          :name => 'Banner Sets',
-          :thumbnail => 'admin/banners/banners.png',
-          :retina => true,
-          :url => '/admin/banner_sets',
-          :order => 120  
+          name: 'Banner Sets',
+          thumbnail: 'admin/banners/banners.png',
+          retina: true,
+          url: '/admin/banner_sets',
+          order: 120
         }]
       end
 

data/lib/spud_banners/liquid_tags.rb

@@ -10,8 +10,11 @@ module Spud
       include ActionView::Context
       include SpudBannersHelper
 
-      def initialize(tag_name, set_identifer, tokens)
-        @banner_set = SpudBannerSet.find_by_identifier(set_identifer)
+      def initialize(_tag_name, set_identifer, _tokens)
+        ActiveSupport::Deprecation.warn(
+          'Support for the spud_banners liquid tag is going away. If you are using this, please refactor your code soon.'
+        )
+        @banner_set = SpudBannerSet.find_with_identifier(set_identifer)
       end
 
       def tag_name
@@ -22,7 +25,7 @@ module Spud
         return @banner_set.name
       end
 
-      def render(context)
+      def render(_context)
         return spud_banners_set_tag(@banner_set)
       end
 

data/lib/spud_banners/version.rb

@@ -1,5 +1,5 @@
 module Spud
   module Banners
-    VERSION = "1.2.1"
+    VERSION = '1.3.beta1'.freeze
   end
 end

data/lib/tb_banners.rb

@@ -2,6 +2,6 @@ module Spud
   module Banners
     require 'spud_banners/configuration'
     require 'spud_banners/liquid_tags'
-    require "spud_banners/engine" if defined?(Rails)
+    require 'spud_banners/engine' if defined?(Rails)
   end
 end

data/spec/authlogic_helper.rb

@@ -1,2 +1,2 @@
 require 'authlogic/test_case'
-include Authlogic::TestCase
+include Authlogic::TestCase