taxjar-ruby 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 47a7bd26490bf919e6339a26097c87d7d9dd0b09ea6214b87070243da422d03c
-  data.tar.gz: ba4de289c2768c0e52effab858cd0569c3a43f524c34698bafc3cbea8e0eab4f
+  metadata.gz: 0bd370b061b002cddb9e65f2a879beed9e11c82678eccaa4b6e3b4b6ceb4c053
+  data.tar.gz: b45f569333906938d5f656442549124f06b12c9dc51c47db9af3a0a29e312730
 SHA512:
-  metadata.gz: 7dbea4df68a8bd664c86507f8b266aa1a5901aad30f9b558d8d0e4fa999d36c887a0b6b5acebf511f0a67d8a812d98c60f0693fa4a54057e201765ea67db7ab3
-  data.tar.gz: d152b6c9d34c19fbae78386346d63aa6bab0ac8d95197a7fa700bb7f2c4ea5da5fede05c6f7458f138febeb7a4065c542cf4c86c7bb320474856352858c67d56
+  metadata.gz: 6960458fd1bb6c89eaeb5f817b15c70a5e68b5b23f6232c05be63273fe02be92102797b989eaaacd76ee77ffa97cef67cdf413293d2a351300633a7d1d51f51a
+  data.tar.gz: fe9903162754fa2c551d1dd4a88fc1bdd270bc92ac5fedeb1489ecc38a817cee5d93bfbf386442f3b3006df082ff8b31e692a24e6a1a95c716cee8d2b5917077

data/.travis.yml

@@ -6,5 +6,6 @@ rvm:
  - "2.5"
  - "2.6"
  - "2.7"
+ - "3.0"
 
 script: bundle exec rspec

data/CHANGELOG.md

@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [3.0.1] - 2021-03-16
+- Throw a `Taxjar::Error` exception for any non-successful HTTP response
+
 ## [3.0.0] - 2020-04-03
 - Add information to custom user agent for debugging and informational purposes
 - Update required Ruby version from 2.0 to 2.3 or higher
@@ -43,7 +46,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Update minimum required Ruby version to 2.0
 - Update HTTP (The Gem) to 2.2
 
-[Unreleased]: https://github.com/taxjar/taxjar-ruby/compare/v3.0.0...HEAD
+[Unreleased]: https://github.com/taxjar/taxjar-ruby/compare/v3.0.1...HEAD
+[3.0.1]: https://github.com/taxjar/taxjar-ruby/compare/v3.0.0...v3.0.1
 [3.0.0]: https://github.com/taxjar/taxjar-ruby/compare/v2.6.1...v3.0.0
 [2.6.1]: https://github.com/taxjar/taxjar-ruby/compare/v2.6.0...v2.6.1
 [2.6.0]: https://github.com/taxjar/taxjar-ruby/compare/v2.5.0...v2.6.0

data/README.md

@@ -4,7 +4,7 @@
 
 A Ruby interface to the TaxJar [Sales Tax API](https://developers.taxjar.com/api/reference/?ruby). TaxJar makes sales tax filing easier for online sellers and merchants. See local jurisdictional tax reports, get payment reminders, and more. You can use our API to access TaxJar API endpoints, which can get information on sales tax rates, categories or upload transactions.
 
-* This wrapper supports 100% of [SmartCalcs v2](https://developers.taxjar.com/api/#introduction)
+* This wrapper supports 100% of the [TaxJar API](https://developers.taxjar.com/api/#introduction)
 * Data returned from API calls are mapped to Ruby objects
 
 <hr>
@@ -1268,7 +1268,7 @@ validation = client.validate({
 
 > Retrieve minimum and average sales tax rates by region as a backup.
 >
-> This method is useful for periodically pulling down rates to use if the SmartCalcs API is unavailable. However, it does not support nexus determination, sourcing based on a ship from and ship to address, shipping taxability, product exemptions, customer exemptions, or sales tax holidays. We recommend using [`tax_for_order` to accurately calculate sales tax for an order](#calculate-sales-tax-for-an-order-api-docs).
+> This method is useful for periodically pulling down rates to use if the TaxJar API is unavailable. However, it does not support nexus determination, sourcing based on a ship from and ship to address, shipping taxability, product exemptions, customer exemptions, or sales tax holidays. We recommend using [`tax_for_order` to accurately calculate sales tax for an order](#calculate-sales-tax-for-an-order-api-docs).
 
 #### Definition
 

data/lib/taxjar/api/request.rb

@@ -34,7 +34,7 @@ module Taxjar
           rescue JSON::ParserError
             nil
           end
-        fail_or_return_response_body(response.code, response_body)
+        fail_or_return_response_body(response, response_body)
       end
 
       private
@@ -72,17 +72,15 @@ module Taxjar
           object
         end
 
-        def fail_or_return_response_body(code, body)
-          e = extract_error(code, body)
-          fail(e) if e
-          body[object_key.to_sym]
-        end
-
-        def extract_error(code, body)
-          return Taxjar::Error.for_json_parse_error(code) if body.nil?
-          klass = Taxjar::Error::ERRORS[code]
-          if !klass.nil?
-            klass.from_response(body)
+        def fail_or_return_response_body(response, body)
+          if body.nil?
+            fail(Taxjar::Error.for_json_parse_error(response.code))
+          elsif response.status.success?
+            body[object_key.to_sym]
+          elsif !(klass = Taxjar::Error::ERRORS[response.code]).nil?
+            fail(klass.from_response(body))
+          else
+            fail(Taxjar::Error.from_response_code(response.code))
           end
         end
     end

data/lib/taxjar/error.rb

@@ -61,6 +61,11 @@ module Taxjar
         new(message, code)
       end
 
+      def from_response_code(code)
+        message = HTTP::Response::Status::REASONS[code] || "Unknown Error"
+        new(message, code)
+      end
+
       def for_json_parse_error(code)
         ServerError.new("Couldn't parse response as JSON.", code)
       end

data/lib/taxjar/version.rb

@@ -10,7 +10,7 @@ module Taxjar
     end
 
     def patch
-      0
+      1
     end
 
     def pre

data/spec/taxjar/api/request_spec.rb

@@ -191,5 +191,41 @@ describe Taxjar::API::Request do
         end
       end
     end
+
+    context "when HTTP status is 502" do
+      it "raises Taxjar::Error" do
+        stub_request(:get, "https://api.taxjar.com/api_path").
+          with(:headers => {'Authorization'=>'Bearer AK', 'Connection'=>'close',
+                            'Host'=>'api.taxjar.com'}).
+          to_return(:status => 502,
+                    :body => '{}',
+                    :headers => {content_type: 'application/json; charset=UTF-8'})
+
+        expect{subject.perform}.to raise_error(
+          an_instance_of(Taxjar::Error).and having_attributes({
+            "message" => "Bad Gateway",
+            "code" => 502
+          })
+        )
+      end
+    end
+
+    context "when HTTP status is 5xx" do
+      it "raises Taxjar::Error" do
+        stub_request(:get, "https://api.taxjar.com/api_path").
+          with(:headers => {'Authorization'=>'Bearer AK', 'Connection'=>'close',
+                            'Host'=>'api.taxjar.com'}).
+          to_return(:status => 509,
+                    :body => '{}',
+                    :headers => {content_type: 'application/json; charset=UTF-8'})
+
+        expect{subject.perform}.to raise_error(
+          an_instance_of(Taxjar::Error).and having_attributes({
+            "message" => "Unknown Error",
+            "code" => 509
+          })
+        )
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: taxjar-ruby
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - TaxJar
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-06 00:00:00.000000000 Z
+date: 2021-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -202,7 +202,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubyforge_project: 
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: Ruby wrapper for Taxjar API