tasks_scheduler 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89877b670ebd68e63175333d60bce49d90de7c4e04737189f5c73a6a277f0595
-  data.tar.gz: 18d4d5224dcabd9dd2238d0cc8a5dea03689d58323de808b5bb4622664a2cc01
+  metadata.gz: 6573b654529a255fe7a822f33662837da3915a7b9a98cdc6e071c19d3143c955
+  data.tar.gz: 3409022b969859d61f236ed5ddbf1678105ef35bd2cd971d5a172c56c43822b5
 SHA512:
-  metadata.gz: 6bb72a00e15bd394f6baa9cbae395e8737295ff72f1177315fd15937b2b60189901b7db0cfe3c2b7b9daf08599023c694558231539d1f6e2b92ea4f6fd0bd2a4
-  data.tar.gz: 766a81812effee371317d38ee615e0e5b57400abac7d6a376a6a5971bc98fc301bdca3e03dbfa3c8f1d3f1c7903ddbdf479fc7b89451292880c386c813311b69
+  metadata.gz: e93580d187fd4e4ff62faf5ee5b5b0b5ea70b13b11f86f38779327f2bb06f329e46089b3add379cc734a06fd666c7a9edc40156939abc8ffadeb655bd43c6f22
+  data.tar.gz: cf55f3658eb3df0c1527a219b67a03ce401af2ce22dde55e49b90184b4c4019c21bd2ab0fc3e3a7741cf6a70e4f2ca8c8a8ec6578b3d304bf6efb62ee5c4c079

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 begin
   require 'bundler/setup'
 rescue LoadError
@@ -14,7 +16,7 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-APP_RAKEFILE = File.expand_path('../test/dummy/Rakefile', __FILE__)
+APP_RAKEFILE = File.expand_path('test/dummy/Rakefile', __dir__)
 load 'rails/tasks/engine.rake'
 
 load 'rails/tasks/statistics.rake'

data/app/controllers/scheduled_tasks_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ScheduledTasksController < ApplicationController
   class << self
     private
@@ -8,7 +10,7 @@ class ScheduledTasksController < ApplicationController
   end
 
   active_scaffold :scheduled_task do |conf|
-    [:create, :update, :list].each do |action|
+    %i[create update list].each do |action|
       conf.send(action).columns.exclude(:next_run, :last_fail_status, :last_run_start,
                                         :last_run_successful_start, :last_run_unsuccessful_start,
                                         :last_run_successful_end, :last_run_unsuccessful_end,
@@ -26,8 +28,7 @@ class ScheduledTasksController < ApplicationController
     @log_file = record.log_file(params[:identifier])
   end
 
-  def status
-  end
+  def status; end
 
   def status_content
     @scheduled_tasks = ::ScheduledTask.order(task: :asc, scheduling: :asc)
@@ -36,7 +37,7 @@ class ScheduledTasksController < ApplicationController
 
   def run_now
     process_action_link_action do |record|
-      record.update_attributes!(next_run: Time.zone.now)
+      record.update!(next_run: Time.zone.now)
       record.reload
       flash[:info] = "Next run adjusted to #{record.next_run}"
     end

data/app/controllers/tasks_scheduler_daemon_controller.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
+
 require 'tasks_scheduler/checker'
 
 class TasksSchedulerDaemonController < ApplicationController
   require_relative 'tasks_scheduler_daemon_controller/_download_log'
 
-  def index
-  end
+  def index; end
 
   def execute
     @result = ::TasksScheduler::Daemon.execute(params[:tasks_scheduler_execute_action])
@@ -13,6 +14,6 @@ class TasksSchedulerDaemonController < ApplicationController
 
   def status
     render json: { daemon_running: ::TasksScheduler::Daemon.running?,
-                   tasks_all_ok: !::ScheduledTask.all.any?(&:failed?) }
+                   tasks_all_ok: ::ScheduledTask.all.none?(&:failed?) }
   end
 end

data/app/controllers/tasks_scheduler_daemon_controller/_download_log.rb

@@ -1,8 +1,12 @@
+# frozen_string_literal: true
+
 class TasksSchedulerDaemonController < ApplicationController
   def download_log
     return unless download_log_validate_log_key
+
     log = ::TasksScheduler::Checker.instance.send("#{download_log_key}_log")
     return unless download_log_validate_log_exist(log)
+
     send_log_file(log)
   end
 
@@ -14,6 +18,7 @@ class TasksSchedulerDaemonController < ApplicationController
 
   def download_log_validate_log_key
     return true if ::TasksScheduler::Checker::LOGS_KEYS.include?(download_log_key)
+
     redirect_to(tasks_scheduler_daemon_path,
                 notice: "Invalid log key: \"#{download_log_key}\"")
     false
@@ -21,6 +26,7 @@ class TasksSchedulerDaemonController < ApplicationController
 
   def download_log_validate_log_exist(log)
     return true if log.exist?
+
     redirect_to(tasks_scheduler_daemon_path, notice: "Log \"#{log.key}\" does not exist.")
     false
   end

data/app/helpers/scheduled_tasks_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ScheduledTasksHelper
   def scheduled_tasks_status_time(time)
     if time.present?

data/app/models/scheduled_task.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rake'
 
 class ScheduledTask < ActiveRecord::Base
@@ -6,7 +8,7 @@ class ScheduledTask < ActiveRecord::Base
   include ::ScheduledTask::Runner
   include ::ScheduledTask::Status
 
-  DEFAULT_TIMEOUT_ENVVAR_NAME = 'TASKS_SCHEDULER_TIMEOUT'.freeze
+  DEFAULT_TIMEOUT_ENVVAR_NAME = 'TASKS_SCHEDULER_TIMEOUT'
   DEFAULT_TIMEOUT = 12.hours
 
   class << self
@@ -20,9 +22,9 @@ class ScheduledTask < ActiveRecord::Base
     def timeout
       @timeout ||= begin
         r = Integer(ENV[DEFAULT_TIMEOUT_ENVVAR_NAME])
-        r > 0 ? r.seconds : DEFAULT_TIMEOUT
-      rescue ArgumentError, TypeError
-        DEFAULT_TIMEOUT
+        r.positive? ? r.seconds : DEFAULT_TIMEOUT
+                   rescue ArgumentError, TypeError
+                     DEFAULT_TIMEOUT
       end
     end
   end
@@ -34,7 +36,7 @@ class ScheduledTask < ActiveRecord::Base
   STATUS_TIMEOUT = 'timeout'
   STATUS_DISABLED = 'disabled'
 
-  LAST_FAIL_STATUSES = [STATUS_FAILED, STATUS_ABORTED, STATUS_TIMEOUT]
+  LAST_FAIL_STATUSES = [STATUS_FAILED, STATUS_ABORTED, STATUS_TIMEOUT].freeze
 
   validates :scheduling, presence: true, 'tasks_scheduler/cron_scheduling': true
   validates :task, presence: true
@@ -69,13 +71,14 @@ class ScheduledTask < ActiveRecord::Base
 
   def process_running?
     return false if pid.nil?
+
     Process.kill(0, pid)
-    return true
+    true
   rescue Errno::EPERM
     raise "No permission to query #{pid}!"
   rescue Errno::ESRCH
-    return false
-  rescue
+    false
+  rescue StandardError
     raise "Unable to determine status for #{pid}"
   end
 
@@ -87,6 +90,7 @@ class ScheduledTask < ActiveRecord::Base
     return if task.blank?
     return unless task_changed?
     return if self.class.rake_tasks.include?(task)
+
     errors.add(:task, "Task \"#{task}\" not found")
   end
 end

data/app/models/scheduled_task/checker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rake'
 
 class ScheduledTask < ActiveRecord::Base
@@ -34,6 +36,7 @@ class ScheduledTask < ActiveRecord::Base
 
     def check_on_pid_not_present
       return unless enabled?
+
       if next_run.present?
         check_task_with_next_run
       else
@@ -55,7 +58,7 @@ class ScheduledTask < ActiveRecord::Base
 
     def check_task_without_next_run
       check_log('Next run blank')
-      update_attributes!(next_run: calculate_next_run)
+      update!(next_run: calculate_next_run)
       check_log("Next run scheduled: #{next_run.in_time_zone}")
     end
 
@@ -78,7 +81,7 @@ class ScheduledTask < ActiveRecord::Base
         spawn_pid = Process.spawn(*params)
       end
       Process.detach(spawn_pid)
-      update_attributes!(pid: spawn_pid, last_fail_status: nil)
+      update!(pid: spawn_pid, last_fail_status: nil)
     end
 
     def timeout?

data/app/models/scheduled_task/log.rb

@@ -1,9 +1,12 @@
+# frozen_string_literal: true
+
 class ScheduledTask < ActiveRecord::Base
   module Log
     def log_file(identifier)
       unless log_identifiers.include?(identifier)
-        fail "Log identifier unknown: \"#{identifier}\" (Valid: #{log_identifiers})"
+        raise "Log identifier unknown: \"#{identifier}\" (Valid: #{log_identifiers})"
       end
+
       Rails.root.join('log', 'tasks_scheduler', "#{id}_#{identifier}.log")
     end
 
@@ -24,11 +27,11 @@ class ScheduledTask < ActiveRecord::Base
 
     def log_on_end(exception)
       running_log = log_file(LOG_RUNNING)
-      if ::File.exist?(running_log)
-        target_log = exception ? log_file(LOG_UNSUCCESSFUL) : log_file(LOG_SUCCESSFUL)
-        File.unlink(target_log) if File.exist?(target_log)
-        File.rename(running_log, target_log)
-      end
+      return unless ::File.exist?(running_log)
+
+      target_log = exception ? log_file(LOG_UNSUCCESSFUL) : log_file(LOG_SUCCESSFUL)
+      File.unlink(target_log) if File.exist?(target_log)
+      File.rename(running_log, target_log)
     end
   end
 end

data/app/models/scheduled_task/runner.rb

@@ -1,9 +1,12 @@
+# frozen_string_literal: true
+
 class ScheduledTask < ActiveRecord::Base
   module Runner
     def run
       log_on_start
       run_banner
       return if process_running? && pid != Process.pid
+
       status_on_start
       exception = invoke_task
       on_end_running(exception, STATUS_FAILED)
@@ -33,7 +36,7 @@ class ScheduledTask < ActiveRecord::Base
 
     def run_banner
       run_log("Task: #{self}")
-      run_log("PID: #{pid ? pid : '-'} (Current: #{Process.pid})")
+      run_log("PID: #{pid || '-'} (Current: #{Process.pid})")
       run_log("Process running? #{process_running? ? 'Yes' : 'No'}")
       run_log("Rails.env: #{Rails.env}")
     end
@@ -44,15 +47,16 @@ class ScheduledTask < ActiveRecord::Base
         Rake::Task.clear
         Rails.application.load_tasks
         Rake::Task[task].invoke(*invoke_args)
-      rescue StandardError => ex
-        run_log(ex, :fatal)
-        exception = ex
+      rescue StandardError => e
+        run_log(e, :fatal)
+        exception = e
       end
       exception
     end
 
     def invoke_args
-      return [] unless args.present?
+      return [] if args.blank?
+
       args.split('|')
     end
   end

data/app/models/scheduled_task/status.rb

@@ -1,10 +1,13 @@
+# frozen_string_literal: true
+
 class ScheduledTask < ActiveRecord::Base
   module Status
     def status
       return STATUS_DISABLED unless enabled?
       return STATUS_RUNNING if running?
       return STATUS_WAITING if waiting?
-      last_fail_status.present? ? last_fail_status : STATUS_FAILED
+
+      last_fail_status.presence || STATUS_FAILED
     end
 
     def failed?
@@ -17,6 +20,7 @@ class ScheduledTask < ActiveRecord::Base
 
     def waiting?
       return true if ended?(last_run_successful_end, last_run_unsuccessful_end)
+
       status_attributes.all? { |a| send(a).blank? }
     end
 
@@ -27,11 +31,11 @@ class ScheduledTask < ActiveRecord::Base
     end
 
     def status_on_start
-      update_attributes!(last_run_start: Time.zone.now)
+      update!(last_run_start: Time.zone.now)
     end
 
     def status_on_end(exception, last_fail_status)
-      update_attributes!(
+      update!(
         next_run: calculate_next_run,
         (exception ? :last_run_unsuccessful_start : :last_run_successful_start) => last_run_start,
         (exception ? :last_run_unsuccessful_end : :last_run_successful_end) => Time.zone.now,
@@ -42,7 +46,7 @@ class ScheduledTask < ActiveRecord::Base
     end
 
     def status_attributes
-      %w(start successful_start successful_end unsuccessful_start unsuccessful_end).map do |a|
+      %w[start successful_start successful_end unsuccessful_start unsuccessful_end].map do |a|
         "last_run_#{a}"
       end
     end

data/config/initializers/assets.rb

@@ -1 +1,3 @@
-Rails.application.config.assets.precompile += %w( active_scaffold/indicator.gif )
+# frozen_string_literal: true
+
+Rails.application.config.assets.precompile += %w[active_scaffold/indicator.gif]

data/config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.routes.draw do
   resources(:scheduled_tasks) do
     as_routes

data/db/migrate/20161122123828_create_scheduled_tasks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateScheduledTasks < ActiveRecord::Migration
   def change
     create_table :scheduled_tasks do |t|

data/db/migrate/20161123130153_add_status_attributes_to_scheduled_tasks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AddStatusAttributesToScheduledTasks < ActiveRecord::Migration
   def change
     add_column :scheduled_tasks, :last_run_start, :datetime

data/db/migrate/20161124200712_add_pid_to_scheduled_tasks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AddPidToScheduledTasks < ActiveRecord::Migration
   def change
     add_column :scheduled_tasks, :pid, :integer

data/db/migrate/20161128163702_add_args_to_scheduled_tasks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AddArgsToScheduledTasks < ActiveRecord::Migration
   def change
     add_column :scheduled_tasks, :args, :string

data/db/migrate/20180223155025_add_last_fail_status_to_scheduled_tasks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AddLastFailStatusToScheduledTasks < ActiveRecord::Migration
   def change
     add_column :scheduled_tasks, :last_fail_status, :string

data/db/migrate/20180302170138_add_enabled_to_scheduled_tasks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AddEnabledToScheduledTasks < ActiveRecord::Migration
   def change
     add_column :scheduled_tasks, :enabled, :boolean, null: false, default: true

data/exe/tasks_scheduler

@@ -1,12 +1,14 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'rubygems'
 require 'daemons'
 require 'fileutils'
 
 def find_rails_root(dir = Dir.pwd)
-  fail 'Rails root not found' if dir == '' || dir == '/' || dir == '.'
+  raise 'Rails root not found' if ['', '/', '.'].include?(dir)
   return dir if File.exist?(File.expand_path('config/environment.rb', dir))
+
   rails_root(File.dirname(dir))
 end
 

data/exe/tasks_scheduler_run_task

@@ -1,11 +1,13 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'rubygems'
 require 'daemons'
 
 def find_rails_root(dir = Dir.pwd)
-  fail 'Rails root not found' if dir == '' || dir == '/' || dir == '.'
+  raise 'Rails root not found' if ['', '/', '.'].include?(dir)
   return dir if File.exist?(File.expand_path('config/environment.rb', dir))
+
   rails_root(File.dirname(dir))
 end
 

data/lib/tasks_scheduler.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'tasks_scheduler/engine'
 require 'active_scaffold'
 require 'js-routes'

data/lib/tasks_scheduler/checker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'tasks_scheduler/checker/log'
 
 module TasksScheduler
@@ -5,8 +7,8 @@ module TasksScheduler
     include Singleton
 
     CHECK_INTERVAL = 15
-    LOG_ON_FILE_ENV_KEY = 'TASKS_SCHEDULER_LOG_ON_FILE'.freeze
-    LOGS_KEYS = %w(rails stdout stderr).freeze
+    LOG_ON_FILE_ENV_KEY = 'TASKS_SCHEDULER_LOG_ON_FILE'
+    LOGS_KEYS = %w[rails stdout stderr].freeze
 
     def run
       check_log
@@ -40,6 +42,7 @@ CODE
 
     def check_log
       return unless log_on_file?
+
       ::Rails.logger = ::Logger.new(rails_log.path)
       $stdout.reopen(stdout_log.path, 'w')
       $stderr.reopen(stderr_log.path, 'w')

data/lib/tasks_scheduler/checker/log.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fileutils'
 
 module TasksScheduler

data/lib/tasks_scheduler/cron_parser_patch.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module TasksScheduler
   module CronParserPatch
     class TasksSchedulerTimeSource
       class << self
-        def local(year, month, day, hour, min, second)
+        def local(year, month, day, hour, min, second) # rubocop:disable Metrics/ParameterLists
           Time.utc(year, month, day, hour, min, second)
         end
 

data/lib/tasks_scheduler/cron_scheduling_validator.rb

@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 module TasksScheduler
   class CronSchedulingValidator < ActiveModel::EachValidator
     def validate_each(record, attribute, value)
       return if value_valid?(value)
+
       record.errors[attribute] << (options[:message] ||
           I18n.translate(:cron_scheduling_validator_error_message))
     end

data/lib/tasks_scheduler/daemon.rb

@@ -1,12 +1,15 @@
+# frozen_string_literal: true
+
 require 'open3'
 
 module TasksScheduler
   class Daemon
-    ACTIONS = %w(status start stop restart).freeze
+    ACTIONS = %w[status start stop restart].freeze
 
     class << self
       def execute(action)
         raise "Action not allowed: #{action} (Allowed: #{ACTIONS})" unless ACTIONS.include?(action)
+
         command = ['bundle', 'exec', 'tasks_scheduler', action]
         Dir.chdir(Rails.root) do
           Open3.popen3(env_args, *command) do |_stdin, stdout, stderr, wait_thr|

data/lib/tasks_scheduler/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TasksScheduler
   class Engine < ::Rails::Engine
     initializer :append_migrations do |app|

data/lib/tasks_scheduler/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TasksScheduler
-  VERSION = '0.3.0'.freeze
+  VERSION = '0.4.0'
 end

data/test/dummy/Rakefile

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require File.expand_path('../config/application', __FILE__)
+require File.expand_path('config/application', __dir__)
 
 Rails.application.load_tasks

data/test/dummy/app/controllers/application_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationController < ActionController::Base
   # Prevent CSRF attacks by raising an exception.
   # For APIs, you may want to use :null_session instead.

data/test/dummy/app/helpers/application_helper.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 module ApplicationHelper
 end

data/test/dummy/bin/bundle

@@ -1,3 +1,5 @@
 #!/usr/bin/env ruby
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+# frozen_string_literal: true
+
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
 load Gem.bin_path('bundler', 'bundle')

data/test/dummy/bin/rails

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
-APP_PATH = File.expand_path('../../config/application', __FILE__)
+# frozen_string_literal: true
+
+APP_PATH = File.expand_path('../config/application', __dir__)
 require_relative '../config/boot'
 require 'rails/commands'

data/test/dummy/bin/rake

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 require_relative '../config/boot'
 require 'rake'
 Rake.application.run

data/test/dummy/bin/setup

@@ -1,8 +1,10 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 require 'pathname'
 
 # path to your application root.
-APP_ROOT = Pathname.new File.expand_path('../../', __FILE__)
+APP_ROOT = Pathname.new File.expand_path('..', __dir__)
 
 Dir.chdir APP_ROOT do
   # This script is a starting point to setup your application.

data/test/dummy/config.ru

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This file is used by Rack-based servers to start the application.
 
 require ::File.expand_path('../config/environment', __FILE__)

data/test/dummy/config/application.rb

@@ -1,4 +1,6 @@
-require File.expand_path('../boot', __FILE__)
+# frozen_string_literal: true
+
+require File.expand_path('boot', __dir__)
 
 require 'rails/all'
 

data/test/dummy/config/boot.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 # Set up gems listed in the Gemfile.
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../../Gemfile', __FILE__)
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../Gemfile', __dir__)
 
 require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])
-$LOAD_PATH.unshift File.expand_path('../../../../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('../../../lib', __dir__)

data/test/dummy/config/environment.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 # Load the Rails application.
-require File.expand_path('../application', __FILE__)
+require File.expand_path('application', __dir__)
 
 # Initialize the Rails application.
 Rails.application.initialize!

data/test/dummy/config/environments/development.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

data/test/dummy/config/environments/production.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

data/test/dummy/config/environments/test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

data/test/dummy/config/initializers/assets.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Version of your assets, change this if you want to expire all your assets.

data/test/dummy/config/initializers/backtrace_silencers.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # You can add backtrace silencers for libraries that you're using but don't wish to see in your

data/test/dummy/config/initializers/cookies_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 Rails.application.config.action_dispatch.cookies_serializer = :json

data/test/dummy/config/initializers/filter_parameter_logging.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Configure sensitive parameters which will be filtered from the log file.

data/test/dummy/config/initializers/inflections.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # Add new inflection rules using the following format. Inflections

data/test/dummy/config/initializers/mime_types.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # Add new mime types for use in respond_to blocks:

data/test/dummy/config/initializers/session_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 Rails.application.config.session_store :cookie_store, key: '_dummy_session'

data/test/dummy/config/initializers/wrap_parameters.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # This file contains settings for ActionController::ParamsWrapper which

data/test/dummy/config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.routes.draw do
   # The priority is based upon order of creation: first created -> highest priority.
   # See how all your routes lay out with "rake routes".

data/test/models/scheduled_task_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class ScheduledTaskTest < ActiveSupport::TestCase
@@ -6,9 +8,9 @@ class ScheduledTaskTest < ActiveSupport::TestCase
     '*/5 * * * *' => Time.utc(2016, 12, 22, 12, 5, 0, 0),
     '* * 1 * *' => Time.utc(2017, 1, 1, 0, 0, 0, 0),
     '* * * * *' => Time.utc(2016, 12, 22, 12, 1, 0, 0)
-  }
+  }.freeze
 
-  SCHEDULING_INVALID_VALUES = ['  ', nil, '1', 'abc123', 456]
+  SCHEDULING_INVALID_VALUES = ['  ', nil, '1', 'abc123', 456].freeze
 
   setup do
     @scheduled_task = scheduled_tasks(:test_scheduling)
@@ -57,7 +59,7 @@ class ScheduledTaskTest < ActiveSupport::TestCase
   end
 
   test 'status 1' do
-    @scheduled_task.update_attributes!(
+    @scheduled_task.update!(
       scheduling: '*/5 * * * *',
       next_run: 'Wed, 28 Feb 2018 15:35:00 UTC +00:00',
       created_at: 'Tue, 06 Dec 2016 20:30:01 UTC +00:00',
@@ -88,7 +90,7 @@ class ScheduledTaskTest < ActiveSupport::TestCase
     assert_equal ['abc'], @scheduled_task.send('invoke_args')
 
     @scheduled_task.args = 'abc|def|ghi'
-    assert_equal %w(abc def ghi), @scheduled_task.send('invoke_args')
+    assert_equal %w[abc def ghi], @scheduled_task.send('invoke_args')
 
     @scheduled_task.args = 'abc||ghi'
     assert_equal ['abc', '', 'ghi'], @scheduled_task.send('invoke_args')

data/test/test_helper.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 # Configure Rails Environment
 ENV['RAILS_ENV'] = 'test'
 
-require File.expand_path('../../test/dummy/config/environment.rb', __FILE__)
+require File.expand_path('../test/dummy/config/environment.rb', __dir__)
 ActiveRecord::Migrator.migrations_paths = [
-  File.expand_path('../../test/dummy/db/migrate', __FILE__)
+  File.expand_path('../test/dummy/db/migrate', __dir__)
 ]
 require 'rails/test_help'
 
@@ -12,11 +14,11 @@ require 'rails/test_help'
 Minitest.backtrace_filter = Minitest::BacktraceFilter.new
 
 # Load support files
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].sort.each { |f| require f }
 
 # Load fixtures from the engine
 if ActiveSupport::TestCase.respond_to?(:fixture_path=)
-  ActiveSupport::TestCase.fixture_path = File.expand_path('../fixtures', __FILE__)
+  ActiveSupport::TestCase.fixture_path = File.expand_path('fixtures', __dir__)
   ActiveSupport::TestCase.fixtures :all
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tasks_scheduler
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Eduardo H. Bogoni
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-08-19 00:00:00.000000000 Z
+date: 2020-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_scaffold
@@ -212,41 +212,41 @@ signing_key:
 specification_version: 4
 summary: Scheduler for Rake tasks.
 test_files:
-- test/models/scheduled_task_test.rb
+- test/dummy/Rakefile
+- test/dummy/README.rdoc
+- test/dummy/config.ru
+- test/dummy/config/boot.rb
+- test/dummy/config/database.yml
+- test/dummy/config/secrets.yml
+- test/dummy/config/locales/en.yml
+- test/dummy/config/application.rb
+- test/dummy/config/environments/development.rb
+- test/dummy/config/environments/test.rb
+- test/dummy/config/environments/production.rb
+- test/dummy/config/environment.rb
 - test/dummy/config/routes.rb
 - test/dummy/config/initializers/assets.rb
 - test/dummy/config/initializers/cookies_serializer.rb
+- test/dummy/config/initializers/inflections.rb
 - test/dummy/config/initializers/session_store.rb
-- test/dummy/config/initializers/backtrace_silencers.rb
 - test/dummy/config/initializers/wrap_parameters.rb
 - test/dummy/config/initializers/filter_parameter_logging.rb
-- test/dummy/config/initializers/inflections.rb
+- test/dummy/config/initializers/backtrace_silencers.rb
 - test/dummy/config/initializers/mime_types.rb
-- test/dummy/config/database.yml
-- test/dummy/config/secrets.yml
-- test/dummy/config/locales/en.yml
-- test/dummy/config/environment.rb
-- test/dummy/config/boot.rb
-- test/dummy/config/application.rb
-- test/dummy/config/environments/production.rb
-- test/dummy/config/environments/test.rb
-- test/dummy/config/environments/development.rb
-- test/dummy/Rakefile
-- test/dummy/public/favicon.ico
-- test/dummy/public/404.html
-- test/dummy/public/500.html
-- test/dummy/public/422.html
-- test/dummy/config.ru
-- test/dummy/app/assets/stylesheets/application.css
-- test/dummy/app/assets/javascripts/application.js
-- test/dummy/app/helpers/application_helper.rb
+- test/dummy/db/schema.rb
 - test/dummy/app/views/layouts/application.html.erb
 - test/dummy/app/controllers/application_controller.rb
-- test/dummy/bin/setup
+- test/dummy/app/helpers/application_helper.rb
+- test/dummy/app/assets/stylesheets/application.css
+- test/dummy/app/assets/javascripts/application.js
+- test/dummy/public/422.html
+- test/dummy/public/404.html
+- test/dummy/public/favicon.ico
+- test/dummy/public/500.html
 - test/dummy/bin/bundle
+- test/dummy/bin/setup
 - test/dummy/bin/rails
 - test/dummy/bin/rake
-- test/dummy/db/schema.rb
-- test/dummy/README.rdoc
 - test/test_helper.rb
 - test/fixtures/scheduled_tasks.yml
+- test/models/scheduled_task_test.rb