taskinator 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a5f5f63478b9c1b1419e33baf6039f8e92153638ba2c08dc60cadd1a968d117
-  data.tar.gz: e222c79a85490ec2cbced43833b05b40e97dc6863782586505b19b178e44f664
+  metadata.gz: 5bcb4199fc1cea26510008421e3e1a1cdef9efc81eb5392f6a8913c70ae47ed1
+  data.tar.gz: '0266388a941c4e79d39b808d747d31d56dc957f8499ae1d14d553aceab7ac467'
 SHA512:
-  metadata.gz: ffd5ee0e0b9bfc78e9f44086d2b60986483c4668acf9b9a282ed3110d15d59477fec68b1042876d52899fe2531648ccd793efa9ba92415231ad4e637922b8049
-  data.tar.gz: 99fb91f000e510dd98eda1d843e644c563ca71288759e7d23493a605b7f7b342a116cff2d2bd530250fb552cd88d728a67171fafb49419461baa7200355d9e47
+  metadata.gz: 55f5bc10cf12986f073f2f3dd590ed17abac7e0ee25b8e4531391fd5d02e0297e6c7ed58961a626d98944c01395223fc75b4d2c49d28f31c85bbeca76bc21efe
+  data.tar.gz: 2a02585f01df20d868ac294c7daef8414ecefe3023d006869ea40c0aea9831361bdc5633e41787e86e20d4e39d749402baee385563adaf7e9405b7efad212a88

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+v0.4.2 - 16 Mar 2021
+---
+Bug fix for process/task keys not expired upon completion.
+
 v0.4.1 - 15 Mar 2021
 ---
 Optimisation to exclude sub-processes which don't have any tasks.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    taskinator (0.4.1)
+    taskinator (0.4.2)
       builder (>= 3.2.2)
       connection_pool (>= 2.2.0)
       globalid (~> 0.3)

data/lib/taskinator/persistence.rb

@@ -604,6 +604,9 @@ module Taskinator
       end
 
       def visit_tasks(tasks)
+        @conn.expire "#{@key}:tasks", expire_in
+        @conn.expire "#{@key}.count", expire_in
+        @conn.expire "#{@key}.pending", expire_in
         tasks.each do |task|
           RedisCleanupVisitor.new(@conn, task, expire_in).visit
         end

data/lib/taskinator/version.rb

@@ -1,3 +1,3 @@
 module Taskinator
-  VERSION = "0.4.1"
+  VERSION = "0.4.2"
 end

data/spec/support/test_flows.rb

@@ -132,4 +132,42 @@ module TestFlows
     end
   end
 
+  module NestedTask
+    extend Taskinator::Definition
+    include Support
+
+    define_process :task_count do
+      task :task_1
+
+      concurrent do
+        task :task_2
+        task :task_3
+
+        sequential do
+          task :task_4
+          task :task_5
+
+          concurrent do
+            task :task_6
+            task :task_7
+
+            sequential do
+              task :task_8
+              task :task_9
+
+            end
+
+            task :task_10
+          end
+
+          task :task_11
+        end
+
+        task :task_12
+      end
+
+      task :task_13
+    end
+  end
+
 end

data/spec/taskinator/persistence_spec.rb

@@ -370,24 +370,27 @@ describe Taskinator::Persistence, :redis => true do
         TestFlows::Job,
         TestFlows::SubProcess,
         TestFlows::Sequential,
-        TestFlows::Concurrent
+        TestFlows::Concurrent,
+        TestFlows::EmptySequentialProcessTest,
+        TestFlows::EmptyConcurrentProcessTest,
+        TestFlows::NestedTask,
       ].each do |definition|
 
         describe "#{definition.name} expire immediately" do
           it {
-            process = definition.create_process(1)
-
             Taskinator.redis do |conn|
-              expect(conn.hget(process.key, :uuid)).to eq(process.uuid)
+              # sanity check
+              expect(conn.keys).to be_empty
 
-              process.cleanup(0) # immediately
+              process = definition.create_process(1)
 
-              expect(conn.hget(process.key, :uuid)).to be_nil
+              # sanity check
+              expect(conn.hget(process.key, :uuid)).to eq(process.uuid)
 
-              recursively_enumerate_tasks(process.tasks) do |task|
-                expect(conn.hget(task.key, :uuid)).to be_nil
-              end
+              process.cleanup(0) # immediately
 
+              # ensure nothing left behind
+              expect(conn.keys).to be_empty
             end
           }
         end
@@ -396,9 +399,14 @@ describe Taskinator::Persistence, :redis => true do
 
       describe "expires in future" do
         it {
-          process = TestFlows::Task.create_process(1)
-
           Taskinator.redis do |conn|
+
+            # sanity check
+            expect(conn.keys).to be_empty
+
+            process = TestFlows::Task.create_process(1)
+
+            # sanity check
             expect(conn.hget(process.key, :uuid)).to eq(process.uuid)
 
             process.cleanup(2)
@@ -411,12 +419,8 @@ describe Taskinator::Persistence, :redis => true do
 
             sleep 3
 
-            # gone!
-            expect(conn.hget(process.key, :uuid)).to be_nil
-            recursively_enumerate_tasks(process.tasks) do |task|
-              expect(conn.hget(task.key, :uuid)).to be_nil
-            end
-
+            # ensure nothing left behind
+            expect(conn.keys).to be_empty
           end
         }
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: taskinator
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Chris Stefano
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-15 00:00:00.000000000 Z
+date: 2021-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis