tapioca 0.9.4 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 212af3a2ba5204b2aa479e52acddf879f32755faaee95691ce51e5c26b306481
-  data.tar.gz: e8f957c96874e08fed7cce1580ac110c41bef0853c6f52f2e46c90bb6435bfe8
+  metadata.gz: 9c7d5aa34969c7dc1bcd885ac0438e4a76d945ca23e7a5942d88d1aa679d4b75
+  data.tar.gz: 0d6fd32d3388e33804bbdbb6cddcd904f724cc3071864219b6fcb88377cb5816
 SHA512:
-  metadata.gz: fe339f96a20827fd80cb4134ccfcb258319ea43017f8b0f98170792e8732e464e468efeed7f7c0092fb095fff1e62e2f79f51113bbc6cff78e45b9cf288febc3
-  data.tar.gz: dafe9aeaa6118b98c1c4a5e40064a55aacf7bc883d9ffb406bca0edd8bfecacb52b7f1f0c898bb8b09fa2c3101c9a88e3ba812fbbd3f71c15837fb110b241e69
+  metadata.gz: fdda19a3d7e5033fb96a3703c6b2f35030fc72ec5299072c8d41db071df61bbe4fcd28c5e68637199c793b52713f0177ffc55086fce58fb7b443194a8de5d2a4
+  data.tar.gz: 7ad308fc2d306370e5a246c9ef548b0199d597027e6c4561f93b7aff4a31ac98f26d2cdc4e5cb836704c1351d634505a71f9a87cfef899899fea0f07ab8d0795

data/LICENSE.txt

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2019-present, Shopify Inc.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/README.md

@@ -30,6 +30,31 @@ Tapioca makes it easy to work with [Sorbet](https://sorbet.org) in your codebase
   * Find useless definitions in shim RBI files from Sorbet's embedded RBI for core and stdlib
   * Synchronization validation for your CI
 
+## Table of Contents <!-- no_toc -->
+<!-- START_TOC -->
+* [Installation](#installation)
+* [Getting started](#getting-started)
+* [Usage](#usage)
+  * [Generating RBI files for gems](#generating-rbi-files-for-gems)
+    * [Manually requiring parts of a gem](#manually-requiring-parts-of-a-gem)
+    * [Excluding a gem from RBI generation](#excluding-a-gem-from-rbi-generation)
+    * [Changing the strictness level of the RBI for a gem](#changing-the-strictness-level-of-the-rbi-for-a-gem)
+    * [Keeping RBI files for gems up-to-date](#keeping-rbi-files-for-gems-up-to-date)
+  * [Pulling RBI annotations from remote sources](#pulling-rbi-annotations-from-remote-sources)
+    * [Basic authentication](#basic-authentication)
+    * [Using a .netrc file](#using-a-netrc-file)
+    * [Changing the typed strictness of annotations files](#changing-the-typed-strictness-of-annotations-files)
+  * [Generating RBI files for Rails and other DSLs](#generating-rbi-files-for-rails-and-other-dsls)
+    * [Keeping RBI files for DSLs up-to-date](#keeping-rbi-files-for-dsls-up-to-date)
+    * [Writing custom DSL compilers](#writing-custom-dsl-compilers)
+  * [RBI files for missing constants and methods](#rbi-files-for-missing-constants-and-methods)
+    * [Generating the RBI file for missing constants](#generating-the-rbi-file-for-missing-constants)
+    * [Manually writing RBI definitions (shims)](#manually-writing-rbi-definitions-shims)
+  * [Configuration](#configuration)
+* [Contributing](#contributing)
+* [License](#license)
+<!-- END_TOC -->
+
 ## Installation
 
 Add this line to your application's `Gemfile`:
@@ -156,8 +181,7 @@ Options:
                                                               # Default: true
           [--exported-gem-rbis], [--no-exported-gem-rbis]     # Include RBIs found in the `rbi/` directory of the gem
                                                               # Default: true
-  -w, [--workers=N]                                           # EXPERIMENTAL: Number of parallel workers to use when generating RBIs
-                                                              # Default: 1
+  -w, [--workers=N]                                           # Number of parallel workers to use when generating RBIs (default: auto)
           [--auto-strictness], [--no-auto-strictness]         # Autocorrect strictness in gem RBIs in case of conflict with the DSL RBIs
                                                               # Default: true
   --dsl-dir, [--dsl-dir=directory]                            # The DSL directory used to correct gems strictnesses
@@ -434,23 +458,23 @@ Usage:
   tapioca dsl [constant...]
 
 Options:
-  --out, -o, [--outdir=directory]              # The output directory for generated DSL RBI files
-                                               # Default: sorbet/rbi/dsl
-          [--file-header], [--no-file-header]  # Add a "This file is generated" header on top of each generated RBI file
-                                               # Default: true
-          [--only=compiler [compiler ...]]     # Only run supplied DSL compiler(s)
-          [--exclude=compiler [compiler ...]]  # Exclude supplied DSL compiler(s)
-          [--verify], [--no-verify]            # Verifies RBIs are up-to-date
-  -q, [--quiet], [--no-quiet]                  # Suppresses file creation output
-  -w, [--workers=N]                            # EXPERIMENTAL: Number of parallel workers to use when generating RBIs
-                                               # Default: 1
-          [--rbi-max-line-length=N]            # Set the max line length of generated RBIs. Signatures longer than the max line length will be wrapped
-                                               # Default: 120
-  -e, [--environment=ENVIRONMENT]              # The Rack/Rails environment to use when generating RBIs
-                                               # Default: development
-  -c, [--config=<config file path>]            # Path to the Tapioca configuration file
-                                               # Default: sorbet/tapioca/config.yml
-  -V, [--verbose], [--no-verbose]              # Verbose output for debugging purposes
+  --out, -o, [--outdir=directory]                # The output directory for generated DSL RBI files
+                                                 # Default: sorbet/rbi/dsl
+          [--file-header], [--no-file-header]    # Add a "This file is generated" header on top of each generated RBI file
+                                                 # Default: true
+          [--only=compiler [compiler ...]]       # Only run supplied DSL compiler(s)
+          [--exclude=compiler [compiler ...]]    # Exclude supplied DSL compiler(s)
+          [--verify], [--no-verify]              # Verifies RBIs are up-to-date
+  -q, [--quiet], [--no-quiet]                    # Suppresses file creation output
+  -w, [--workers=N]                              # Number of parallel workers to use when generating RBIs (default: auto)
+          [--rbi-max-line-length=N]              # Set the max line length of generated RBIs. Signatures longer than the max line length will be wrapped
+                                                 # Default: 120
+  -e, [--environment=ENVIRONMENT]                # The Rack/Rails environment to use when generating RBIs
+                                                 # Default: development
+  -l, [--list-compilers], [--no-list-compilers]  # List all loaded compilers
+  -c, [--config=<config file path>]              # Path to the Tapioca configuration file
+                                                 # Default: sorbet/tapioca/config.yml
+  -V, [--verbose], [--no-verbose]                # Verbose output for debugging purposes
 
 generate RBIs for dynamic methods
 ```
@@ -568,7 +592,7 @@ Errors: 5
 
 To solve this you will have to create your own DSL compiler able that understands the `Encryptable` DSL and can generate the RBI definitions representing the actual shape of `CreditCard` at runtime.
 
-To do so, create the new DSL compiler inside the `sorbet/tapioca/compilers` directory of your application with the following contents:
+To do so, you need to create a new DSL compiler similar to the following:
 
 ```rb
 module Tapioca
@@ -603,6 +627,8 @@ module Tapioca
 end
 ```
 
+In order for this DSL compiler to be discovered by Tapioca, it either needs to be placed inside the `sorbet/tapioca/compilers` directory of your application or be inside a `tapioca/dsl/compilers` folder on the load path. For example, if `Encryptable` was being exposed by a gem, all the gem needs to do is to place the DSL compiler inside the `lib/tapioca/dsl/compilers` folder and it will be automatically discovered and loaded by Tapioca.
+
 There are two main parts to the DSL compiler API: `gather_constants` and `decorate`:
 
 * The `gather_constants` class method collects all classes (or modules) that should be processed by this specific DSL compiler.
@@ -742,8 +768,7 @@ Options:
                                                    # Default: sorbet/rbi/todo.rbi
       [--payload], [--no-payload]                  # Check shims against Sorbet's payload
                                                    # Default: true
-  -w, [--workers=N]                                # EXPERIMENTAL: Number of parallel workers
-                                                   # Default: 1
+  -w, [--workers=N]                                # Number of parallel workers (default: auto)
   -c, [--config=<config file path>]                # Path to the Tapioca configuration file
                                                    # Default: sorbet/tapioca/config.yml
   -V, [--verbose], [--no-verbose]                  # Verbose output for debugging purposes
@@ -795,6 +820,7 @@ dsl:
   workers: 1
   rbi_max_line_length: 120
   environment: development
+  list_compilers: false
 gem:
   outdir: sorbet/rbi/gems
   file_header: true

data/lib/tapioca/cli.rb

@@ -105,8 +105,7 @@ module Tapioca
     option :workers,
       aliases: ["-w"],
       type: :numeric,
-      desc: "EXPERIMENTAL: Number of parallel workers to use when generating RBIs",
-      default: 1
+      desc: "Number of parallel workers to use when generating RBIs (default: auto)"
     option :rbi_max_line_length,
       type: :numeric,
       desc: "Set the max line length of generated RBIs. Signatures longer than the max line length will be wrapped",
@@ -116,6 +115,11 @@ module Tapioca
       type: :string,
       desc: "The Rack/Rails environment to use when generating RBIs",
       default: DEFAULT_ENVIRONMENT
+    option :list_compilers,
+      aliases: ["-l"],
+      type: :boolean,
+      desc: "List all loaded compilers",
+      default: false
     def dsl(*constants)
       set_environment(options)
 
@@ -125,7 +129,6 @@ module Tapioca
         only: options[:only],
         exclude: options[:exclude],
         file_header: options[:file_header],
-        compiler_path: Tapioca::Dsl::Compilers::DIRECTORY,
         tapioca_path: TAPIOCA_DIR,
         should_verify: options[:verify],
         quiet: options[:quiet],
@@ -134,15 +137,12 @@ module Tapioca
         rbi_formatter: rbi_formatter(options)
       )
 
-      if options[:workers] != 1
-        say(
-          "Using more than one worker is experimental and might produce results that are not deterministic",
-          :red
-        )
-      end
-
       Tapioca.silence_warnings do
-        command.execute
+        if options[:list_compilers]
+          command.list_compilers
+        else
+          command.execute
+        end
       end
     end
 
@@ -201,8 +201,7 @@ module Tapioca
     option :workers,
       aliases: ["-w"],
       type: :numeric,
-      desc: "EXPERIMENTAL: Number of parallel workers to use when generating RBIs",
-      default: 1
+      desc: "Number of parallel workers to use when generating RBIs (default: auto)"
     option :auto_strictness,
       type: :boolean,
       desc: "Autocorrect strictness in gem RBIs in case of conflict with the DSL RBIs",
@@ -252,13 +251,6 @@ module Tapioca
           raise MalformattedArgumentError, "Option '--verify' must be provided without any other arguments" if verify
         end
 
-        if options[:workers] != 1
-          say(
-            "Using more than one worker is experimental and might produce results that are not deterministic",
-            :red
-          )
-        end
-
         if gems.empty? && !all
           command.sync(should_verify: verify, exclude: options[:exclude])
         else
@@ -275,7 +267,7 @@ module Tapioca
     option :annotations_rbi_dir, type: :string, desc: "Path to annotations RBIs", default: DEFAULT_ANNOTATIONS_DIR
     option :todo_rbi_file, type: :string, desc: "Path to the generated todo RBI file", default: DEFAULT_TODO_FILE
     option :payload, type: :boolean, desc: "Check shims against Sorbet's payload", default: true
-    option :workers, aliases: ["-w"], type: :numeric, desc: "EXPERIMENTAL: Number of parallel workers", default: 1
+    option :workers, aliases: ["-w"], type: :numeric, desc: "Number of parallel workers (default: auto)"
     def check_shims
       Tapioca.disable_traces
 
@@ -325,8 +317,10 @@ module Tapioca
     end
 
     no_commands do
-      def self.exit_on_failure?
-        true
+      class << self
+        def exit_on_failure?
+          true
+        end
       end
     end
 

data/lib/tapioca/commands/annotations.rb

@@ -247,13 +247,13 @@ module Tapioca
       sig { returns(T::Hash[String, T.nilable(String)]) }
       def repo_tokens
         @netrc_info = Netrc.read(@netrc_file) if @netrc_file
-        @central_repo_root_uris.map do |uri|
+        @central_repo_root_uris.filter_map do |uri|
           if @auth
             [uri, @auth]
           else
             [uri, token_for(uri)]
           end
-        end.compact.to_h
+        end.to_h
       end
 
       sig { params(repo_uri: String).returns(T.nilable(String)) }

data/lib/tapioca/commands/dsl.rb

@@ -14,7 +14,6 @@ module Tapioca
           only: T::Array[String],
           exclude: T::Array[String],
           file_header: T::Boolean,
-          compiler_path: String,
           tapioca_path: String,
           should_verify: T::Boolean,
           quiet: T::Boolean,
@@ -31,7 +30,6 @@ module Tapioca
         only:,
         exclude:,
         file_header:,
-        compiler_path:,
         tapioca_path:,
         should_verify: false,
         quiet: false,
@@ -46,7 +44,6 @@ module Tapioca
         @only = only
         @exclude = exclude
         @file_header = file_header
-        @compiler_path = compiler_path
         @tapioca_path = tapioca_path
         @should_verify = should_verify
         @quiet = quiet
@@ -57,16 +54,40 @@ module Tapioca
         @rbi_formatter = rbi_formatter
 
         super()
+      end
+
+      sig { void }
+      def list_compilers
+        Loaders::Dsl.load_application(
+          tapioca_path: @tapioca_path,
+          eager_load: @requested_constants.empty?
+        )
+
+        pipeline = create_pipeline
+
+        say("")
+        say("Loaded DSL compiler classes:")
+        say("")
+
+        table = pipeline.compilers.map do |compiler|
+          status = if pipeline.active_compilers.include?(compiler)
+            set_color("enabled", :green)
+          else
+            set_color("disabled", :red)
+          end
+
+          [compiler.name, status]
+        end
 
-        @loader = T.let(nil, T.nilable(Runtime::Loader))
+        print_table(table, { indent: 2 })
       end
 
       sig { override.void }
       def execute
-        load_dsl_extensions
-        load_application(eager_load: @requested_constants.empty?)
-        abort_if_pending_migrations!
-        load_dsl_compilers
+        Loaders::Dsl.load_application(
+          tapioca_path: @tapioca_path,
+          eager_load: @requested_constants.empty?
+        )
 
         if @should_verify
           say("Checking for out-of-date RBIs...")
@@ -78,15 +99,7 @@ module Tapioca
         outpath = @should_verify ? Pathname.new(Dir.mktmpdir) : @outpath
         rbi_files_to_purge = existing_rbi_filenames(@requested_constants)
 
-        pipeline = Tapioca::Dsl::Pipeline.new(
-          requested_constants: constantize(@requested_constants),
-          requested_compilers: constantize_compilers(@only),
-          excluded_compilers: constantize_compilers(@exclude),
-          error_handler: ->(error) {
-            say_error(error, :bold, :red)
-          },
-          number_of_workers: @number_of_workers
-        )
+        pipeline = create_pipeline
 
         processed_files = pipeline.run do |constant, contents|
           constant_name = T.must(Tapioca::Runtime::Reflection.name_of(constant))
@@ -120,7 +133,7 @@ module Tapioca
               gem_dir: @gem_dir,
               dsl_dir: @outpath.to_s,
               auto_strictness: @auto_strictness,
-              compilers: pipeline.compilers
+              compilers: pipeline.active_compilers
             )
           end
 
@@ -131,42 +144,17 @@ module Tapioca
 
       private
 
-      sig { params(eager_load: T::Boolean).void }
-      def load_application(eager_load:)
-        say("Loading Rails application... ")
-
-        loader.load_rails_application(
-          environment_load: true,
-          eager_load: eager_load
+      sig { returns(Tapioca::Dsl::Pipeline) }
+      def create_pipeline
+        Tapioca::Dsl::Pipeline.new(
+          requested_constants: constantize(@requested_constants),
+          requested_compilers: constantize_compilers(@only),
+          excluded_compilers: constantize_compilers(@exclude),
+          error_handler: ->(error) {
+            say_error(error, :bold, :red)
+          },
+          number_of_workers: @number_of_workers
         )
-
-        say("Done", :green)
-      end
-
-      sig { void }
-      def abort_if_pending_migrations!
-        return unless File.exist?("config/application.rb")
-        return unless defined?(::Rake)
-
-        Rails.application.load_tasks
-        if Rake::Task.task_defined?("db:abort_if_pending_migrations")
-          Rake::Task["db:abort_if_pending_migrations"].invoke
-        end
-      end
-
-      sig { void }
-      def load_dsl_compilers
-        say("Loading DSL compiler classes... ")
-
-        Dir.glob([
-          "#{@compiler_path}/*.rb",
-          "#{@tapioca_path}/generators/**/*.rb", # TODO: Here for backcompat, remove later
-          "#{@tapioca_path}/compilers/**/*.rb",
-        ]).each do |compiler|
-          require File.expand_path(compiler)
-        end
-
-        say("Done", :green)
       end
 
       sig { params(requested_constants: T::Array[String], path: Pathname).returns(T::Set[Pathname]) }
@@ -309,9 +297,9 @@ module Tapioca
 
         common_files = (existing_rbis & new_rbis)
 
-        changed_files = common_files.map do |filename|
+        changed_files = common_files.filter_map do |filename|
           filename unless FileUtils.identical?(@outpath / filename, tmp_dir / filename)
-        end.compact
+        end
 
         changed_files.each do |file|
           diff[file] = :changed
@@ -356,11 +344,6 @@ module Tapioca
         end.sort
       end
 
-      sig { returns(Runtime::Loader) }
-      def loader
-        @loader ||= Runtime::Loader.new
-      end
-
       sig { params(class_name: String).returns(String) }
       def underscore(class_name)
         return class_name unless /[A-Z-]|::/.match?(class_name)
@@ -382,11 +365,6 @@ module Tapioca
       def generate_command_for(constant)
         default_command(:dsl, constant)
       end
-
-      sig { void }
-      def load_dsl_extensions
-        Dir["#{__dir__}/../dsl/extensions/*.rb"].sort.each { |f| require(f) }
-      end
     end
   end
 end

data/lib/tapioca/commands/gem.rb

@@ -55,8 +55,7 @@ module Tapioca
 
         super()
 
-        @loader = T.let(nil, T.nilable(Runtime::Loader))
-        @bundle = T.let(nil, T.nilable(Gemfile))
+        @bundle = T.let(Gemfile.new(exclude), Gemfile)
         @existing_rbis = T.let(nil, T.nilable(T::Hash[String, String]))
         @expected_rbis = T.let(nil, T.nilable(T::Hash[String, String]))
         @include_doc = T.let(include_doc, T::Boolean)
@@ -66,7 +65,12 @@ module Tapioca
 
       sig { override.void }
       def execute
-        require_gem_file
+        Loaders::Gem.load_application(
+          bundle: @bundle,
+          prerequire: @prerequire,
+          postrequire: @postrequire,
+          default_command: default_command(:require),
+        )
 
         gem_queue = gems_to_generate(@gem_names).reject { |gem| @exclude.include?(gem.name) }
         anything_done = [
@@ -87,7 +91,7 @@ module Tapioca
             gem_dir: @outpath.to_s,
             dsl_dir: @dsl_dir,
             auto_strictness: @auto_strictness,
-            gems: bundle.dependencies
+            gems: @bundle.dependencies
           )
 
           say("All operations performed in working directory.", [:green, :bold])
@@ -117,7 +121,7 @@ module Tapioca
             gem_dir: @outpath.to_s,
             dsl_dir: @dsl_dir,
             auto_strictness: @auto_strictness,
-            gems: bundle.dependencies
+            gems: @bundle.dependencies
           )
 
           say("All operations performed in working directory.", [:green, :bold])
@@ -131,39 +135,9 @@ module Tapioca
 
       private
 
-      sig { returns(Runtime::Loader) }
-      def loader
-        @loader ||= Runtime::Loader.new
-      end
-
-      sig { returns(Gemfile) }
-      def bundle
-        @bundle ||= Gemfile.new(@exclude)
-      end
-
-      sig { void }
-      def require_gem_file
-        say("Requiring all gems to prepare for compiling... ")
-        begin
-          loader.load_bundle(bundle, @prerequire, @postrequire)
-        rescue LoadError => e
-          explain_failed_require(@postrequire, e)
-          exit(1)
-        end
-
-        Runtime::Trackers::Autoload.eager_load_all!
-
-        say(" Done", :green)
-        unless bundle.missing_specs.empty?
-          say("  completed with missing specs: ")
-          say(bundle.missing_specs.join(", "), :yellow)
-        end
-        puts
-      end
-
       sig { params(gem_names: T::Array[String]).returns(T::Array[Gemfile::GemSpec]) }
       def gems_to_generate(gem_names)
-        return bundle.dependencies if gem_names.empty?
+        return @bundle.dependencies if gem_names.empty?
 
         gem_names.map do |gem_name|
           gem = @bundle.gem(gem_name)
@@ -264,7 +238,12 @@ module Tapioca
           if gems.empty?
             say("Nothing to do.")
           else
-            require_gem_file
+            Loaders::Gem.load_application(
+              bundle: @bundle,
+              prerequire: @prerequire,
+              postrequire: @postrequire,
+              default_command: default_command(:require),
+            )
 
             Executor.new(gems, number_of_workers: @number_of_workers).run_in_parallel do |gem_name|
               filename = expected_rbi(gem_name)
@@ -274,7 +253,7 @@ module Tapioca
                 move(old_filename, filename) unless old_filename == filename
               end
 
-              gem = T.must(bundle.gem(gem_name))
+              gem = T.must(@bundle.gem(gem_name))
               compile_gem_rbi(gem)
               puts
             end
@@ -288,17 +267,6 @@ module Tapioca
         anything_done
       end
 
-      sig { params(file: String, error: LoadError).void }
-      def explain_failed_require(file, error)
-        say_error("\n\nLoadError: #{error}", :bold, :red)
-        say_error("\nTapioca could not load all the gems required by your application.", :yellow)
-        say_error("If you populated ", :yellow)
-        say_error("#{file} ", :bold, :blue)
-        say_error("with ", :yellow)
-        say_error("`#{default_command(:require)}`", :bold, :blue)
-        say_error("you should probably review it and remove the faulty line.", :yellow)
-      end
-
       sig { returns(T::Array[String]) }
       def removed_rbis
         (existing_rbis.keys - expected_rbis.keys).sort
@@ -360,7 +328,7 @@ module Tapioca
 
       sig { returns(T::Hash[String, String]) }
       def expected_rbis
-        @expected_rbis ||= bundle.dependencies
+        @expected_rbis ||= @bundle.dependencies
           .reject { |gem| @exclude.include?(gem.name) }
           .to_h { |gem| [gem.name, gem.version.to_s] }
       end

data/lib/tapioca/commands/todo.rb

@@ -72,13 +72,12 @@ module Tapioca
           .out
           .strip
           .each_line
-          .map do |line|
+          .filter_map do |line|
             next if line.include?("<")
 
             line.strip
               .gsub(/T\.class_of\(([:\w]+)\)/, '\1') # Turn T.class_of(Foo)::Bar into Foo::Bar
           end
-          .compact
           .sort
       end
     end