talon_one 0.0.9 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9686c435c7623cefc2b775f13ece7ddf2122701c
-  data.tar.gz: 3bd87ca7fbbb042ea917ccea433125e629c91cf4
+  metadata.gz: f18f0015fc47df3940ed680ecea31d131be528b8
+  data.tar.gz: 40b19f136345f6b6b9e46ffe3935025c95312a5b
 SHA512:
-  metadata.gz: ca9cd7e9bd12fb13e90ea07835c044c33eaedeeec6c8fc3654ea15b6745c97b19687b015d1ca969b8aea1fd06bc3b24fc64abad1158a9c9d84104ca37c8b19e5
-  data.tar.gz: 248ef713cecac93bee40a77dec6680c1e8ae141a3e732837c7318b6190d6701d7f1ac6940da47950b8cfe26880635df1c41c1ce64112d2daa4cfafe36a214615
+  metadata.gz: fb9274252cd2350a2556835aea585903bf6fb90bca74bbdb11f3d69ecb084c22e3609238860c4bcf385c71cefe817d7cb1f5a718df3ad97c8f38dfa340a2196c
+  data.tar.gz: 545b4c5400fb59d2c112d8b4cf4633170dea301b15f0e47eb1c08089105d29a6d0f8a47d9fa1b3c4880516352bc3ffdca1652cdf2e714a37fba175ef42a7eba5

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.0.10 / 2017-06-13
+
+* [FEATURE] Throw custom errors in stead of general RunTime errors whenever the API returns a 400
+
 # 0.0.9 / 2017-06-08
 
 * [FEATURE] Add support for creating and deleting attributes

data/lib/integration/client.rb

@@ -4,6 +4,7 @@ require 'oj'
 require_relative './search_profiles_result'
 require_relative './rule_engine_result'
 require_relative './referral_code'
+require_relative './client_error'
 
 module TalonOne
   module Integration
@@ -34,7 +35,7 @@ module TalonOne
         if res.code[0] == '2'
           result.new(Oj.load(res.body, oj_options(:strict)))
         else
-          raise "#{method.upcase} #{path} -> #{res.code} #{res.body}"
+          raise TalonOne::Integration::ClientError.new("#{method.upcase} #{path} -> #{res.code} #{res.body}")
         end
       end
 

data/lib/integration/client_error.rb

@@ -0,0 +1,9 @@
+module TalonOne
+  module Integration
+    class ClientError < StandardError
+      def initialize(msg)
+        super
+      end
+    end
+  end
+end

data/talon_one.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name = 'talon_one'
-  s.version = '0.0.9'
-  s.date = '2017-06-08'
+  s.version = '0.0.10'
+  s.date = '2017-06-13'
   s.summary = 'Client for the Talon.One API'
   s.description = 'A simple client for using the Talon.One API'
   s.authors = ['Talon.One GmbH']

data/test/test_integration_api_live.rb

@@ -17,7 +17,8 @@ class TestIntegrationApiLive < LiveApiTest
 
     management_client.update_campaign_status @app["id"], @campaign["id"], "enabled"
 
-    @attribute ||= management_client.create_attribute({ entity: "Event", eventType: "Viewed Page", name: "URL", title: "Page URL", type: "string", description: "The URL of the page that the user has viewed", tags: [], editable: true })
+    @event_type ||= "Viewed Page#{rand(36**3).to_s(36)}"
+    @attribute ||= management_client.create_attribute({ entity: "Event", eventType: @event_type, name: "URL", title: "Page URL", type: "string", description: "The URL of the page that the user has viewed", tags: [], editable: true })
   end
 
   def teardown
@@ -30,7 +31,7 @@ class TestIntegrationApiLive < LiveApiTest
   end
 
   def test_track_event
-    res = integration_client.track_event "a-session", "Viewed Page", { URL: "http://example.com" }
+    res = integration_client.track_event "a-session", @event_type, { URL: "http://example.com" }
     assert res.profile
     assert res.session
     assert_instance_of TalonOne::Integration::Event, res.event
@@ -38,7 +39,7 @@ class TestIntegrationApiLive < LiveApiTest
     assert !res.event.accepted_coupon?, "No coupon -> no acceptCoupon effect"
     assert_equal 1, res.event.effects.length
     assert_equal "setDiscount", res.event.effects[0].function
-    assert_equal "Viewed Page", res.event.type
+    assert_equal @event_type, res.event.type
     assert_equal "a-session", res.event.session_id, "a-session"
     assert_equal({ "URL" => "http://example.com" }, res.event.attributes)
     assert_instance_of BigDecimal, res.session["discounts"]["Free money"]
@@ -51,4 +52,13 @@ class TestIntegrationApiLive < LiveApiTest
     }
     assert res.event.rejected_coupon?, "invalid coupon code was rejected"
   end
+
+  def test_raise_error
+    err = assert_raises TalonOne::Integration::ClientError do
+      integration_client.track_event "a-session", @event_type, { BADURL: "http://example.com" }
+    end
+
+    assert_includes err.message, '400'
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: talon_one
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - Talon.One GmbH
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-08 00:00:00.000000000 Z
+date: 2017-06-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oj
@@ -67,6 +67,7 @@ files:
 - README.md
 - Rakefile
 - lib/integration/client.rb
+- lib/integration/client_error.rb
 - lib/integration/customer_profile.rb
 - lib/integration/effect.rb
 - lib/integration/event.rb