taiwanese_id_validator 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 138804708933184e1ad20325ad662f9fb26a6b6841f7ebbdc844319ab6f41245
-  data.tar.gz: 591d61b99e22b9ecc372fb0924686bbeb13a108da813cb14d730cdf22c008a8b
+  metadata.gz: 4369f6bf917fbd32056fcb9084fd6640a083f6cea7449d0212e3d87c5830f35e
+  data.tar.gz: 9bd602649636f06c50ca11a22930f7621a414285ab1a447f5927a6113946b9dd
 SHA512:
-  metadata.gz: 026a849d7d4c4d8a605a1eb36a754ca09c249a6930930c67d1e5d4e695b3a89f2df3fe5eeed255423e1d7f0bc0126309b6513d064fbe683d1a96c3b4bcd3855c
-  data.tar.gz: c3153324521c9baa73603483925c5f43d5dbd7464992cadd7995d0b3c5294da1c57363b6c675884f0aef125d03231f154ba9593542a4ed351b8f5ebfe2a545a9
+  metadata.gz: 8350403c7f2e5d6e80d62a193aa2d5fb46d896c07b0914309c6c718e8919123496a72550b8c321cd8596bf56cb93f09dfb197cb0738ed160c4f16cf9bcee5598
+  data.tar.gz: 11e07f4a93b054b8c47487a8d7e1891f880f1c35be44640e707f17f9abfb2af5c0d03b2477376b43a0556ad7d4329b49fbf8bc0cfc4ee840eddd927d56484c50

data/CHANGELOG.md

@@ -0,0 +1,14 @@
+# Changelog
+
+## V0.0.3
+
+- Fix `TwidValidator.valid?(nil)` raise Error problem [PR#3](https://github.com/wayne5540/taiwanese_id_validator/pull/3)
+
+## V0.0.2
+
+- Support new International ID format [PR#1](https://github.com/wayne5540/taiwanese_id_validator/pull/1)
+- Upgrade bundler dependency, now requires version >= 2.2.33
+
+## V0.0.1
+
+First version

data/DEVELOPMENT.md

@@ -0,0 +1,37 @@
+## Get Started
+
+1. Fork it ( https://github.com/[my-github-username]/taiwanese_id_validator/fork )
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Commit your changes (`git commit -am 'Add some feature'`)
+4. Push to the branch (`git push origin my-new-feature`)
+5. Create a new Pull Request
+
+## Run Tests
+
+`rspec`
+
+## Build the gem
+
+Build the gem:
+
+```
+gem build taiwanese_id_validator.gemspec
+```
+
+Install the gem, change the version name if needed
+
+```
+gem install ./taiwanese_id_validator-0.0.3.gem
+```
+
+Push to RubyGem
+
+```
+gem push ./taiwanese_id_validator-0.0.3.gem
+```
+
+More details about how to make the gem including build, install, push can be found [here](https://guides.rubygems.org/make-your-own-gem/)
+
+## TODOs
+
+- Support Chinese ID Validation

data/README.md

@@ -6,11 +6,10 @@
 
 ## Features
 
-* Rails model 內驗證 (Rails 3+/4)
-* Rails model 外驗證
-* 新式統一證號驗證
-* 產生符合格式的身分證字號，可選擇男女
-
+- Rails model 內驗證 (Rails 3+/4/5/6/7)
+- Rails model 外驗證
+- 新式統一證號驗證
+- 產生符合格式的身分證字號，可選擇男女
 
 ## Installation
 
@@ -40,7 +39,7 @@ end
 
 #### Options
 
-* `allow_nil` or `allow_blank`
+- `allow_nil` or `allow_blank`
 
 ```ruby
 class User < ActiveRecord::Base
@@ -48,7 +47,7 @@ class User < ActiveRecord::Base
 end
 ```
 
-* Case sensitive, default is true
+- Case sensitive, default is true
 
 ```ruby
 class User < ActiveRecord::Base
@@ -56,7 +55,6 @@ class User < ActiveRecord::Base
 end
 ```
 
-
 ### Validation outside the model
 
 #### 驗證身分證字號
@@ -101,18 +99,12 @@ ItidValidator.valid?('A800000015') #=> false
 
 ## Others
 
-[身分證公式](https://zh.wikipedia.org/wiki/%E4%B8%AD%E8%8F%AF%E6%B0%91%E5%9C%8B%E5%9C%8B%E6%B0%91%E8%BA%AB%E5%88%86%E8%AD%89)
-[新式統一證號](http://www.registration.fcu.edu.tw/wSite/public/Attachment/f1582594331972.pdf)
-
+- [身分證公式](https://zh.wikipedia.org/wiki/%E4%B8%AD%E8%8F%AF%E6%B0%91%E5%9C%8B%E5%9C%8B%E6%B0%91%E8%BA%AB%E5%88%86%E8%AD%89)
+- [新式統一證號](https://zh.wikipedia.org/wiki/%E4%B8%AD%E8%8F%AF%E6%B0%91%E5%9C%8B%E5%B1%85%E7%95%99%E8%AD%89)
 
 ## Contributing
 
-1. Fork it ( https://github.com/[my-github-username]/taiwanese_id_validator/fork )
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create a new Pull Request
-
+Check [DEVELOPMENT.md](DEVELOPMENT.md)
 
 ## LICENSE
 

data/lib/international_id_validator/itid_validator.rb

@@ -2,6 +2,9 @@ require 'international_id_validator/itid_mapping'
 
 module ItidValidator
   def self.valid?(itid, case_sensitive = true, allow_old = false)
+    return false if !itid
+    return false if !itid.is_a?(String)
+
     itid = itid.upcase unless case_sensitive
 
     return false if itid.length != 10

data/lib/taiwanese_id_validator/twid_validator.rb

@@ -2,6 +2,9 @@ require 'taiwanese_id_validator/twid_mapping'
 
 module TwidValidator
   def self.valid?(twid, case_sensitive = true)
+    return false if !twid
+    return false if !twid.is_a?(String)
+
     twid = twid.upcase unless case_sensitive
 
     return false if twid.length != 10

data/spec/international_id_validator/itid_validator_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+describe ItidValidator do
+
+  describe "#valid?" do
+    context "when id not valid" do
+      it "returns false if id too short" do
+        expect( ItidValidator.valid?("A8000") ).to be false
+      end
+
+      it "returns false if id too long" do
+        expect( ItidValidator.valid?("A800000014111") ).to be false
+      end
+
+      it "returns false if id calculation is wrong" do
+        expect( ItidValidator.valid?("A800000013") ).to be false
+      end
+
+      it "returns false if format is wrong" do
+        expect( ItidValidator.valid?("YAC4713412") ).to be false
+      end
+
+      it "returns false if id is nil" do
+        expect( ItidValidator.valid?(nil) ).to be false
+      end
+
+      it "returns false if id is nil" do
+        expect( ItidValidator.valid?(1) ).to be false
+      end
+    end
+
+    context "when id is valid" do
+      let(:id) { "A800000014" }
+
+      it "returns true" do
+        expect( ItidValidator.valid?(id) ).to be true
+      end
+    end
+  end
+end

data/spec/taiwanese_id_validator/twid_validator_spec.rb

@@ -19,6 +19,14 @@ describe TwidValidator do
       it "returns false if format is wrong" do
         expect( TwidValidator.valid?("YAC4713412") ).to be false
       end
+
+      it "returns false if id is nil" do
+        expect( TwidValidator.valid?(nil) ).to be false
+      end
+
+      it "returns false if id is nil" do
+        expect( TwidValidator.valid?(1) ).to be false
+      end
     end
 
     context "when id is valid" do

data/taiwanese_id_validator.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "taiwanese_id_validator"
-  spec.version       = "0.0.2"
+  spec.version       = "0.0.3"
   spec.authors       = ["Wayne Chu"]
   spec.email         = ["wayne.5540@gmail.com"]
   spec.summary       = "Taiwanese Id Validator."

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: taiwanese_id_validator
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Wayne Chu
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-12-27 00:00:00.000000000 Z
+date: 2024-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -75,7 +75,8 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
-- CHANGELOG
+- CHANGELOG.md
+- DEVELOPMENT.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -87,6 +88,7 @@ files:
 - lib/taiwanese_id_validator/twid_generator.rb
 - lib/taiwanese_id_validator/twid_mapping.rb
 - lib/taiwanese_id_validator/twid_validator.rb
+- spec/international_id_validator/itid_validator_spec.rb
 - spec/international_id_validator_spec.rb
 - spec/spec_helper.rb
 - spec/taiwanese_id_validator/twid_generator_spec.rb
@@ -112,7 +114,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Taiwanese Id Validator.

data/CHANGELOG

@@ -1,11 +0,0 @@
-# Changelog
-
-## V0.0.2
-
-- Support new International ID format PR#1
-- Upgrade bundler dependency, now requires version >= 2.2.33
-
-
-## V0.0.1
-
-First version