tainted_params 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 65666fe19c54decad64747cd681f5c602abcdfec
-  data.tar.gz: ea37c8c5a85fdd7ded0a3d61bb9a86402d4dbd45
+  metadata.gz: 850558584222bbe91bd8409f4b35900f4f9bfc3a
+  data.tar.gz: 20172f254c3c3c389981167118d69e8d84c39c11
 SHA512:
-  metadata.gz: 634c472cb70888cd2fa94e0dd025494ef0d261efd19af819edab4652d5aef48c4234b76e683d53928545fa39317d9fdbc39dcf30f76021845462ded011d83b7c
-  data.tar.gz: 7d7f16e9d52012d4a92921421cb5ae37decf85225d72216ade98c87f7f5e0cdbbbbe5dd45420a9c392a633425978a68bc41c3e113dea3db82e7d125cf4f5a462
+  metadata.gz: 3696a33659110c78cf3ef2f453a4cc3d12a3ad9f842e2338a13a12b025f39948a96a82e8f1230793517ce9fbce30f5ddee551bfaee192ad9f05722dd3e5639e6
+  data.tar.gz: 1ad9fbb6bc9bb3857ec67cd070766979df0b240b277225a92f94166860e0946b6b4699d40d3022d6731609b651fd3f9b4d3cef970efd4ec2aa711811159f6f78

data/README.md

@@ -2,22 +2,22 @@
 
 https://github.com/Ragmaanir/tainted_params
 
-# DESCRIPTION
+## Description
 
 Behaves like strong_parameters, with some minor differences.
 
-# FEATURES
+## Features
 
 - Validate required and optional parameters
 - Validate their types
 - Type coercions for parameters
 
-# PROBLEMS/TODO
+## Problems/Todo
 
 - made some monkey patches to hash(slice, only, except, map_pairs) to not having to depend on active support gem
 - custom HashWithIndifferentAccess
 
-# SYNOPSIS
+## Synopsis
 
     builder = TaintedParams::ParamsValidatorBuilder.new do
       required :id, :Integer
@@ -31,20 +31,21 @@ Behaves like strong_parameters, with some minor differences.
 
     result = validator.validate(options: { name: 'bob', active: 1, admin: true })
 
-    assert{ result.valid        == { options: { name: 'bob' } } }
-    assert{ result.invalid      == { options: { active: 1 } } }
-    assert{ result.unpermitted  == { options: { admin: true } } }
-    assert{ result.missing      == { id: nil } }
+    # These evaluate to true:
+    result.valid        == { options: { name: 'bob' } }
+    result.invalid      == { options: { active: 1 } }
+    result.unpermitted  == { options: { admin: true } }
+    result.missing      == { id: nil }
 
-# REQUIREMENTS
+## Requirements
 
 * Ruby >= 2
 
-# INSTALL
+## Install
 
 * FIX
 
-# DEVELOPERS
+## Developers
 
 After checking out the source, run:
 
@@ -53,11 +54,11 @@ After checking out the source, run:
 This task will install any missing dependencies, run the tests/specs,
 and generate the RDoc.
 
-# INTERNALS
+## Internals
 
 The ParamsValidatorBuilder constructs a ParamsValidator out of ParamConstraints. The ParamsValidator contains the validation logic to split a params-hash into valid, invalid, missing and unpermitted parts.
 
-# LICENSE
+## License
 
 (The MIT License)
 

data/lib/tainted_params/core_ext/hash.rb

@@ -16,11 +16,11 @@ class Hash
   #   end
   # end
 
-  def slice(keys)
-    select{ |k,_| keys.include?(k) }
-  end
+  # def slice(keys)
+  #   select{ |k,_| keys.include?(k) }
+  # end
 
-  alias_method :only, :slice
+  #alias_method :only, :slice
 
   def except(keys)
     select{ |k,_| !keys.include?(k) }

data/lib/tainted_params/string_key_hash.rb

@@ -17,12 +17,29 @@ module TaintedParams
       @hash = self.class.stringify_keys(hash).freeze
     end
 
-    def_delegators :@hash, :fetch, :each, :map_pairs, :values_at, :keys, :values
+    def_delegators :@hash, *%w{
+      fetch
+      keys values rassoc shift
+      each map_pairs
+      length size empty?
+    }
+
+    def key?(k)
+      @hash.key?(convert_key(k))
+    end
+
+    alias_method :include?, :key?
+    alias_method :has_key?, :key?
+    alias_method :member?, :key?
 
     def [](key)
       @hash[convert_key(key)]
     end
 
+    def values_at(*args)
+      args.map{ |k| self[k] }
+    end
+
     def merge(hash, &block)
       self.class.new(self.to_hash.merge(hash, &block))
     end
@@ -35,6 +52,14 @@ module TaintedParams
       @hash
     end
 
+    def ==(other)
+      case other
+        when Hash then self == self.class.new(other)
+        when self.class then to_hash == other.to_hash
+        else false
+      end
+    end
+
   private
 
     def convert_key(key)

data/lib/tainted_params/version.rb

@@ -1,3 +1,3 @@
 module TaintedParams
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

data/spec/unit/string_key_hash_spec.rb

@@ -2,18 +2,62 @@ describe TaintedParams::StringKeyHash do
 
   let(:h) { described_class.new(symbol: 1, 'string' => 2) }
 
-  it '' do
+  it '#respond_to?' do
+    %w{
+      fetch [] key? member? include? has_key? shift
+      each
+      length size empty? any?
+      map select reject map collect
+      values_at merge keys rassoc dup ==}.each do |meth|
+      assert{ h.respond_to?(meth) }
+    end
+  end
+
+  it '#[]' do
     assert{ h['symbol'] == 1 }
     assert{ h[:string] == 2 }
   end
 
-  it '' do
+  it '#each' do
+    res = {}
+    h.each do |k,v|
+      res[k] = v
+    end
+
+    assert{ res == {'symbol' => 1, 'string' => 2} }
+  end
+
+  it '#select' do
+    res = h.select{ |k,v| v > 1 }
+    assert{ res == [['string', 2]] }
+  end
+
+  it '#map' do
+    res = h.map{ |k,v| [k, v + 1] }
+    assert{ res == [['symbol', 2], ['string', 3]] }
+  end
+
+  it '#values_at' do
+    assert{ h.values_at(:symbol, 'string') == [1,2] }
+  end
+
+  it '#merge' do
     h2 = h.merge(newsymbol: 3)
+    assert{ h2.is_a?(described_class) }
     assert{ h2['newsymbol'] == 3 }
   end
 
-  it '' do
+  it '#keys' do
     assert{ h.keys == ['symbol', 'string'] }
   end
 
+  it '#rassoc' do
+    assert{ h.rassoc(1) == ['symbol', 1] }
+  end
+
+  it '#==' do
+    assert{ h == {symbol: 1, 'string' => 2} }
+    assert{ h == {'symbol' => 1, 'string' => 2} }
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: tainted_params
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Ragmaanir
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-17 00:00:00.000000000 Z
+date: 2015-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec