tainers 0.0.1 → 0.0.2

data/lib/tainers/cli.rb

@@ -97,6 +97,15 @@ module Tainers
         end
       end
 
+      def create_command
+        return 0 if specification.create
+        1
+      end
+
+      def self.create_help
+        "Creates specified container, if it doesn't already exist; exits with 0 on creation, 1 if already exists."
+      end
+
       def ensure_command
         return 0 if specification.ensure
         255

data/lib/tainers/specification.rb

@@ -40,6 +40,28 @@ module Tainers
       return nil
     end
 
+    # Creates the container named by this specification, if it does
+    # not already exist.
+    #
+    # Returns true (self, actually) if the invocation resulted in the
+    # creation of a new container; false otherwise.
+    #
+    # A false condition could result from:
+    # - The container already existing
+    # - The container being simultaneously created by another
+    #   actor, with your invocation losing the race.
+    # 
+    # A failure to create due to operational or semantic issues
+    # should result in an exception.  Therefore, any non-exceptional
+    # case should mean that a container of the expected name exists,
+    # though in the false result case there is no firm guarantee
+    # that the existing container has the requested configuration e.
+    def create
+      return false if exists?
+      return self if Tainers::API.create(@args)
+      false
+    end
+
     # The name of the container described by this specification.
     def name
       @args['name']
@@ -70,14 +92,18 @@ module Tainers
       end
     end
 
-    def self.create_or_conflict params
+    def self.create params
       begin
         Docker::Container.create(params.dup)
         return true
       rescue Excon::Errors::Conflict
-        return true
+        return false
       end
-      false
+    end
+
+    def self.create_or_conflict params
+      create params
+      true
     end
   end
 

data/spec/commands/create_spec.rb

@@ -0,0 +1,22 @@
+require_relative 'common_examples'
+
+shared_examples_for 'create command' do
+  before do
+    args << 'create'
+  end
+
+  it "creates container and exits with 0 on creation" do
+    expect(specification).to receive(:create).with(no_args).and_return(true)
+    expect(command_run).to eq(0)
+  end
+
+  it "creates container and exits with 1 on non-creation" do
+    expect(specification).to receive(:create).with(no_args).and_return(false)
+    expect(command_run).to eq(1)
+  end
+end
+
+describe 'tainers create' do
+  it_behaves_like "a command", "create command"
+end
+

data/spec/specification_spec.rb

@@ -1,5 +1,27 @@
 require 'rspec_helper'
 
+shared_examples_for 'container creator' do
+  before do
+    expect(subject).to receive(:exists?).and_return(false)
+  end
+
+  it 'uses Docker::Container for creation' do
+    expect(Docker::Container).to receive(:create).with(specification_args).and_return(container = double)
+    expect(creation_operation).to be(subject)
+  end
+
+  it 'is okay with a conflict result' do
+    expect(Docker::Container).to receive(:create).with(specification_args).and_raise(Excon::Errors::Conflict, "Pickles")
+    expect(creation_operation).to be(expected_conflict_result)
+  end
+
+  it 'does not handle other exceptions' do
+    expect(Docker::Container).to receive(:create).with(specification_args).and_raise(Exception, "You suck.")
+    expect { creation_operation }.to raise_error("You suck.")
+  end
+end
+
+
 RSpec.describe Tainers::Specification do
   it 'requires a name' do
     expect { Tainers::Specification.new 'Image' => 'foo/image:latest' }.to raise_error(/name is required/)
@@ -26,24 +48,17 @@ RSpec.describe Tainers::Specification do
       end
 
       context '#ensure' do
-        before do
-          expect(subject).to receive(:exists?).and_return(false)
-        end
-
-        it 'uses Docker::Container for creation' do
-          expect(Docker::Container).to receive(:create).with(specification_args).and_return(container = double)
-          expect(subject.ensure).to be(subject)
-        end
-
-        it 'is okay with a conflict result' do
-          expect(Docker::Container).to receive(:create).with(specification_args).and_raise(Excon::Errors::Conflict, "Pickles")
-          expect(subject.ensure).to be(subject)
-        end
-
-        it 'does not handle other exceptions' do
-          expect(Docker::Container).to receive(:create).with(specification_args).and_raise(Exception, "You suck.")
-          expect { subject.ensure }.to raise_error("You suck.")
-        end
+        let(:expected_conflict_result) { subject }
+        let(:creation_operation) { subject.ensure }
+
+        it_behaves_like 'container creator'
+      end
+
+      context '#create' do
+        let(:expected_conflict_result) { false }
+        let(:creation_operation) { subject.create }
+
+        it_behaves_like 'container creator'
       end
     end
 
@@ -58,6 +73,12 @@ RSpec.describe Tainers::Specification do
         expect(Docker::Container).to receive(:create).never
         expect(subject.ensure).to be(subject)
       end
+
+      it 'does a no-op for #create' do
+        expect(subject).to receive(:exists?).and_return(true)
+        expect(Docker::Container).to receive(:create).never
+        expect(subject.create).to be(false)
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tainers
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -74,6 +74,7 @@ files:
 - spec/commands/exists_spec.rb
 - spec/commands/ensure_spec.rb
 - spec/commands/common_examples.rb
+- spec/commands/create_spec.rb
 - spec/commands/name_spec.rb
 - spec/specification_spec.rb
 - spec/rspec_helper.rb