tagtical 1.5.2 → 1.5.3

data/VERSION

@@ -1 +1 @@
-1.5.2
+1.5.3

data/lib/tagtical/tag.rb

@@ -187,7 +187,7 @@ module Tagtical
 
     def validate_possible_values
       if possible_values && !possible_values.include?(value)
-        errors.add(:value, %{Value "#{value}" not found in list: #{possible_values.inspect}})
+        errors.add(:value, %{"#{value}" not found in list: #{possible_values.inspect}})
       end
     end
 

data/lib/tagtical/taggable/core.rb

@@ -296,7 +296,7 @@ module Tagtical::Taggable
             tag_list = tag_list.uniq
 
             # Find existing tags or create non-existing tags:
-            tag_value_lookup = tag_type.scoping { find_or_create_tags(tag_list) }
+            tag_value_lookup = tag_type.klass.find_or_create_tags(tag_list)
             tags = tag_value_lookup.keys
 
 

data/spec/tagtical/tag_spec.rb

@@ -41,7 +41,7 @@ describe Tagtical::Tag do
       it "should not be valid if value is not in possible_values" do
         @tag.value = "glass"
         @tag.should be_invalid
-        @tag.errors[:value][0].should == %{Value "glass" not found in list: ["knife", "fork", "spoon"]}
+        @tag.errors[:value][0].should == %{"glass" not found in list: ["knife", "fork", "spoon"]}
       end
 
       it "should be valid even if cases are different" do

data/spec/tagtical/taggable_spec.rb

@@ -113,10 +113,15 @@ describe Tagtical::Taggable do
       @taggable.should have_only_tag_values %w{Knitting Ruby Pottery}
     end
 
+    it "should raise an error when saved with value not in possible_values" do
+      @taggable.craft_list << "not-in-list"
+      lambda { @taggable.save! }.should raise_error(ActiveRecord::RecordInvalid)
+    end
+
   end
 
   describe "#cascade_set_tag_list!" do
-    when_possible_values_specified(:values => %w{Knitting Ruby Pottery}, :klass => Tag::Skill) do
+    when_possible_values_specified(:values => %w{Knitting Ruby Pottery Basketball}, :klass => Tag::Skill) do
       before do
         @taggable.update_attributes!(:tag_list => "tree, train", :skill_list => "basketball", :craft_list => "pottery")
         @taggable.reload
@@ -175,7 +180,7 @@ describe Tagtical::Taggable do
         end
 
         it "should not change the tags in skill" do
-          @taggable.skill_list.should have_same_elements ["basketball", "pottery"]
+          @taggable.skill_list.should have_same_elements ["Basketball", "Pottery"]
         end
 
         it "should have set the values at the tag level" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tagtical
 version: !ruby/object:Gem::Version
-  version: 1.5.2
+  version: 1.5.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,12 +9,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-08-06 00:00:00.000000000 -07:00
+date: 2011-09-30 00:00:00.000000000 -05:00
 default_executable: 
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &2166310680 !ruby/object:Gem::Requirement
+  requirement: &2172699060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - <=
@@ -22,10 +22,10 @@ dependencies:
         version: 3.0.5
   type: :runtime
   prerelease: false
-  version_requirements: *2166310680
+  version_requirements: *2172699060
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2166310200 !ruby/object:Gem::Requirement
+  requirement: &2172698580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - <=
@@ -33,10 +33,10 @@ dependencies:
         version: 2.6.0
   type: :runtime
   prerelease: false
-  version_requirements: *2166310200
+  version_requirements: *2172698580
 - !ruby/object:Gem::Dependency
   name: sqlite3-ruby
-  requirement: &2166309720 !ruby/object:Gem::Requirement
+  requirement: &2172698100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +44,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2166309720
+  version_requirements: *2172698100
 - !ruby/object:Gem::Dependency
   name: mysql
-  requirement: &2166309240 !ruby/object:Gem::Requirement
+  requirement: &2172697620 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +55,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2166309240
+  version_requirements: *2172697620
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &2166308760 !ruby/object:Gem::Requirement
+  requirement: &2172697140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,10 +66,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2166308760
+  version_requirements: *2172697140
 - !ruby/object:Gem::Dependency
   name: rcov
-  requirement: &2166308280 !ruby/object:Gem::Requirement
+  requirement: &2172713800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -77,7 +77,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2166308280
+  version_requirements: *2172713800
 description: Tagtical allows you do create subclasses for Tag and add additional functionality
   in an STI fashion. For example. You could do Tag::Color.find_by_name('blue').to_rgb.
   It also supports storing weights or relevance on the taggings.