tags4free 0.1.1 → 0.1.2

data/History.txt

@@ -1,3 +1,9 @@
+=== 0.1.2 / 2008-10-10
+
+* Bugfix release
+
+  * Error handling corrected.
+  
 === 0.1.1 / 2008-10-10
 
 * Minor Bugfix release

data/lib/tags_4_free.rb

@@ -1,11 +1,12 @@
 module Tags4Free
   require 'rubygems'
+  require 'net/http'
   require 'httparty'
   include HTTParty
   
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
   
-  class YahooApiError < ArgumentError; end
+  class YahooApiError < StandardError; end
 
   class YahooApiFormatError < ArgumentError
     def initialize(content, result_set)
@@ -23,9 +24,12 @@ module Tags4Free
   #
   # tags = Tags4Free.for('The content that should be tagged')
   def self.for(content)
-    result_set = get(SERVICE_URL, :query => {:appid => APPID, :context => content})
-
-    raise YahooApiError.new(result_set['Error']['Message']) if result_set['Error']
+    begin
+      result_set = get(SERVICE_URL, :query => {:appid => APPID, :context => content})
+    rescue Net::HTTPServerException => e
+      raise YahooApiError
+    end
+    
     raise YahooApiFormatError.new(content, result_set) unless result_set['ResultSet']
     
     result_set['ResultSet']['Result'] || []

data/spec/spec_helper.rb

@@ -6,4 +6,4 @@ rescue LoadError
   require 'spec'
 end
  
-require File.join(File.dirname(__FILE__), '..', 'lib', 'tags4_free')
+require File.join(File.dirname(__FILE__), '..', 'lib', 'tags_4_free')

data/spec/tags_4_free_spec.rb

@@ -8,12 +8,13 @@ describe Tags4Free do
   end
   
   it "should raise an exception if Yahoo! reports an error" do
-    Tags4Free.should_receive(:get).and_return({"Error"=>{"Message"=>"invalid value: context", "xmlns"=>"urn:yahoo:api"}})
+    def Tags4Free.get(*args)
+      raise Net::HTTPForbidden.new(403,'Forbidden','').error!
+    end
     
     begin
       Tags4Free.for("Erroneous content")
     rescue Tags4Free::YahooApiError => e
-      e.message.should include('invalid value: context')
     else
       violated('YahooApiError should be raised!')
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: tags4free
 version: !ruby/object:Gem::Version 
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors: 
 - "Thorben Schr\xC3\xB6der"