tacky 0.5.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 19d56d7272a88d0af05fdf1a22a826fc98e7d71f3205c962884c502b86487ac5
-  data.tar.gz: 570d9b1a70f86d9787856a7dfc4d5843d5b43ff9835a1be3f65fcdfb4f557bf8
+  metadata.gz: d5169130c14020b608d8c321ecd838a5593c61b6c43494c69cad647611313d29
+  data.tar.gz: 95583567be0ac82aff2e1af2fbe310b9c4b3cd6bb34bfe75669adb4f734a772c
 SHA512:
-  metadata.gz: ac16193c8a93e90096f3864a5b52032efb6123a06044ca23fe552311135b137ee091cb769def25d6b9dab668b3102b2bdb384bf1e666ec965ae655433c553cb8
-  data.tar.gz: 388dffe5ca6a6d70ea33ff47ad7fa96b39c19da463176e8c907859b8809d124ae5ccf3d38a01144f2ec0dbd21535384e5c2fb3b095fc18cc4ae5ae71e898d9c3
+  metadata.gz: 371e36840b98444725e97e6ab46080da007e34df15c557c09fcf3727e9b4cde6edd8b142ab773bce3ece3a4b3c16cfbaba52cb3b579498d467fefee66b6aa9c1
+  data.tar.gz: 875cecc83dc3b6b6b8b6b53eab2153adae00aa5f5fffc2c505396466cef25c0a68c1f1668a00e7f90cac95bdd4f3b29719dfcf7ccb75ec3b72007d252350e5b7

data/.rubocop.yml

@@ -29,9 +29,9 @@ Metrics/MethodLength:
 Metrics/ClassLength:
   Max: 180
 Metrics/CyclomaticComplexity:
-  Max: 10
+  Max: 15
 Metrics/PerceivedComplexity:
-  Max: 10
+  Max: 15
 Metrics/ParameterLists:
   Max: 10
 Layout/ParameterAlignment:

data/lib/tacky.rb

@@ -32,14 +32,16 @@ class Tacky
   end
 
   def method_missing(*args)
+    maybe = %i[key keyreq]
     @mutex.synchronize do
       key = args.dup
       mtd = args.shift
       unless @cache.key?(key)
         params = @origin.method(mtd).parameters
+        reqs = params.count { |p| p[0] == :req }
         @cache[key] =
-          if params.any? { |p| p[0] == :keyreq }
-            @origin.__send__(mtd, *args[0...-1], **args.last) do |*a|
+          if params.any? { |p| maybe.include?(p[0]) } && args.size > reqs
+            @origin.__send__(mtd, *args[0..-2], **args.last) do |*a|
               yield(*a) if block_given?
             end
           else

data/tacky.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to? :required_rubygems_version=
   s.required_ruby_version = '>= 2.3'
   s.name = 'tacky'
-  s.version = '0.5.1'
+  s.version = '0.5.2'
   s.license = 'MIT'
   s.summary = 'Primitive Object Memoization for Ruby'
   s.description =

data/test/test_tacky.rb

@@ -23,12 +23,14 @@ class TackyTest < Minitest::Test
 
   def test_passes_hash_args
     foo = Object.new
-    def foo.value(_one, _two:)
-      rand(100)
+    def foo.value(one, two:)
+      rand(one + two)
     end
     bar = Tacky.new(foo)
-    first = bar.value(42, _two: 1)
-    assert_equal(bar.value(42, _two: 1), first)
+    first = bar.value(42, two: 1)
+    assert_equal(bar.value(42, two: 1), first)
+    refute_equal(bar.value(777, two: 1), first)
+    refute_equal(bar.value(42, two: 555), first)
   end
 
   def test_passes_default_hash_args
@@ -39,6 +41,18 @@ class TackyTest < Minitest::Test
     bar = Tacky.new(foo)
     first = bar.value(42)
     assert_equal(bar.value(42), first)
+    refute_equal(bar.value(0), first)
+  end
+
+  def test_passes_one_default_hash_args
+    foo = Object.new
+    def foo.value(_one: 42)
+      rand(100)
+    end
+    bar = Tacky.new(foo)
+    first = bar.value
+    assert_equal(bar.value, first)
+    refute_equal(bar.value(_one: 44), first)
   end
 
   def test_passes_default_args
@@ -49,6 +63,7 @@ class TackyTest < Minitest::Test
     bar = Tacky.new(foo)
     first = bar.value
     assert_equal(bar.value, first)
+    refute_equal(bar.value(7), first)
   end
 
   def test_deep_caching

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: tacky
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - Yegor Bugayenko