table_warnings 1.0.0 → 1.0.1

data/CHANGELOG

@@ -1,3 +1,13 @@
+1.0.1 / 2012-06-07
+
+* Bug fixes
+
+  * Fix typo in #warn_if_blanks
+
+* Enhancements
+
+  * Actually test #warn_if_blanks and #warn_unless_size
+
 1.0.0 / 2012-06-07
 
 * Breaking changes

data/lib/table_warnings.rb

@@ -37,11 +37,11 @@ module TableWarnings
     pool = column_names.map do |column_name|
       TableWarnings::Column.new self, column_name
     end
-    exclusive = TableWarnings.registry.exclusive(self)
+    exclusive_warnings = TableWarnings.registry.exclusive(self)
 
     assignments = {}
     # pass 1 - exclusives and covers
-    exclusive.each do |warning|
+    exclusive_warnings.each do |warning|
       disposition = Disposition.new
       disposition.exclusives = warning.exclusives pool
       disposition.covers = warning.covers pool
@@ -55,7 +55,7 @@ module TableWarnings
       end
     end
     # pass 2 - allow regexp matching, but only if somebody else didn't cover it
-    exclusive.each do |warning|
+    exclusive_warnings.each do |warning|
       disposition = assignments[warning]
       disposition.matches = warning.matches(pool).select do |match|
         assignments.except(warning).none? { |_, other| other.covers.include?(match) }

data/lib/table_warnings/column.rb

@@ -16,7 +16,7 @@ module TableWarnings
       table.columns_hash[name].try(:type) == :string
     end
 
-    def blank?(conditions)
+    def blanks?(conditions)
       table.where(conditions).where(["LENGTH(TRIM(#{table.quoted_table_name}.#{name})) = 0"]).count > 0
     end
 

data/lib/table_warnings/nonexistent_owner.rb

@@ -9,9 +9,9 @@ module TableWarnings
     def message(column)
       if column.nonexistent_owners?(conditions) or (not allow_null? and column.nulls?(conditions))
         if conditions.empty?
-          "Foreign keys#{null_warning} refer to nonexistent values in #{column.name.inspect}"
+          "Values in foreign key column #{column.name.inspect}#{null_warning} do not correspond to actual values in foreign table."
         else
-          "Foreign keys#{null_warning} refer to nonexistent values in #{column.name.inspect} given #{conditions.inspect}"
+          "Values in foreign key column #{column.name.inspect} under condition #{conditions.inspect}#{null_warning} do not correspond to actual values in foreign table."
         end
       end
     end
@@ -24,7 +24,7 @@ module TableWarnings
 
     def null_warning
       if not allow_null?
-        ' are nil and/or'
+        ' are NULL and/or'
       end
     end
   end

data/lib/table_warnings/size.rb

@@ -14,9 +14,9 @@ module TableWarnings
       current_count = effective_count
       unless allowed_size.include? current_count
         if conditions.empty?
-          "Table is not of expected size (expected: #{allowed_size.to_s}, actual: #{current_count})"
+          "Row count is expected to be #{allowed_size.to_s}, but is #{current_count}"
         else
-          "Table count with conditions #{conditions.inspect} is not of expected size (expected: #{allowed_size.to_s}, actual: #{current_count})"
+          "Row count with conditions #{conditions.inspect} is expected to be #{allowed_size.to_s}, but is #{current_count}"
         end
       end
     end
@@ -45,7 +45,7 @@ module TableWarnings
         100_000..1_000_000
       when :millions
         1_000_000..1_000_000_000
-      when Range
+      when ::Range
         approximate_size
       when Numeric
         approximate_size..approximate_size

data/lib/table_warnings/version.rb

@@ -1,3 +1,3 @@
 module TableWarnings
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/test/helper.rb

@@ -67,7 +67,8 @@ class MiniTest::Spec
     refute hits.many?, "#{model.name} had MULTIPLE warnings like #{expected_warning.inspect}: #{hits.inspect}"
   end
 
-  def assert_no_warning(model, specific_unexpected_warning = nil)
+  def refute_warning(model, specific_unexpected_warning = nil)
+    raise if block_given?
     warnings = model.table_warnings
     if specific_unexpected_warning
       refute(warnings.any? { |warning| warning =~ specific_unexpected_warning }, "#{model.name} unexpectedly had warning #{specific_unexpected_warning.inspect}")
@@ -79,7 +80,7 @@ class MiniTest::Spec
   def assert_causes_warning(model, expected_warnings)
     expected_warnings = [expected_warnings].flatten
     expected_warnings.each do |expected_warning|
-      assert_no_warning model, expected_warning
+      refute_warning model, expected_warning
     end
     warnings_before = model.table_warnings
     yield
@@ -92,10 +93,10 @@ class MiniTest::Spec
     refute unexpected_warnings.any?, "#{model.name} unexpectedly ALSO got warnings #{unexpected_warnings.inspect}"
   end
 
-  def assert_does_not_cause_warning(model)
-    assert_no_warning model
+  def refute_causes_warning(model)
+    refute_warning model
     yield
-    assert_no_warning model
+    refute_warning model
   end
 
 end

data/test/test_combinations.rb

@@ -60,7 +60,7 @@ describe TableWarnings do
       end
     end
     it "combines a positive regexp with conditions and a negative regexp with conditions" do
-      assert_does_not_cause_warning PetDelta do
+      refute_causes_warning PetDelta do
         PetDelta.force_create!
       end
       PetDelta.delete_all # !

data/test/test_warn_if_blanks.rb

@@ -0,0 +1,17 @@
+require 'helper'
+
+class PetDoh < ActiveRecord::Base
+  col :gender
+  warn_if_blanks :gender
+end
+PetDoh.auto_upgrade!
+
+describe TableWarnings do
+  describe :warn_if_nulls do
+    it "takes a single column" do
+      assert_causes_warning PetDoh, /blank.*gender/i do
+        PetDoh.force_create!
+      end
+    end
+  end
+end

data/test/test_warn_if_nonexistent_owner.rb

@@ -32,27 +32,27 @@ describe TableWarnings do
       Person.force_create! :llc_name => 'My Small Business, LLC'
     end
     it "takes a single belongs-to association name" do
-      assert_causes_warning PetRed, /nonexistent.*handler/i do
+      assert_causes_warning PetRed, /handler.*do not correspond/i do
         PetRed.force_create!
       end
     end
     it "checks the value of foreign keys not just their presence" do
-      assert_causes_warning PetRed, /nonexistent.*handler/i do
+      assert_causes_warning PetRed, /handler.*do not correspond/i do
         PetRed.force_create! :handler_id => 999999
       end
     end
     it "doesn't raise false warnings" do
-      assert_does_not_cause_warning PetRed do
+      refute_causes_warning PetRed do
         PetRed.force_create! :handler_id => Person.first.id
       end
     end
     it "regards nulls as nonexistent even if the association primary key column contains nulls" do
-      assert_causes_warning PetBlue, /nonexistent.*trainer/i do
+      assert_causes_warning PetBlue, /trainer.*do not correspond/i do
         PetBlue.force_create!
       end
     end
     it "allows nulls if explicitly requested" do
-      assert_does_not_cause_warning PetGreen do
+      refute_causes_warning PetGreen do
         PetGreen.force_create!
       end
     end

data/test/test_warn_if_nonexistent_owner_except.rb

@@ -38,27 +38,27 @@ describe TableWarnings do
       Gente.force_create! :llc_name => 'My Small Business, LLC'
     end
     it "takes a single belongs-to association name" do
-      assert_causes_warning PetRojo, /nonexistent.*trainer/i do
+      assert_causes_warning PetRojo, /trainer.*do not correspond/i do
         PetRojo.force_create!
       end
     end
     it "checks the value of foreign keys not just their presence" do
-      assert_causes_warning PetRojo, /nonexistent.*trainer/i do
+      assert_causes_warning PetRojo, /trainer.*do not correspond/i do
         PetRojo.force_create! :trainer_id => 999999
       end
     end
     it "doesn't raise false warnings" do
-      assert_does_not_cause_warning PetRojo do
+      refute_causes_warning PetRojo do
         PetRojo.force_create! :trainer_id => Gente.first.llc_name
       end
     end
     it "regards nulls as nonexistent even if the association primary key column contains nulls" do
-      assert_causes_warning PetAzul, /nonexistent.*handler/i do
+      assert_causes_warning PetAzul, /handler.*do not correspond/i do
         PetAzul.force_create!
       end
     end
     it "allows nulls if explicitly requested" do
-      assert_does_not_cause_warning PetVerde do
+      refute_causes_warning PetVerde do
         PetVerde.force_create!
       end
     end

data/test/{test_warn_if_nulls_in.rb → test_warn_if_nulls.rb}

@@ -79,7 +79,7 @@ describe TableWarnings do
       end
     end
     it "takes a single column and a condition" do
-      assert_does_not_cause_warning Pet5 do
+      refute_causes_warning Pet5 do
         Pet5.force_create!
       end
       assert_causes_warning Pet5, /null.*birthday/i do
@@ -87,7 +87,7 @@ describe TableWarnings do
       end
     end
     it "takes multiple columns and a condition" do
-      assert_does_not_cause_warning Pet6 do
+      refute_causes_warning Pet6 do
         Pet6.force_create!
       end
       assert_causes_warning Pet6, [/null.*birthday/i, /null.*gender/i] do
@@ -95,7 +95,7 @@ describe TableWarnings do
       end
     end
     it "takes a single regexp and a condition" do
-      assert_does_not_cause_warning Pet7 do
+      refute_causes_warning Pet7 do
         Pet7.force_create!
       end
       assert_causes_warning Pet7, /null.*birthday/i do
@@ -103,7 +103,7 @@ describe TableWarnings do
       end
     end
     it "takes multiple regexps and a condition" do
-      assert_does_not_cause_warning Pet8 do
+      refute_causes_warning Pet8 do
         Pet8.force_create!
       end
       assert_causes_warning Pet8, [/null.*birthday/i, /null.*gender/i] do

data/test/test_warn_if_nulls_except.rb

@@ -70,7 +70,7 @@ describe TableWarnings do
       end
     end
     it "takes multiple columns" do
-      assert_does_not_cause_warning PetB do
+      refute_causes_warning PetB do
         PetB.force_create!
       end
     end
@@ -80,12 +80,12 @@ describe TableWarnings do
       end
     end
     it "takes multiple regexps" do
-      assert_does_not_cause_warning PetD do
+      refute_causes_warning PetD do
         PetD.force_create!
       end
     end
     it "takes a single column and a condition" do
-      assert_does_not_cause_warning PetE do
+      refute_causes_warning PetE do
         PetE.force_create!
       end
       assert_causes_warning PetE, /null.*gender/i do
@@ -93,7 +93,7 @@ describe TableWarnings do
       end
     end
     it "takes multiple columns and a condition" do
-      assert_does_not_cause_warning PetF do
+      refute_causes_warning PetF do
         PetF.force_create!
       end
       assert_causes_warning PetF, /null.*sire/i do
@@ -101,7 +101,7 @@ describe TableWarnings do
       end
     end
     it "takes a single regexp and a condition" do
-      assert_does_not_cause_warning PetG do
+      refute_causes_warning PetG do
         PetG.force_create!
       end
       assert_causes_warning PetG, /null.*gender/i do
@@ -109,7 +109,7 @@ describe TableWarnings do
       end
     end
     it "takes multiple regexps and a condition" do
-      assert_does_not_cause_warning PetH do
+      refute_causes_warning PetH do
         PetH.force_create!
       end
       assert_causes_warning PetH, /null.*sire/i do

data/test/test_warn_unless_size.rb

@@ -0,0 +1,33 @@
+require 'helper'
+
+class PetOdin < ActiveRecord::Base
+  warn_unless_size 0
+end
+PetOdin.auto_upgrade!
+
+class PetDva < ActiveRecord::Base
+  warn_unless_size 0..1
+end
+PetDva.auto_upgrade!
+
+describe TableWarnings do
+  describe :warn_unless_size do
+    it "takes an exact integer" do
+      assert_causes_warning PetOdin, /expected.*0/ do
+        PetOdin.force_create!
+      end
+    end
+    it "takes a range" do
+      refute_warning PetDva
+      
+      refute_causes_warning PetDva do
+        PetDva.force_create!
+      end
+
+      assert_causes_warning PetDva, /expected.*0..1/ do
+        PetDva.force_create!
+        PetDva.force_create!
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: table_warnings
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -168,11 +168,13 @@ files:
 - table_warnings.gemspec
 - test/helper.rb
 - test/test_combinations.rb
+- test/test_warn_if_blanks.rb
 - test/test_warn_if_nonexistent_owner.rb
 - test/test_warn_if_nonexistent_owner_except.rb
+- test/test_warn_if_nulls.rb
 - test/test_warn_if_nulls_except.rb
-- test/test_warn_if_nulls_in.rb
 - test/test_warn_unless_range.rb
+- test/test_warn_unless_size.rb
 homepage: https://github.com/seamusabshere/table_warnings
 licenses: []
 post_install_message: 
@@ -201,9 +203,11 @@ summary: It's called validations to remind people of per-record validations, but
 test_files:
 - test/helper.rb
 - test/test_combinations.rb
+- test/test_warn_if_blanks.rb
 - test/test_warn_if_nonexistent_owner.rb
 - test/test_warn_if_nonexistent_owner_except.rb
+- test/test_warn_if_nulls.rb
 - test/test_warn_if_nulls_except.rb
-- test/test_warn_if_nulls_in.rb
 - test/test_warn_unless_range.rb
+- test/test_warn_unless_size.rb
 has_rdoc: