table_warnings 0.0.5 → 0.0.6

data/lib/table_warnings/version.rb

@@ -1,3 +1,3 @@
 module TableWarnings
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/lib/table_warnings/warning/arbitrary.rb

@@ -0,0 +1,13 @@
+module TableWarnings
+  class Warning
+    class Arbitrary < Warning
+      attr_reader :blk
+      
+      def messages
+        if m = blk.call
+          [m].flatten
+        end
+      end
+    end
+  end
+end

data/lib/table_warnings/warning.rb

@@ -2,6 +2,7 @@ module TableWarnings
   class Warning
     autoload :Blank, 'table_warnings/warning/blank'
     autoload :Size, 'table_warnings/warning/size'
+    autoload :Arbitrary, 'table_warnings/warning/arbitrary'
     
     attr_reader :table
     

data/lib/table_warnings.rb

@@ -37,6 +37,12 @@ module TableWarnings
     warning = ::TableWarnings::Warning::Size.new :table => self, :approximate_size => approximate_size
     ::TableWarnings.config.warnings[self].add warning
   end
+  
+  # An arbitrary warning.
+  def warn(&blk)
+    warning = ::TableWarnings::Warning::Arbitrary.new :table => self, :blk => blk
+    ::TableWarnings.config.warnings[self].add warning
+  end
 end
 
 unless ::ActiveRecord::Base.method_defined? :table_warnings

data/table_warnings.gemspec

@@ -18,7 +18,11 @@ Gem::Specification.new do |s|
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ['lib']
+
+  s.add_runtime_dependency 'activerecord'
+
   s.add_development_dependency 'fastercsv'
-  s.add_development_dependency 'earth'
-  s.add_dependency 'activerecord'
+  s.add_development_dependency 'rake'
+  s.add_development_dependency 'mini_record'
+  s.add_development_dependency 'sqlite3'
 end

data/test/helper.rb

@@ -4,6 +4,7 @@ Bundler.setup
 require 'test/unit'
 require 'active_support/all'
 require 'active_record'
+require 'mini_record'
 # thanks authlogic!
 ActiveRecord::Schema.verbose = false
 begin
@@ -11,8 +12,12 @@ begin
 rescue ArgumentError
   ActiveRecord::Base.establish_connection(:adapter => "sqlite3", :dbfile => ":memory:")
 end
-require 'earth'
-Earth.init :automobile, :apply_schemas => true
+
+# require 'logger'
+# logger = Logger.new $stdout
+# logger.level = Logger::DEBUG
+# ActiveRecord::Base.logger = logger
+
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 require 'table_warnings'

data/test/test_table_warnings.rb

@@ -1,18 +1,33 @@
 require 'helper'
 
 class AutomobileMake < ActiveRecord::Base
+  col :name
+  col :fuel_efficiency, :type => :float
+  col :fuel_efficiency_units
+    
   warn_if_blanks_in :name
   warn_if_blanks_in :fuel_efficiency
   warn_unless_size_is :hundreds
-  warn_unless_size_is 100..1000
+  warn do
+    if exists? ['fuel_efficiency < ?', 0]
+      "That's a strange looking fuel efficiency"
+    end
+  end
 end
 
 class AutomobileFuelType < ActiveRecord::Base
+  col :name
+  col :code
+  col :fuel_efficiency, :type => :float
+  col :fuel_efficiency_units
+
   warn_if_any_blanks
-  warn_unless_size_is :few
   warn_unless_size_is 1..6
 end
 
+AutomobileMake.auto_upgrade!
+AutomobileFuelType.auto_upgrade!
+
 class TestTableWarnings < Test::Unit::TestCase
   def setup
     AutomobileMake.delete_all
@@ -22,22 +37,28 @@ class TestTableWarnings < Test::Unit::TestCase
   def test_001_warn_for_blanks_in_specific_columns
     AutomobileMake.create! :name => '       ', :fuel_efficiency => nil, :fuel_efficiency_units => 'kilometres_per_litre'
     AutomobileMake.create! :name => 'Alfa Romeo', :fuel_efficiency => 10.4075, :fuel_efficiency_units => 'kilometres_per_litre'
-    assert AutomobileMake.table_warnings.one? { |w| w =~ /blanks in.*name.*column/ }
-    assert AutomobileMake.table_warnings.one? { |w| w =~ /blanks in.*fuel_efficiency.*column/ }
+    assert AutomobileMake.table_warnings.one? { |w| w =~ /blanks.*name.*column/ }
+    assert AutomobileMake.table_warnings.one? { |w| w =~ /blanks.*fuel_efficiency.*column/ }
   end
   
   def test_002_warn_of_size
-    assert_equal 0, AutomobileMake.count
-    assert AutomobileMake.table_warnings.many? { |w| w =~ /expected.*size/ }
+    assert AutomobileMake.table_warnings.one? { |w| w =~ /expected.*100\.\.1000/ }
+    assert AutomobileFuelType.table_warnings.one? { |w| w =~ /expected.*1\.\.6/ }
   end
 
   def test_003_warn_for_blanks_in_any_column
     AutomobileFuelType.create! :name => 'gas'
-    assert AutomobileFuelType.table_warnings.one? { |w| w =~ /blanks in.*code.*column/ }
+    assert AutomobileFuelType.table_warnings.one? { |w| w =~ /blanks.*code.*column/ }
+    assert AutomobileFuelType.table_warnings.many? { |w| w =~ /blanks.*fuel_efficiency.*column/ }
   end
 
   def test_004_dont_treat_0_as_blank
     AutomobileMake.create! :name => 'Acme', :fuel_efficiency => 0
-    assert !AutomobileMake.table_warnings.any? { |w| w =~ /blanks in.*fuel_efficiency.*column/ }
+    assert !AutomobileMake.table_warnings.any? { |w| w =~ /blanks.*fuel_efficiency.*column/ }
+  end
+  
+  def test_005_warn_if_arbitrary_block
+    AutomobileMake.create! :name => 'Acme', :fuel_efficiency => -5
+    assert AutomobileMake.table_warnings.one? { |w| w =~ /strange looking fuel efficiency/ }
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: table_warnings
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-06-24 00:00:00.000000000Z
+date: 2011-09-22 00:00:00.000000000Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: &2154426760 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: *2154426760
 - !ruby/object:Gem::Dependency
   name: fastercsv
-  requirement: &2153873040 !ruby/object:Gem::Requirement
+  requirement: &2154426340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153873040
+  version_requirements: *2154426340
 - !ruby/object:Gem::Dependency
-  name: earth
-  requirement: &2153872620 !ruby/object:Gem::Requirement
+  name: rake
+  requirement: &2154425920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,18 +43,29 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153872620
+  version_requirements: *2154425920
 - !ruby/object:Gem::Dependency
-  name: activerecord
-  requirement: &2153872200 !ruby/object:Gem::Requirement
+  name: mini_record
+  requirement: &2154425500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
+  prerelease: false
+  version_requirements: *2154425500
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: &2154425080 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
   prerelease: false
-  version_requirements: *2153872200
+  version_requirements: *2154425080
 description: Validate an entire [ActiveRecord] table, checking for things like blank
   rows or total number of rows
 email:
@@ -60,6 +82,7 @@ files:
 - lib/table_warnings/config.rb
 - lib/table_warnings/version.rb
 - lib/table_warnings/warning.rb
+- lib/table_warnings/warning/arbitrary.rb
 - lib/table_warnings/warning/blank.rb
 - lib/table_warnings/warning/size.rb
 - table_warnings.gemspec
@@ -85,7 +108,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: table_warnings
-rubygems_version: 1.8.5
+rubygems_version: 1.8.6
 signing_key: 
 specification_version: 3
 summary: It's called validations to remind people of per-record validations, but it