table_sync 1.10.0 → 1.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '08f6482ff6549370e3855dced47343465678ed5b095f3c613363c4a6bbe743ef'
-  data.tar.gz: 59a541d16d2d2f0ae6e7f317b798aa1d3d8e4c7cc7a8dcd5e8696d6a892288c5
+  metadata.gz: 86c13b07f0c63f70ecd2acc80fca50cdd57e0c3682ad5d7bafa56ef69b94185d
+  data.tar.gz: 8e01d572ffa14629317b248e0090bab8bde89e3dee513434b51b0bc897ceb02f
 SHA512:
-  metadata.gz: 623bf01e97409e583b008890f458d8bf8646254e373bc1ee4f9406ef54f4cb470957437c284e5309b0b5b0a5285589a7713beb7e64f4935d2473d71180f45dff
-  data.tar.gz: ce06f381c631a0ce48eabf873b239f48310fe6bc120d2c4152c8ce0a81e47101fb16ed256eb00d4e89d6a32f24dfb8c6b01bbfee9412104bf4d0c8d4f2c0ed10
+  metadata.gz: 741c3d1904400d34d1e3f0fb03eac24d9b954544744dd0736fa672a3a94751b09e0b221867d4e625749a8301f674e527f82cf62d297ccb1e4f4d1c09b6ad45f9
+  data.tar.gz: 62ee1dc7912c8c301105f0134e0a8dbef9f45ba3ca9d82ff321127f9daedd03129f261ee7af8b738da029d3f5d012627c2cbbd0f9e759826218f1b2c70f5c0b2

data/CHANGELOG.md

@@ -1,6 +1,11 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## [1.11.0] - 2019-09-11
+### Added
+- Receiving: inconsistent events raises `TableSync::UnprovidedEventTargetKeysError`
+  (events that include only some of the target keys (or none))
+
 ## [1.10.0] - 2019-08-28
 ### Added
 - convert symbolic values to strings in hashes to support older versions of activejob

data/lib/table_sync/errors.rb

@@ -16,15 +16,26 @@ module TableSync
     end
   end
 
+  class UndefinedConfig < Error
+    def initialize(model)
+      super("Config not defined for model; model: #{model.inspect}")
+    end
+  end
+
   class DestroyError < Error
     def initialize(data)
       super("Destroy has changed more than 1 row; data: #{data.inspect}")
     end
   end
 
-  class UndefinedConfig < Error
-    def initialize(model)
-      super("Config not defined for model; model: #{model.inspect}")
+  class UnprovidedEventTargetKeysError < Error
+    # @param target_keys [Array<Symbol,String>]
+    # @param target_attributes [Hash<Symbol|String,Any>]
+    def initialize(target_keys, target_attributes)
+      super(<<~MSG.squish)
+        Some target keys not found in received attributes!
+        (Expects: #{target_keys}, Actual: #{target_attributes.keys})
+      MSG
     end
   end
 end

data/lib/table_sync/event_actions.rb

@@ -3,6 +3,12 @@
 module TableSync
   module EventActions
     def update(data) # rubocop:disable Metrics/MethodLength
+      data.each_value do |attribute_set|
+        attribute_set.each do |attributes|
+          prevent_incomplete_event!(attributes)
+        end
+      end
+
       model.transaction do
         args = {
           data: data,
@@ -21,7 +27,7 @@ module TableSync
         end
 
         return if results.empty?
-        raise TableSync::UpsertError.new(**args) unless correct_keys?(results)
+        raise TableSync::UpsertError.new(**args) unless expected_update_result?(results)
 
         @config.model.after_commit do
           @config.callback_registry.get_callbacks(kind: :after_commit, event: :update).each do |cb|
@@ -33,7 +39,8 @@ module TableSync
 
     def destroy(data)
       attributes = data.first || {}
-      target_attributes = attributes.select { |key| target_keys.include?(key) }
+      target_attributes = attributes.select { |key, _value| target_keys.include?(key) }
+      prevent_incomplete_event!(target_attributes)
 
       model.transaction do
         @config.callback_registry.get_callbacks(kind: :before_commit, event: :destroy).each do |cb|
@@ -56,8 +63,14 @@ module TableSync
       end
     end
 
-    def correct_keys?(query_results)
+    def expected_update_result?(query_results)
       query_results.uniq { |d| d.slice(*target_keys) }.size == query_results.size
     end
+
+    def prevent_incomplete_event!(attributes)
+      unless target_keys.all?(&attributes.keys.method(:include?))
+        raise TableSync::UnprovidedEventTargetKeysError.new(target_keys, attributes)
+      end
+    end
   end
 end

data/lib/table_sync/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module TableSync
-  VERSION = "1.10.0"
+  VERSION = "1.11.0"
 end

data/table_sync.gemspec

@@ -32,7 +32,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "coveralls", "~> 0.8"
   spec.add_development_dependency "rspec", "~> 3.8"
-  spec.add_development_dependency "rubocop-config-umbrellio", "~> 0.70"
+  spec.add_development_dependency "rubocop-config-umbrellio", "~> 0.74"
   spec.add_development_dependency "simplecov", "~> 0.16"
 
   spec.add_development_dependency "activejob", ">= 4.2.11"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: table_sync
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.11.0
 platform: ruby
 authors:
 - Umbrellio
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-28 00:00:00.000000000 Z
+date: 2019-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: memery
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.70'
+        version: '0.74'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.70'
+        version: '0.74'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement