table_cloth 0.2.0 → 0.2.1

data/lib/table_cloth/base.rb

@@ -3,6 +3,8 @@ module TableCloth
     NoPresenterError = Class.new(Exception)
 
     attr_reader :collection, :view
+    class_attribute :config, instance_accessor: false
+    self.config = Class.new { include ConfigurableElements }
 
     def initialize(collection, view)
       @collection = collection
@@ -16,7 +18,7 @@ module TableCloth
     end
 
     def columns
-      @columns ||=self.class.columns.each_with_object({}) do |(column_name, column), columns|
+      @columns ||= self.class.columns.each_with_object({}) do |(column_name, column), columns|
         columns[column_name] = column if column.available?(self)
       end
     end
@@ -26,10 +28,6 @@ module TableCloth
     end
 
     class << self
-      def config
-        @config ||= Class.new { include ConfigurableElements }
-      end
-
       def presenter(klass=nil)
         return @presenter = klass if klass
 

data/lib/table_cloth/version.rb

@@ -1,3 +1,3 @@
 module TableCloth
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/lib/table_cloth.rb

@@ -1,4 +1,5 @@
 require 'action_view'
+require 'active_support/core_ext/class'
 require 'table_cloth/version'
 require 'table_cloth/configurable_elements'
 require 'table_cloth/base'
@@ -21,7 +22,7 @@ module TableCloth
   end
 
   def config_for(type)
-    Configuration.config_for(type)
+    Configuration.config_for(type).dup
   end
   module_function :config_for
 end

data/spec/lib/base_spec.rb

@@ -149,4 +149,18 @@ describe TableCloth::Base do
       subject.columns[:actions].should have(2).actions
     end
   end
+
+  context "configuration" do
+    subject { Class.new(TableCloth::Base) }
+    let(:sibling1_class) { Class.new(subject) }
+    let(:sibling2_class) { Class.new(subject) }
+
+    it "allows configuration" do
+      expect { subject.config.table.cellpadding = '0' }.to change { subject.config.table.cellpadding }.to('0')
+    end
+
+    it "doesn't interfere with configuration of parent classes" do
+      expect { sibling1_class.config.table.cellpadding = '0' }.not_to change { sibling2_class.config.table.cellpadding }
+    end
+  end
 end

data/spec/lib/presenter_spec.rb

@@ -49,22 +49,16 @@ describe TableCloth::Presenter do
   end
 
   context 'tags' do
-    before(:all) { TableCloth::Configuration.table.class = 'stuff' }
     it '.wrapper_tag includes config for a tag in block form' do
-      table = subject.wrapper_tag(:table) do
-        'Hello'
-      end
-      table = Nokogiri::HTML(table)
-
-      table.at_xpath('//table')[:class].should == 'stuff'
-      table.at_xpath('//table').text.should include 'Hello'
+      TableCloth::Configuration.table.should_receive(:to_hash).and_return(class: "stuff")
+      table = subject.wrapper_tag(:table) { "Hello "}
+      Nokogiri::HTML(table).at_xpath('//table')[:class].should == 'stuff'
     end
 
     it '.wrapper_tag includes config for a tag without a block' do
+      TableCloth::Configuration.table.should_receive(:to_hash).and_return(class: "stuff")
       table = subject.wrapper_tag(:table, 'Hello')
-      table = Nokogiri::HTML(table)
-      table.at_xpath('//table')[:class].should == 'stuff'
-      table.at_xpath('//table').text.should include 'Hello'
+      Nokogiri::HTML(table).at_xpath('//table')[:class].should == 'stuff'
     end
   end
 end

data/spec/lib/presenters/default_spec.rb

@@ -11,14 +11,7 @@ describe TableCloth::Presenters::Default do
   end
 
   let(:objects) do
-    3.times.map do |n|
-      num = n+1
-      DummyModel.new.tap do |d|
-        d.id    = num # Wat
-        d.email = "robert#{num}@example.com"
-        d.name  = "robert#{num}"
-      end 
-    end
+    3.times.map {|n| dummy_model.dup.tap {|dm| dm.id = n+1 } }
   end
 
   let(:view_context) { ActionView::Base.new }
@@ -190,8 +183,8 @@ describe TableCloth::Presenters::Default do
     include_examples "table configuration"
 
     context "is extendable" do
-      let(:dummy_table) do 
-        table = Class.new(TableCloth::Base) do
+      let(:parent_table) do
+        Class.new(TableCloth::Base) do
           column :email
 
           config.table.class = 'table2'
@@ -201,7 +194,10 @@ describe TableCloth::Presenters::Default do
           config.tr.class    = 'tr2'
           config.td.class    = 'td2'
         end
-        Class.new(table)
+      end
+
+      let(:dummy_table) do
+        Class.new(parent_table)
       end
       
       include_examples "table configuration"

data/spec/spec_helper.rb

@@ -11,5 +11,5 @@ RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
-  config.order = 'random'
+  config.include LetDeclarations
 end

data/spec/support/let_declarations.rb

@@ -0,0 +1,2 @@
+module LetDeclarations
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: table_cloth
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-01 00:00:00.000000000 Z
+date: 2012-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -167,6 +167,7 @@ files:
 - spec/support/dummy_table.rb
 - spec/support/dummy_table_with_actions.rb
 - spec/support/dummy_table_with_value_options.rb
+- spec/support/let_declarations.rb
 - spec/support/shared_config_examples.rb
 - spec/support/view_mocks.rb
 - table_cloth.gemspec
@@ -210,5 +211,6 @@ test_files:
 - spec/support/dummy_table.rb
 - spec/support/dummy_table_with_actions.rb
 - spec/support/dummy_table_with_value_options.rb
+- spec/support/let_declarations.rb
 - spec/support/shared_config_examples.rb
 - spec/support/view_mocks.rb