table-for 3.6.2 → 3.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0ed186963c980c1b8a756b21fb207d93817e6a1b09e0d39a5048af3cd44675bd
-  data.tar.gz: ea3427c27fcd27836a6d1902b8c13452f0fe545eac441305bb4503a12b1b208f
+  metadata.gz: f1aabb31a760c3e8a7a3daebaaa15bc31bb048a6e32ed6ea0bff5a806bee36ff
+  data.tar.gz: 8fd9a0f9f7d84599be3a1451a8aaebf56fa591c977cb5d3d243d001caa291c7d
 SHA512:
-  metadata.gz: 5aa25b5877ce491bbcdbab566bb05fe42b9cf204f587be3a380dce5244ea3d1a8d34220dd75ed2fb33f568329cf41e7abbc9a1d4f9fb1db49906ad773c27ee82
-  data.tar.gz: a29d3f3548725d57b84ba350c449be5d2afe10c012ef0bfadacfbc4f98e9ad65e9128770ce932cfc5a5d1dbaa1b161c2a5d48a281dbacbc3ba3647e8c964bf5e
+  metadata.gz: 9496076ac639882e9f6efbfc081e86ca1ac2f45c4137b9aec6044089cf96bb0f2b6a3647ae442f0ba75ea910acdbc2a781700ff8888995f093a5045988364998
+  data.tar.gz: ed794daad6b98d873a98ceb996589b47dc9586b495e8911f71a6199a768a4a05bf7196bc2f9fa3a424b1b66e1000e41874f6242374383d3f122997dfee191ec8

data/CHANGELOG.rdoc

@@ -1,3 +1,9 @@
+3.7.0
+* The page param is no longer included in the sort links generated for columns. This was pointed out 
+by {karwank}[https://github.com/karwank] as unexpected behavior. I am bumping the minor version of the 
+gem since this does change the default behavior, in case anybody is not expecting the default sort behavior to 
+have been updated.
+
 3.6.2
 * Added :sort_modes option to be able to specify sort_modes on a column by column basis (thanks {karwank}[https://github.com/karwank])
 * Fixed bug preventing action and controller from being removed in pagination link params in some versions of Rails (thanks {karwank}[https://github.com/karwank])

data/lib/table_for/base.rb

@@ -117,6 +117,7 @@ module TableFor
         parameters = view.params.merge(:order => order, :sort_mode => next_sort_mode)
         parameters.delete(:action)
         parameters.delete(:controller)
+        parameters.delete(:page)
         if parameters.respond_to?(:to_unsafe_h)
           parameters = parameters.to_unsafe_h
         end

data/lib/table_for/version.rb

@@ -1,3 +1,3 @@
 module TableFor
-  VERSION = "3.6.2"
+  VERSION = "3.7.0"
 end

data/spec/table_for/base_spec.rb

@@ -138,8 +138,8 @@ describe TableFor::Base do
       @base.header_sort_link(@column, :order => "first_name,last_name", :sortable => true).should eql "my link"
     end
 
-    it "should remove the action and controller params when generating the url" do
-      @view.expects(:params).at_least_once.returns(:controller => "users", :action => "show")
+    it "should remove the action, controller, and page params when generating the url" do
+      @view.expects(:params).at_least_once.returns(:controller => "users", :action => "show", page: 50)
       @view.expects(:link_to).with(@column.name.to_s.titleize, "?order=#{@column.name}&sort_mode=asc").returns "my link"
       @base.header_sort_link(@column, :sortable => true) { @column.name.to_s.titleize }.should eql "my link"
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: table-for
 version: !ruby/object:Gem::Version
-  version: 3.6.2
+  version: 3.7.0
 platform: ruby
 authors:
 - Andrew Hunter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-16 00:00:00.000000000 Z
+date: 2019-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails