table-for 3.4.0 → 3.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8719b9d60d0575d808cd0e59db4da06669581cff
-  data.tar.gz: 5365a9d7259191c5b11895eb47320663a89b68c1
+  metadata.gz: a3533f2825ffff2f3b66f417e90842b92cf0aa7b
+  data.tar.gz: f289fb64ff8ee7bc3325193caad41cd14dba36ba
 SHA512:
-  metadata.gz: c4a894bbb863ca45c866c1710ea119cdf11abc2cf8355d907ff4f89a63e6ee83ea7495421f43fcf1a7335a9672186d4a098afec49a76ee0e94a0e2742e06d06e
-  data.tar.gz: 0a9e4f2628c39dfe85acd549ea1aee6553437b9fdc633489e377c196b63b50a35312471bff12752789392d542b5321af7503f6089351c0df66ec823e77c61309
+  metadata.gz: 87a9393fb42dd5506b3c2ea181703b0d048c181f7d4e40b7cf8b13438d35b04f2d6b5d681bee59e555877fc6d061df40abffe61284fcf93cad3ccb0c5611d3f4
+  data.tar.gz: 7d084afb99618c8f1b5952de9020ae821ff313b807d3e7f9d833ddb4e2b4f8361033aefa99dbb6cc8608b01c5ea54e937b65b05a7753b085f8285ea990bd649d

data/CHANGELOG.rdoc

@@ -1,3 +1,7 @@
+3.4.1
+* Fixed bug introduced in version 3.4.0 where link_namespace defined globally
+on the table_for call was getting completely ignored. Thanks @panyamin for reporting.
+
 3.4.0
 * Links options that are applied to a column will now generate the link even if you override
 column. In haml, this example pointed out by @noctivityinc, now works:

data/lib/table_for/base.rb

@@ -33,7 +33,11 @@ module TableFor
           url = if options[:link_url]
             call_with_params(options[:link_url], record)
           else
-            [options[:link_action], options[:link_namespace], record].flatten.compact
+            [
+              options[:link_action],
+              options[:link_namespace] || global_options[:link_namespace],
+              record
+            ].flatten.compact
           end
           html_options = {data: {}}
           html_options[:data][:method] = options[:link_method] if options[:link_method].present?

data/lib/table_for/version.rb

@@ -1,3 +1,3 @@
 module TableFor
-  VERSION = "3.4.0"
+  VERSION = "3.4.1"
 end

data/spec/integration/table_for_spec.rb

@@ -548,6 +548,21 @@ describe "table_for" do
       html_includes?(buffer, "<a href='/admin/users/1'>andrew.hunter@livingsocial.com</a>")
     end
 
+    it "should use the globally defined link_namespace unless defined directly on the column" do
+      @view.class.send(:define_method, :admin_user_path) do |user|
+        "/admin/users/#{user.id}"
+      end
+      @view.class.send(:define_method, :profile_user_path) do |user|
+        "/profile/users/#{user.id}"
+      end
+      buffer = @view.table_for @users, link_namespace: :admin do |table|
+        table.column :email, link: true
+        table.column :id, link_namespace: :profile, link: true
+      end
+      html_includes?(buffer, "<a href='/admin/users/1'>andrew.hunter@livingsocial.com</a>")
+      html_includes?(buffer, "<a href='/profile/users/1'>1</a>")
+    end
+
     it "should be able to replace an individual column data contents block" do
       buffer = @view.table_for @users[0,1] do |table|
         table.column :email, :header => "Email Address"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: table-for
 version: !ruby/object:Gem::Version
-  version: 3.4.0
+  version: 3.4.1
 platform: ruby
 authors:
 - Andrew Hunter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-22 00:00:00.000000000 Z
+date: 2016-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails