syslogger 1.6.5 → 1.6.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 10037fda0f96cf2e4073a7b721083696f1b30404
-  data.tar.gz: e483814598921fe12e703c5b519abe904121b290
+SHA256:
+  metadata.gz: f36b2f4ea6682e821787ea055e08b01368b4568544bc41a71dd93bde6ed0390b
+  data.tar.gz: b951b4952c20d20882b161675785cbcb2430b1c9d229d01d56f3c9c4152d7fc9
 SHA512:
-  metadata.gz: 4eff79de93b2c28c2ec407d6d4675f815698894f0b4f2ceb79e9a7f0d96e54655310f96ccfa69244f3c742daa55e242491a09499a9f41827b40db969672d5be3
-  data.tar.gz: 66deff30ebd629b8d0251981b0c8f4530c72764bb0c56bdfdc97ba5ca403993626e098f106717020dbdc1abe0287dd3b53d3507bd33c75a36483a69035748872
+  metadata.gz: 2567599956b7b79965b7617e1bbb2caecbed9c482bf7d3792e25247133bb4179ac31fc88109d03223172677734080a169bdd869ba232765a2022a538e4dcb8b6
+  data.tar.gz: 262ef1518804b333cb846a40b2607f7c5389276dbb10a0dc9bb6e19dc9c7819aa67f6a821d36b69abc9d886f2b2066fda66572b2f790cdd40f43872d29f4e99d

data/.github/workflows/ci.yml

@@ -0,0 +1,58 @@
+---
+name: CI
+
+on:
+  - push
+  - pull_request
+
+jobs:
+  rspec:
+    runs-on: ubuntu-20.04
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby:
+          - '3.0'
+          - '2.7'
+          - '2.6'
+          - '2.5'
+        rails:
+          - rails_5.2.4
+          - rails_6.0.3
+          - rails_6.1.0
+        exclude:
+          - ruby: '3.0'
+            rails: rails_5.2.4
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+
+      - name: Setup Ruby cache
+        uses: actions/cache@v2
+        with:
+          path: "${GITHUB_WORKSPACE}/vendor/bundle"
+          key: ${{ runner.os }}-gems-${{ matrix.ruby }}-${{ matrix.rails }}-${{ hashFiles('**/Gemfile.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-gems-${{ matrix.ruby }}-${{ matrix.rails }}-
+
+      - name: Bundle
+        env:
+          RAILS_VERSION: ${{ matrix.rails }}
+        run: |
+          export BUNDLE_GEMFILE="${GITHUB_WORKSPACE}/gemfiles/${RAILS_VERSION}.gemfile"
+          gem install bundler
+          bundle config path "${GITHUB_WORKSPACE}/vendor/bundle"
+          bundle install --jobs 4 --retry 3
+
+      - name: RSpec
+        env:
+          RAILS_VERSION: ${{ matrix.rails }}
+        run: |
+          export BUNDLE_GEMFILE="${GITHUB_WORKSPACE}/gemfiles/${RAILS_VERSION}.gemfile"
+          bundle exec rake

data/.gitignore

@@ -1,26 +1,17 @@
-## MAC OS
-.DS_Store
+# Ignore bundler config.
+/.bundle
 
-## TEXTMATE
-*.tmproj
-tmtags
+# Ignore Gemfile.lock
+/Gemfile.lock
+/gemfiles/*.lock
+/gemfiles/.bundle
 
-## EMACS
-*~
-\#*
-.\#*
+# Ignore test files
+/coverage
+/tmp
 
-## VIM
-*.swp
-
-## PROJECT::GENERAL
-coverage
-rdoc
-pkg
-Gemfile.lock
-
-## PROJECT::SPECIFIC
-
-## RVM
-.rvmrc
+# RVM files
+/.ruby-version
 
+# Gem files
+/*.gem

data/.rubocop.yml

@@ -0,0 +1,8 @@
+AllCops:
+  Exclude:
+    - bin/*
+    - gemfiles/*
+    - spec/**/*
+
+Metrics/LineLength:
+  Enabled: false

data/Appraisals

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+RAILS_VERSIONS = %w[
+  5.2.4
+  6.0.3
+  6.1.0
+].freeze
+
+RAILS_VERSIONS.each do |version|
+  appraise "rails_#{version}" do
+    gem 'activejob', version
+  end
+end

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # CHANGELOG
 
+## 1.6.6
+
+* Drop support of Ruby 2.3
+* Drop support of Ruby 2.4
+* Add support of Ruby 2.6
+* Add support of Ruby 2.7
+* Add support of Ruby 3.0
+* Drop support of Rails 5.1
+* Add support of Rails 6.0
+* Add support of Rails 6.1
+* Add binstubs to ease development
+* Migrate from Travis to Github Actions
+
 ## 1.6.5
 
 * Merge [Fixnum type is deprecated](https://github.com/crohr/syslogger/pull/42) (thanks thesmart)

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec

data/Guardfile

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+guard :rspec, cmd: 'bundle exec rspec' do
+  require 'guard/rspec/dsl'
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+end

data/README.md

@@ -4,7 +4,7 @@
 [![GitHub release](https://img.shields.io/github/release/crohr/syslogger.svg)](https://github.com/crohr/syslogger/releases/latest)
 [![Gem](https://img.shields.io/gem/v/syslogger.svg)](https://rubygems.org/gems/syslogger)
 [![Gem](https://img.shields.io/gem/dtv/syslogger.svg)](https://rubygems.org/gems/syslogger)
-[![Build Status](https://travis-ci.org/crohr/syslogger.svg?branch=master)](https://travis-ci.org/crohr/syslogger)
+[![CI](https://github.com/crohr/syslogger/workflows/CI/badge.svg)](https://github.com/crohr/syslogger/actions)
 
 A drop-in replacement for the standard Logger Ruby library, that logs to the syslog instead of a log file.
 Contrary to the SyslogLogger library, you can specify the facility and the syslog options.

data/Rakefile

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rdoc/task'
 

data/bin/_guard-core

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application '_guard-core' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("guard", "_guard-core")

data/bin/appraisal

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'appraisal' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("appraisal", "appraisal")

data/bin/guard

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'guard' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("guard", "guard")

data/bin/rake

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rake' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rake", "rake")

data/bin/rspec

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rspec' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rspec-core", "rspec")

data/bin/rubocop

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rubocop' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rubocop", "rubocop")

data/gemfiles/rails_5.2.4.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activejob", "5.2.4"
+
+gemspec path: "../"

data/gemfiles/rails_6.0.3.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activejob", "6.0.3"
+
+gemspec path: "../"

data/gemfiles/rails_6.1.0.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "activejob", "6.1.0"
+
+gemspec path: "../"

data/lib/syslogger.rb

@@ -1,13 +1,14 @@
+require 'forwardable'
 require 'syslog'
 require 'logger'
-require 'thread'
 
 class Syslogger
+  extend Forwardable
 
   MUTEX = Mutex.new
 
-  attr_reader :level, :ident, :options, :facility, :max_octets
-  attr_accessor :formatter
+  attr_reader   :level, :options, :facility
+  attr_accessor :ident, :formatter, :max_octets
 
   MAPPING = {
     Logger::DEBUG   => Syslog::LOG_DEBUG,
@@ -18,16 +19,23 @@ class Syslogger
     Logger::UNKNOWN => Syslog::LOG_ALERT
   }.freeze
 
-  #
+  LEVELS = %w[debug info warn error fatal unknown].freeze
+
   # Initializes default options for the logger
+  #
   # <tt>ident</tt>:: the name of your program [default=$0].
+  #
   # <tt>options</tt>::  syslog options [default=<tt>Syslog::LOG_PID | Syslog::LOG_CONS</tt>].
+  #
   #                     Correct values are:
   #                       LOG_CONS    : writes the message on the console if an error occurs when sending the message;
   #                       LOG_NDELAY  : no delay before sending the message;
   #                       LOG_PERROR  : messages will also be written on STDERR;
   #                       LOG_PID     : adds the process number to the message (just after the program name)
-  # <tt>facility</tt>:: the syslog facility [default=nil] Correct values include:
+  #
+  # <tt>facility</tt>:: the syslog facility [default=nil]
+  #
+  #                     Correct values include:
   #                       Syslog::LOG_DAEMON
   #                       Syslog::LOG_USER
   #                       Syslog::LOG_SYSLOG
@@ -42,45 +50,37 @@ class Syslogger
   #   logger.debug "debug message"
   #   logger.info "my_subapp" { "Some lazily computed message" }
   #
-  def initialize(ident = $0, options = Syslog::LOG_PID | Syslog::LOG_CONS, facility = nil)
+  def initialize(ident = $PROGRAM_NAME, options = Syslog::LOG_PID | Syslog::LOG_CONS, facility = nil)
     @ident     = ident
     @options   = options || (Syslog::LOG_PID | Syslog::LOG_CONS)
     @facility  = facility
     @level     = Logger::INFO
-    @formatter = proc do |_, _, _, msg|
-      msg
-    end
+    @formatter = SimpleFormatter.new
   end
 
-  %w{debug info warn error fatal unknown}.each do |logger_method|
+  LEVELS.each do |logger_method|
     # Accepting *args as message could be nil.
     #  Default params not supported in ruby 1.8.7
     define_method logger_method.to_sym do |*args, &block|
       severity = Logger.const_get(logger_method.upcase)
-      return true if @level > severity
+      return true if level > severity
+
       add(severity, nil, args.first, &block)
     end
 
-    unless logger_method == 'unknown'
-      define_method "#{logger_method}?".to_sym do
-        @level <= Logger.const_get(logger_method.upcase)
-      end
+    next if logger_method == 'unknown'.freeze
+
+    define_method "#{logger_method}?".to_sym do
+      level <= Logger.const_get(logger_method.upcase)
     end
   end
 
-  # Log a message at the Logger::INFO level. Useful for use with Rack::CommonLogger
+  # Log a message at the Logger::INFO level.
   def write(msg)
     add(Logger::INFO, msg)
   end
-
-  # Logs a message at the Logger::INFO level.
-  def <<(msg)
-    add(Logger::INFO, msg)
-  end
-
-  def puts(msg)
-    add(Logger::INFO, msg)
-  end
+  alias <<   write
+  alias puts write
 
   # Low level method to add a message.
   # +severity+::  the level of the message. One of Logger::DEBUG, Logger::INFO, Logger::WARN, Logger::ERROR, Logger::FATAL, Logger::UNKNOWN
@@ -93,7 +93,7 @@ class Syslogger
       message, progname = progname, nil
     end
     progname ||= @ident
-    mask = Syslog::LOG_UPTO(MAPPING[@level])
+    mask = Syslog::LOG_UPTO(MAPPING[level])
     communication = message || block && block.call
     formatted_communication = clean(formatter.call(severity, Time.now, progname, communication))
 
@@ -101,47 +101,18 @@ class Syslogger
     syslog_add(progname, severity, mask, formatted_communication)
   end
 
-  # Set the max octets of the messages written to the log
-  def max_octets=(max_octets)
-    @max_octets = max_octets
-  end
-
   # Sets the minimum level for messages to be written in the log.
   # +level+:: one of <tt>Logger::DEBUG</tt>, <tt>Logger::INFO</tt>, <tt>Logger::WARN</tt>, <tt>Logger::ERROR</tt>, <tt>Logger::FATAL</tt>, <tt>Logger::UNKNOWN</tt>
   def level=(level)
     @level = sanitize_level(level)
   end
 
-  # Sets the ident string passed along to Syslog
-  def ident=(ident)
-    @ident = ident
-  end
-
   # Tagging code borrowed from ActiveSupport gem
   def tagged(*tags)
-    new_tags = push_tags(*tags)
-    yield self
-  ensure
-    pop_tags(new_tags.size)
-  end
-
-  def push_tags(*tags)
-    tags.flatten.reject { |i| i.respond_to?(:empty?) ? i.empty? : !i }.tap do |new_tags|
-      current_tags.concat(new_tags).uniq!
-    end
+    formatter.tagged(*tags) { yield self }
   end
 
-  def pop_tags(size = 1)
-    current_tags.pop size
-  end
-
-  def clear_tags!
-    current_tags.clear
-  end
-
-  def current_tags
-    Thread.current[:syslogger_tagged_logging_tags] ||= []
-  end
+  def_delegators :formatter, :current_tags, :push_tags, :pop_tags, :clear_tags!
 
   protected
 
@@ -163,40 +134,76 @@ class Syslogger
   def clean(message)
     message = message.to_s.dup
     message.strip! # remove whitespace
-    message.gsub!(/\n/, '\\n') # escape newlines
-    message.gsub!(/%/, '%%') # syslog(3) freaks on % (printf)
-    message.gsub!(/\e\[[^m]*m/, '') # remove useless ansi color codes
+    message.gsub!(/\n/, '\\n'.freeze) # escape newlines
+    message.gsub!(/%/, '%%'.freeze) # syslog(3) freaks on % (printf)
+    message.gsub!(/\e\[[^m]*m/, ''.freeze) # remove useless ansi color codes
     message
   end
 
   private
 
-  def tags_text
-    tags = current_tags
-    if tags.any?
-      clean(tags.collect { |tag| "[#{tag}] " }.join) << ' '
-    end
-  end
-
   def syslog_add(progname, severity, mask, formatted_communication)
     MUTEX.synchronize do
       Syslog.open(progname, @options, @facility) do |s|
         s.mask = mask
-        if self.max_octets
-          buffer = "#{tags_text}"
+        if max_octets
+          buffer = ''
           formatted_communication.bytes do |byte|
             buffer.concat(byte)
             # if the last byte we added is potentially part of an escape, we'll go ahead and add another byte
-            if buffer.bytesize >= self.max_octets && !['%'.ord,'\\'.ord].include?(byte)
+            if buffer.bytesize >= max_octets && !['%'.ord, '\\'.ord].include?(byte)
               s.log(MAPPING[severity], buffer)
               buffer = ''
             end
           end
           s.log(MAPPING[severity], buffer) unless buffer.empty?
         else
-          s.log(MAPPING[severity], "#{tags_text}#{formatted_communication}")
+          s.log(MAPPING[severity], formatted_communication)
         end
       end
     end
   end
+
+  # Borrowed from ActiveSupport.
+  # See: https://github.com/rails/rails/blob/master/activesupport/lib/active_support/tagged_logging.rb
+  class SimpleFormatter < Logger::Formatter
+    # This method is invoked when a log event occurs.
+    def call(_severity, _timestamp, _progname, msg)
+      "#{tags_text}#{msg}"
+    end
+
+    def tagged(*tags)
+      new_tags = push_tags(*tags)
+      yield self
+    ensure
+      pop_tags(new_tags.size)
+    end
+
+    def push_tags(*tags)
+      tags.flatten.reject { |i| i.respond_to?(:empty?) ? i.empty? : !i }.tap do |new_tags|
+        current_tags.concat(new_tags).uniq!
+      end
+    end
+
+    def pop_tags(size = 1)
+      current_tags.pop size
+    end
+
+    def clear_tags!
+      current_tags.clear
+    end
+
+    # Fix: https://github.com/crohr/syslogger/issues/29
+    # See: https://github.com/rails/rails/blob/master/activesupport/lib/active_support/tagged_logging.rb#L47
+    def current_tags
+      # We use our object ID here to avoid conflicting with other instances
+      thread_key = @thread_key ||= "syslogger_tagged_logging_tags:#{object_id}".freeze
+      Thread.current[thread_key] ||= []
+    end
+
+    def tags_text
+      tags = current_tags
+      tags.collect { |tag| "[#{tag}] " }.join if tags.any?
+    end
+  end
 end

data/lib/syslogger/version.rb

@@ -1,3 +1,17 @@
+# frozen_string_literal: true
+
 class Syslogger
-  VERSION = '1.6.5'.freeze
+
+  def self.gem_version
+    Gem::Version.new VERSION::STRING
+  end
+
+  module VERSION
+    MAJOR = 1
+    MINOR = 6
+    TINY  = 6
+    PRE   = nil
+
+    STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.')
+  end
 end

data/spec/spec_helper.rb

@@ -1,5 +1,6 @@
 require 'simplecov'
 require 'rspec'
+require 'active_job'
 
 # Start Simplecov
 SimpleCov.start
@@ -17,5 +18,36 @@ RSpec.configure do |config|
   end
 end
 
+# Module helper for unit tests
+module JobBuffer
+  class << self
+    def clear
+      values.clear
+    end
+
+    def add(value)
+      values << value
+    end
+
+    def values
+      @values ||= []
+    end
+
+    def last_value
+      values.last
+    end
+  end
+end
+
+# Class helper for unit tests
+class HelloJob < ActiveJob::Base
+  def perform(greeter = "David")
+    JobBuffer.add("#{greeter} says hello")
+  end
+end
+
+# Configure I18n otherwise it throws errors in syslog
+I18n.available_locales = [:en]
+
 # Load lib
 require 'syslogger'

data/spec/syslogger_spec.rb

@@ -64,15 +64,19 @@ describe Syslogger do
     end
 
     it 'should clean formatted message' do
+      formatter = Class.new(Syslogger::SimpleFormatter) do
+        def call(severity, timestamp, progname, msg)
+          msg.split(//).join('%')
+        end
+      end
+
       allow(Syslog).to receive(:open).and_yield(fake_syslog)
       expect(fake_syslog).to receive(:log).with(Syslog::LOG_INFO, "m%%e%%s%%s%%a%%g%%e")
 
       original_formatter = logger.formatter
 
       begin
-        logger.formatter = proc do |severity, datetime, progname, msg|
-          msg.split(//).join('%')
-        end
+        logger.formatter = formatter.new
         logger.add(Logger::INFO, 'message')
       ensure
         logger.formatter = original_formatter
@@ -118,11 +122,14 @@ describe Syslogger do
     end
 
     it 'should apply the log formatter to the message' do
+      formatter = Class.new(Syslogger::SimpleFormatter) do
+        def call(severity, timestamp, progname, msg)
+          "test #{msg}!"
+        end
+      end
       allow(Syslog).to receive(:open).and_yield(fake_syslog)
       expect(fake_syslog).to receive(:log).with(Syslog::LOG_INFO, 'test message!')
-      logger.formatter = proc do |severity, datetime, progname, msg|
-        "test #{msg}!"
-      end
+      logger.formatter = formatter.new
       logger.add(Logger::INFO, 'message')
     end
   end
@@ -295,6 +302,19 @@ describe Syslogger do
     end
   end
 
+  # Fix https://github.com/crohr/syslogger/issues/29
+  describe '#formatter' do
+    let(:logger) { Syslogger.new('my_app', Syslog::LOG_PID, Syslog::LOG_USER) }
+
+    it 'should not raise error' do
+      ActiveJob::Base.logger = logger
+      expect(logger).to receive(:info).at_least(1).times.with(nil)
+      expect {
+        HelloJob.perform_later "Cristian"
+      }.to_not raise_error
+    end
+  end
+
   describe '#push_tags' do
     let(:logger) { Syslogger.new('my_app', Syslog::LOG_PID, Syslog::LOG_USER) }
     after(:each) { logger.clear_tags! }

data/syslogger.gemspec

@@ -1,10 +1,10 @@
-# -*- encoding: utf-8 -*-
-$:.push File.expand_path('../lib', __FILE__)
-require 'syslogger/version'
+# frozen_string_literal: true
+
+require_relative 'lib/syslogger/version'
 
 Gem::Specification.new do |s|
   s.name        = 'syslogger'
-  s.version     = Syslogger::VERSION
+  s.version     = Syslogger::VERSION::STRING
   s.platform    = Gem::Platform::RUBY
   s.authors     = ['Cyril Rohr']
   s.email       = ['cyril.rohr@gmail.com']
@@ -12,16 +12,21 @@ Gem::Specification.new do |s|
   s.summary     = 'Dead simple Ruby Syslog logger'
   s.description = 'Same as SyslogLogger, but without the ridiculous number of dependencies and with the possibility to specify the syslog facility'
   s.license     = 'MIT'
+  s.metadata    = {
+    'homepage_uri'    => 'https://github.com/crohr/syslogger',
+    'changelog_uri'   => 'https://github.com/crohr/syslogger/blob/master/CHANGELOG.md',
+    'source_code_uri' => 'https://github.com/crohr/syslogger',
+    'bug_tracker_uri' => 'https://github.com/crohr/syslogger/issues'
+  }
+
+  s.files = `git ls-files`.split("\n")
 
+  s.add_development_dependency 'activejob'
+  s.add_development_dependency 'appraisal'
+  s.add_development_dependency 'guard-rspec'
   s.add_development_dependency 'rake'
-  s.add_development_dependency 'rspec'
   s.add_development_dependency 'rdoc'
+  s.add_development_dependency 'rspec'
+  s.add_development_dependency 'rubocop'
   s.add_development_dependency 'simplecov'
-
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.require_paths = ['lib']
-
-  s.rdoc_options = ['--charset=UTF-8']
 end

metadata

@@ -1,15 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: syslogger
 version: !ruby/object:Gem::Version
-  version: 1.6.5
+  version: 1.6.6
 platform: ruby
 authors:
 - Cyril Rohr
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-11-16 00:00:00.000000000 Z
+date: 2021-02-09 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activejob
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -24,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rdoc
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -39,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rdoc
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -74,13 +130,25 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
-- ".travis.yml"
+- ".rubocop.yml"
+- Appraisals
 - CHANGELOG.md
 - Gemfile
+- Guardfile
 - LICENSE
 - README.md
 - Rakefile
+- bin/_guard-core
+- bin/appraisal
+- bin/guard
+- bin/rake
+- bin/rspec
+- bin/rubocop
+- gemfiles/rails_5.2.4.gemfile
+- gemfiles/rails_6.0.3.gemfile
+- gemfiles/rails_6.1.0.gemfile
 - lib/syslogger.rb
 - lib/syslogger/version.rb
 - spec/spec_helper.rb
@@ -89,10 +157,13 @@ files:
 homepage: http://github.com/crohr/syslogger
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
-rdoc_options:
-- "--charset=UTF-8"
+metadata:
+  homepage_uri: https://github.com/crohr/syslogger
+  changelog_uri: https://github.com/crohr/syslogger/blob/master/CHANGELOG.md
+  source_code_uri: https://github.com/crohr/syslogger
+  bug_tracker_uri: https://github.com/crohr/syslogger/issues
+post_install_message:
+rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
@@ -106,11 +177,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
-signing_key: 
+rubygems_version: 3.2.7
+signing_key:
 specification_version: 4
 summary: Dead simple Ruby Syslog logger
-test_files:
-- spec/spec_helper.rb
-- spec/syslogger_spec.rb
+test_files: []

data/.travis.yml

@@ -1,9 +0,0 @@
-dist: trusty
-language: ruby
-sudo: false
-cache: bundler
-rvm:
-  - 2.4.2
-  - 2.3.5
-  - 2.2.8
-  - jruby-9.1.9.0