syslogger 1.2.2 → 1.2.3

data/lib/syslogger.rb

@@ -2,11 +2,11 @@ require 'syslog'
 require 'logger'
 
 class Syslogger
-  
-  VERSION = "1.2.2"
-  
+
+  VERSION = "1.2.3"
+
   attr_reader :level, :ident, :options, :facility
-  
+
   MAPPING = {
     Logger::DEBUG => Syslog::LOG_DEBUG,
     Logger::INFO => Syslog::LOG_INFO,
@@ -15,15 +15,15 @@ class Syslogger
     Logger::FATAL => Syslog::LOG_ERR,
     Logger::UNKNOWN => Syslog::LOG_ALERT
   }
-  
-  # 
+
+  #
   # Initializes default options for the logger
   # <tt>ident</tt>:: the name of your program [default=$0].
-  # <tt>options</tt>::  syslog options [default=<tt>Syslog::LOG_PID | Syslog::LOG_CONS</tt>].    
-  #                     Correct values are:   
-  #                       LOG_CONS    : writes the message on the console if an error occurs when sending the message;  
-  #                       LOG_NDELAY  : no delay before sending the message;  
-  #                       LOG_PERROR  : messages will also be written on STDERR;  
+  # <tt>options</tt>::  syslog options [default=<tt>Syslog::LOG_PID | Syslog::LOG_CONS</tt>].
+  #                     Correct values are:
+  #                       LOG_CONS    : writes the message on the console if an error occurs when sending the message;
+  #                       LOG_NDELAY  : no delay before sending the message;
+  #                       LOG_PERROR  : messages will also be written on STDERR;
   #                       LOG_PID     : adds the process number to the message (just after the program name)
   # <tt>facility</tt>:: the syslog facility [default=nil] Correct values include:
   #                       Syslog::LOG_DAEMON
@@ -32,55 +32,60 @@ class Syslogger
   #                       Syslog::LOG_LOCAL2
   #                       Syslog::LOG_NEWS
   #                       etc.
-  # 
+  #
   # Usage:
   #   logger = Syslogger.new("my_app", Syslog::LOG_PID | Syslog::LOG_CONS, Syslog::LOG_LOCAL0)
   #   logger.level = Logger::INFO # use Logger levels
   #   logger.warn "warning message"
   #   logger.debug "debug message"
-  # 
+  #
   def initialize(ident = $0, options = Syslog::LOG_PID | Syslog::LOG_CONS, facility = nil)
     @ident = ident
     @options = options || (Syslog::LOG_PID | Syslog::LOG_CONS)
     @facility = facility
     @level = Logger::INFO
   end
-  
+
   %w{debug info warn error fatal unknown}.each do |logger_method|
     define_method logger_method.to_sym do |message|
       add(Logger.const_get(logger_method.upcase), message)
     end
-    
+
     unless logger_method == 'unknown'
       define_method "#{logger_method}?".to_sym do
         @level <= Logger.const_get(logger_method.upcase)
       end
     end
   end
-  
+
   # Logs a message at the Logger::INFO level.
   def <<(msg)
     add(Logger::INFO, msg)
   end
-  
+
   # Low level method to add a message.
   # +severity+::  the level of the message. One of Logger::DEBUG, Logger::INFO, Logger::WARN, Logger::ERROR, Logger::FATAL, Logger::UNKNOWN
   # +message+:: the message string. If nil, the method will call the block and use the result as the message string.
   # +progname+:: optionally, a overwrite the program name that appears in the log message.
   def add(severity, message = nil, progname = nil, &block)
     progname ||= @ident
-    Syslog.open(progname, @options, @facility) { |s| 
+    Syslog.open(progname, @options, @facility) { |s|
       s.mask = Syslog::LOG_UPTO(MAPPING[@level])
-      # substitute '%' for '%%' before logging
-      # so that syslog won't complain about malformed characters
-      s.log(MAPPING[severity], (message || block.call).to_s.gsub(/%/, '%%'))
+      s.log(MAPPING[severity], clean(message || block.call))
     }
   end
-  
+
   # Sets the minimum level for messages to be written in the log.
   # +level+:: one of <tt>Logger::DEBUG</tt>, <tt>Logger::INFO</tt>, <tt>Logger::WARN</tt>, <tt>Logger::ERROR</tt>, <tt>Logger::FATAL</tt>, <tt>Logger::UNKNOWN</tt>
   def level=(level)
     @level = level
   end
-  
-end
+
+  protected
+
+  # Borrowed from SyslogLogger.
+  def clean(message)
+    # syslog(3) freaks on % (printf)
+    message.strip.gsub(/%/, '%%')
+  end
+end

data/spec/syslogger_spec.rb

@@ -57,6 +57,12 @@ describe "Syslogger" do
       syslog.should_receive(:log).with(Syslog::LOG_INFO, "%%me%%ssage%%")
       @logger.add(Logger::INFO, "%me%ssage%")
     end
+
+    it "should strip the :message" do
+      Syslog.stub(:open).and_yield(syslog=mock("syslog", :mask= => true))
+      syslog.should_receive(:log).with(Syslog::LOG_INFO, "message")
+      @logger.add(Logger::INFO, "\n\nmessage  ")
+    end
   end # describe "add"
   
   describe ":level? methods" do

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 2
-  - 2
-  version: 1.2.2
+  - 3
+  version: 1.2.3
 platform: ruby
 authors: 
 - Cyril Rohr
@@ -14,14 +14,13 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-06 00:00:00 +01:00
+date: 2011-02-07 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rake
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
@@ -35,7 +34,6 @@ dependencies:
   name: rspec
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
@@ -71,7 +69,6 @@ rdoc_options:
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
@@ -80,7 +77,6 @@ required_ruby_version: !ruby/object:Gem::Requirement
       - 8
       version: "1.8"
 required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
@@ -91,7 +87,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: Dead simple Ruby Syslog logger