sys-proctable 0.8.0-x86-linux → 0.8.1-x86-linux

data/CHANGES

@@ -1,3 +1,13 @@
+== 0.8.1 - 6-Apr-2009
+* The Linux and Solaris libraries now handle the possibility of a process
+  terminating in the middle of a read more gracefully. If that happens, they
+  merely skip to the next record, i.e. it's all or nothing. Thanks go to
+  Heejong Lee for the spot and patch.
+* Fixed a bug in the Linux version where embedded nulls were not being
+  stripped out of the cmdline data.
+* Added the comm alias back to the Solaris version. Thanks go to Jun Young Kim
+  for the spot.
+
 == 0.8.0 - 26-Jan-2009
 * The Linux and Solaris versions of this library are now pure Ruby. Be warned,
   however, that only Solaris 8 and later are now supported. This may change

data/lib/sys/proctable.rb

@@ -8,7 +8,7 @@ module Sys
       private_class_method :new
 
       # The version of the sys-proctable library
-      VERSION = '0.8.0'
+      VERSION = '0.8.1'
 
       private
 
@@ -87,6 +87,12 @@ module Sys
       #   # Print process table information for only pid 1001
       #   p ProcTable.ps(1001)
       #
+      #--
+      #  It's possible that a process could terminate while gathering
+      #  information for that process. When that happens, this library
+      #  will simply skip to the next record. In short, this library will
+      #  either return all information for a process, or none at all.
+      #
       def self.ps(pid=nil)
          array  = block_given? ? nil : []
          struct = nil
@@ -99,8 +105,13 @@ module Sys
 
             struct = ProcTableStruct.new
             
-            # Get /proc/<pid>/cmdline information
-            struct.cmdline = IO.read("/proc/#{file}/cmdline")
+            # Get /proc/<pid>/cmdline information. Strip out embedded nulls.
+            begin
+               data = IO.read("/proc/#{file}/cmdline").tr("\000", ' ').strip
+               struct.cmdline = data
+            rescue
+               next # Process terminated, on to the next process
+            end
 
             # Get /proc/<pid>/cwd information
             struct.cwd = File.readlink("/proc/#{file}/cwd") rescue nil
@@ -139,7 +150,7 @@ module Sys
             struct.root = File.readlink("/proc/#{file}/root") rescue nil
 
             # Get /proc/<pid>/stat information
-            stat = IO.read("/proc/#{file}/stat")
+            stat = IO.read("/proc/#{file}/stat") rescue next
 
             # Deal with spaces in comm name. Courtesy of Ara Howard.
             re = %r/\([^\)]+\)/

data/test/test_sys_proctable_all.rb

@@ -23,7 +23,7 @@ class TC_ProcTable_All < Test::Unit::TestCase
    end
 
    def test_version
-      assert_equal('0.8.0', ProcTable::VERSION)
+      assert_equal('0.8.1', ProcTable::VERSION)
    end
 
    def test_fields

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: sys-proctable
 version: !ruby/object:Gem::Version 
-  version: 0.8.0
+  version: 0.8.1
 platform: x86-linux
 authors: 
 - Daniel J. Berger
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-01-26 00:00:00 -07:00
+date: 2009-01-29 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency