syobocalite 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f8dcc7caf5e785e5db9e1a125e3a6ae293649e8e1d8b1147f02be88765a37603
-  data.tar.gz: ec89b3bc62616e1410eef439ab5618bd1bb4a6bd60d738cf02dba81a99e8eb44
+  metadata.gz: f7f070e10f14d7a0c05cb53c7174b79743733ea920021b19eda731a690925847
+  data.tar.gz: bf7cb84980a92810e73bfa70ac0ed432851f14517617ce56b260ad80ede919fb
 SHA512:
-  metadata.gz: 4bffe23133dbd2af590cc510e9853e2c24ed082bc58b8627a27134fbd1caac3e83197b0efeb4d628e363bc699fc5509cd63eacd675e025437e8dff0ff5498e9d
-  data.tar.gz: 7e35926344c57137a133463649dc2285b64ee85fd1aa051a32fb4c4e2d2fa1ee99a88c83703d7a7201de4b0a32405ed9f3f617b1b6cee1550cf3cbc1dbc86472
+  metadata.gz: d0d529f375366b4ebf8f551365bcf9dda0f299717a1fcf571e3d6aad04367ee998b4da09e22491cafdff79c321468bc47ec9dae69e205b7b8c873b1bcd5b95ab
+  data.tar.gz: 93fe3b38ae5498d3f76fa232f88eca0fc5ccde2b11de8e1504f3741329833e22910a6e465fcd79f16534f3f0b99acf54a4d966dbd552b1c12bd875b9eb703837

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## master
-[full changelog](https://github.com/sue445/syobocalite/compare/v0.1.0...master)
+[full changelog](https://github.com/sue445/syobocalite/compare/v0.1.1...master)
+
+## 0.1.0
+[full changelog](https://github.com/sue445/syobocalite/compare/v0.1.0...v0.1.1)
+
+* Refactor `Syobocalite::Program#Initialize`
+  * https://github.com/sue445/syobocalite/pull/3
 
 ## 0.1.0
 * first release

data/README.md

@@ -2,6 +2,7 @@
 
 Lite client for [Syoboi calendar](http://cal.syoboi.jp/) API.
 
+[![Gem Version](https://badge.fury.io/rb/syobocalite.svg)](https://badge.fury.io/rb/syobocalite)
 [![Build Status](https://travis-ci.org/sue445/syobocalite.svg?branch=master)](https://travis-ci.org/sue445/syobocalite)
 [![Coverage Status](https://coveralls.io/repos/github/sue445/syobocalite/badge.svg?branch=master)](https://coveralls.io/github/sue445/syobocalite?branch=master)
 [![Maintainability](https://api.codeclimate.com/v1/badges/9f77793acf8d5c24886e/maintainability)](https://codeclimate.com/github/sue445/syobocalite/maintainability)

data/lib/syobocalite.rb

@@ -18,7 +18,7 @@ module Syobocalite
     response = MultiXml.parse(xml)
     prog_items = response["syobocal"]["ProgItems"]["ProgItem"]
 
-    programs = prog_items.map { |prog_item| Syobocalite::Program.new(prog_item) }
+    programs = prog_items.map { |prog_item| Syobocalite::Program.from_prog_item(prog_item) }
 
     programs.select do |program|
       (start_at...end_at).cover?(program.st_time)

data/lib/syobocalite/program.rb

@@ -44,38 +44,68 @@ module Syobocalite
     #   @return [String]
     attr_accessor :prog_comment
 
-    # @param attrs [Hash]
-    def initialize(attrs = {})
-      @pid          = attrs["PID"]&.to_i
-      @tid          = attrs["TID"]&.to_i
-      @st_time      = to_time(attrs["StTime"])
-      @ed_time      = to_time(attrs["EdTime"])
-      @ch_name      = attrs["ChName"]
-      @ch_id        = attrs["ChID"]&.to_i
-      @count        = attrs["Count"]&.to_i
-      @st_offset    = attrs["StOffset"]&.to_i
-      @sub_title    = sanitize_text(attrs["SubTitle"])
-      @title        = sanitize_text(attrs["Title"])
-      @prog_comment = attrs["ProgComment"]&.gsub(/^!/, "")
+    # @param pid          [Integer]
+    # @param tid          [Integer]
+    # @param st_time      [TimeWithZone]
+    # @param ed_time      [TimeWithZone]
+    # @param ch_name      [String]
+    # @param ch_id        [Integer]
+    # @param count        [Integer]
+    # @param st_offset    [Integer]
+    # @param sub_title    [String]
+    # @param title        [String]
+    # @param prog_comment [String]
+    def initialize(pid: nil, tid: nil, st_time: nil, ed_time: nil, ch_name: nil, ch_id: nil,
+                   count: nil, st_offset: nil, sub_title: nil, title: nil, prog_comment: nil)
+      @pid          = pid
+      @tid          = tid
+      @st_time      = st_time
+      @ed_time      = ed_time
+      @ch_name      = ch_name
+      @ch_id        = ch_id
+      @count        = count
+      @st_offset    = st_offset
+      @sub_title    = sub_title
+      @title        = title
+      @prog_comment = prog_comment
     end
 
     alias_method :story_number,  :count
     alias_method :story_number=, :count=
 
-    private
+    # @param attrs [Hash]
+    #
+    # @return [Syobocalite::Program]
+    def self.from_prog_item(attrs = {})
+      Syobocalite::Program.new(
+        pid:          attrs["PID"]&.to_i,
+        tid:          attrs["TID"]&.to_i,
+        st_time:      to_time(attrs["StTime"]),
+        ed_time:      to_time(attrs["EdTime"]),
+        ch_name:      attrs["ChName"],
+        ch_id:        attrs["ChID"]&.to_i,
+        count:        attrs["Count"]&.to_i,
+        st_offset:    attrs["StOffset"]&.to_i,
+        sub_title:    sanitize_text(attrs["SubTitle"]),
+        title:        sanitize_text(attrs["Title"]),
+        prog_comment: attrs["ProgComment"]&.gsub(/^!/, ""),
+      )
+    end
 
-    def to_time(str)
+    def self.to_time(str)
       return nil unless str
 
       Time.use_zone("Tokyo") do
         Time.zone.parse(str)
       end
     end
+    private_class_method :to_time
 
-    def sanitize_text(str)
+    def self.sanitize_text(str)
       return nil unless str
 
       CGI.unescapeHTML(str)
     end
+    private_class_method :sanitize_text
   end
 end

data/lib/syobocalite/version.rb

@@ -1,3 +1,3 @@
 module Syobocalite
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: syobocalite
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - sue445