synvert 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a16d51a6f5e6376390a8d50951f1adaca53f6737
-  data.tar.gz: 295744d184ca5bbea1cf1faa0fef5428aeb8a402
+  metadata.gz: b61c84cfe6968ed5efdacf7d2eecd4c3e5299e53
+  data.tar.gz: a0893a9ba00e2266a9b00a598f02bac263931005
 SHA512:
-  metadata.gz: 259cbde5e5e77897abcf7f7c3c0557f9ecfe13ce4ba0638035dbf96147c536465818044cdaa10cc648bd487bf54806aca1c8d1208a358c6a4d530ef8c56892c8
-  data.tar.gz: 52fc74d210b5236e2cccb196d460a485421c99f47d7d825b86d86edb4f6813195cea04b5bd1b5a3ae8ecd2dd6e59fb9250aef407266b12ed0952968d2be8affd
+  metadata.gz: c7d1e4f23d7c5492d216f0034c839c0ef1420773f5c83ecebc802b826ca82eeedcea8a1c06031b24d959375c30038c0c290a56532d5d0e03d005c44d4f282f43
+  data.tar.gz: f88a50587f6e0807ea8ea8ee5c5e80b066d0c85ebb51df4f13c06ab4b4c6e56338f6a25e6626096d2158ed05f21fdb4a9dcdddf75d60eb96b387c0e23354f194

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # CHANGELOG
 
+## 0.0.5
+
+* Add add_snippet dsl for reuse
+* Abstract strong_parameters and convert_dynamic_finders snippet
+
 ## 0.0.4
 
 * Test snippets

data/README.md

@@ -28,6 +28,24 @@ Currently it supports
 * convert to FactoryGirl short syntax
 * upgrade rails from 3.2.x to 4.0.0
 
+## Example
+
+```ruby
+Synvert::Rewriter.new "factory_girl_short_syntax", "FactoryGirl uses short syntax" do
+  within_file 'sepc/**/*.rb' do
+    with_node type: 'send', receiver: 'FactoryGirl', message: 'create' do
+      replace_with "create({{arguments}})"
+    end
+  end
+end
+```
+
+This snippet will convert `post = FactoryGirl.create(:post)` to `post =
+create(:post)`.
+
+There are more examples [here][1], I will write down the Documents
+later.
+
 ## Contributing
 
 1. Fork it
@@ -35,3 +53,6 @@ Currently it supports
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+
+[1]: https://github.com/xinminlabs/synvert/tree/master/lib/synvert/snippets

data/lib/synvert/cli.rb

@@ -15,9 +15,10 @@ module Synvert
       paths = optparse.parse(args)
       Configuration.instance.set :path, paths.first || Dir.pwd
 
-      Dir.glob(File.join(File.dirname(__FILE__), 'snippets/**/*.rb')).each do |file|
-        eval(File.read(file)).process
+      rewriters = Dir.glob(File.join(File.dirname(__FILE__), 'snippets/**/*.rb')).map do |file|
+        eval(File.read(file))
       end
+      rewriters.map(&:process)
     end
   end
 end

data/lib/synvert/node_ext.rb

@@ -125,7 +125,7 @@ private
       actual.to_sym == expected
     when String
       if Parser::AST::Node === actual
-        actual.source(instance) == expected
+        actual.source(instance) == expected || actual.source(instance) == ':' + expected
       else
         actual.to_s == expected
       end

data/lib/synvert/rewriter/condition.rb

@@ -13,6 +13,16 @@ module Synvert
     end
   end
 
+  class Rewriter::IfExistCondition < Rewriter::Condition
+    def match?
+      match = false
+      @instance.current_node.recursive_children do |child_node|
+        match = match || (child_node && child_node.match?(@instance, @options))
+      end
+      match
+    end
+  end
+
   class Rewriter::UnlessExistCondition < Rewriter::Condition
     def match?
       match = false

data/lib/synvert/rewriter/instance.rb

@@ -4,8 +4,7 @@ module Synvert
   class Rewriter::Instance
     attr_accessor :current_node, :current_source, :current_file
 
-    def initialize(rewriter, file_pattern, &block)
-      @rewriter = rewriter
+    def initialize(file_pattern, &block)
       @actions = []
       @file_pattern = file_pattern
       @block = block
@@ -48,6 +47,10 @@ module Synvert
 
     alias with_node within_node
 
+    def if_exist_node(options, &block)
+      Rewriter::IfExistCondition.new(self, options, &block).process
+    end
+
     def unless_exist_node(options, &block)
       Rewriter::UnlessExistCondition.new(self, options, &block).process
     end
@@ -76,14 +79,6 @@ module Synvert
       @actions << Rewriter::RemoveAction.new(self)
     end
 
-    def assign(name, key, value)
-      @rewriter.set name, key, value
-    end
-
-    def fetch(name, key)
-      @rewriter.get name, key
-    end
-
   private
 
     def remove_code_or_whole_line(source, line)

data/lib/synvert/rewriter.rb

@@ -12,26 +12,32 @@ module Synvert
     autoload :Scope, 'synvert/rewriter/scope'
 
     autoload :Condition, 'synvert/rewriter/condition'
+    autoload :IfExistCondition, 'synvert/rewriter/condition'
     autoload :UnlessExistCondition, 'synvert/rewriter/condition'
     autoload :IfOnlyExistCondition, 'synvert/rewriter/condition'
 
     autoload :GemSpec, 'synvert/rewriter/gem_spec'
 
-    attr_reader :description
-
-    def initialize(description, &block)
-      @description = description
-      @block = block
-      @assignments = {}
-    end
+    class <<self
+      def register(name, rewriter)
+        @rewriters ||= {}
+        @rewriters[name.to_s] = rewriter
+      end
 
-    def set(name, key, value)
-      @assignments[name] ||= {}
-      @assignments[name][key] = value
+      def call(name)
+        if @rewriters[name.to_s]
+          @rewriters[name.to_s].process
+        else
+          raise RewriterNotFound.new "Rewriter #{name} not found"
+        end
+      end
     end
 
-    def get(name, key)
-      @assignments[name] and @assignments[name][key]
+    def initialize(name, description, &block)
+      @name = name
+      @description = description
+      @block = block
+      self.class.register(name, self)
     end
 
     def process
@@ -43,11 +49,15 @@ module Synvert
     end
 
     def within_file(file_pattern, &block)
-      if @gem_spec.match?
-        Rewriter::Instance.new(self, file_pattern, &block).process
+      if !@gem_spec || @gem_spec.match?
+        Rewriter::Instance.new(file_pattern, &block).process
       end
     end
 
     alias within_files within_file
+
+    def add_snippet(name)
+      self.class.call(name)
+    end
   end
 end

data/lib/synvert/rewriter_not_found.rb

@@ -0,0 +1,4 @@
+module Synvert
+  class RewriterNotFound < Exception
+  end
+end

data/lib/synvert/snippets/factory_girl/syntax_methods.rb

@@ -1,4 +1,4 @@
-Synvert::Rewriter.new "FactoryGirl uses short syntax" do
+Synvert::Rewriter.new "factory_girl_short_syntax", "FactoryGirl uses short syntax" do
   gem_spec 'factory_girl', '2.0.0'
 
   # insert include FactoryGirl::Syntax::Methods

data/lib/synvert/snippets/rails/convert_dynamic_finders.rb

@@ -0,0 +1,60 @@
+require 'securerandom'
+
+class Synvert::Rewriter::Instance
+  def dynamic_finder_to_hash(node, prefix)
+    fields = node.message.to_s[prefix.length..-1].split("_and_")
+    fields.length.times.map { |i|
+      fields[i] + ": " + node.arguments[i].source(self)
+    }.join(", ")
+  end
+end
+
+Synvert::Rewriter.new "convert_dynamic_finders", "Convert dynamic finders" do
+  within_files '**/*.rb' do
+    # find_all_by_... => where(...)
+    with_node type: 'send', message: /find_all_by_(.*)/ do
+      hash_params = dynamic_finder_to_hash(node, "find_all_by_")
+      replace_with "{{receiver}}.where(#{hash_params})"
+    end
+  end
+
+  within_files '**/*.rb' do
+    # find_by_... => where(...).first
+    with_node type: 'send', message: /find_by_(.*)/ do
+      hash_params = dynamic_finder_to_hash(node, "find_by_")
+      replace_with "{{receiver}}.where(#{hash_params}).first"
+    end
+  end
+
+  within_files '**/*.rb' do
+    # find_last_by_... => where(...).last
+    with_node type: 'send', message: /find_last_by_(.*)/ do
+      hash_params = dynamic_finder_to_hash(node, "find_last_by_")
+      replace_with "{{receiver}}.where(#{hash_params}).last"
+    end
+  end
+
+  within_files '**/*.rb' do
+    # scoped_by_... => where(...)
+    with_node type: 'send', message: /scoped_by_(.*)/ do
+      hash_params = dynamic_finder_to_hash(node, "scoped_by_")
+      replace_with "{{receiver}}.where(#{hash_params})"
+    end
+  end
+
+  within_files '**/*.rb' do
+    # find_or_initialize_by_... => find_or_initialize_by(...)
+    with_node type: 'send', message: /find_or_initialize_by_(.*)/ do
+      hash_params = dynamic_finder_to_hash(node, "find_or_initialize_by_")
+      replace_with "{{receiver}}.find_or_initialize_by(#{hash_params})"
+    end
+  end
+
+  within_files '**/*.rb' do
+    # find_or_create_by_... => find_or_create_by(...)
+    with_node type: 'send', message: /find_or_create_by_(.*)/ do
+      hash_params = dynamic_finder_to_hash(node, "find_or_create_by_")
+      replace_with "{{receiver}}.find_or_create_by(#{hash_params})"
+    end
+  end
+end

data/lib/synvert/snippets/rails/strong_parameters.rb

@@ -0,0 +1,44 @@
+Synvert::Rewriter.new "strong_parameters", "use strong_parameters syntax" do
+  within_files 'config/**/*.rb' do
+    # remove config.active_record.whitelist_attributes = ...
+    with_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'active_record'}, message: 'whitelist_attributes=' do
+      remove
+    end
+  end
+
+  parameters = {}
+  within_files 'app/models/**/*.rb' do
+    # assign and remove attr_accessible ...
+    within_node type: 'class' do
+      object_name = node.name.source(self).underscore
+      with_node type: 'send', message: 'attr_accessible' do
+        parameters[object_name] = node.arguments.map { |key| key.source(self) }.join(', ')
+        remove
+      end
+    end
+  end
+
+  within_file 'app/controllers/**/*.rb' do
+    within_node type: 'class' do
+      object_name = node.name.source(self).sub('Controller', '').singularize.underscore
+      if_exist_node type: 'send', receiver: 'params', message: '[]', arguments: [object_name] do
+        if parameters[object_name]
+          # append def xxx_params; ...; end
+          unless_exist_node type: 'def', name: "#{object_name}_params" do
+            append """def #{object_name}_params
+  params.require(:#{object_name}).permit(#{parameters[object_name]})
+end"""
+          end
+
+          # params[:xxx] => xxx_params
+          with_node type: 'send', receiver: 'params', message: '[]' do
+            object_name = eval(node.arguments.first.source(self)).to_s
+            if parameters[object_name]
+              replace_with "#{object_name}_params"
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/synvert/snippets/rails/upgrade_3_2_to_4_0.rb

@@ -1,15 +1,6 @@
 require 'securerandom'
 
-class Synvert::Rewriter::Instance
-  def dynamic_finder_to_hash(node, prefix)
-    fields = node.message.to_s[prefix.length..-1].split("_and_")
-    fields.length.times.map { |i|
-      fields[i] + ": " + node.arguments[i].source(self)
-    }.join(", ")
-  end
-end
-
-Synvert::Rewriter.new "Upgrade rails from 3.2 to 4.0" do
+Synvert::Rewriter.new "upgrade_rails_3_2_to_4_0", "Upgrade rails from 3.2 to 4.0" do
   gem_spec 'rails', '3.2.0'
 
   within_file 'config/application.rb' do
@@ -55,13 +46,6 @@ Synvert::Rewriter.new "Upgrade rails from 3.2 to 4.0" do
     end
   end
 
-  within_files 'config/**/*.rb' do
-    # remove config.active_record.whitelist_attributes = ...
-    with_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'active_record'}, message: 'whitelist_attributes=' do
-      remove
-    end
-  end
-
   within_file 'config/environments/production.rb' do
     # insert config.eager_load = true
     unless_exist_node type: 'send', message: 'eager_load=' do
@@ -132,54 +116,6 @@ Synvert::Rewriter.new "Upgrade rails from 3.2 to 4.0" do
     end
   end
 
-  within_files 'app/**/*.rb' do
-    # find_all_by_... => where(...)
-    with_node type: 'send', message: /find_all_by_(.*)/ do
-      hash_params = dynamic_finder_to_hash(node, "find_all_by_")
-      replace_with "{{receiver}}.where(#{hash_params})"
-    end
-  end
-
-  within_files 'app/**/*.rb' do
-    # find_by_... => where(...).first
-    with_node type: 'send', message: /find_by_(.*)/ do
-      hash_params = dynamic_finder_to_hash(node, "find_by_")
-      replace_with "{{receiver}}.where(#{hash_params}).first"
-    end
-  end
-
-  within_files 'app/**/*.rb' do
-    # find_last_by_... => where(...).last
-    with_node type: 'send', message: /find_last_by_(.*)/ do
-      hash_params = dynamic_finder_to_hash(node, "find_last_by_")
-      replace_with "{{receiver}}.where(#{hash_params}).last"
-    end
-  end
-
-  within_files 'app/**/*.rb' do
-    # scoped_by_... => where(...)
-    with_node type: 'send', message: /scoped_by_(.*)/ do
-      hash_params = dynamic_finder_to_hash(node, "scoped_by_")
-      replace_with "{{receiver}}.where(#{hash_params})"
-    end
-  end
-
-  within_files 'app/**/*.rb' do
-    # find_or_initialize_by_... => find_or_initialize_by(...)
-    with_node type: 'send', message: /find_or_initialize_by_(.*)/ do
-      hash_params = dynamic_finder_to_hash(node, "find_or_initialize_by_")
-      replace_with "{{receiver}}.find_or_initialize_by(#{hash_params})"
-    end
-  end
-
-  within_files 'app/**/*.rb' do
-    # find_or_create_by_... => find_or_create_by(...)
-    with_node type: 'send', message: /find_or_create_by_(.*)/ do
-      hash_params = dynamic_finder_to_hash(node, "find_or_create_by_")
-      replace_with "{{receiver}}.find_or_create_by(#{hash_params})"
-    end
-  end
-
   {'ActionController::Integration' => 'ActionDispatch::Integration',
    'ActionController::IntegrationTest' => 'ActionDispatch::IntegrationTest',
    'ActionController::PerformanceTest' => 'ActionDispatch::PerformanceTest',
@@ -195,39 +131,6 @@ Synvert::Rewriter.new "Upgrade rails from 3.2 to 4.0" do
     end
   end
 
-  #####################
-  # strong_parameters #
-  #####################
-  within_files 'app/models/**/*.rb' do
-    # assign and remove attr_accessible ...
-    within_node type: 'class' do
-      class_node = node
-      with_node type: 'send', message: 'attr_accessible' do
-        assign 'parameters', class_node.name.source(self).underscore, node.arguments.map { |key| key.source(self) }.join(', ')
-        remove
-      end
-    end
-  end
-
-  within_file 'app/controllers/**/*.rb' do
-    within_node type: 'class' do
-      # insert def xxx_params; ...; end
-      object_name = node.name.source(self).sub('Controller', '').singularize.underscore
-      if fetch('parameters', object_name)
-        unless_exist_node type: 'def', name: "#{object_name}_params" do
-          append """def #{object_name}_params
-  params.require(:#{object_name}).permit(#{fetch 'parameters', object_name})
-end"""
-        end
-
-        # params[:xxx] => xxx_params
-        with_node type: 'send', receiver: 'params', message: '[]' do
-          object_name = eval(node.arguments.first.source(self)).to_s
-          if fetch('parameters', object_name)
-            replace_with "#{object_name}_params"
-          end
-        end
-      end
-    end
-  end
+  add_snippet 'convert_dynamic_finders'
+  add_snippet 'strong_parameters'
 end

data/lib/synvert/version.rb

@@ -1,5 +1,5 @@
 # coding: utf-8
 
 module Synvert
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/lib/synvert.rb

@@ -11,4 +11,5 @@ module Synvert
   autoload :CheckingVisitor, 'synvert/checking_visitor'
   autoload :Configuration, 'synvert/configuration'
   autoload :Rewriter, 'synvert/rewriter'
+  autoload :RewriterNotFound, 'synvert/rewriter_not_found'
 end

data/spec/synvert/rewriter/condition_spec.rb

@@ -1,6 +1,39 @@
 require 'spec_helper'
 
 module Synvert
+  describe Rewriter::IfExistCondition do
+    let(:source) {
+      """
+      RSpec.configure do |config|
+        config.include EmailSpec::Helpers
+        config.include EmailSpec::Methods
+      end
+      """
+    }
+    let(:node) { Parser::CurrentRuby.parse(source) }
+    let(:instance) { double(:current_node => node, :current_source => source) }
+
+    describe '#process' do
+      it 'call block if match anything' do
+        run = false
+        condition = Rewriter::IfExistCondition.new instance, type: 'send', message: 'include', arguments: ['EmailSpec::Helpers'] do
+          run = true
+        end
+        condition.process
+        expect(run).to be_true
+      end
+
+      it 'not call block if not match anything' do
+        run = false
+        condition = Rewriter::IfExistCondition.new instance, type: 'send', message: 'include', arguments: ['FactoryGirl::SyntaxMethods'] do
+          run = true
+        end
+        condition.process
+        expect(run).to be_false
+      end
+    end
+  end
+
   describe Rewriter::UnlessExistCondition do
     let(:source) {
       """

data/spec/synvert/rewriter/instance_spec.rb

@@ -2,8 +2,7 @@ require 'spec_helper'
 
 module Synvert
   describe Rewriter::Instance do
-    let(:rewriter) { Rewriter.new 'description' do; end }
-    let(:instance) { Rewriter::Instance.new(rewriter, 'file pattern') }
+    let(:instance) { Rewriter::Instance.new('file pattern') }
 
     it 'parses within_node' do
       scope = double()
@@ -21,6 +20,14 @@ module Synvert
       instance.with_node(type: 'send', message: 'create', &block)
     end
 
+    it 'parses if_exist_node' do
+      condition = double()
+      block = Proc.new {}
+      expect(Rewriter::IfExistCondition).to receive(:new).with(instance, type: 'send', message: 'create', &block).and_return(condition)
+      expect(condition).to receive(:process)
+      instance.if_exist_node(type: 'send', message: 'create', &block)
+    end
+
     it 'parses unless_exist_node' do
       condition = double()
       block = Proc.new {}
@@ -62,16 +69,11 @@ module Synvert
       instance.remove
     end
 
-    it 'parses assign / fetch' do
-      instance.assign 'parameters', 'user', 'email'
-      expect(instance.fetch 'parameters', 'user').to eq 'email'
-    end
-
     describe '#process' do
       before { Configuration.instance.set :path, '.' }
 
       it 'FactoryGirl uses short syntax' do
-        instance = Rewriter::Instance.new rewriter, 'spec/**/*_spec.rb' do
+        instance = Rewriter::Instance.new 'spec/**/*_spec.rb' do
           with_node type: 'send', receiver: 'FactoryGirl', message: 'create' do
             replace_with 'create {{arguments}}'
           end
@@ -97,7 +99,7 @@ end
       end
 
       it 'includes FactoryGirl::Syntax::Methods' do
-        instance = Rewriter::Instance.new rewriter, 'spec/spec_helper.rb'  do
+        instance = Rewriter::Instance.new 'spec/spec_helper.rb'  do
           with_node type: 'block', caller: {receiver: 'RSpec', message: 'configure'} do
             unless_exist_node type: 'send', message: 'include', arguments: ['FactoryGirl::Syntax::Methods'] do
               insert "{{arguments.first}}.include FactoryGirl::Syntax::Methods"
@@ -120,7 +122,7 @@ end
       end
 
       it 'does not include FactoryGirl::Syntax::Methods' do
-        instance = Rewriter::Instance.new rewriter, 'spec/spec_helper.rb' do
+        instance = Rewriter::Instance.new 'spec/spec_helper.rb' do
           with_node type: 'block', caller: {receiver: 'RSpec', message: 'configure'} do
             unless_exist_node type: 'send', message: 'include', arguments: ['FactoryGirl::Syntax::Methods'] do
               insert "{{arguments.first}}.include FactoryGirl::Syntax::Methods"
@@ -144,7 +146,7 @@ end
       end
 
       it 'process nested send nodes' do
-        instance = Rewriter::Instance.new rewriter, 'config/*.rb'  do
+        instance = Rewriter::Instance.new 'config/*.rb'  do
           with_node type: 'send', receiver: {type: 'send', receiver: {type: 'send', message: 'config'}, message: 'active_record'}, message: 'identity_map=' do
             remove
           end

data/spec/synvert/rewriter_spec.rb

@@ -2,39 +2,60 @@ require 'spec_helper'
 
 module Synvert
   describe Rewriter do
-    it 'sets description' do
-      rewriter = Rewriter.new 'this is description' do; end
-      expect(rewriter.description).to eq 'this is description'
-    end
-
-    describe 'get / set' do
-      it 'set and get parameters' do
-        rewriter = Rewriter.new 'this is description' do; end
-        rewriter.set 'parameter', 'post', ':title, :description'
-        expect(rewriter.get 'parameter', 'post').to eq ':title, :description'
+    it 'parses gem_spec' do
+      expect(Rewriter::GemSpec).to receive(:new).with('synvert', '1.0.0')
+      rewriter = Rewriter.new 'name', 'description' do
+        gem_spec 'synvert', '1.0.0'
       end
+      rewriter.process
     end
 
-    describe '#process' do
+    describe 'parses within_file' do
       it 'does nothing if gem_spec not match' do
         expect_any_instance_of(Rewriter::GemSpec).to receive(:match?).and_return(false)
         expect_any_instance_of(Rewriter::Instance).not_to receive(:process)
-        rewriter = Rewriter.new 'description' do
+        rewriter = Rewriter.new 'name', 'description' do
           gem_spec 'synvert', '1.0.0'
           within_file 'config/routes.rb' do; end
         end
         rewriter.process
       end
 
-      it 'delegates process to instances' do
+      it 'delegates process to instances if gem_spec not exist' do
+        expect_any_instance_of(Rewriter::Instance).to receive(:process)
+        rewriter = Rewriter.new 'name', 'description' do
+          within_file 'config/routes.rb' do; end
+        end
+        rewriter.process
+      end
+
+      it 'delegates process to instances if gem_spec matches' do
         expect_any_instance_of(Rewriter::GemSpec).to receive(:match?).and_return(true)
         expect_any_instance_of(Rewriter::Instance).to receive(:process)
-        rewriter = Rewriter.new 'description' do
+        rewriter = Rewriter.new 'name', 'description' do
           gem_spec 'synvert', '1.0.0'
           within_file 'config/routes.rb' do; end
         end
         rewriter.process
       end
     end
+
+    describe 'parses add_snippet' do
+      it 'process the rewritter' do
+        rewriter1 = Synvert::Rewriter.new 'rewriter1', 'description1'
+        rewriter2 = Synvert::Rewriter.new 'rewriter2', 'description2' do
+          add_snippet :rewriter1
+        end
+        expect(rewriter1).to receive(:process)
+        rewriter2.process
+      end
+
+      it 'raises RewriterNotFound' do
+        rewriter = Synvert::Rewriter.new 'name', 'description' do
+          add_snippet :not_exist
+        end
+        expect { rewriter.process }.to raise_error(Synvert::RewriterNotFound)
+      end
+    end
   end
 end

data/spec/synvert/snippets/rails/convert_dynamic_finders_spec.rb

@@ -0,0 +1,83 @@
+require 'spec_helper'
+
+describe 'Convert dynamic finders' do
+  before do
+    Synvert::Configuration.instance.set :path, '.'
+    rewriter_path = File.join(File.dirname(__FILE__), '../../../../lib/synvert/snippets/rails/convert_dynamic_finders.rb')
+    @rewriter = eval(File.read(rewriter_path))
+    allow_any_instance_of(Synvert::Rewriter::GemSpec).to receive(:match?).and_return(true)
+  end
+
+  describe 'with fakefs', fakefs: true do
+    let(:post_model_content) {'''
+class Post < ActiveRecord::Base
+  def active_users_by_email(email)
+    User.find_all_by_email_and_active(email, true)
+  end
+
+  def first_active_user_by_email(email)
+    User.find_by_email_and_active(email, true)
+  end
+
+  def last_active_user_by_email(email)
+    User.find_last_by_email_and_active(email, true)
+  end
+
+  def scoped_active_user_by_email(email)
+    User.scoped_by_email_and_active(email, true)
+  end
+end
+    '''}
+    let(:post_model_rewritten_content) {'''
+class Post < ActiveRecord::Base
+  def active_users_by_email(email)
+    User.where(email: email, active: true)
+  end
+
+  def first_active_user_by_email(email)
+    User.where(email: email, active: true).first
+  end
+
+  def last_active_user_by_email(email)
+    User.where(email: email, active: true).last
+  end
+
+  def scoped_active_user_by_email(email)
+    User.where(email: email, active: true)
+  end
+end
+    '''}
+    let(:users_controller_content) {'''
+class UsersController < ApplicationController
+  def new
+    @user = User.find_or_initialize_by_login_and_email(params[:user][:login], params[:user][:email])
+  end
+
+  def create
+    @user = User.find_or_create_by_login_and_email(params[:user][:login], params[:user][:email])
+  end
+end
+    '''}
+    let(:users_controller_rewritten_content) {'''
+class UsersController < ApplicationController
+  def new
+    @user = User.find_or_initialize_by(login: params[:user][:login], email: params[:user][:email])
+  end
+
+  def create
+    @user = User.find_or_create_by(login: params[:user][:login], email: params[:user][:email])
+  end
+end
+    '''}
+
+    it 'process' do
+      FileUtils.mkdir_p 'app/models'
+      FileUtils.mkdir_p 'app/controllers'
+      File.write 'app/models/post.rb', post_model_content
+      File.write 'app/controllers/users_controller.rb', users_controller_content
+      @rewriter.process
+      expect(File.read 'app/models/post.rb').to eq post_model_rewritten_content
+      expect(File.read 'app/controllers/users_controller.rb').to eq users_controller_rewritten_content
+    end
+  end
+end

data/spec/synvert/snippets/rails/strong_parameters_spec.rb

@@ -0,0 +1,76 @@
+require 'spec_helper'
+
+describe 'rails strong_parameters snippet' do
+  before do
+    Synvert::Configuration.instance.set :path, '.'
+    rewriter_path = File.join(File.dirname(__FILE__), '../../../../lib/synvert/snippets/rails/strong_parameters.rb')
+    @rewriter = eval(File.read(rewriter_path))
+    allow_any_instance_of(Synvert::Rewriter::GemSpec).to receive(:match?).and_return(true)
+  end
+
+  describe 'with fakefs', fakefs: true do
+    let(:application_content) {'''
+module Synvert
+  class Application < Rails::Application
+    config.active_record.whitelist_attributes = true
+  end
+end
+    '''}
+    let(:application_rewritten_content) {'''
+module Synvert
+  class Application < Rails::Application
+  end
+end
+    '''}
+    let(:post_model_content) {'''
+class Post < ActiveRecord::Base
+  attr_accessible :title, :description
+end
+    '''}
+    let(:post_model_rewritten_content) {'''
+class Post < ActiveRecord::Base
+end
+    '''}
+    let(:posts_controller_content) {'''
+class PostsController < ApplicationController
+  def update
+    @post = Post.find(params[:id])
+    if @post.update_attributes params[:post]
+      redirect_to post_path(@post)
+    else
+      render :action => :edit
+    end
+  end
+end
+    '''}
+    let(:posts_controller_rewritten_content) {'''
+class PostsController < ApplicationController
+  def update
+    @post = Post.find(params[:id])
+    if @post.update_attributes post_params
+      redirect_to post_path(@post)
+    else
+      render :action => :edit
+    end
+  end
+
+  def post_params
+    params.require(:post).permit(:title, :description)
+  end
+end
+    '''}
+
+    it 'process' do
+      FileUtils.mkdir_p 'config'
+      FileUtils.mkdir_p 'app/models'
+      FileUtils.mkdir_p 'app/controllers'
+      File.write 'config/application.rb', application_content
+      File.write 'app/models/post.rb', post_model_content
+      File.write 'app/controllers/posts_controller.rb', posts_controller_content
+      @rewriter.process
+      expect(File.read 'config/application.rb').to eq application_rewritten_content
+      expect(File.read 'app/models/post.rb').to eq post_model_rewritten_content
+      expect(File.read 'app/controllers/posts_controller.rb').to eq posts_controller_rewritten_content
+    end
+  end
+end

data/spec/synvert/snippets/rails/upgrade_3_2_to_4_0_spec.rb

@@ -6,6 +6,10 @@ describe 'Upgrade rails from 3.2 to 4.0' do
     rewriter_path = File.join(File.dirname(__FILE__), '../../../../lib/synvert/snippets/rails/upgrade_3_2_to_4_0.rb')
     @rewriter = eval(File.read(rewriter_path))
     allow_any_instance_of(Synvert::Rewriter::GemSpec).to receive(:match?).and_return(true)
+    strong_parameters_rewriter_path = File.join(File.dirname(__FILE__), '../../../../lib/synvert/snippets/rails/strong_parameters.rb')
+    eval(File.read(strong_parameters_rewriter_path))
+    convert_dynamic_finders_rewriter_path = File.join(File.dirname(__FILE__), '../../../../lib/synvert/snippets/rails/convert_dynamic_finders.rb')
+    eval(File.read(convert_dynamic_finders_rewriter_path))
     expect(SecureRandom).to receive(:hex).with(64).and_return("bf4f3f46924ecd9adcb6515681c78144545bba454420973a274d7021ff946b8ef043a95ca1a15a9d1b75f9fbdf85d1a3afaf22f4e3c2f3f78e24a0a188b581df")
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: synvert
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-16 00:00:00.000000000 Z
+date: 2014-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -120,7 +120,10 @@ files:
 - lib/synvert/rewriter/gem_spec.rb
 - lib/synvert/rewriter/instance.rb
 - lib/synvert/rewriter/scope.rb
+- lib/synvert/rewriter_not_found.rb
 - lib/synvert/snippets/factory_girl/syntax_methods.rb
+- lib/synvert/snippets/rails/convert_dynamic_finders.rb
+- lib/synvert/snippets/rails/strong_parameters.rb
 - lib/synvert/snippets/rails/upgrade_3_2_to_4_0.rb
 - lib/synvert/version.rb
 - spec/spec_helper.rb
@@ -133,6 +136,8 @@ files:
 - spec/synvert/rewriter/scope_spec.rb
 - spec/synvert/rewriter_spec.rb
 - spec/synvert/snippets/factory_girl/syntax_methods_spec.rb
+- spec/synvert/snippets/rails/convert_dynamic_finders_spec.rb
+- spec/synvert/snippets/rails/strong_parameters_spec.rb
 - spec/synvert/snippets/rails/upgrade_3_2_to_4_0_spec.rb
 - synvert.gemspec
 homepage: ''
@@ -170,4 +175,6 @@ test_files:
 - spec/synvert/rewriter/scope_spec.rb
 - spec/synvert/rewriter_spec.rb
 - spec/synvert/snippets/factory_girl/syntax_methods_spec.rb
+- spec/synvert/snippets/rails/convert_dynamic_finders_spec.rb
+- spec/synvert/snippets/rails/strong_parameters_spec.rb
 - spec/synvert/snippets/rails/upgrade_3_2_to_4_0_spec.rb