synvert 0.0.9 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 15b18499a48bc225d4ae1c3bda5b9cb1c1040a49
-  data.tar.gz: 378b683c0d0844c5c7d6b6b00ad4be92abf5da25
+  metadata.gz: 614d00dc632a03aa4e33b46e9abd3632e3cd1192
+  data.tar.gz: cda16861b6998679c265db36fa32c094ca391417
 SHA512:
-  metadata.gz: 564b0445b50d28b9a14ed805320e68821f3dbaa87923519f6014c1e64bb0c9fdf6576585c9d52c05df38a9312c720393802bce2b365e2867f63aa5cb95be905c
-  data.tar.gz: 3a64f525fec4d10f99fa39243e369373e37e453ce90bc2f81f527b0c4ea62bdd4b41f28859d8275d84fa8ebdd91f2b4e0ce800717586d244cb2c38a008aec834
+  metadata.gz: dc0094150dfdc672a9f4cbe95ba484cedf065d778a988b60790c2a417748b1e7b07c50e74df7fe3b44835f32313c4ac7708e0928b5cac4db41f5fd9ad59c8f24
+  data.tar.gz: 2531c8a731dcfcf741634f23450abd0415b630197c64845958a3f81dd3f7d7b43b3d07ef706c31c1bf7d650beb04e9b4c7c768ad05fdb22694212f1fe90ed781

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # CHANGELOG
 
+## 0.0.10
+
+* Add not ast node operator
+* Replace with multipe line code
+* Add RSpec new syntax snippet
+
 ## 0.0.9
 
 * Add add_file dsl

data/README.md

@@ -2,6 +2,7 @@
 
 [![Build Status](https://secure.travis-ci.org/xinminlabs/synvert.png)](http://travis-ci.org/xinminlabs/synvert)
 [![Coverage Status](https://coveralls.io/repos/xinminlabs/synvert/badge.png?branch=master)](https://coveralls.io/r/xinminlabs/synvert)
+[![Gem Version](https://badge.fury.io/rb/synvert.png)](http://badge.fury.io/rb/synvert)
 
 synvert = syntax + convert, makes it easy to rewrite ruby code
 automatically.
@@ -41,12 +42,24 @@ $ synvert --run-snippets factory_girl_short_syntax,upgrade_rails_3_2_to_4_0 ~/Si
 
 name | description
 --- | ---
-factory_girl_short_syntax | FactoryGirl uses short syntax
-convert_dynamic_finders | Convert dynamic finders
-strong_parameters | Use strong_parameters syntax
-upgrade_rails_3_2_to_4_0 | Upgrade rails from 3.2 to 4.0, it contains convert_dynamic_finder and strong_parameters snippets
-upgrade_rails_3_1_to_3_2 | Upgrade rails from 3.1 to 3.2
-upgrade_rails_3_0_to_3_1 | Upgrade rails from 3.0 to 3.1
+factory_girl_short_syntax                | FactoryGirl uses short syntax
+convert_dynamic_finders                  | Convert dynamic finders
+strong_parameters                        | Use strong_parameters syntax
+upgrade_rails_3_0_to_3_1                 | Upgrade rails from 3.0 to 3.1
+upgrade_rails_3_1_to_3_2                 | Upgrade rails from 3.1 to 3.2
+upgrade_rails_3_2_to_4_0                 | Upgrade rails from 3.2 to 4.0, it contains convert_dynamic_finder and strong_parameters snippets
+convert_rspec_be_close_to_be_within      | RSpec converts be_close to be_within
+convert_rspec_block_to_expect            | RSpec converts block to expect
+convert_rspec_boolean_matcher            | RSpec converts boolean matcher
+convert_rspec_collection_matcher         | RSpec converts collection matcher
+convert_rspec_its_to_it                  | RSpec converts its to it
+convert_rspec_message_expectation        | RSpec converts message expectation
+convert_rspec_method_stub                | RSpec converts method stub
+convert_rspec_negative_error_expectation | RSpec converts negative error expectation
+rspec_new_syntax                         | Use RSpec new syntax
+convert_rspec_one_liner_expectation      | RSpec converts one liner expectation
+convert_rspec_should_to_expect           | RSpec converts should to expect
+convert_rspec_stub_and_mock_to_double    | RSpec converts stub and mock to double
 
 ## Documentation
 

data/lib/synvert/node_ext.rb

@@ -48,8 +48,11 @@ class Parser::AST::Node
   end
 
   def body
-    if :block == self.type
-      self.children[2]
+    case self.type
+    when :begin
+      self.children
+    when :block
+      :begin == self.children[2].type ? self.children[2].children : [self.children[2]]
     else
       raise NotImplementedError.new "body is not handled for #{self.inspect}"
     end
@@ -88,6 +91,10 @@ class Parser::AST::Node
         actual_values = actual_value(self, instance, multi_keys[0...-1])
         expected = expected_value(rules, multi_keys)
         actual_values.any? { |actual| match_value?(instance, actual, expected) }
+      elsif multi_keys.last == :not
+        actual = actual_value(self, instance, multi_keys[0...-1])
+        expected = expected_value(rules, multi_keys)
+        !match_value?(instance, actual, expected)
       else
         actual = actual_value(self, instance, multi_keys)
         expected = expected_value(rules, multi_keys)
@@ -104,10 +111,14 @@ class Parser::AST::Node
         source = evaluated.loc.expression.source_buffer.source
         source[evaluated.loc.expression.begin_pos...evaluated.loc.expression.end_pos]
       when Array
-        source = evaluated.first.loc.expression.source_buffer.source
-        source[evaluated.first.loc.expression.begin_pos...evaluated.last.loc.expression.end_pos]
+        if evaluated.size > 0
+          source = evaluated.first.loc.expression.source_buffer.source
+          source[evaluated.first.loc.expression.begin_pos...evaluated.last.loc.expression.end_pos]
+        end
       when String
         evaluated
+      when NilClass
+        'nil'
       else
         raise NotImplementedError.new "rewritten_source is not handled for #{evaluated.inspect}"
       end
@@ -140,6 +151,12 @@ private
       actual.zip(expected).all? { |a, e| match_value?(instance, a, e) }
     when NilClass
       actual.nil?
+    when Numeric
+      if Parser::AST::Node === actual
+        actual.children[0] == expected
+      else
+        actual == expected
+      end
     when TrueClass
       :true == actual.type
     when FalseClass

data/lib/synvert/rewriter/action.rb

@@ -41,7 +41,19 @@ module Synvert
     end
 
     def rewritten_code
-      @node.rewritten_source(@code)
+      if rewritten_source.split("\n").length > 1
+        "\n\n" + rewritten_source.split("\n").map { |line|
+          indent(@node) + line
+        }.join("\n")
+      else
+        rewritten_source
+      end
+    end
+
+  private
+
+    def indent(node)
+      ' ' * node.indent
     end
   end
 

data/lib/synvert/rewriter/condition.rb

@@ -35,8 +35,8 @@ module Synvert
 
   class Rewriter::IfOnlyExistCondition < Rewriter::Condition
     def match?
-      :begin != @instance.current_node.body.type &&
-        @instance.current_node.body.match?(@instance, @rules)
+      @instance.current_node.body.size == 1 &&
+        @instance.current_node.body.first.match?(@instance, @rules)
     end
   end
 end

data/lib/synvert/snippets/rails/upgrade_3_0_to_3_1.rb

@@ -1,4 +1,4 @@
-Synvert::Rewriter.new 'upgrade_rails_3_1_to_3_2', 'Upgrade rails from 3.0 to 3.1' do
+Synvert::Rewriter.new 'upgrade_rails_3_0_to_3_1', 'Upgrade rails from 3.0 to 3.1' do
   gem_spec 'rails', '3.0.0'
 
   within_file 'config/application.rb' do

data/lib/synvert/snippets/rspec/be_close_to_be_within.rb

@@ -0,0 +1,12 @@
+Synvert::Rewriter.new "convert_rspec_be_close_to_be_within", "RSpec converts be_close to be_within" do
+  gem_spec 'rspec', '2.1.0'
+
+  within_files 'spec/**/*.rb' do
+    # expect(1.0 / 3.0).to be_close(0.333, 0.001) => expect(1.0 / 3.0).to be_within(0.001).of(0.333)
+    with_node type: 'send', message: 'to', arguments: {first: {type: 'send', message: 'be_close'}} do
+      within_arg = node.arguments.first.arguments.last.source(self)
+      of_arg = node.arguments.first.arguments.first.source(self)
+      replace_with "{{receiver}}.to be_within(#{within_arg}).of(#{of_arg})"
+    end
+  end
+end

data/lib/synvert/snippets/rspec/block_to_expect.rb

@@ -0,0 +1,14 @@
+Synvert::Rewriter.new "convert_rspec_block_to_expect", "RSpec converts block to expect" do
+  gem_spec 'rspec', '2.11.0'
+
+  {should: 'to', should_not: 'not_to'}.each do |old_message, new_message|
+    within_files 'spec/**/*.rb' do
+      # lambda { do_something }.should raise_error => expect { do_something }.to raise_error
+      # proc { do_something }.should raise_error => expect { do_something }.to raise_error
+      # -> { do_something }.should raise_error => expect { do_something }.to raise_error
+      with_node type: 'send', receiver: {type: 'block'}, message: old_message do
+        replace_with "expect { {{receiver.body}} }.#{new_message} {{arguments}}"
+      end
+    end
+  end
+end

data/lib/synvert/snippets/rspec/boolean_matcher.rb

@@ -0,0 +1,13 @@
+Synvert::Rewriter.new "convert_rspec_boolean_matcher", "RSpec converts boolean matcher" do
+  gem_spec 'rspec', '2.99.0'
+
+  {be_true: 'be_truthy', be_false: 'be_falsey'}.each do |old_matcher, new_matcher|
+    within_files 'spec/**/*_spec.rb' do
+      # be_true => be_truthy
+      # be_false => be_falsey
+      with_node type: 'send', receiver: nil, message: old_matcher do
+        replace_with new_matcher
+      end
+    end
+  end
+end

data/lib/synvert/snippets/rspec/collection_matcher.rb

@@ -0,0 +1,23 @@
+Synvert::Rewriter.new "convert_rspec_collection_matcher", "RSpec converts collection matcher" do
+  gem_spec 'rspec', '2.99.0'
+
+  {have: 'eq', have_exactly: 'eq', have_at_least: 'be >=', have_at_most: 'be <='}.each do |old_matcher, new_matcher|
+    within_files 'spec/**/*_spec.rb' do
+      # expect(collection).to have(3).items => expect(collection.size).to eq(3)
+      # expect(collection).to have_exactly(3).items => expect(collection.size).to eq(3)
+      # expect(collection).to have_at_least(3).items => expect(collection.size).to be >= 3
+      # expect(collection).to have_at_most(3).items => expect(collection.size).to be <= 3
+      #
+      # expect(team).to have(3).players => expect(team.players.size).to eq 3
+      with_node type: 'send', message: 'to', arguments: {first: {type: 'send', receiver: {type: 'send', message: old_matcher}}} do
+        times = node.arguments.first.receiver.arguments.first.source(self)
+        items_name = node.arguments.first.message
+        if :items == items_name
+          replace_with "expect({{receiver.arguments}}.size).to #{new_matcher} #{times}"
+        else
+          replace_with "expect({{receiver.arguments}}.#{items_name}.size).to #{new_matcher} #{times}"
+        end
+      end
+    end
+  end
+end

data/lib/synvert/snippets/rspec/its_to_it.rb

@@ -0,0 +1,56 @@
+Synvert::Rewriter.new "convert_rspec_its_to_it", "RSpec converts its to it" do
+  gem_spec 'rspec', '2.99.0'
+
+  [:should, :should_not].each do |message|
+    within_files 'spec/**/*.rb' do
+      # describe 'example' do
+      #   subject { { foo: 1, bar: 2 } }
+      #   its(:size) { should == 2 }
+      #   its([:foo]) { should == 1 }
+      #   its('keys.first') { should == :foo }
+      # end
+      # =>
+      # describe 'example' do
+      #   subject { { foo: 1, bar: 2 } }
+      #
+      #   describe '#size' do
+      #     subject { super().size }
+      #     it { should == 2 }
+      #   end
+      #
+      #   describe '[:foo]' do
+      #     subject { super()[:foo] }
+      #     it { should == 1 }
+      #   end
+      #
+      #   describe '#keys' do
+      #     subject { super().keys }
+      #     describe '#first' do
+      #       subject { super().first }
+      #       it { should == :foo }
+      #     end
+      #   end
+      # end
+      with_node type: 'block', caller: {message: 'its'} do
+        if node.body.length == 1
+          its_arg = node.caller.arguments.first.source(self)
+          its_arg = its_arg[1...-1] if its_arg =~ /^['"].*['"]$/
+          its_arg = its_arg[1..-1] if its_arg[0] == ':'
+          rewritten_code = ""
+          args = its_arg.split(".")
+          args.each_with_index do |arg, index|
+            describe_name = arg[0] =~ /^[a-z]/ ? '#' + arg : arg
+            message_name = arg[0] =~ /^[a-z]/ ? '.' + arg : arg
+            rewritten_code << "#{'  ' * index}describe '#{describe_name}' do\n"
+            rewritten_code << "#{'  ' * (index + 1)}subject { super()#{message_name} }\n"
+            rewritten_code << "#{'  ' * (index + 1)}it { {{body}} }\n" if index + 1 == args.length
+          end
+          args.length.times do |i|
+            rewritten_code << "#{'  ' * (args.length - 1 - i)}end\n"
+          end
+          replace_with rewritten_code
+        end
+      end
+    end
+  end
+end

data/lib/synvert/snippets/rspec/message_expectation.rb

@@ -0,0 +1,28 @@
+Synvert::Rewriter.new "convert_rspec_message_expectation", "RSpec converts message expectation" do
+  gem_spec 'rspec', '2.14.0'
+
+  within_files 'spec/**/*.rb' do
+    # obj.should_receive(:message) => expect(obj).to receive(:message)
+    # Klass.any_instance.should_receive(:message) => expect_any_instance_of(Klass).to receive(:message)
+    with_node type: 'send', message: 'should_receive' do
+      if_exist_node type: 'send', message: 'any_instance' do
+        replace_with "expect_any_instance_of({{receiver.receiver}}).to receive({{arguments}})"
+      end
+      unless_exist_node type: 'send', message: 'any_instance' do
+        replace_with "expect({{receiver}}).to receive({{arguments}})"
+      end
+    end
+  end
+
+  within_files 'spec/**/*.rb' do
+    # expect(obj).to receive(:message).and_return { 1 } => expect(obj).to receive(:message) { 1 }
+    with_node type: 'send', receiver: {type: 'send', message: 'expect'}, arguments: {first: {type: 'block', caller: {type: 'send', message: 'and_return', arguments: []}}} do
+      replace_with "{{receiver}}.to {{arguments.first.caller.receiver}} { {{arguments.first.body}} }"
+    end
+
+    # expect(obj).to receive(:message).and_return => expect(obj).to receive(:message)
+    with_node type: 'send', receiver: {type: 'send', message: 'expect'}, arguments: {first: {type: 'send', message: 'and_return', arguments: []}} do
+      replace_with "{{receiver}}.to {{arguments.first.receiver}}"
+    end
+  end
+end

data/lib/synvert/snippets/rspec/method_stub.rb

@@ -0,0 +1,71 @@
+Synvert::Rewriter.new "convert_rspec_method_stub", "RSpec converts method stub" do
+  gem_spec 'rspec', '2.14.0'
+
+  within_files 'spec/**/*.rb' do
+    # obj.stub!(:message) => obj.stub(:message)
+    # obj.unstub!(:message) => obj.unstub(:message)
+    {stub!: 'stub', unstub!: 'unstub'}.each do |old_message, new_message|
+      with_node type: 'send', message: old_message do
+        replace_with "{{receiver}}.#{new_message}({{arguments}})"
+      end
+    end
+  end
+
+  within_files 'spec/**/*.rb' do
+    # obj.stub(:message).any_number_of_times => allow(obj).to receive(:message)
+    # obj.stub(:message).at_least(0) => allow(obj).to receive(:message)
+    with_node type: 'send', message: 'any_number_of_times' do
+      replace_with "{{receiver}}"
+    end
+
+    with_node type: 'send', message: 'at_least', arguments: [0] do
+      replace_with "{{receiver}}"
+    end
+  end
+
+  within_files 'spec/**/*.rb' do
+    # obj.stub(:message) => allow(obj).to receive(:message)
+    # Klass.any_instance.stub(:message) => allow_any_instance_of(Klass).to receive(:message)
+    with_node type: 'send', message: 'stub', arguments: {first: {type: {not: 'hash'}}} do
+      if_exist_node type: 'send', message: 'any_instance' do
+        replace_with "allow_any_instance_of({{receiver.receiver}}).to receive({{arguments}})"
+      end
+      unless_exist_node type: 'send', message: 'any_instance' do
+        replace_with "allow({{receiver}}).to receive({{arguments}})"
+      end
+    end
+  end
+
+  gem_spec 'rspec', '3.0.0'
+
+  within_files 'spec/**/*.rb' do
+    # obj.stub_chain(:foo, :bar, :baz) => allow(obj).to receive_message_chain(:foo, :bar, :baz)
+    with_node type: 'send', message: 'stub_chain' do
+      if_exist_node type: 'send', message: 'any_instance' do
+        replace_with "allow_any_instance_of({{receiver.receiver}}).to receive_message_chain({{arguments}})"
+      end
+      unless_exist_node type: 'send', message: 'any_instance' do
+        replace_with "allow({{receiver}}).to receive_message_chain({{arguments}})"
+      end
+    end
+  end
+
+  within_files 'spec/**/*.rb' do
+    # obj.stub(:foo => 1, :bar => 2) => allow(obj).to receive_messages(:foo => 1, :bar => 2)
+    with_node type: 'send', message: 'stub', arguments: {first: {type: 'hash'}} do
+      replace_with "allow({{receiver}}).to receive_messages({{arguments}})"
+    end
+  end
+
+  within_files 'spec/**/*.rb' do
+    # allow(obj).to receive(:message).and_return { 1 } => allow(obj).to receive(:message) { 1 }
+    with_node type: 'send', receiver: {type: 'send', message: 'allow'}, arguments: {first: {type: 'block', caller: {type: 'send', message: 'and_return', arguments: []}}} do
+      replace_with "{{receiver}}.to {{arguments.first.caller.receiver}} { {{arguments.first.body}} }"
+    end
+
+    # allow(obj).to receive(:message).and_return => allow(obj).to receive(:message)
+    with_node type: 'send', receiver: {type: 'send', message: 'allow'}, arguments: {first: {type: 'send', message: 'and_return', arguments: []}} do
+      replace_with "{{receiver}}.to {{arguments.first.receiver}}"
+    end
+  end
+end

data/lib/synvert/snippets/rspec/negative_error_expectation.rb

@@ -0,0 +1,14 @@
+Synvert::Rewriter.new "convert_rspec_negative_error_expectation", "RSpec converts negative error expectation" do
+  gem_spec 'rspec', '2.14.0'
+
+  within_files 'spec/**/*.rb' do
+    # expect { do_something }.not_to raise_error(SomeErrorClass) => expect { do_something }.not_to raise_error
+    # expect { do_something }.not_to raise_error('message') => expect { do_something }.not_to raise_error
+    # expect { do_something }.not_to raise_error(SomeErrorClass, 'message') => expect { do_something }.not_to raise_error
+    within_node type: 'send', receiver: {type: 'block'}, message: 'not_to' do
+      with_node type: 'send', message: 'raise_error' do
+        replace_with "raise_error"
+      end
+    end
+  end
+end

data/lib/synvert/snippets/rspec/new_syntax.rb

@@ -0,0 +1,14 @@
+Synvert::Rewriter.new "rspec_new_syntax", "Use RSpec new syntax" do
+  add_snippet "convert_rspec_should_to_expect"
+  add_snippet "convert_rspec_block_to_expect"
+  add_snippet "convert_rspec_one_liner_expectation"
+  add_snippet "convert_rspec_boolean_matcher"
+  add_snippet "convert_rspec_be_close_to_be_within"
+  add_snippet "convert_rspec_collection_matcher"
+  add_snippet "convert_rspec_negative_error_expectation"
+  add_snippet "convert_rspec_its_to_it"
+
+  add_snippet "convert_rspec_stub_and_mock_to_double"
+  add_snippet "convert_rspec_message_expectation"
+  add_snippet "convert_rspec_method_stub"
+end

data/lib/synvert/snippets/rspec/one_liner_expectation.rb

@@ -0,0 +1,51 @@
+Synvert::Rewriter.new "convert_rspec_one_liner_expectation", "RSpec converts one liner expectation" do
+  gem_spec 'rspec', '2.99.0'
+
+  {should: 'to', should_not: 'not_to'}.each do |old_message, new_message|
+    matcher_converters = {have: 'eq', have_exactly: 'eq', have_at_least: 'be >=', have_at_most: 'be <='}
+    matcher_converters.each do |old_matcher, new_matcher|
+      within_files 'spec/**/*.rb' do
+        # it { should have(3).items }
+        # =>
+        # it 'has 3 items' do
+        #   expect(subject.size).to eq(3)
+        # end
+        #
+        # it { should have_at_least(3).players }
+        # =>
+        # it 'has at least 3 players' do
+        #   expect(subject.players.size).to be >= 3
+        # end
+        with_node type: 'block', caller: {message: 'it'} do
+          if_only_exist_node type: 'send', receiver: nil, message: old_message, arguments: {first: {type: 'send', receiver: {type: 'send', message: old_matcher}}} do
+            times = node.body.first.arguments.first.receiver.arguments.first.source(self)
+            items_name = node.body.first.arguments.first.message
+            if :items == items_name
+              replace_with """it 'has #{times} items' do
+  expect(subject.size).#{new_message} #{new_matcher}(#{times})
+end"""
+            else
+              it_message = "#{old_matcher.to_s.sub('have', 'has').gsub('_', ' ')} #{times} #{items_name}"
+              replace_with """it '#{it_message}' do
+  expect(subject.#{items_name}.size).#{new_message} #{new_matcher} #{times}
+end"""
+            end
+          end
+        end
+      end
+    end
+  end
+
+  {should: 'to', should_not: 'not_to'}.each do |old_message, new_message|
+    within_files 'spec/**/*.rb' do
+      # it { should matcher } => it { is_expected.to matcher }
+      # it { should_not matcher } => it { is_expected.not_to matcher }
+      with_node type: 'block', caller: {message: 'it'} do
+        if_only_exist_node type: 'send', receiver: nil, message: old_message do
+          matcher = node.body.first.arguments.first.source(self)
+          replace_with "it { is_expected.#{new_message} #{matcher} }"
+        end
+      end
+    end
+  end
+end

data/lib/synvert/snippets/rspec/should_to_expect.rb

@@ -0,0 +1,40 @@
+Synvert::Rewriter.new "convert_rspec_should_to_expect", "RSpec converts should to expect" do
+  gem_spec 'rspec', '2.11.0'
+
+  {should: 'to', should_not: 'not_to'}.each do |old_message, new_message|
+    within_files 'spec/**/*.rb' do
+      # obj.should matcher => expect(obj).to matcher
+      # obj.should_not matcher => expect(obj).not_to matcher
+      with_node type: 'send', receiver: {type: {not: 'block'}}, message: old_message do
+        if node.receiver && node.arguments.size > 0
+          replace_with "expect({{receiver}}).#{new_message} {{arguments}}"
+        end
+      end
+    end
+
+    {'==' => 'eq', '<' => 'be <', '>' => 'be >', '<=' => 'be <=', '>=' => 'be >=', '===' => 'be ==='}.each do |old_matcher, new_matcher|
+      within_files 'spec/**/*.rb' do
+        # 1.should == 1 => expect(1).to eq 1
+        # 1.should < 1 => expect(1).to be < 2
+        # Integer.should === 1 => expect(Integer).to be === 1
+        with_node type: 'send', receiver: {type: 'send', message: old_message}, message: old_matcher do
+          if node.receiver.receiver
+            replace_with "expect({{receiver.receiver}}).#{new_message} #{new_matcher} {{arguments}}"
+          end
+        end
+      end
+    end
+
+    within_files 'spec/**/*.rb' do
+      # 'string'.should =~ /^str/ => expect('string').to match /^str/
+      # [1, 2, 3].should =~ [2, 1, 3] => expect([1, 2, 3]).to match_array [2, 1, 3]
+      with_node type: 'send', receiver: {type: 'send', message: old_message}, message: '=~' do
+        if :regexp == node.arguments.first.type
+          replace_with "expect({{receiver.receiver}}).#{new_message} match {{arguments}}"
+        else
+          replace_with "expect({{receiver.receiver}}).#{new_message} match_array {{arguments}}"
+        end
+      end
+    end
+  end
+end

data/lib/synvert/snippets/rspec/stub_and_mock_to_double.rb

@@ -0,0 +1,15 @@
+Synvert::Rewriter.new "convert_rspec_stub_and_mock_to_double", "RSpec converts stub and mock to double" do
+  gem_spec 'rspec', '2.14.0'
+
+  within_files 'spec/**/*.rb' do
+    # stub('something') => double('something')
+    # mock('something') => double('something')
+    with_node type: 'send', receiver: nil, message: 'stub' do
+      replace_with "double({{arguments}})"
+    end
+
+    with_node type: 'send', receiver: nil, message: 'mock' do
+      replace_with "double({{arguments}})"
+    end
+  end
+end

data/lib/synvert/version.rb

@@ -1,5 +1,5 @@
 # coding: utf-8
 
 module Synvert
-  VERSION = "0.0.9"
+  VERSION = "0.0.10"
 end

data/spec/synvert/node_ext_spec.rb

@@ -67,9 +67,19 @@ describe Parser::AST::Node do
   end
 
   describe '#body' do
-    it 'gets for block node' do
+    it 'gets one line for block node' do
       node = parse('RSpec.configure do |config|; include EmailSpec::Helpers; end')
-      expect(node.body).to eq parse('include EmailSpec::Helpers')
+      expect(node.body).to eq [parse('include EmailSpec::Helpers')]
+    end
+
+    it 'gets multiple lines for block node' do
+      node = parse('RSpec.configure do |config|; include EmailSpec::Helpers; include EmailSpec::Matchers; end')
+      expect(node.body).to eq [parse('include EmailSpec::Helpers'), parse('include EmailSpec::Matchers')]
+    end
+
+    it 'gets for begin node' do
+      node = parse('foo; bar')
+      expect(node.body).to eq [parse('foo'), parse('bar')]
     end
   end
 
@@ -132,6 +142,13 @@ describe Parser::AST::Node do
       expect(node).to be_match(instance, type: 'send', receiver: 'params', message: '[]', arguments: [:user])
     end
 
+    it 'matches assign number' do
+      source = 'at_least(0)'
+      instance.current_source = source
+      node = parse(source)
+      expect(node).to be_match(instance, type: 'send', arguments: [0])
+    end
+
     it 'matches arguments with string' do
       source = 'params["user"]'
       instance.current_source = source
@@ -145,5 +162,12 @@ describe Parser::AST::Node do
       node = parse(source)
       expect(node).to be_match(instance, type: 'send', arguments: {any: 'Lifo::Cache'})
     end
+
+    it 'matches not' do
+      source = 'class Synvert; end'
+      instance.current_source = source
+      node = parse(source)
+      expect(node).not_to be_match(instance, type: 'class', name: {not: 'Synvert'})
+    end
   end
 end

data/spec/synvert/rewriter/action_spec.rb

@@ -2,23 +2,52 @@ require 'spec_helper'
 
 module Synvert
   describe Rewriter::ReplaceWithAction do
-    subject {
-      source = "post = FactoryGirl.create_list :post, 2"
-      send_node = Parser::CurrentRuby.parse(source).children[1]
-      instance = double(:current_node => send_node)
-      Rewriter::ReplaceWithAction.new(instance, 'create_list {{arguments}}')
-    }
+    context "replace with single line" do
+      subject {
+        source = "post = FactoryGirl.create_list :post, 2"
+        send_node = Parser::CurrentRuby.parse(source).children[1]
+        instance = double(:current_node => send_node)
+        Rewriter::ReplaceWithAction.new(instance, 'create_list {{arguments}}')
+      }
 
-    it 'gets begin_pos' do
-      expect(subject.begin_pos).to eq "post = ".length
-    end
+      it 'gets begin_pos' do
+        expect(subject.begin_pos).to eq "post = ".length
+      end
 
-    it 'gets end_pos' do
-      expect(subject.end_pos).to eq "post = FactoryGirl.create_list :post, 2".length
+      it 'gets end_pos' do
+        expect(subject.end_pos).to eq "post = FactoryGirl.create_list :post, 2".length
+      end
+
+      it 'gets rewritten_code' do
+        expect(subject.rewritten_code).to eq 'create_list :post, 2'
+      end
     end
 
-    it 'gets rewritten_code' do
-      expect(subject.rewritten_code).to eq 'create_list :post, 2'
+    context "#replace with multiple line" do
+      subject {
+        source = "  its(:size) { should == 1 }"
+        send_node = Parser::CurrentRuby.parse(source)
+        instance = double(:current_node => send_node)
+        Rewriter::ReplaceWithAction.new(instance, """describe '#size' do
+  subject { super().size }
+  it { {{body}} }
+end""")
+      }
+
+      it 'gets begin_pos' do
+        expect(subject.begin_pos).to eq 2
+      end
+
+      it 'gets end_pos' do
+        expect(subject.end_pos).to eq "  its(:size) { should == 1 }".length
+      end
+
+      it 'gets rewritten_code' do
+        expect(subject.rewritten_code).to eq """\n\n  describe '#size' do
+    subject { super().size }
+    it { should == 1 }
+  end"""
+      end
     end
   end
 

data/spec/synvert/snippets/rspec/new_syntax_spec.rb

@@ -0,0 +1,183 @@
+require 'spec_helper'
+
+describe 'Use RSpec new syntax' do
+  before do
+    Synvert::Configuration.instance.set :path, '.'
+    allow_any_instance_of(Synvert::Rewriter::GemSpec).to receive(:match?).and_return(true)
+    Dir.glob File.join(File.dirname(__FILE__), '../../../../lib/synvert/snippets/rspec/*') do |file|
+      if file =~ /new_syntax.rb$/
+        @rewriter = eval(File.read(file))
+      else
+        eval(File.read(file))
+      end
+    end
+  end
+
+  describe 'rspec', fakefs: true do
+    let(:post_spec_content) {"""
+it 'case' do
+  obj.should matcher
+  obj.should_not matcher
+
+  1.should == 1
+  1.should < 2
+  Integer.should === 1
+  'string'.should =~ /^str/
+  [1, 2, 3].should =~ [2, 1, 3]
+
+  expect(obj).to be_true
+  expect(obj).to be_false
+
+  expect(1.0 / 3.0).to be_close(0.333, 0.001)
+
+  expect(collection).to have(3).items
+  expect(collection).to have_exactly(3).items
+  expect(collection).to have_at_least(3).items
+  expect(collection).to have_at_most(3).items
+
+  expect(team).to have(3).players
+
+  lambda { do_something }.should raise_error
+  proc { do_something }.should raise_error
+  -> { do_something }.should raise_error
+
+  expect { do_something }.not_to raise_error(SomeErrorClass)
+  expect { do_something }.not_to raise_error('message')
+  expect { do_something }.not_to raise_error(SomeErrorClass, 'message')
+
+  obj.should_receive(:message)
+  Klass.any_instance.should_receive(:message)
+
+  obj.stub(:message)
+  obj.stub!(:message)
+  obj.stub_chain(:foo, :bar, :baz)
+  Klass.any_instance.stub(:message)
+
+  obj.stub(:foo => 1, :bar => 2)
+
+  obj.unstub!(:message)
+
+  obj.stub(:message).any_number_of_times
+  obj.stub(:message).at_least(0)
+
+  expect(obj).to receive(:message).and_return { 1 }
+  allow(obj).to receive(:message).and_return { 1 }
+
+  expect(obj).to receive(:message).and_return
+  allow(obj).to receive(:message).and_return
+
+  stub('something')
+  mock('something')
+end
+
+it { should matcher }
+it { should_not matcher }
+
+it { should have(3).items }
+it { should have_at_least(3).players }
+
+describe 'example' do
+  subject { { foo: 1, bar: 2 } }
+  its(:size) { should == 2 }
+  its([:foo]) { should == 1 }
+  its('keys.first') { should == :foo }
+end
+    """}
+    let(:post_spec_rewritten_content) {"""
+it 'case' do
+  expect(obj).to matcher
+  expect(obj).not_to matcher
+
+  expect(1).to eq 1
+  expect(1).to be < 2
+  expect(Integer).to be === 1
+  expect('string').to match /^str/
+  expect([1, 2, 3]).to match_array [2, 1, 3]
+
+  expect(obj).to be_truthy
+  expect(obj).to be_falsey
+
+  expect(1.0 / 3.0).to be_within(0.001).of(0.333)
+
+  expect(collection.size).to eq 3
+  expect(collection.size).to eq 3
+  expect(collection.size).to be >= 3
+  expect(collection.size).to be <= 3
+
+  expect(team.players.size).to eq 3
+
+  expect { do_something }.to raise_error
+  expect { do_something }.to raise_error
+  expect { do_something }.to raise_error
+
+  expect { do_something }.not_to raise_error
+  expect { do_something }.not_to raise_error
+  expect { do_something }.not_to raise_error
+
+  expect(obj).to receive(:message)
+  expect_any_instance_of(Klass).to receive(:message)
+
+  allow(obj).to receive(:message)
+  allow(obj).to receive(:message)
+  allow(obj).to receive_message_chain(:foo, :bar, :baz)
+  allow_any_instance_of(Klass).to receive(:message)
+
+  allow(obj).to receive_messages(:foo => 1, :bar => 2)
+
+  obj.unstub(:message)
+
+  allow(obj).to receive(:message)
+  allow(obj).to receive(:message)
+
+  expect(obj).to receive(:message) { 1 }
+  allow(obj).to receive(:message) { 1 }
+
+  expect(obj).to receive(:message)
+  allow(obj).to receive(:message)
+
+  double('something')
+  double('something')
+end
+
+it { is_expected.to matcher }
+it { is_expected.not_to matcher }
+
+it 'has 3 items' do
+  expect(subject.size).to eq(3)
+end
+
+it 'has at least 3 players' do
+  expect(subject.players.size).to be >= 3
+end
+
+describe 'example' do
+  subject { { foo: 1, bar: 2 } }
+
+  describe '#size' do
+    subject { super().size }
+    it { should == 2 }
+  end
+
+  describe '[:foo]' do
+    subject { super()[:foo] }
+    it { should == 1 }
+  end
+
+  describe '#keys' do
+    subject { super().keys }
+    describe '#first' do
+      subject { super().first }
+      it { should == :foo }
+    end
+  end
+end
+    """}
+
+    it 'process' do
+      FileUtils.mkdir_p 'spec/models'
+      File.write 'spec/models/post_spec.rb', post_spec_content
+      @rewriter.process
+      expect(File.read 'spec/models/post_spec.rb').to eq post_spec_rewritten_content
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: synvert
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-28 00:00:00.000000000 Z
+date: 2014-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -128,6 +128,18 @@ files:
 - lib/synvert/snippets/rails/upgrade_3_0_to_3_1.rb
 - lib/synvert/snippets/rails/upgrade_3_1_to_3_2.rb
 - lib/synvert/snippets/rails/upgrade_3_2_to_4_0.rb
+- lib/synvert/snippets/rspec/be_close_to_be_within.rb
+- lib/synvert/snippets/rspec/block_to_expect.rb
+- lib/synvert/snippets/rspec/boolean_matcher.rb
+- lib/synvert/snippets/rspec/collection_matcher.rb
+- lib/synvert/snippets/rspec/its_to_it.rb
+- lib/synvert/snippets/rspec/message_expectation.rb
+- lib/synvert/snippets/rspec/method_stub.rb
+- lib/synvert/snippets/rspec/negative_error_expectation.rb
+- lib/synvert/snippets/rspec/new_syntax.rb
+- lib/synvert/snippets/rspec/one_liner_expectation.rb
+- lib/synvert/snippets/rspec/should_to_expect.rb
+- lib/synvert/snippets/rspec/stub_and_mock_to_double.rb
 - lib/synvert/version.rb
 - spec/spec_helper.rb
 - spec/support/parser_helper.rb
@@ -144,6 +156,7 @@ files:
 - spec/synvert/snippets/rails/upgrade_3_0_to_3_1_spec.rb
 - spec/synvert/snippets/rails/upgrade_3_1_to_3_2_spec.rb
 - spec/synvert/snippets/rails/upgrade_3_2_to_4_0_spec.rb
+- spec/synvert/snippets/rspec/new_syntax_spec.rb
 - synvert.gemspec
 homepage: ''
 licenses:
@@ -185,3 +198,4 @@ test_files:
 - spec/synvert/snippets/rails/upgrade_3_0_to_3_1_spec.rb
 - spec/synvert/snippets/rails/upgrade_3_1_to_3_2_spec.rb
 - spec/synvert/snippets/rails/upgrade_3_2_to_4_0_spec.rb
+- spec/synvert/snippets/rspec/new_syntax_spec.rb