synvert-core 0.7.4 → 0.7.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 46b762aaad4169f0bfc8b8857b06af6048532335
-  data.tar.gz: 2f4c8f3d350d69bafe0dd7f775270261421bdd06
+  metadata.gz: 147d5855d29224ef920cd0249c021c0825f52ae7
+  data.tar.gz: 151c8fcd306d95ac3e401f6b5e7c266dde352bd5
 SHA512:
-  metadata.gz: f6500aff52b0381a6bf29fa8f38f76163508d915b2b69e2ba07f53e3cd7f4c1d5e545d58c33ba6cf48ff183d84dd20a68c8aa729ee0286c8013ff29bc7228007
-  data.tar.gz: cf34ebc9213041687782fe32f1b9ba0c07f85e17b1e6763b606482e12d292f339c4fa861d28943798b1cd4272a2bc720e991b6138c675327122828de7d9b8f06
+  metadata.gz: efd95157a71e181ad15658aa06c3ddb41d85a80801ecb118cd4d74877db98bdfaf9a6ff66d9838deca432cdcbd3cc122c572c6998120053a3711db6ac6ea02b2
+  data.tar.gz: 4d7105931e33abe42f7d6722e9948251151155db3ee401ecb6f187228c67226b0662f831dc45b3de0050a4bf280400781c20c1b6d3b43251889e28635030b8d1

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## 0.7.5
+
+* Fix left_value and right_value node attribute
+
 ## 0.7.4
 
 * Add add_arguments_with_parenthesis_if_necessary helper method

data/lib/synvert/core/node_ext.rb

@@ -214,13 +214,10 @@ module Parser::AST
 
     # Return the left value.
     #
-    # @return [Array<Parser::AST::Node>] variable nodes.
+    # @return [Parser::AST::Node] variable nodes.
     # @raise [Synvert::Core::MethodNotSupported] if calls on other node.
     def left_value
-      case self.type
-      when :masgn
-        self.children[0].children
-      when :lvasgn, :ivasgn
+      if [:masgn, :lvasgn, :ivasgn].include? self.type
         self.children[0]
       else
         raise Synvert::Core::MethodNotSupported.new "left_value is not handled for #{self.debug_info}"
@@ -232,10 +229,7 @@ module Parser::AST
     # @return [Array<Parser::AST::Node>] variable nodes.
     # @raise [Synvert::Core::MethodNotSupported] if calls on other node.
     def right_value
-      case self.type
-      when :masgn
-        self.children[1].children
-      when :lvasgn, :ivasgn
+      if [:masgn, :lvasgn, :ivasgn].include? self.type
         self.children[1]
       else
         raise Synvert::Core::MethodNotSupported.new "right_value is not handled for #{self.debug_info}"

data/lib/synvert/core/version.rb

@@ -2,6 +2,6 @@
 
 module Synvert
   module Core
-    VERSION = "0.7.4"
+    VERSION = "0.7.5"
   end
 end

data/spec/synvert/core/node_ext_spec.rb

@@ -190,7 +190,7 @@ describe Parser::AST::Node do
   describe "#left_value" do
     it 'gets for masgn' do
       node = parse("a, b = 1, 2")
-      expect(node.left_value.map(&:to_source)).to eq ['a', 'b']
+      expect(node.left_value.to_source).to eq 'a, b'
     end
 
     it 'gets for lvasgn' do
@@ -207,7 +207,12 @@ describe Parser::AST::Node do
   describe "#right_value" do
     it 'gets for masgn' do
       node = parse("a, b = 1, 2")
-      expect(node.right_value).to eq [parse("1"), parse("2")]
+      expect(node.right_value).to eq parse('[1, 2]')
+    end
+
+    it 'gets for masgn' do
+      node = parse("a, b = params")
+      expect(node.right_value).to eq parse("params")
     end
 
     it 'gets for lvasgn' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: synvert-core
 version: !ruby/object:Gem::Version
-  version: 0.7.4
+  version: 0.7.5
 platform: ruby
 authors:
 - Richard Huang