synchronised_migration 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4ef871349cf34d118ae3cdcc03dd6560ea479000
-  data.tar.gz: 18c52c61ba632ed6fc4dec7140ee164c499ff025
+  metadata.gz: 212072787b988c9bbf519fcbc300f47c43b369d0
+  data.tar.gz: 6c11fc29b21f4b21997ce99d9ac487417d975260
 SHA512:
-  metadata.gz: 3deed9eafa27fbc5262fb6a52969dcd374c06805b93010783346d8e00e0507ddd3f61452e163154d0a222c209704d12f22967167dd1e4c38ae0d7d2a4e216a34
-  data.tar.gz: 24b5c0160ba71b687806e40bc48ecd6d4e281801110d7a6c975565443cfe95307253f54d3640590d3b867ed81eb21e92cc8e51fb45c9f916ea4171d3a1172f50
+  metadata.gz: eb93c86309e617ee74f2bf28129310028fe6eaa29836b80eb9b41b7ac6ad5a9a4c17ae58f00a95921d114f8ffefbee7c6ed007cdd255778d785b7baff66f49fc
+  data.tar.gz: b390df5675f5ba096e4be05ce0b12aa9151eccfd45b9f5cc2259ed4c14025152a15c343333a37e1fa9c302de894802ce9568963df1a2d766a0cdfa8f0eb20a9c

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Synchronised Migration
 
+## 1.0.0
+
+* [DO-100] Allow nesting bundler exec
+
 ## 0.1.0
 
 * [DO-70] Use Redis to synchronise migrations across multiple deployments

data/README.md

@@ -27,6 +27,7 @@ You may override these settings through environment variables.
 
 ```
 SYNCHRONISED_COMMAND=bin/launch/migrate
+WITH_CLEAN_BUNDLER_ENV=1 # Non-empty for true
 REDLOCK_TIMEOUT_MS=3600000
 REDLOCK_RETRY_DELAY_MS=200
 REDLOCK_LOCK_KEY=migration-in-progress

data/lib/synchronised_migration/main.rb

@@ -49,7 +49,14 @@ class SynchronisedMigration::Main
   end
 
   def migrate
-    Kernel.system target_command
+    return Kernel.system target_command unless with_clean_env?
+    Bundler.with_clean_env do
+      Kernel.system target_command
+    end
+  end
+
+  def with_clean_env?
+    not ENV.fetch('WITH_CLEAN_BUNDLER_ENV', '').empty?
   end
 
   def migration_failed?

data/lib/synchronised_migration/version.rb

@@ -1,3 +1,3 @@
 module SynchronisedMigration
-  VERSION = '0.1.0'
+  VERSION = '1.0.0'
 end

data/spec/synchronised_migration/main_spec.rb

@@ -27,6 +27,8 @@ describe SynchronisedMigration::Main do
         method.call *args
       }
 
+      allow(Bundler).to receive(:with_clean_env).and_call_original
+
       stub_const(
         'RedisConfig', double(
           get: {
@@ -45,10 +47,24 @@ describe SynchronisedMigration::Main do
         expect(redis).to have_received(:get).with('migration-failed')
         expect(redis).to have_received(:set).with('migration-failed', 1)
         expect(Kernel).to have_received(:system)
+        expect(Bundler).not_to have_received(:with_clean_env)
         expect(redis).to have_received(:del).with('migration-failed')
       end
     end
 
+    context 'when require a clean Bundler environment' do
+      before do
+        allow(ENV).to receive(:fetch).and_call_original
+        allow(ENV).to receive(:fetch).with('WITH_CLEAN_BUNDLER_ENV', '').and_return('1')
+      end
+
+      it 'executes it with a clean Bundler environment' do
+        expect(result).to be_success
+        expect(Kernel).to have_received(:system)
+        expect(Bundler).to have_received(:with_clean_env)
+      end
+    end
+
     context 'after a deployment failed previously' do
       let(:fail_marker_value) { '1' }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: synchronised_migration
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Alvin Yim
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-12 00:00:00.000000000 Z
+date: 2017-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redlock