synchronised_migration 0.1.0.pre.alpha.1 → 0.1.0.pre.alpha.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3ab84276b5cbc3b6a059da59e59c414496f72a69
-  data.tar.gz: ba49512428c7d3554fbafa2d98b6746204f3d4ad
+  metadata.gz: 9000c0002dc564ee9f7cfaf21709223579272438
+  data.tar.gz: 1872e38d3548032b9f8fcc20451a00040034baf6
 SHA512:
-  metadata.gz: f18218af70a990a21ccdb7a88944bcf5482d56fc84b9181b52b48ee60339d1b412f27dcf91922849d617e59f0ca4dcc8429b8c5cfea32eef707d4286633c489c
-  data.tar.gz: 3dc0653bc15b35736138bacbdb9752e76589f571657966bc0b5ef641e1f67350d1fa4b201690320c54aa00fcc38001e74ce44c3cd8d10c262d21bbfca67c0180
+  metadata.gz: e8ea7ef4379e2759718215ecfe675f8490c965aa32f1e1ad7a057e7b4282a37402f6df8aad4924d44c5f819cd0f928c0cdd8be4ef3c3556813b40e86939aa5c1
+  data.tar.gz: e5b8f5c075a49a142cbfa03af6e89bff4f5303833d773d72e73c43d711cc7bfae21dbfc5850da71a95326afcc00b386210b886c493e5199a2c9bdf9f0ba6df3a

data/.gitignore

@@ -1,3 +1,4 @@
 /.bundle
 /vendor
 /coverage
+/*.gem

data/README.md

@@ -26,7 +26,7 @@ RedisConfig.get[:db] # 0
 You may override these settings through environment variables.
 
 ```
-SYNC_RAKE_TASK=launch:migrate
+SYNCHRONISED_COMMAND=bin/launch/migrate
 REDLOCK_TIMEOUT_MS=3600000
 REDLOCK_RETRY_DELAY_MS=200
 REDLOCK_LOCK_KEY=migration-in-progress

data/lib/synchronised_migration/main.rb

@@ -30,6 +30,7 @@ class SynchronisedMigration::Main
     return Result.new 'Halting the script because the previous migration failed.' if previous_failed?
     mark_failed
     migrate
+    return Result.new 'Migration failed.' if migration_failed?
     remove_fail_marker
     Result.new
   end
@@ -48,11 +49,15 @@ class SynchronisedMigration::Main
   end
 
   def migrate
-    Rake::Task[target_rake_task].invoke
+    Kernel.system target_command
   end
 
-  def target_rake_task
-    ENV.fetch 'SYNC_RAKE_TASK', 'launch:migrate'
+  def migration_failed?
+    not $?.success?
+  end
+
+  def target_command
+    ENV.fetch 'SYNCHRONISED_COMMAND', 'bin/launch/migrate'
   end
 
   def redis
@@ -70,7 +75,7 @@ class SynchronisedMigration::Main
 
   def redis_url
     sprintf(
-      'redis:://%s:%s/%s',
+      'redis://%s:%s/%s',
       RedisConfig.get[:host],
       RedisConfig.get[:port],
       RedisConfig.get[:db]

data/lib/synchronised_migration/version.rb

@@ -1,3 +1,3 @@
 module SynchronisedMigration
-  VERSION = '0.1.0-alpha.1'
+  VERSION = '0.1.0-alpha.2'
 end

data/spec/synchronised_migration/main_spec.rb

@@ -9,7 +9,6 @@ describe SynchronisedMigration::Main do
     let(:redis) { double }
     let(:redlock) { double }
     let(:fail_marker_value) { nil }
-    let(:rake_task) { double }
 
     before do
       subject.instance.instance_variable_set :@redis, nil
@@ -23,10 +22,10 @@ describe SynchronisedMigration::Main do
       allow(Redlock::Client).to receive(:new).and_return(redlock)
       allow(redlock).to receive(:lock!) { |lock_key, timeout, &block| block.call }
 
-      stub_const 'Rake', Module.new
-      stub_const 'Rake::Task', { 'launch:migrate' => rake_task }
-
-      allow(rake_task).to receive(:invoke)
+      allow(Kernel).to receive(:system).and_wrap_original { |method, *args|
+        next if args == [ 'bin/launch/migrate' ]
+        method.call *args
+      }
 
       stub_const(
         'RedisConfig', double(
@@ -45,7 +44,7 @@ describe SynchronisedMigration::Main do
         expect(redlock).to have_received(:lock!)
         expect(redis).to have_received(:get).with('migration-failed')
         expect(redis).to have_received(:set).with('migration-failed', 1)
-        expect(rake_task).to have_received(:invoke)
+        expect(Kernel).to have_received(:system)
         expect(redis).to have_received(:del).with('migration-failed')
       end
     end
@@ -55,19 +54,17 @@ describe SynchronisedMigration::Main do
 
       it "doesn't execute the migration" do
         expect(result).not_to be_success
-        expect(rake_task).not_to have_received(:invoke)
+        expect(Kernel).not_to have_received(:system)
       end
     end
 
     context 'when the task crashed' do
       before do
-        allow(rake_task).to receive(:invoke) do
-          fail 'An error message'
-        end
+        allow_any_instance_of(Process::Status).to receive(:success?).and_return(false)
       end
 
       it 'marks the failure in Redis' do
-        expect { result }.to raise_error('An error message')
+        expect(result).not_to be_success
         expect(redis).to have_received(:set).with('migration-failed', 1)
         expect(redis).not_to have_received(:del)
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: synchronised_migration
 version: !ruby/object:Gem::Version
-  version: 0.1.0.pre.alpha.1
+  version: 0.1.0.pre.alpha.2
 platform: ruby
 authors:
 - Alvin Yim
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-11 00:00:00.000000000 Z
+date: 2017-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redlock